10845 2006-09-13 13:57:26 -0700 Various bugs in ResourceLoaderWin with local files 2006-09-18 19:26:10 -0700 1 1 1 Unclassified WebKit Platform 420+ PC Windows XP RESOLVED FIXED P2 Major --- 0 fishd webkit-unassigned beidson mrowe oldest_to_newest 55441 0 fishd 2006-09-13 13:57:26 -0700 Various bugs in ResourceLoaderWin with local files: - m_fileHandle is sometimes compared to NULL and sometimes compared to INVALID_HANDLE_VALUE. lack of consistency results in bad behavior. - ResourceLoader::fileLoadTimer does not call client()->receivedResponse, which causes the rest of WebCore to get confused and sometimes crash. Patch coming up. 55443 1 10544 fishd 2006-09-13 14:03:42 -0700 Created attachment 10544 patch I chose to #include <windows.h> in ResourceLoaderInternal.h instead of attempting to re-define INVALID_HANDLE_VALUE. It seems like you guys are trying to minimize headers included by headers to help compile time, so if you want me to do this another way, just say so. 55444 2 10545 fishd 2006-09-13 14:07:46 -0700 Created attachment 10545 patch 2 Actually, this is better. There was no need for me to check m_fileHandle in the timer callback. 55445 3 10545 ddkilzer 2006-09-13 14:13:51 -0700 Comment on attachment 10545 patch 2 NOTE: Using WebKitTools/Scripts/svn-create-patch will avoid creating ChangeLog patches that are "shifted" like the one below. :) >Index: ChangeLog >=================================================================== >--- ChangeLog (revision 16346) >+++ ChangeLog (working copy) >@@ -1,5 +1,18 @@ > 2006-09-13 MorganL <morlmor@yahoo.com> > >+ Reviewed by NOBODY (OOPS!). >+ >[...] >+ >+2006-09-13 MorganL <morlmor@yahoo.com> >+ > Reviewed/landed by aroben. > > Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833 55447 4 10546 fishd 2006-09-13 14:16:03 -0700 Created attachment 10546 patch 2.1 - using svn-create-patch Thanks for the suggestion. 55460 5 10546 beidson 2006-09-13 16:24:17 -0700 Comment on attachment 10546 patch 2.1 - using svn-create-patch void ResourceLoader::fileLoadTimer(Timer<ResourceLoader>* timer) { + client()->receivedResponse(this, 0); This seems to me to introduce incorrect behavior - client->receivedResponse() is only supposed to be called when the HTTP response comes back for a HTTP request. If it's only data you're talking about, client->receivedData() is all that needs to be called. Can you tell use what the crash is you're seeing? 55461 6 beidson 2006-09-13 16:26:31 -0700 Also, I can go ahead and mention I'll probably be spending some time working on the ResourceLoader and getting a proper request/response infrastructure in place soon. 55471 7 fishd 2006-09-13 20:18:24 -0700 (In reply to comment #5) > (From update of attachment 10546 [edit]) > void ResourceLoader::fileLoadTimer(Timer<ResourceLoader>* timer) > { > + client()->receivedResponse(this, 0); > > This seems to me to introduce incorrect behavior - client->receivedResponse() > is only supposed to be called when the HTTP response comes back for a HTTP > request. If it's only data you're talking about, client->receivedData() is > all that needs to be called. I see. I figured that the consumer might be insulated from such details. Perhaps it would help if there was some documentation for the ResourceLoaderClient. Afterall, someone is very likely to write code that assumes a receivedResponse occurs before the first receivedData, especially if they only test with HTTP URLs. I'll try to reproduce the crash and see if this is truly to blame. I assumed it was merely an oversight :-/ 55472 8 fishd 2006-09-13 21:03:03 -0700 Hmm... with the latest trunk, I'm not seeing the crash. I'm also pretty sure that the lack of a receivedResponse notification must be unrelated to what I was seeing since the implementation in loader.cc does nothing on Windows. So, what about the rest of the patch? Is the rest of the patch OK? 55476 9 beidson 2006-09-13 22:38:03 -0700 I wish we had more docs, too, for *all* parts of the code ;) ResourceLoaderDelegate is a little slippery I suppose, in the aspect you just identified. Regardless, maybe when I do some rewrite and cleanup of it all, I'll *at least* comment those. As for the rest of your patch, yah, t'is cool - I will land that tommorrow! 55477 10 10546 beidson 2006-09-13 22:39:00 -0700 Comment on attachment 10546 patch 2.1 - using svn-create-patch Removing the client()->receivedResponse() call in the fileLoadTimer makes this patch totally r-plusable 55483 11 mrowe 2006-09-14 00:24:09 -0700 Landed in r16361, omitting the client()->receivedResponse() call in fileLoadTimer. 55532 12 10561 fishd 2006-09-14 17:29:22 -0700 Created attachment 10561 patch: add receivedResponse call I spoke with Brady about this, and we came to the conclusion that this was a good idea actually. It does end up impacting WebKit/COM/WebFrame.cpp, which currently promotes m_provisionalDataSource to m_dataSource only when it gets the receivedResponse callback. Without that, the WebFrame gets into a confused state, which can mess up the embedding app. 55869 13 10561 beidson 2006-09-18 19:26:10 -0700 Comment on attachment 10561 patch: add receivedResponse call Yes 10544 2006-09-13 14:03:42 -0700 2006-09-13 14:07:46 -0700 patch fix-loader.diff text/plain 3380 fishd SW5kZXg6IHBsYXRmb3JtL3dpbi9SZXNvdXJjZUxvYWRlcldpbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g cGxhdGZvcm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNwcAkocmV2aXNpb24gMTYzNDYpCisrKyBw bGF0Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzMs NyArMjMzLDcgQEAKIAogUmVzb3VyY2VMb2FkZXJJbnRlcm5hbDo6flJlc291cmNlTG9hZGVySW50 ZXJuYWwoKQogewotICAgIGlmIChtX2ZpbGVIYW5kbGUpCisgICAgaWYgKG1fZmlsZUhhbmRsZSAh PSBJTlZBTElEX0hBTkRMRV9WQUxVRSkKICAgICAgICAgQ2xvc2VIYW5kbGUobV9maWxlSGFuZGxl KTsKIH0KIApAQCAtMzIzLDIwICszMjMsMjUgQEAKIAogdm9pZCBSZXNvdXJjZUxvYWRlcjo6Zmls ZUxvYWRUaW1lcihUaW1lcjxSZXNvdXJjZUxvYWRlcj4qIHRpbWVyKQogewotICAgIGJvb2wgcmVz dWx0ID0gZmFsc2U7Ci0gICAgRFdPUkQgYnl0ZXNSZWFkID0gMDsKKyAgICBjbGllbnQoKS0+cmVj ZWl2ZWRSZXNwb25zZSh0aGlzLCAwKTsKIAotICAgIGRvIHsKLSAgICAgICAgY29uc3QgaW50IGJ1 ZmZlclNpemUgPSA4MTkyOwotICAgICAgICBjaGFyIGJ1ZmZlcltidWZmZXJTaXplXTsKLSAgICAg ICAgcmVzdWx0ID0gUmVhZEZpbGUoZC0+bV9maWxlSGFuZGxlLCAmYnVmZmVyLCBidWZmZXJTaXpl LCAmYnl0ZXNSZWFkLCBOVUxMKTsgCi0gICAgICAgIGQtPmNsaWVudC0+cmVjZWl2ZWREYXRhKHRo aXMsIGJ1ZmZlciwgYnl0ZXNSZWFkKTsKLSAgICAgICAgLy8gQ2hlY2sgZm9yIGVuZCBvZiBmaWxl LiAKLSAgICB9IHdoaWxlIChyZXN1bHQgJiYgYnl0ZXNSZWFkKTsKKyAgICBpZiAoZC0+bV9maWxl SGFuZGxlICE9IElOVkFMSURfSEFORExFX1ZBTFVFKSB7CisgICAgICAgIGJvb2wgcmVzdWx0ID0g ZmFsc2U7CisgICAgICAgIERXT1JEIGJ5dGVzUmVhZCA9IDA7CiAKLSAgICBDbG9zZUhhbmRsZShk LT5tX2ZpbGVIYW5kbGUpOwotICAgIGQtPm1fZmlsZUhhbmRsZSA9IDA7CisgICAgICAgIGRvIHsK KyAgICAgICAgICAgIGNvbnN0IGludCBidWZmZXJTaXplID0gODE5MjsKKyAgICAgICAgICAgIGNo YXIgYnVmZmVyW2J1ZmZlclNpemVdOworICAgICAgICAgICAgcmVzdWx0ID0gUmVhZEZpbGUoZC0+ bV9maWxlSGFuZGxlLCAmYnVmZmVyLCBidWZmZXJTaXplLCAmYnl0ZXNSZWFkLCBOVUxMKTsgCisg ICAgICAgICAgICBpZiAocmVzdWx0ICYmIGJ5dGVzUmVhZCkKKyAgICAgICAgICAgICAgICBkLT5j bGllbnQtPnJlY2VpdmVkRGF0YSh0aGlzLCBidWZmZXIsIGJ5dGVzUmVhZCk7CisgICAgICAgICAg ICAvLyBDaGVjayBmb3IgZW5kIG9mIGZpbGUuIAorICAgICAgICB9IHdoaWxlIChyZXN1bHQgJiYg Ynl0ZXNSZWFkKTsKIAorICAgICAgICBDbG9zZUhhbmRsZShkLT5tX2ZpbGVIYW5kbGUpOworICAg ICAgICBkLT5tX2ZpbGVIYW5kbGUgPSBJTlZBTElEX0hBTkRMRV9WQUxVRTsKKyAgICB9CisKICAg ICBQbGF0Zm9ybURhdGFTdHJ1Y3QgcGxhdGZvcm1EYXRhOwogICAgIHBsYXRmb3JtRGF0YS5lcnJv clN0cmluZyA9IDA7CiAgICAgcGxhdGZvcm1EYXRhLmVycm9yID0gMDsKSW5kZXg6IHBsYXRmb3Jt L1Jlc291cmNlTG9hZGVySW50ZXJuYWwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9SZXNvdXJj ZUxvYWRlckludGVybmFsLmgJKHJldmlzaW9uIDE2MzQ2KQorKysgcGxhdGZvcm0vUmVzb3VyY2VM b2FkZXJJbnRlcm5hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw3ICszNyw3IEBACiAjZW5kaWYK IAogI2lmIFVTRShXSU5JTkVUKQotdHlwZWRlZiB2b2lkKiBIQU5ETEU7CisjaW5jbHVkZSA8d2lu ZG93cy5oPgogI2VuZGlmCiAKICNpZiBQTEFURk9STShHREspCkBAIC03MSw3ICs3MSw3IEBACiAg ICAgICAgICAgICAsIHJlc3BvbnNlKG5pbCkKICNlbmRpZgogI2lmIFVTRShXSU5JTkVUKQotICAg ICAgICAgICAgLCBtX2ZpbGVIYW5kbGUoMCkKKyAgICAgICAgICAgICwgbV9maWxlSGFuZGxlKElO VkFMSURfSEFORExFX1ZBTFVFKQogICAgICAgICAgICAgLCBtX2ZpbGVMb2FkVGltZXIoam9iLCAm UmVzb3VyY2VMb2FkZXI6OmZpbGVMb2FkVGltZXIpCiAgICAgICAgICAgICAsIG1fcmVzb3VyY2VI YW5kbGUoMCkKICAgICAgICAgICAgICwgbV9zZWNvbmRhcnlIYW5kbGUoMCkKQEAgLTEwMyw3ICsx MDMsNyBAQAogICAgICAgICAgICAgLCByZXNwb25zZShuaWwpCiAjZW5kaWYKICNpZiBVU0UoV0lO SU5FVCkKLSAgICAgICAgICAgICwgbV9maWxlSGFuZGxlKDApCisgICAgICAgICAgICAsIG1fZmls ZUhhbmRsZShJTlZBTElEX0hBTkRMRV9WQUxVRSkKICAgICAgICAgICAgICwgbV9maWxlTG9hZFRp bWVyKGpvYiwgJlJlc291cmNlTG9hZGVyOjpmaWxlTG9hZFRpbWVyKQogICAgICAgICAgICAgLCBt X3Jlc291cmNlSGFuZGxlKDApCiAgICAgICAgICAgICAsIG1fc2Vjb25kYXJ5SGFuZGxlKDApCklu ZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjM0NikK KysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDE4IEBACiAyMDA2LTA5LTEz ICBNb3JnYW5MICA8bW9ybG1vckB5YWhvby5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4u b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg0NQorICAgICAgICBWYXJpb3VzIGJ1Z3MvY3Jhc2hlcyBp biBSZXNvdXJjZUxvYWRlcldpbiB3aXRoIGxvY2FsIGZpbGVzLgorCisgICAgICAgICogcGxhdGZv cm0vUmVzb3VyY2VMb2FkZXJJbnRlcm5hbC5oOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VM b2FkZXJJbnRlcm5hbDo6UmVzb3VyY2VMb2FkZXJJbnRlcm5hbCk6CisgICAgICAgICogcGxhdGZv cm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNl TG9hZGVySW50ZXJuYWw6On5SZXNvdXJjZUxvYWRlckludGVybmFsKToKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlTG9hZGVyOjpmaWxlTG9hZFRpbWVyKToKKworMjAwNi0wOS0xMyAgTW9yZ2Fu TCAgPG1vcmxtb3JAeWFob28uY29tPgorCiAgICAgICAgIFJldmlld2VkL2xhbmRlZCBieSBhcm9i ZW4uCiAKICAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3df YnVnLmNnaT9pZD0xMDgzMwo= 10545 2006-09-13 14:07:46 -0700 2006-09-13 14:16:03 -0700 patch 2 fix-loader-2.diff text/plain 3352 fishd SW5kZXg6IHBsYXRmb3JtL3dpbi9SZXNvdXJjZUxvYWRlcldpbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g cGxhdGZvcm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNwcAkocmV2aXNpb24gMTYzNDYpCisrKyBw bGF0Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzMs NyArMjMzLDcgQEAKIAogUmVzb3VyY2VMb2FkZXJJbnRlcm5hbDo6flJlc291cmNlTG9hZGVySW50 ZXJuYWwoKQogewotICAgIGlmIChtX2ZpbGVIYW5kbGUpCisgICAgaWYgKG1fZmlsZUhhbmRsZSAh PSBJTlZBTElEX0hBTkRMRV9WQUxVRSkKICAgICAgICAgQ2xvc2VIYW5kbGUobV9maWxlSGFuZGxl KTsKIH0KIApAQCAtMjY0LDYgKzI2NCw4IEBACiAgICAgICAgICAgICBwYXRoID0gcGF0aC5taWQo MSk7CiAgICAgICAgIGQtPm1fZmlsZUhhbmRsZSA9IENyZWF0ZUZpbGVBKHBhdGguYXNjaWkoKSwg R0VORVJJQ19SRUFELCAwLCBOVUxMLCBPUEVOX0VYSVNUSU5HLCBGSUxFX0FUVFJJQlVURV9OT1JN QUwsIE5VTEwpOwogCisgICAgICAgIC8vIEZJWE1FOiBwZXJoYXBzIHRoaXMgZXJyb3Igc2hvdWxk IGJlIHJlcG9ydGVkIGFzeW5jaHJvbm91c2x5IGZvcgorICAgICAgICAvLyBjb25zaXN0ZW5jeS4K ICAgICAgICAgaWYgKGQtPm1fZmlsZUhhbmRsZSA9PSBJTlZBTElEX0hBTkRMRV9WQUxVRSkgewog ICAgICAgICAgICAgZGVsZXRlIHRoaXM7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0z MjMsNiArMzI1LDggQEAKIAogdm9pZCBSZXNvdXJjZUxvYWRlcjo6ZmlsZUxvYWRUaW1lcihUaW1l cjxSZXNvdXJjZUxvYWRlcj4qIHRpbWVyKQogeworICAgIGNsaWVudCgpLT5yZWNlaXZlZFJlc3Bv bnNlKHRoaXMsIDApOworCiAgICAgYm9vbCByZXN1bHQgPSBmYWxzZTsKICAgICBEV09SRCBieXRl c1JlYWQgPSAwOwogCkBAIC0zMzAsMTIgKzMzNCwxNSBAQAogICAgICAgICBjb25zdCBpbnQgYnVm ZmVyU2l6ZSA9IDgxOTI7CiAgICAgICAgIGNoYXIgYnVmZmVyW2J1ZmZlclNpemVdOwogICAgICAg ICByZXN1bHQgPSBSZWFkRmlsZShkLT5tX2ZpbGVIYW5kbGUsICZidWZmZXIsIGJ1ZmZlclNpemUs ICZieXRlc1JlYWQsIE5VTEwpOyAKLSAgICAgICAgZC0+Y2xpZW50LT5yZWNlaXZlZERhdGEodGhp cywgYnVmZmVyLCBieXRlc1JlYWQpOworICAgICAgICBpZiAocmVzdWx0ICYmIGJ5dGVzUmVhZCkK KyAgICAgICAgICAgIGQtPmNsaWVudC0+cmVjZWl2ZWREYXRhKHRoaXMsIGJ1ZmZlciwgYnl0ZXNS ZWFkKTsKICAgICAgICAgLy8gQ2hlY2sgZm9yIGVuZCBvZiBmaWxlLiAKICAgICB9IHdoaWxlIChy ZXN1bHQgJiYgYnl0ZXNSZWFkKTsKIAorICAgIC8vIEZJWE1FOiBoYW5kbGUgZXJyb3JzIGJldHRl cgorCiAgICAgQ2xvc2VIYW5kbGUoZC0+bV9maWxlSGFuZGxlKTsKLSAgICBkLT5tX2ZpbGVIYW5k bGUgPSAwOworICAgIGQtPm1fZmlsZUhhbmRsZSA9IElOVkFMSURfSEFORExFX1ZBTFVFOwogCiAg ICAgUGxhdGZvcm1EYXRhU3RydWN0IHBsYXRmb3JtRGF0YTsKICAgICBwbGF0Zm9ybURhdGEuZXJy b3JTdHJpbmcgPSAwOwpJbmRleDogcGxhdGZvcm0vUmVzb3VyY2VMb2FkZXJJbnRlcm5hbC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHBsYXRmb3JtL1Jlc291cmNlTG9hZGVySW50ZXJuYWwuaAkocmV2aXNpb24g MTYzNDYpCisrKyBwbGF0Zm9ybS9SZXNvdXJjZUxvYWRlckludGVybmFsLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM3LDcgKzM3LDcgQEAKICNlbmRpZgogCiAjaWYgVVNFKFdJTklORVQpCi10eXBlZGVm IHZvaWQqIEhBTkRMRTsKKyNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjZW5kaWYKIAogI2lmIFBMQVRG T1JNKEdESykKQEAgLTcxLDcgKzcxLDcgQEAKICAgICAgICAgICAgICwgcmVzcG9uc2UobmlsKQog I2VuZGlmCiAjaWYgVVNFKFdJTklORVQpCi0gICAgICAgICAgICAsIG1fZmlsZUhhbmRsZSgwKQor ICAgICAgICAgICAgLCBtX2ZpbGVIYW5kbGUoSU5WQUxJRF9IQU5ETEVfVkFMVUUpCiAgICAgICAg ICAgICAsIG1fZmlsZUxvYWRUaW1lcihqb2IsICZSZXNvdXJjZUxvYWRlcjo6ZmlsZUxvYWRUaW1l cikKICAgICAgICAgICAgICwgbV9yZXNvdXJjZUhhbmRsZSgwKQogICAgICAgICAgICAgLCBtX3Nl Y29uZGFyeUhhbmRsZSgwKQpAQCAtMTAzLDcgKzEwMyw3IEBACiAgICAgICAgICAgICAsIHJlc3Bv bnNlKG5pbCkKICNlbmRpZgogI2lmIFVTRShXSU5JTkVUKQotICAgICAgICAgICAgLCBtX2ZpbGVI YW5kbGUoMCkKKyAgICAgICAgICAgICwgbV9maWxlSGFuZGxlKElOVkFMSURfSEFORExFX1ZBTFVF KQogICAgICAgICAgICAgLCBtX2ZpbGVMb2FkVGltZXIoam9iLCAmUmVzb3VyY2VMb2FkZXI6OmZp bGVMb2FkVGltZXIpCiAgICAgICAgICAgICAsIG1fcmVzb3VyY2VIYW5kbGUoMCkKICAgICAgICAg ICAgICwgbV9zZWNvbmRhcnlIYW5kbGUoMCkKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzQ2KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDUgKzEsMTggQEAKIDIwMDYtMDktMTMgIE1vcmdhbkwgIDxtb3JsbW9yQHlhaG9vLmNv bT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhl cyBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTEwODQ1Cisg ICAgICAgIFZhcmlvdXMgYnVncy9jcmFzaGVzIGluIFJlc291cmNlTG9hZGVyV2luIHdpdGggbG9j YWwgZmlsZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9SZXNvdXJjZUxvYWRlckludGVybmFsLmg6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRlckludGVybmFsOjpSZXNvdXJjZUxvYWRl ckludGVybmFsKToKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXJJbnRlcm5hbDo6flJlc291cmNlTG9h ZGVySW50ZXJuYWwpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmZpbGVMb2Fk VGltZXIpOgorCisyMDA2LTA5LTEzICBNb3JnYW5MICA8bW9ybG1vckB5YWhvby5jb20+CisKICAg ICAgICAgUmV2aWV3ZWQvbGFuZGVkIGJ5IGFyb2Jlbi4KIAogICAgICAgICBGaXhlcyBodHRwOi8v YnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTEwODMzCg== 10546 2006-09-13 14:16:03 -0700 2006-09-13 22:39:00 -0700 patch 2.1 - using svn-create-patch fix-loader-2.1.diff text/plain 3486 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzQ2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDYtMDkt MTMgIE1vcmdhbkwgIDxtb3JsbW9yQHlhaG9vLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTEwODQ1CisgICAgICAgIFZhcmlvdXMgYnVncy9jcmFzaGVz IGluIFJlc291cmNlTG9hZGVyV2luIHdpdGggbG9jYWwgZmlsZXMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9SZXNvdXJjZUxvYWRlckludGVybmFsLmg6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJj ZUxvYWRlckludGVybmFsOjpSZXNvdXJjZUxvYWRlckludGVybmFsKToKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VMb2FkZXJJbnRlcm5hbDo6flJlc291cmNlTG9hZGVySW50ZXJuYWwpOgorICAgICAgICAoV2Vi Q29yZTo6UmVzb3VyY2VMb2FkZXI6OmZpbGVMb2FkVGltZXIpOgorCiAyMDA2LTA5LTEzICBNb3Jn YW5MICA8bW9ybG1vckB5YWhvby5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQvbGFuZGVkIGJ5IGFy b2Jlbi4KSW5kZXg6IHBsYXRmb3JtL1Jlc291cmNlTG9hZGVySW50ZXJuYWwuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBwbGF0Zm9ybS9SZXNvdXJjZUxvYWRlckludGVybmFsLmgJKHJldmlzaW9uIDE2MzQ2KQor KysgcGxhdGZvcm0vUmVzb3VyY2VMb2FkZXJJbnRlcm5hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0z Nyw3ICszNyw3IEBACiAjZW5kaWYKIAogI2lmIFVTRShXSU5JTkVUKQotdHlwZWRlZiB2b2lkKiBI QU5ETEU7CisjaW5jbHVkZSA8d2luZG93cy5oPgogI2VuZGlmCiAKICNpZiBQTEFURk9STShHREsp CkBAIC03MSw3ICs3MSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICwgcmVz cG9uc2UobmlsKQogI2VuZGlmCiAjaWYgVVNFKFdJTklORVQpCi0gICAgICAgICAgICAsIG1fZmls ZUhhbmRsZSgwKQorICAgICAgICAgICAgLCBtX2ZpbGVIYW5kbGUoSU5WQUxJRF9IQU5ETEVfVkFM VUUpCiAgICAgICAgICAgICAsIG1fZmlsZUxvYWRUaW1lcihqb2IsICZSZXNvdXJjZUxvYWRlcjo6 ZmlsZUxvYWRUaW1lcikKICAgICAgICAgICAgICwgbV9yZXNvdXJjZUhhbmRsZSgwKQogICAgICAg ICAgICAgLCBtX3NlY29uZGFyeUhhbmRsZSgwKQpAQCAtMTAzLDcgKzEwMyw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgICAgICwgcmVzcG9uc2UobmlsKQogI2VuZGlmCiAjaWYgVVNF KFdJTklORVQpCi0gICAgICAgICAgICAsIG1fZmlsZUhhbmRsZSgwKQorICAgICAgICAgICAgLCBt X2ZpbGVIYW5kbGUoSU5WQUxJRF9IQU5ETEVfVkFMVUUpCiAgICAgICAgICAgICAsIG1fZmlsZUxv YWRUaW1lcihqb2IsICZSZXNvdXJjZUxvYWRlcjo6ZmlsZUxvYWRUaW1lcikKICAgICAgICAgICAg ICwgbV9yZXNvdXJjZUhhbmRsZSgwKQogICAgICAgICAgICAgLCBtX3NlY29uZGFyeUhhbmRsZSgw KQpJbmRleDogcGxhdGZvcm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBwbGF0Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3BwCShyZXZpc2lvbiAxNjM0NikKKysr IHBsYXRmb3JtL3dpbi9SZXNvdXJjZUxvYWRlcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIz Myw3ICsyMzMsNyBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXplT2ZmU2NyZWVuUmVzb3VyY2VMCiAK IFJlc291cmNlTG9hZGVySW50ZXJuYWw6On5SZXNvdXJjZUxvYWRlckludGVybmFsKCkKIHsKLSAg ICBpZiAobV9maWxlSGFuZGxlKQorICAgIGlmIChtX2ZpbGVIYW5kbGUgIT0gSU5WQUxJRF9IQU5E TEVfVkFMVUUpCiAgICAgICAgIENsb3NlSGFuZGxlKG1fZmlsZUhhbmRsZSk7CiB9CiAKQEAgLTI2 NCw2ICsyNjQsOCBAQCBib29sIFJlc291cmNlTG9hZGVyOjpzdGFydChEb2NMb2FkZXIqIGRvCiAg ICAgICAgICAgICBwYXRoID0gcGF0aC5taWQoMSk7CiAgICAgICAgIGQtPm1fZmlsZUhhbmRsZSA9 IENyZWF0ZUZpbGVBKHBhdGguYXNjaWkoKSwgR0VORVJJQ19SRUFELCAwLCBOVUxMLCBPUEVOX0VY SVNUSU5HLCBGSUxFX0FUVFJJQlVURV9OT1JNQUwsIE5VTEwpOwogCisgICAgICAgIC8vIEZJWE1F OiBwZXJoYXBzIHRoaXMgZXJyb3Igc2hvdWxkIGJlIHJlcG9ydGVkIGFzeW5jaHJvbm91c2x5IGZv cgorICAgICAgICAvLyBjb25zaXN0ZW5jeS4KICAgICAgICAgaWYgKGQtPm1fZmlsZUhhbmRsZSA9 PSBJTlZBTElEX0hBTkRMRV9WQUxVRSkgewogICAgICAgICAgICAgZGVsZXRlIHRoaXM7CiAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0zMjMsNiArMzI1LDggQEAgYm9vbCBSZXNvdXJjZUxv YWRlcjo6c3RhcnQoRG9jTG9hZGVyKiBkbwogCiB2b2lkIFJlc291cmNlTG9hZGVyOjpmaWxlTG9h ZFRpbWVyKFRpbWVyPFJlc291cmNlTG9hZGVyPiogdGltZXIpCiB7CisgICAgY2xpZW50KCktPnJl Y2VpdmVkUmVzcG9uc2UodGhpcywgMCk7CisKICAgICBib29sIHJlc3VsdCA9IGZhbHNlOwogICAg IERXT1JEIGJ5dGVzUmVhZCA9IDA7CiAKQEAgLTMzMCwxMiArMzM0LDE1IEBAIHZvaWQgUmVzb3Vy Y2VMb2FkZXI6OmZpbGVMb2FkVGltZXIoVGltZXIKICAgICAgICAgY29uc3QgaW50IGJ1ZmZlclNp emUgPSA4MTkyOwogICAgICAgICBjaGFyIGJ1ZmZlcltidWZmZXJTaXplXTsKICAgICAgICAgcmVz dWx0ID0gUmVhZEZpbGUoZC0+bV9maWxlSGFuZGxlLCAmYnVmZmVyLCBidWZmZXJTaXplLCAmYnl0 ZXNSZWFkLCBOVUxMKTsgCi0gICAgICAgIGQtPmNsaWVudC0+cmVjZWl2ZWREYXRhKHRoaXMsIGJ1 ZmZlciwgYnl0ZXNSZWFkKTsKKyAgICAgICAgaWYgKHJlc3VsdCAmJiBieXRlc1JlYWQpCisgICAg ICAgICAgICBkLT5jbGllbnQtPnJlY2VpdmVkRGF0YSh0aGlzLCBidWZmZXIsIGJ5dGVzUmVhZCk7 CiAgICAgICAgIC8vIENoZWNrIGZvciBlbmQgb2YgZmlsZS4gCiAgICAgfSB3aGlsZSAocmVzdWx0 ICYmIGJ5dGVzUmVhZCk7CiAKKyAgICAvLyBGSVhNRTogaGFuZGxlIGVycm9ycyBiZXR0ZXIKKwog ICAgIENsb3NlSGFuZGxlKGQtPm1fZmlsZUhhbmRsZSk7Ci0gICAgZC0+bV9maWxlSGFuZGxlID0g MDsKKyAgICBkLT5tX2ZpbGVIYW5kbGUgPSBJTlZBTElEX0hBTkRMRV9WQUxVRTsKIAogICAgIFBs YXRmb3JtRGF0YVN0cnVjdCBwbGF0Zm9ybURhdGE7CiAgICAgcGxhdGZvcm1EYXRhLmVycm9yU3Ry aW5nID0gMDsK 10561 2006-09-14 17:29:22 -0700 2006-09-18 19:26:10 -0700 patch: add receivedResponse call fix-win.diff text/plain 1055 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzY3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDkt MTQgIE1vcmdhbkwgIDxtb3JsbW9yQHlhaG9vLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZW5kIHJlY2VpdmVkUmVzcG9uc2UgY2FsbGJhY2sg dG8gUmVzb3VyY2VMb2FkZXJDbGllbnQgd2hlbiBsb2FkaW5nCisgICAgICAgIGZpbGUgVVJMcy4K KworICAgICAgICBTZWUgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDg0NQorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjpmaWxlTG9hZFRpbWVyKToKKwog MjAwNi0wOS0xNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTWFjaWVqJ3MgcnViYmVyIHN0YW1wCkluZGV4OiBwbGF0Zm9ybS93aW4vUmVz b3VyY2VMb2FkZXJXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL3dpbi9SZXNvdXJjZUxv YWRlcldpbi5jcHAJKHJldmlzaW9uIDE2MzY3KQorKysgcGxhdGZvcm0vd2luL1Jlc291cmNlTG9h ZGVyV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI1LDYgKzMyNSw4IEBAIGJvb2wgUmVzb3Vy Y2VMb2FkZXI6OnN0YXJ0KERvY0xvYWRlciogZG8KIAogdm9pZCBSZXNvdXJjZUxvYWRlcjo6Zmls ZUxvYWRUaW1lcihUaW1lcjxSZXNvdXJjZUxvYWRlcj4qIHRpbWVyKQogeworICAgIGQtPmNsaWVu dC0+cmVjZWl2ZWRSZXNwb25zZSh0aGlzLCAwKTsKKwogICAgIGJvb2wgcmVzdWx0ID0gZmFsc2U7 CiAgICAgRFdPUkQgYnl0ZXNSZWFkID0gMDsKIAo=