108442 2013-01-31 01:08:00 -0800 [chromium] move runModalBeforeUnloadDialog to TestRunner library 2013-01-31 02:03:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen webkit.review.bot oldest_to_newest 821232 0 jochen 2013-01-31 01:08:00 -0800 [chromium] move runModalBeforeUnloadDialog to TestRunner library 821233 1 185710 jochen 2013-01-31 01:08:38 -0800 Created attachment 185710 Patch 821264 2 185710 webkit.review.bot 2013-01-31 02:03:37 -0800 Comment on attachment 185710 Patch Clearing flags on attachment: 185710 Committed r141392: <http://trac.webkit.org/changeset/141392> 821265 3 webkit.review.bot 2013-01-31 02:03:41 -0800 All reviewed patches have been landed. Closing bug. 185710 2013-01-31 01:08:38 -0800 2013-01-31 02:03:36 -0800 Patch bug-108442-20130131100522.patch text/plain 5429 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMzg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmIwNjcyYjlkZGEwNTgzYmIzNzE4YjBiMTQ0YjIzOGFm MDEwY2Q4OC4uYTZiYjgzZjdiZTFiZmNmZTZiYTI2NDlmN2JmOTFjNzVmNmY3MjVmMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEzLTAxLTMxICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgog CisgICAgICAgIFtjaHJvbWl1bV0gbW92ZSBydW5Nb2RhbEJlZm9yZVVubG9hZERpYWxvZyB0byBU ZXN0UnVubmVyIGxpYnJhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwODQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9wdWJsaWMvV2Vi VGVzdFByb3h5Lmg6CisgICAgICAgIChXZWJUZXN0UnVubmVyOjpXZWJUZXN0UHJveHk6OnJ1bk1v ZGFsQmVmb3JlVW5sb2FkRGlhbG9nKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0UHJveHkuY3BwOgorICAgICAgICAoV2ViVGVzdFJ1bm5l cjo6V2ViVGVzdFByb3h5QmFzZTo6cnVuTW9kYWxCZWZvcmVVbmxvYWREaWFsb2cpOgorICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcDoKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oOgorCisyMDEzLTAxLTMxICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtjaHJvbWl1bV0g bW92ZSBwb3N0TWVzc2FnZSByZWxhdGVkIG1ldGhvZHMgdG8gVGVzdFJ1bm5lciBsaWJyYXJ5CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgzNDMKIApk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9wdWJs aWMvV2ViVGVzdFByb3h5LmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVu bmVyL3B1YmxpYy9XZWJUZXN0UHJveHkuaAppbmRleCAzZGU0MGU0NWY2ZjFkMzAxYTE5NzFiMGNl YzFkNTJlZmFiZGIxYmM5Li5jNTQxNGY0ODg4Zjg0Y2VlMGYxOTYyMjk0N2RiMjg5MWRiOTliNzRk IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3B1 YmxpYy9XZWJUZXN0UHJveHkuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0UnVubmVyL3B1YmxpYy9XZWJUZXN0UHJveHkuaApAQCAtNDY1LDggKzQ2NSw3IEBAIHB1Ymxp YzoKICAgICB9CiAgICAgdmlydHVhbCBib29sIHJ1bk1vZGFsQmVmb3JlVW5sb2FkRGlhbG9nKFdl YktpdDo6V2ViRnJhbWUqIGZyYW1lLCBjb25zdCBXZWJLaXQ6OldlYlN0cmluZyYgbWVzc2FnZSkK ICAgICB7Ci0gICAgICAgIFdlYlRlc3RQcm94eUJhc2U6OnJ1bk1vZGFsQmVmb3JlVW5sb2FkRGlh bG9nKGZyYW1lLCBtZXNzYWdlKTsKLSAgICAgICAgcmV0dXJuIEJhc2U6OnJ1bk1vZGFsQmVmb3Jl VW5sb2FkRGlhbG9nKGZyYW1lLCBtZXNzYWdlKTsKKyAgICAgICAgcmV0dXJuIFdlYlRlc3RQcm94 eUJhc2U6OnJ1bk1vZGFsQmVmb3JlVW5sb2FkRGlhbG9nKGZyYW1lLCBtZXNzYWdlKTsKICAgICB9 CiAgICAgdmlydHVhbCBXZWJLaXQ6OldlYk5hdmlnYXRpb25Qb2xpY3kgZGVjaWRlUG9saWN5Rm9y TmF2aWdhdGlvbihXZWJLaXQ6OldlYkZyYW1lKiBmcmFtZSwgY29uc3QgV2ViS2l0OjpXZWJVUkxS ZXF1ZXN0JiByZXF1ZXN0LCBXZWJLaXQ6OldlYk5hdmlnYXRpb25UeXBlIHR5cGUsIGNvbnN0IFdl YktpdDo6V2ViTm9kZSYgb3JpZ2luYXRpbmdOb2RlLCBXZWJLaXQ6OldlYk5hdmlnYXRpb25Qb2xp Y3kgZGVmYXVsdFBvbGljeSwgYm9vbCBpc1JlZGlyZWN0KQogICAgIHsKZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQcm94eS5j cHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL3NyYy9XZWJUZXN0 UHJveHkuY3BwCmluZGV4IDgyZTQ5MDdjN2I3OWQyYjczYTNjMDgwODMxYmExMDNjNzdiYzIzY2Qu LjUxMTUwMDVlN2U4NmVkNzEwZTU0Yjk3N2UwMjA3OTI1OThmOTFiNDYgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvc3JjL1dlYlRlc3RQcm94eS5j cHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9zcmMvV2Vi VGVzdFByb3h5LmNwcApAQCAtOTc1LDcgKzk3NSw5IEBAIGJvb2wgV2ViVGVzdFByb3h5QmFzZTo6 cnVuTW9kYWxQcm9tcHREaWFsb2coV2ViRnJhbWUqIGZyYW1lLCBjb25zdCBXZWJTdHJpbmcmIG1l CiBib29sIFdlYlRlc3RQcm94eUJhc2U6OnJ1bk1vZGFsQmVmb3JlVW5sb2FkRGlhbG9nKFdlYkZy YW1lKiwgY29uc3QgV2ViU3RyaW5nJiBtZXNzYWdlKQogewogICAgIG1fZGVsZWdhdGUtPnByaW50 TWVzc2FnZShzdHJpbmcoIkNPTkZJUk0gTkFWSUdBVElPTjogIikgKyBtZXNzYWdlLnV0ZjgoKS5k YXRhKCkgKyAiXG4iKTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICBpZiAoIW1fdGVzdEludGVyZmFj ZXMtPnRlc3RSdW5uZXIoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuICFtX3Rl c3RJbnRlcmZhY2VzLT50ZXN0UnVubmVyKCktPnNob3VsZFN0YXlPblBhZ2VBZnRlckhhbmRsaW5n QmVmb3JlVW5sb2FkKCk7CiB9CiAKIHZvaWQgV2ViVGVzdFByb3h5QmFzZTo6bG9jYXRpb25DaGFu Z2VEb25lKFdlYkZyYW1lKiBmcmFtZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1dlYlZpZXdIb3N0LmNwcAppbmRleCAzNjU2ZDZmOGQzNzVmNjE5ZWM5YjNhNzQzZDhiMjljMDBh YmVmMDBhLi41NWRlY2Y2M2ExNWZiMjQ3YzI3MzVmZjhlNDY5M2Y5MTQ5MTg0YjY1IDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCkBAIC0yMzYsMTEg KzIzNiw2IEBAIGJvb2wgV2ViVmlld0hvc3Q6OnJ1bk1vZGFsUHJvbXB0RGlhbG9nKFdlYkZyYW1l KiBmcmFtZSwgY29uc3QgV2ViU3RyaW5nJiBtZXNzYWdlCiAgICAgcmV0dXJuIHRydWU7CiB9CiAK LWJvb2wgV2ViVmlld0hvc3Q6OnJ1bk1vZGFsQmVmb3JlVW5sb2FkRGlhbG9nKFdlYkZyYW1lKiwg Y29uc3QgV2ViU3RyaW5nJiBtZXNzYWdlKQotewotICAgIHJldHVybiAhdGVzdFJ1bm5lcigpLT5z aG91bGRTdGF5T25QYWdlQWZ0ZXJIYW5kbGluZ0JlZm9yZVVubG9hZCgpOwotfQotCiB2b2lkIFdl YlZpZXdIb3N0OjpzaG93Q29udGV4dE1lbnUoV2ViRnJhbWUqLCBjb25zdCBXZWJDb250ZXh0TWVu dURhdGEmIGNvbnRleHRNZW51RGF0YSkKIHsKICAgICBtX2xhc3RDb250ZXh0TWVudURhdGEgPSBh ZG9wdFB0cihuZXcgV2ViQ29udGV4dE1lbnVEYXRhKGNvbnRleHRNZW51RGF0YSkpOwpAQCAtMTEz NCwxMSArMTEyOSw2IEBAIGJvb2wgV2ViVmlld0hvc3Q6Om5hdmlnYXRlKGNvbnN0IFRlc3ROYXZp Z2F0aW9uRW50cnkmIGVudHJ5LCBib29sIHJlbG9hZCkKIAogLy8gUHJpdmF0ZSBmdW5jdGlvbnMg LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogCi06OldlYlRlc3RSdW5uZXI6OldlYlRlc3RSdW5uZXIqIFdlYlZpZXdIb3N0Ojp0ZXN0UnVu bmVyKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9zaGVsbC0+dGVzdFJ1bm5lcigpOwotfQotCiB2 b2lkIFdlYlZpZXdIb3N0Ojp1cGRhdGVGb3JDb21taXR0ZWRMb2FkKFdlYkZyYW1lKiBmcmFtZSwg Ym9vbCBpc05ld05hdmlnYXRpb24pCiB7CiAgICAgLy8gQ29kZSBkdXBsaWNhdGVkIGZyb20gUmVu ZGVyVmlldzo6RGlkQ29tbWl0TG9hZEZvckZyYW1lLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0LmgKaW5kZXggMmI3NjIzZTI2NDUxZGY4MGRiNTg3ZjhjYWZjNjM5 YThhZjFiMmFjMy4uYWQzMTEyZjFjY2JjYzkxMjk4ODRjNWEyMGQwNTdhNzZkZGViOTBlMCAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCkBAIC0yMDcsNyAr MjA3LDYgQEAgY2xhc3MgV2ViVmlld0hvc3QgOiBwdWJsaWMgV2ViS2l0OjpXZWJWaWV3Q2xpZW50 LCBwdWJsaWMgV2ViS2l0OjpXZWJGcmFtZUNsaWVudCwKICAgICB2aXJ0dWFsIHZvaWQgcnVuTW9k YWxBbGVydERpYWxvZyhXZWJLaXQ6OldlYkZyYW1lKiwgY29uc3QgV2ViS2l0OjpXZWJTdHJpbmcm KTsKICAgICB2aXJ0dWFsIGJvb2wgcnVuTW9kYWxDb25maXJtRGlhbG9nKFdlYktpdDo6V2ViRnJh bWUqLCBjb25zdCBXZWJLaXQ6OldlYlN0cmluZyYpOwogICAgIHZpcnR1YWwgYm9vbCBydW5Nb2Rh bFByb21wdERpYWxvZyhXZWJLaXQ6OldlYkZyYW1lKiwgY29uc3QgV2ViS2l0OjpXZWJTdHJpbmcm IG1lc3NhZ2UsIGNvbnN0IFdlYktpdDo6V2ViU3RyaW5nJiBkZWZhdWx0VmFsdWUsIFdlYktpdDo6 V2ViU3RyaW5nKiBhY3R1YWxWYWx1ZSk7Ci0gICAgdmlydHVhbCBib29sIHJ1bk1vZGFsQmVmb3Jl VW5sb2FkRGlhbG9nKFdlYktpdDo6V2ViRnJhbWUqLCBjb25zdCBXZWJLaXQ6OldlYlN0cmluZyYp OwogICAgIHZpcnR1YWwgdm9pZCBzaG93Q29udGV4dE1lbnUoV2ViS2l0OjpXZWJGcmFtZSosIGNv bnN0IFdlYktpdDo6V2ViQ29udGV4dE1lbnVEYXRhJik7CiAgICAgdmlydHVhbCB2b2lkIGRpZFVw ZGF0ZUxheW91dCgpOwogICAgIHZpcnR1YWwgdm9pZCBuYXZpZ2F0ZUJhY2tGb3J3YXJkU29vbihp bnQgb2Zmc2V0KTsKQEAgLTMwMiw4ICszMDEsNiBAQCBwcml2YXRlOgogICAgICAgICBDYWxsYmFj a01ldGhvZFR5cGUgbV9jYWxsYmFjazsKICAgICB9OwogCi0gICAgV2ViVGVzdFJ1bm5lcjo6V2Vi VGVzdFJ1bm5lciogdGVzdFJ1bm5lcigpIGNvbnN0OwotCiAgICAgLy8gQ2FsbGVkIHRoZSB0aXRs ZSBvZiB0aGUgcGFnZSBjaGFuZ2VzLgogICAgIC8vIENhbiBiZSB1c2VkIHRvIHVwZGF0ZSB0aGUg dGl0bGUgb2YgdGhlIHdpbmRvdy4KICAgICB2b2lkIHNldFBhZ2VUaXRsZShjb25zdCBXZWJLaXQ6 OldlYlN0cmluZyYpOwo=