108436 2013-01-30 23:40:39 -0800 [V8] Trace not only major DOM GCs but also minor DOM GCs 2013-01-31 00:54:35 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet nduca webkit.review.bot oldest_to_newest 821138 0 haraken 2013-01-30 23:40:39 -0800 Currently only major DOM GCs are traced. We should also trace minor DOM GCs. 821140 1 185688 haraken 2013-01-30 23:41:44 -0800 Created attachment 185688 Patch 821159 2 185688 abarth 2013-01-31 00:04:06 -0800 Comment on attachment 185688 Patch TRACE_EVENT_BEGIN0 runs in release, right? Does this impact the performance of minor GC? 821166 3 haraken 2013-01-31 00:07:50 -0800 (In reply to comment #2) > (From update of attachment 185688 [details]) > TRACE_EVENT_BEGIN0 runs in release, right? Does this impact the performance of minor GC? Yes, it runs in release. But when I measured the overhead of TRACE_EVENT(), it was less than 10 ns, which is ignorable for minor GCs. 821167 4 abarth 2013-01-31 00:11:18 -0800 Thanks! 821227 5 185688 webkit.review.bot 2013-01-31 00:54:31 -0800 Comment on attachment 185688 Patch Clearing flags on attachment: 185688 Committed r141390: <http://trac.webkit.org/changeset/141390> 821228 6 webkit.review.bot 2013-01-31 00:54:35 -0800 All reviewed patches have been landed. Closing bug. 185688 2013-01-30 23:41:44 -0800 2013-01-31 00:54:31 -0800 Patch bug-108436-20130131163828.patch text/plain 1752 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzgwOGVjMDkzZjFkYWUy Nzk4NGQ1ZDU4MDE5Y2VlM2MzZWMxYTYxOS4uZDdjNzZhMWVlNjkzODkyNDBmYTEyMDRkYTBjZTgw MGM2YzhmNjUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTMwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFRyYWNlIG5v dCBvbmx5IG1ham9yIERPTSBHQ3MgYnV0IGFsc28gbWlub3IgRE9NIEdDcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NDM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IG9ubHkgbWFqb3Ig RE9NIEdDcyBhcmUgdHJhY2VkLgorICAgICAgICBXZSBzaG91bGQgYWxzbyB0cmFjZSBtaW5vciBE T00gR0NzLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOEdDQ29udHJvbGxlcjo6bWlub3JHQ1Byb2xvZ3VlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4 R0NDb250cm9sbGVyOjptaW5vckdDRXBpbG9ndWUpOgorCiAyMDEzLTAxLTMwICBQYXRyaWNrIEdh bnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFBvcnQgRHJhZ0ltYWdlV2lu LmNwcCB0byBXaW5DRQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhH Q0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xs ZXIuY3BwCmluZGV4IDYyY2QyZDNkY2FkYzhhZjcwZDJlOWUxM2M3ZDQ4NzdiOGI1NjliODguLjhl YTAwODU1NTdhYWU5ODMzYTM5NzAyY2E5YzhmZGQyZDRkOTFiZDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKQEAgLTMzMiw2ICszMzIsOCBAQCB2 b2lkIFY4R0NDb250cm9sbGVyOjpnY1Byb2xvZ3VlKHY4OjpHQ1R5cGUgdHlwZSwgdjg6OkdDQ2Fs bGJhY2tGbGFncyBmbGFncykKIAogdm9pZCBWOEdDQ29udHJvbGxlcjo6bWlub3JHQ1Byb2xvZ3Vl KCkKIHsKKyAgICBUUkFDRV9FVkVOVF9CRUdJTjAoInY4IiwgIkdDIik7CisKICAgICBpZiAoaXNN YWluVGhyZWFkT3JHQ1RocmVhZCgpICYmIG1fZWRlbk5vZGVzKSB7CiAgICAgICAgIGZvciAoc2l6 ZV90IGkgPSAwOyBpIDwgbV9lZGVuTm9kZXMtPnNpemUoKTsgaSsrKSB7CiAgICAgICAgICAgICBB U1NFUlQoIW1fZWRlbk5vZGVzLT5hdChpKS0+d3JhcHBlcigpLklzRW1wdHkoKSk7CkBAIC0zNzQs NiArMzc2LDcgQEAgdm9pZCBWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSh2ODo6R0NUeXBlIHR5 cGUsIHY4OjpHQ0NhbGxiYWNrRmxhZ3MgZmxhZ3MpCiAKIHZvaWQgVjhHQ0NvbnRyb2xsZXI6Om1p bm9yR0NFcGlsb2d1ZSgpCiB7CisgICAgVFJBQ0VfRVZFTlRfRU5EMCgidjgiLCAiR0MiKTsKIH0K IAogdm9pZCBWOEdDQ29udHJvbGxlcjo6bWFqb3JHQ0VwaWxvZ3VlKCkK