108422 2013-01-30 21:00:43 -0800 REGRESSION(r141349): "yet another windows ews fix needed" (Requested by lforschler on #webkit). 2013-02-01 12:51:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 107968 1 webkit.review.bot webkit.review.bot abarth jonlee lforschler roger_fong slewis thorton oldest_to_newest 821042 0 webkit.review.bot 2013-01-30 21:00:43 -0800 http://trac.webkit.org/changeset/141349 broke the build: "yet another windows ews fix needed" (Requested by lforschler on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 821044 1 185671 webkit.review.bot 2013-01-30 21:01:12 -0800 Created attachment 185671 ROLLOUT of r141349 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 821045 2 lforschler 2013-01-30 21:02:45 -0800 build-dumprendertree is failing... Looks like we need to get that working before these will ever work. DRT does build on our build slaves ok, so we need to find out what is missing/needed on the EWS bots. Failed to run "['/home/buildbot/WebKit/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=APPLE-EWS-1', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive', '--port=win']" exit_code: 2 cwd: /home/buildbot/WebKit Running run-webkit-tests Failed to run "['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling DumpRenderTree failed! Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106. Failed to run "['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling DumpRenderTree failed! Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106. 822210 3 185911 roger_fong 2013-01-31 18:28:41 -0800 Created attachment 185911 patch Fix to make Win EWS bots go! Again! 822211 4 roger_fong 2013-01-31 18:30:07 -0800 I'm about to submit the patch anyways so I'll cq- the rollout 822215 5 roger_fong 2013-01-31 18:37:03 -0800 Just kidding. The bots aren't in a good state for EWS right now. I'll need to clean that up first. CQ+ing the rollout 822221 6 185671 webkit.review.bot 2013-01-31 18:46:08 -0800 Comment on attachment 185671 ROLLOUT of r141349 Clearing flags on attachment: 185671 Committed r141522: <http://trac.webkit.org/changeset/141522> 823006 7 roger_fong 2013-02-01 11:17:49 -0800 Can someone review this? Thanks 823019 8 185911 lforschler 2013-02-01 11:26:15 -0800 Comment on attachment 185911 patch View in context: https://bugs.webkit.org/attachment.cgi?id=185911&action=review > Scripts/webkitpy/tool/steps/runtests.py:93 > + print self._options.build_style; Is this in here for debugging? You probably want to remove it if so. 823039 9 roger_fong 2013-02-01 11:32:59 -0800 (In reply to comment #8) > (From update of attachment 185911 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185911&action=review > > > Scripts/webkitpy/tool/steps/runtests.py:93 > > + print self._options.build_style; > > Is this in here for debugging? You probably want to remove it if so. Oh yeah, that won't be there. 823070 10 lforschler 2013-02-01 11:48:45 -0800 looks good to me. I don't have reviewer privelidges. But, you can land this manually with the print statement removed. 823151 11 185911 thorton 2013-02-01 12:48:18 -0800 Comment on attachment 185911 patch View in context: https://bugs.webkit.org/attachment.cgi?id=185911&action=review > ChangeLog:8 > + Disabling --quiet option on Windows for now because that fails when we try to use /dev/null. You should fix this on the other end, but it's fine for now. 823159 12 roger_fong 2013-02-01 12:51:44 -0800 http://trac.webkit.org/changeset/141628 Hoepfully that fixes all the issues 185671 2013-01-30 21:01:12 -0800 2013-01-31 18:46:08 -0800 ROLLOUT of r141349 bug-108422-20130131045756.patch text/plain 1393 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMzcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmM0ZmU0MGU3NjliNDg2NDEyN2Y0MGE1MzEwMTYyYjAw MmI0OWI0OS4uZTk3ZmE0ZGIxNjQ3MWZlYzVjNzMxZGNiYWZlMWM2ZDAyNGJhZmVkNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAxLTMwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQxMzQ5LgorICAgICAgICBo dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNDEzNDkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODQyMgorCisgICAgICAgICJ5ZXQgYW5v dGhlciB3aW5kb3dzIGV3cyBmaXggbmVlZGVkIiAoUmVxdWVzdGVkIGJ5IGxmb3JzY2hsZXIKKyAg ICAgICAgb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5OgorICAgICAgICAoV2luRVdTKToKKwogMjAxMy0w MS0zMCAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCB0ZXN0IGZhaWx1cmUgZml4IGZvciByMTQxMzQxLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkK aW5kZXggNzliN2NmNjY4NTdhYWQ2MTlmYWJhMTY0ZGMwYWQxZDgxNDY2ZTNjZC4uYzc0YTRjNDg0 YTc5ZjgwMzc1ZDQxZjQ5MzEyNmU0OGNkM2FjZmFiMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CkBA IC0xNzcsNyArMTc3LDYgQEAgY2xhc3MgV2luRVdTKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVt KToKICAgICAjIFVzZSBkZWJ1ZywgdGhlIEFwcGxlIFdpbiBwb3J0IGZhaWxzIHRvIGxpbmsgUmVs ZWFzZSBvbiAzMi1iaXQgV2luZG93cy4KICAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zOTE5NwogICAgIF9idWlsZF9zdHlsZSA9ICJkZWJ1ZyIKLSAgICBfZGVm YXVsdF9ydW5fdGVzdHMgPSBUcnVlCiAKIAogY2xhc3MgQWJzdHJhY3RDaHJvbWl1bUVXUyhBYnN0 cmFjdEVhcmx5V2FybmluZ1N5c3RlbSk6Cg== 185911 2013-01-31 18:28:41 -0800 2013-02-01 12:48:17 -0800 patch ews_patch.patch text/plain 2296 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTUx OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAx LTMxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRl c3Qgc2NyaXB0cyBmb3IgRVdTIGJvdHMgdG8gZ2V0IHRoZW0gcnVubmluZyBvbmNlIGFuZCBmb3Ig YWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4 NDIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlz YWJsaW5nIC0tcXVpZXQgb3B0aW9uIG9uIFdpbmRvd3MgZm9yIG5vdyBiZWNhdXNlIHRoYXQgZmFp bHMgd2hlbiB3ZSB0cnkgdG8gdXNlIC9kZXYvbnVsbC4KKyAgICAgICAgcnVudGVzdHMucHkgd2Fz IG5vdCBwYXNzaW5nIGluIGEgY29uZmlndXJhdGlvbiB0byBydW4td2Via2l0LXRlc3RzIHdoaWNo IGNhdXNlcyBEUlQgdG8gYnVpbGQgaW4gcmVsZWFzZSBieSBkZWZhdWx0LgorICAgICAgICBIb3dl dmVyLCB3ZSBidWlsZCBpbiBEZWJ1ZyBvbmx5IG9uIHRoZSBFV1MgV2luZG93cyBib3RzLCB3aGlj aCBjYXVzZWQgdGhlIGJ1aWxkIHRvIGZhaWwuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvc3RlcHMvcnVudGVzdHMucHk6CisgICAgICAgIChSdW5UZXN0cy5vcHRpb25zKToKKyAg ICAgICAgKFJ1blRlc3RzLnJ1bik6CisKIDIwMTMtMDEtMzEgIFJvdXNsYW4gU29sb21ha2hpbiAg PHJvdXNsYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gU3VnZ2VzdCAndXBw ZXJjYXNlJyBmb3IgbXVsdGktd29yZCBtaXNzcGVsbGluZyAndXBwZXIgY2FzZScKSW5kZXg6IFNj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkJKHJldmlzaW9uIDE0MTQ2OCkKKysr IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weQkod29ya2luZyBjb3B5KQpA QCAtNDMsNiArNDMsNyBAQAogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBvcHRpb25zKGNscyk6 CiAgICAgICAgIHJldHVybiBBYnN0cmFjdFN0ZXAub3B0aW9ucygpICsgWworICAgICAgICAgICAg T3B0aW9ucy5idWlsZF9zdHlsZSwKICAgICAgICAgICAgIE9wdGlvbnMudGVzdCwKICAgICAgICAg ICAgIE9wdGlvbnMubm9uX2ludGVyYWN0aXZlLAogICAgICAgICAgICAgT3B0aW9ucy5xdWlldCwK QEAgLTg3LDExICs4OCwxOSBAQAogICAgICAgICAgICAgICAgICItLW5vLW5ldy10ZXN0LXJlc3Vs dHMiLAogICAgICAgICAgICAgICAgICItLW5vLXNob3ctcmVzdWx0cyIsCiAgICAgICAgICAgICAg ICAgIi0tZXhpdC1hZnRlci1uLWZhaWx1cmVzPSVzIiAlIHNlbGYuTk9OX0lOVEVSQUNUSVZFX0ZB SUxVUkVfTElNSVRfQ09VTlQsCi0gICAgICAgICAgICAgICAgIi0tcXVpZXQiLAogICAgICAgICAg ICAgXSkKIAorICAgICAgICAgICAgcHJpbnQgc2VsZi5fb3B0aW9ucy5idWlsZF9zdHlsZTsKKyAg ICAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuYnVpbGRfc3R5bGUgPT0gInJlbGVhc2UiOgorICAg ICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCItLXJlbGVhc2UiKQorICAgICAgICAgICAgZWxpZiBz ZWxmLl9vcHRpb25zLmJ1aWxkX3N0eWxlID09ICJkZWJ1ZyI6CisgICAgICAgICAgICAgICAgYXJn cy5hcHBlbmQoIi0tZGVidWciKQorCisgICAgICAgICAgICAjIG9sZC1ydW4td2Via2l0LXRlc3Rz IGRvZXMgbm90IHN1cHBvcnQgLS1za2lwLWZhaWxpbmctdGVzdHMKKyAgICAgICAgICAgICMgVXNp bmcgLS1xdWlldCBvbmUgV2luZG93cyBmYWlscyB3aGVuIHdlIHRyeSB0byB1c2UgL2Rldi9udWxs LCBkaXNhYmxpbmcgZm9yIG5vdyB1bnRpbCB3ZSBmaW5kIGEgZml4CiAgICAgICAgICAgICBpZiBz eXMucGxhdGZvcm0gIT0gImN5Z3dpbiI6CiAgICAgICAgICAgICAgICAgYXJncy5hcHBlbmQoIi0t c2tpcC1mYWlsaW5nLXRlc3QiKQorICAgICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCItLXF1aWV0 IikKIAogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLnF1aWV0OgogICAgICAgICAgICAgYXJncy5h cHBlbmQoIi0tcXVpZXQiKQ==