108400 2013-01-30 16:18:46 -0800 Disable process suppression of DumpRenderTree on Mac 2015-04-27 19:46:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144308 InRadar P2 Normal --- 1 cmuppala cmuppala dfarler jberlin webkit.review.bot oldest_to_newest 820764 0 cmuppala 2013-01-30 16:18:46 -0800 A lot of tests under animations are failing because DumpRenderTree is being process suppressed. A assertion must be taken to prevent this. 820766 1 cmuppala 2013-01-30 16:18:59 -0800 <rdar://problem/13115914> 820777 2 185614 cmuppala 2013-01-30 16:27:14 -0800 Created attachment 185614 Patch 820810 3 185614 jberlin 2013-01-30 16:48:43 -0800 Comment on attachment 185614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185614&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1443 > + reason:@"DumpRenderTree should not be subject to process suppression"]; Please do not use colon-aligning indentation. Subsequent lines should just use a 4 space indent. Also, you need a retain since beginSuspensionOfSystemBehaviors returns an autoreleased object. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1444 > + UNUSED_PARAM(assertion); You should use ASSERT_UNUSED instead. 820825 4 185626 cmuppala 2013-01-30 16:58:38 -0800 Created attachment 185626 Patch 820826 5 cmuppala 2013-01-30 16:59:07 -0800 (In reply to comment #3) > (From update of attachment 185614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185614&action=review > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1443 > > + reason:@"DumpRenderTree should not be subject to process suppression"]; > > Please do not use colon-aligning indentation. Subsequent lines should just use a 4 space indent. > Fixed. > Also, you need a retain since beginSuspensionOfSystemBehaviors returns an autoreleased object. > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1444 > > + UNUSED_PARAM(assertion); > > You should use ASSERT_UNUSED instead. Replaced with ASSERT_UNUSED. 820901 6 185626 webkit.review.bot 2013-01-30 18:08:48 -0800 Comment on attachment 185626 Patch Clearing flags on attachment: 185626 Committed r141353: <http://trac.webkit.org/changeset/141353> 820902 7 webkit.review.bot 2013-01-30 18:08:51 -0800 All reviewed patches have been landed. Closing bug. 185614 2013-01-30 16:27:14 -0800 2013-01-30 16:58:37 -0800 Patch bug-108400-20130130162359.patch text/plain 1606 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMzAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIxZmZiMGE5YTZiNDBhYmM4ZGMyZTY1ZDUxOGE2OTZh MTMyMDE2Mi4uYmNjYzdlZTU2M2Q0MDJiYTk3YjkyMTJiMGM4MjY1MmM3YmU4Njc5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTAxLTMwICBLaXJhbiBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgcHJvY2VzcyBzdXBwcmVzc2lvbiBvZiBEdW1wUmVuZGVyVHJlZSBvbiBN YWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODQw MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOgorICAgICAgICAoK1tEdW1wUmVuZGVy VHJlZUFwcGxpY2F0aW9uIGluaXRpYWxpemVdKTogVGFrZSBhc3NlcnRpb24gdG8gcHJldmVudAor ICAgICAgICBwcm9jZXNzIHN1cHByZXNzaW9uLgorCiAyMDEzLTAxLTMwICBKb2NoZW4gRWlzaW5n ZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gbW92ZSBjdXN0 b20gcG9saWN5IGRlbGVnYXRlIHRvIFRlc3RSdW5uZXIgbGlicmFyeQpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCmluZGV4IDgwM2FkMTU5ZDE4NWY4Yjc3NzFlNmU5 NTUzYTZiNzc0NTBiZmRlODUuLjkwY2YyYzA5Mzc2NmMzMjUzYjFlYzgzYWNlNTIwYTU1NWYyNTcw NjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5t bQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KQEAgLTE0 MzYsNiArMTQzNiwxNSBAQCB2b2lkIGRpc3BsYXlXZWJWaWV3KCkKIAogQGltcGxlbWVudGF0aW9u IER1bXBSZW5kZXJUcmVlQXBwbGljYXRpb24KIAorKyAodm9pZClpbml0aWFsaXplCit7CisjaWYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCisgICAgc3RhdGljIGlkIGFz c2VydGlvbiA9IFtbTlNQcm9jZXNzSW5mbyBwcm9jZXNzSW5mb10gYmVnaW5TdXNwZW5zaW9uT2ZT eXN0ZW1CZWhhdmlvcnM6TlNTeXN0ZW1CZWhhdmlvckNvbW1vbkJlaGF2aW9ycworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmVhc29uOkAiRHVtcFJlbmRlclRyZWUgc2hvdWxkIG5vdCBiZSBzdWJq ZWN0IHRvIHByb2Nlc3Mgc3VwcHJlc3Npb24iXTsKKyAgICBVTlVTRURfUEFSQU0oYXNzZXJ0aW9u KTsKKyNlbmRpZgorfQorCiAtIChCT09MKWlzUnVubmluZwogewogICAgIC8vIDxyZGFyOi8vcHJv YmxlbS83Njg2MTIzPiBKYXZhIHBsdWctaW4gZnJlZXplcyB1bmxlc3MgTlNBcHBsaWNhdGlvbiBp cyBydW5uaW5nCg== 185626 2013-01-30 16:58:38 -0800 2013-01-30 18:08:48 -0800 Patch bug-108400-20130130165522.patch text/plain 1527 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMzAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIxZmZiMGE5YTZiNDBhYmM4ZGMyZTY1ZDUxOGE2OTZh MTMyMDE2Mi4uMzI0ZGUwMTQwM2M2NGRlZWE0MWI1YjcyOTk1ODQ1YWQyOTkxZDVjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTAxLTMwICBLaXJhbiBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgcHJvY2VzcyBzdXBwcmVzc2lvbiBvZiBEdW1wUmVuZGVyVHJlZSBvbiBN YWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODQw MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOgorICAgICAgICAocHJlcGFyZUNvbnNp c3RlbnRUZXN0aW5nRW52aXJvbm1lbnQpOiBUYWtlIGFzc2VydGlvbiB0byBwcmV2ZW50CisgICAg ICAgIHByb2Nlc3Mgc3VwcHJlc3Npb24uCisKIDIwMTMtMDEtMzAgIEpvY2hlbiBFaXNpbmdlciAg PGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBtb3ZlIGN1c3RvbSBw b2xpY3kgZGVsZWdhdGUgdG8gVGVzdFJ1bm5lciBsaWJyYXJ5CmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0gYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KaW5kZXggODAzYWQxNTlkMTg1ZjhiNzc3MWU2ZTk1NTNh NmI3NzQ1MGJmZGU4NS4uMGNhZDExZjBjMjhlYmM1ZjI5MWFhN2Y3OGZjYzQ1N2Y5Y2E0ZGQzZCAx MDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpAQCAtODQzLDYg Kzg0MywxMiBAQCBzdGF0aWMgdm9pZCBwcmVwYXJlQ29uc2lzdGVudFRlc3RpbmdFbnZpcm9ubWVu dCgpCiAgICAgYWxsb2NhdGVHbG9iYWxDb250cm9sbGVycygpOwogICAgIAogICAgIG1ha2VMYXJn ZU1hbGxvY0ZhaWxTaWxlbnRseSgpOworCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDkwCisgICAgc3RhdGljIGlkIGFzc2VydGlvbiA9IFtbW05TUHJvY2Vzc0luZm8g cHJvY2Vzc0luZm9dIGJlZ2luU3VzcGVuc2lvbk9mU3lzdGVtQmVoYXZpb3JzOk5TU3lzdGVtQmVo YXZpb3JDb21tb25CZWhhdmlvcnMKKyAgICAgICAgcmVhc29uOkAiRHVtcFJlbmRlclRyZWUgc2hv dWxkIG5vdCBiZSBzdWJqZWN0IHRvIHByb2Nlc3Mgc3VwcHJlc3Npb24iXSByZXRhaW5dOworICAg IEFTU0VSVF9VTlVTRUQoYXNzZXJ0aW9uLCBhc3NlcnRpb24pOworI2VuZGlmCiB9CiAKIHZvaWQg ZHVtcFJlbmRlclRyZWUoaW50IGFyZ2MsIGNvbnN0IGNoYXIgKmFyZ3ZbXSkK