10840 2006-09-13 09:16:58 -0700 REGRESSION: Shadow of file upload button is clipped 2006-11-02 19:25:13 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED data:text/html,<input%20type="button"%20value="Choose%20File"><input%20type="file"> Regression P1 Normal --- 1 mitz aroben aroben joost oldest_to_newest 55405 0 mitz 2006-09-13 09:16:58 -0700 The shadow below the new file upload button is clipped. See URL and attached screenshot. 55406 1 10531 mitz 2006-09-13 09:18:04 -0700 Created attachment 10531 Screenshot 55414 2 aroben 2006-09-13 10:27:16 -0700 Looks like we just need a little vertical padding to fix this. RenderFileUploadControl pushes a clip in paint() based on the size of the renderer, so we just need to increase the height to keep from clipping the shadow. 55422 3 ddkilzer 2006-09-13 11:02:04 -0700 Do we need a 'NativeFileUpload' keyword in Bugzilla? 55429 4 aroben 2006-09-13 11:20:14 -0700 (In reply to comment #3) > Do we need a 'NativeFileUpload' keyword in Bugzilla? Adele just created one, and I've added it to the relevant bugs 55526 5 10560 aroben 2006-09-14 15:48:41 -0700 Created attachment 10560 Fix: Expand the clip 2px in height This can be fixed by adding 2px to the height of the clip to allow the shadow to draw. See patch. P.S. There's something oddly satisfying about using the new upload control to upload a patch to fix the new upload control. 55563 6 mitz 2006-09-14 23:23:14 -0700 (In reply to comment #5) > Created an attachment (id=10560) [edit] > Fix: Expand the clip 2px in height > > This can be fixed by adding 2px to the height of the clip to allow the shadow > to draw. See patch. > Hmm... this works well for the default style on the Mac (in which case you might as well not clip), but in other cases, i.e. when the button is style (for example, by increasing the font size, which selects a bigger Mac button with bigger shadow, or by using a non-themed button) or set a smaller height for the upload control, it seems to me that this patch will defeat the purpose of clipping, and might also not repaint those 2 pixels (in fact, that's true for the default case too, but it's currently common to all Mac buttons). 47590 7 andersca 2006-11-02 19:25:13 -0800 Committed revision 17555. 10531 2006-09-13 09:18:04 -0700 2006-09-13 09:18:04 -0700 Screenshot shadow clipped.png image/png 2811 mitz iVBORw0KGgoAAAANSUhEUgAAAKsAAAAaCAIAAABHHDueAAABzGlDQ1BJQ0MgUHJvZmlsZQAAeJyt kT9oU1EUh7/7StqAEkSeqNDhCdI6pCE0SquDJGYQ0UKoEZOAlJf7XpNA3svl5SZVcOjkJoKDOJQi iOjiIoh/OpjBwUGRIhRHNwfdlC6iz+EaAkJw8cCB7/zgHM75HZiYdpVqW0AQ6mj57BmnUq05Uzsk OESSUxx2ZVcVSqULjI3dHQTAhzlXqfaXt5k7z24kjsyufypMPXz6YnwfAKmoUq2BSAN2w3AesOuG y4C9ppUG0QRs2XQ9ENeBdFReLoJ4BKQahp8DqbrhN0CqLxsaxEcgG3qtEKwksOj5XQlWHljxujIA 6x5wNAg6HlivgWNSRRqsr8BcpVpzzMr9z3B6E6xbI61ah8cn4cDCSJu5CfYCbLkj7fttBCAObnZX c/MAiD0rkLgSx98WYfI9/Doexz+exPHPuzCxC6+2ZS/q//FLiHfwr9rcbGrY1kMax8YXALJwfwCX gfMD2BjAzBrs34JSHspg5XLDNB4CkGgtuUP+bxG0e8OZAtjrh5cuAklgmhZLuEjzL4DJfbAxC/Ay 82D971nav6oBih11LWo1mtopKNX2nWInUD3tR2nnXCgzaWc+mz0B8Bv4a4S2KiVIAwAACOpJREFU aIHtWmtsFNcVPvcxc2fGay84u4sNMbbB4IcIBsdCVfFSDFZaWiRKKS4NoIY6aQgJqUQtEE0QiFRt BSIqiUKKVFeVEhUKRBWNoDbgYGRDBVUI6xAMi11jjB/FeNf78HpfM7c/rr0s9kKpmoLT5fsx2j17 5s757p773ccZxDmHJ0hi4McdwBM8ZjzJgGQHfcBvnHPOeTgcRghxzsVVgBDC4wAACCGEEMZ4XNkF OOeyLIvP//su/YohcQYYhhGJRG7evHn16tUbN260trampKQEAoFHHNx/D13XMcZ5eXk5OTkFBQVT p06VJAnjxMqXnKxRwpXgwMDAoUOHrl27lpubW1xcnJubm5aWBgCUUjGSDMOAkXEGI2pxt9FxY49G o16vt7293eFwtLe35+fnV1ZWTpgwIWFfJCfrBBkQCoVqamqcTmdxcXFZWZnFYqH0QZOFkNnxbI9G o319fWfPnnU4HDNnzqyqqmKMjborOVlDwlmgtra2ra2tsLAwOztbURTRlnjGWOdxjlinqKqanZ0d DoedTmdtbe2yZctGeSYnaxibAZ2dnS0tLfn5+Var1Ww267oeDAYxxmIWQQgFB+54dMRYismkUID+ z+v+FpmztGSSeHCsv2K69CjskZ66I45ZK7/1NB3tDwCGYRiGoeu62Wy22WwIoZaWlpKSkqysrCRn LXDP6oBz3tzczBizWCyapolpT7TFOec+5/5XrFkzCmcVFMzIzcq0rnX4eNeZNes+ucU5Fz53nUfw pdkDlzbYbNYRfHe/w+d412p912UYfOjW2tfX9gQStBNrShDRNM1isTDGmpub4zUzOVkL3KMBhmF0 d3dbLBaz2UwIAYDYUOC85+3pZbuKfnqmpbrIogz5+pyXOyap6LZcVgSSyEHDMGKDJj5nvxw7Qn6A LQcvvDpvQkhHVDGZwHbmTDQVIU7ofJgfv9mLtSO+6ro+NDQEAIwxSqnFYunu7jYMQ3AEgORknUAD hPplZmYyxjRNo5Tquj44OOjz+br/fnQXwO9qNmTggMvlGoqQrPxpstcVCER09xcH3lpls9kyVu/5 9Jbb7Xbfvnr6zaUia5fWnPzC4/G43e5rDTUjtuoTV3vcbren+7PdL9ptNpvVWtXY6XK5XK7bl9/f aM/IyLDZNza09bni4B7wugE0c8pQhBuGEQ54e66e2Lnvk1632+P1RyHqG3C7XK6eyydeK7NarVb7 xpp2j8fj8fh8vmAwaBgGpVTTNFVVMzMzg8Ggrusx4snJOkEGxCQCj4AQQimllPZdOwuwY95kZRTk lMnX3nn9dPr6ixfrqup3n7wZUpT+ffbK5kUHrnR0XDi8ZOvq8qZ+qnjO2yu3LjpwrqPDeXhJz2r7 3n5F8Vw+svsvFec6OpzNOwrMiqLQ82+XbzdtbuvoqHspXLm9Ht3zKGYGqD1yuO7jjz/6qMlDFRr2 1f/JJ37CgGVFUZT+veWrTZvPdXRcecm9dXtd13CQsixJkizL8XvisXqYnKxHrwQxxqmpqYQQVVXF /QghQgjVMRQSNmY/IRu34ScH3l9vBwjmF4JPY6TvwntQdLyqPJ1Bun3NrqIdhy91F8snAba9UD6N AdhfqJ6/47lLPduWzHgWYMOLm8i2135cbmMQ7WmqAZjfsHePw+38M5yYxeMfxyUMgFMo1ahGqcyY rFEAkBmTDQkDlmVGeq7UAMxv+MMeBzhPwIniIUmSdF0fpXuEkFHHI8nJOnEGCD9N0yRJopSKsyRC SO6zdtjyxqW+9Ysy7vE3ECrKtBFCAHgEASaYG1GAdEZEAASnA4oaBh4CUORhG0EA2CCmGSt7WuYc PfjbH5bPefmDz35RgRHA95cvX/P1p4YiK17ZmZ4WT4IQP8DyFT9aWaQIgx8jETClBAHChBCMAeDb y1eXPwWRFat3pk+llBJCdF2XJIlzLmbNwcHBhL2TbKwF7kkKhJCqqhhjVVVlWVYURQwIWZYnFi/Z BPCDVdub+8OSJPGI79P6+i5DpgQhTGVZZowRBERi5gL7Omjaf/yKJEmB6/XVTfA9e36efRnAG39t CUiSdL32gyZY97UC8+Ct6/9MKXj+Z7/+jR2a/uGV1GnPbYAjR6+r04rnzn3maYtZ6JiIgTEJAeiI M8aG7UAAKGNMkigCJDGm5c/bBFD7uWf6nDlz5xamp6qx+CVJEsIYIxi/0U9O1gk0ACFks9nu3Llj s9kIIbGhQCnldMZbXRe0l+ctLtg37D2r+mLFUkVFKCIyH2sIIhhjnP2ri4cqS74x4VUAgOoPzz8/ M5Xz5RcPvVmyIHsDAMCCD8//MU/GV86/M2/9QQAAWHXs98WU0m/+smXv+sJnMrYAACzY23u86q4e YmwGUNjdWY0qBGYBxliSqBkQxpiQnJ+3HNtc+J1J2wEAFuw+e2z9bDQCUT3SdV0QjO+L5GQ9/KfH Lw10XW9vbz99+vTixYvF1kjoSex8FCHkd/cNRYGqqRNNyqi2eNzZBUDU7w9SxaTQOHs06A9GFZOJ xvz1ULxFYMjn05Fk+jftP8Ae9fuDQJUUNix60WhU13Vx9Xg89fX15eXlubm5MVVsbW1NQtbD7EYt Dr1e76lTp0Kh0MKFC1NTU2PLogeE8p/H+qjtnPNwOByJRHw+X0NDA2OsoqJCVH0EkpO1wOjFoaqq paWlfr+/sbGxt7c31hHwECfk93N47HaEkCzLvb29jY2Nfr+/tLRUVdV4z+RkPezGxxSU/H5/V1dX c3Nza2trWlpaXl7e9OnTJ0+ePDZ9xj+8Xm93d3dbW1tra6vX683Ly5s9e/aUKVNMJlN86S85WQsk KDWK00S3293V1XXjxo3Ozs6+vj6v1xsKhWInSmKzMepGMcGMKztjLC0tzWq1ZmVl5eTkTJkyZeLE iaqqjt0XJSdruN8bIoZhRKPRUCjk9/sHBwcDgUAkEolEIjFnlKhKHV+hGid2sa3SNC0lJcVkMokT 8vu9LZOcSJwBMPLCiagwxlefhm/7imRADOLMJ76O8gQC982AeDyMz3jGk3/9AXioDHiC/2P8Cy+T oD9CFSXkAAAAAElFTkSuQmCC 10560 2006-09-14 15:48:41 -0700 2006-09-14 23:01:58 -0700 Fix: Expand the clip 2px in height bugzilla-10840-fileupload-clip.diff text/plain 1867 aroben SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjM2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDktMTQgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVz IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NDAKKyAg ICAgICAgUkVHUkVTU0lPTjogU2hhZG93IG9mIGZpbGUgdXBsb2FkIGJ1dHRvbiBpcyBjbGlwcGVk CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OnBhaW50T2JqZWN0KTogQWRk IDJweCB0byB0aGUgY2xpcAorICAgICAgICBoZWlnaHQgdG8ga2VlcCBmcm9tIGNsaXBwaW5nIGlu IHRoZSBzaGFkb3cKKwogMjAwNi0wOS0xNCAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IGhhcnJpc29uCkluZGV4OiBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCShyZXZpc2lvbiAxNjM2 MykKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTg3LDYgKzE4Nyw4IEBAIFJlbmRlclN0eWxlKiBSZW5kZXJGaWxlVXBs b2FkQ29udHJvbDo6Y3IKIAogdm9pZCBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6cGFpbnRPYmpl Y3QoUGFpbnRJbmZvJiBpLCBpbnQgdHgsIGludCB0eSkKIHsKKyAgICBjb25zdCBpbnQgYnV0dG9u U2hhZG93SGVpZ2h0ID0gMjsKKyAgICAKICAgICAvLyBTaW5jZSB3ZSBkcmF3IHRoZSBmaWxlIGlj b24gd2l0aG91dCBnb2luZyB0aHJvdWdoIHRoZSBncmFwaGljcyBjb250ZXh0LAogICAgIC8vIHdl IG5lZWQgdG8gbWFrZSBzdXJlIHBhaW50aW5nIGlzIG5vdCBkaXNhYmxlZCBiZWZvcmUgZHJhd2lu ZwogICAgIGlmIChpLnAtPnBhaW50aW5nRGlzYWJsZWQoKSkKQEAgLTE5NSw3ICsxOTcsNyBAQCB2 b2lkIFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpwYWludE9iamVjCiAgICAgLy8gUHVzaCBhIGNs aXAuCiAgICAgaWYgKGkucGhhc2UgPT0gUGFpbnRQaGFzZUZvcmVncm91bmQgfHwgaS5waGFzZSA9 PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmRzKSB7CiAgICAgICAgIEludFJlY3QgY2xp cFJlY3QodHggKyBib3JkZXJMZWZ0KCksIHR5ICsgYm9yZGVyVG9wKCksCi0gICAgICAgICAgICAg ICAgICAgICAgICAgd2lkdGgoKSAtIGJvcmRlckxlZnQoKSAtIGJvcmRlclJpZ2h0KCksIGhlaWdo dCgpIC0gYm9yZGVyQm90dG9tKCkgLSBib3JkZXJUb3AoKSk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgd2lkdGgoKSAtIGJvcmRlckxlZnQoKSAtIGJvcmRlclJpZ2h0KCksIGhlaWdodCgpIC0g Ym9yZGVyQm90dG9tKCkgLSBib3JkZXJUb3AoKSArIGJ1dHRvblNoYWRvd0hlaWdodCk7CiAgICAg ICAgIGlmIChjbGlwUmVjdC53aWR0aCgpID09IDAgfHwgY2xpcFJlY3QuaGVpZ2h0KCkgPT0gMCkK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgaS5wLT5zYXZlKCk7Cg==