108390 2013-01-30 14:57:52 -0800 Make JSEventListener more robust in the event of the compiled handler being released. 2013-01-30 17:30:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 820640 0 oliver 2013-01-30 14:57:52 -0800 Make JSEventListener more robust in the event of the compiled handler being released. 820650 1 185591 oliver 2013-01-30 15:03:29 -0800 Created attachment 185591 Patch 820839 2 oliver 2013-01-30 17:09:52 -0800 Committed r141348: <http://trac.webkit.org/changeset/141348> 820840 3 185591 ggaren 2013-01-30 17:09:55 -0800 Comment on attachment 185591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185591&action=review > Source/WebCore/bindings/js/JSLazyEventListener.cpp:-125 > - // Since we only parse once, there's no need to keep data used for parsing around anymore. > - m_functionName = String(); > - m_code = String(); > - m_eventParameterName = String(); > - m_sourceURL = String(); Why do we need this, given the early return? 820859 4 oliver 2013-01-30 17:30:19 -0800 (In reply to comment #3) > (From update of attachment 185591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185591&action=review > > > Source/WebCore/bindings/js/JSLazyEventListener.cpp:-125 > > - // Since we only parse once, there's no need to keep data used for parsing around anymore. > > - m_functionName = String(); > > - m_code = String(); > > - m_eventParameterName = String(); > > - m_sourceURL = String(); > > Why do we need this, given the early return? So that we maintain correct behaviour - the only reason we hit this is if we want to execute the function so not running the function would result in incorrect behaviour. 185591 2013-01-30 15:03:29 -0800 2013-01-30 17:09:55 -0800 Patch bug-108390-20130130150014.patch text/plain 3286 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYyOTA2MGNmZDU1Zjk2 NWVjYTUwMjRjNzYxOGI0YmM4ODBiYWM4Yy4uMDk2M2FjOWRmMzg4N2FkMzBlNzAyYzg3ZTJlNDc3 OWM1NTAwYzNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAxLTMwICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBKU0V2ZW50TGlzdGVu ZXIgbW9yZSByb2J1c3QgaW4gdGhlIGV2ZW50IG9mIHRoZSBjb21waWxlZCBoYW5kbGVyIGJlaW5n IHJlbGVhc2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA4MzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSXQgc2hvdWxkbid0IGJlIHBvc3NpYmxlIGZvciBhIGhhbmRsZXIgdG8gYmUgY29sbGVjdGVk IGZvciBhbnkgb2JqZWN0IHRoYXQKKyAgICAgICAgbWlnaHQgc3RpbGwgdHJpZ2dlciBhbiBldmVu dC4gIE5vbmV0aGVsZXNzIGl0IGRvZXMgc3RpbGwgaGFwcGVuLCBhbmQgdGhlCisgICAgICAgIG9u bHkgcG9pbnQgb2YgZmFpbHVyZSB0aGF0IGN1cnJlbnRseSBleGlzdHMgaXMgY29tcGlsaW5nIHRo ZSBoYW5kbGVyLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgbW9zdGx5IGp1c3QgYXNzZXJ0aW9u cywgYnV0IGFsc28gcmVtb3ZlcyBhIGJ1bmNoIG9mIGZpZWxkCisgICAgICAgIGNsZWFyaW5nIHRo YXQgd2FzIHByZXZpb3VzbHkgYmVpbmcgcGVyZm9ybWVkLiAgR2l2ZW4gd2UgZG8gc2VlbSB0byBw ZXJpb2RpY2FsbHkKKyAgICAgICAgZW5kIHVwIG5lZWRpbmcgdG8gcmVjb21waWxlIGEgaGFuZGxl ciB0aGlzIGFwcGVhcnMgdG8gYmUgbmVjZXNzYXJ5LiAgVGhhdAorICAgICAgICBzYWlkIHRoZXJl IGRvZXMgbm90IGFwcGVhciB0byBiZSBhIG1lbW9yeSBoaXQgZnJvbSB0aGlzIGFzIHRoZSBldmVu dCBoYW5kbGVycworICAgICAgICB0aGF0IG1ha2UgdXMgdXNlIEpTTGF6eUV2ZW50TGlzdGVuZXIg YXJlIG5vdCBmcmVxdWVudGx5IGNvbXBpbGVkLCBhbmQgdGhlIGJ1bGsKKyAgICAgICAgb2YgdGhl IGZ1bmN0aW9ucyB0aGF0IGFyZSBjb21waWxlZCBlbmQgdXAgY2F1c2luZyB1cyB0byBrZWVwIHRo ZSBzdHJpbmdzIGFyb3VuZAorICAgICAgICBhbnl3YXkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9KU0xhenlFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTTGF6eUV2ZW50 TGlzdGVuZXI6OkpTTGF6eUV2ZW50TGlzdGVuZXIpOgorICAgICAgICAoV2ViQ29yZTo6SlNMYXp5 RXZlbnRMaXN0ZW5lcjo6aW5pdGlhbGl6ZUpTRnVuY3Rpb24pOgorCiAyMDEzLTAxLTMwICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSB3aWxs QWRkQXV0aG9yU2hhZG93Um9vdCBhbmQgcmVwbGFjZSB3aXRoIGFsd2F5c0NyZWF0ZVVzZXJBZ2Vu dFNoYWRvd1Jvb3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTGF6 eUV2ZW50TGlzdGVuZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNMYXp5RXZl bnRMaXN0ZW5lci5jcHAKaW5kZXggODdkYzQ5MjUzN2RlMzU3YWJlOGRiZTc4YzRhZDdiYjA4M2Iw MTdhZi4uODc0NDlhZjcxMjM2ZjdlN2QyZmVkNDliOTE1YzE4MzA0NzRkMmMwMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNMYXp5RXZlbnRMaXN0ZW5lci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNMYXp5RXZlbnRMaXN0ZW5lci5jcHAKQEAg LTU2LDYgKzU2LDggQEAgSlNMYXp5RXZlbnRMaXN0ZW5lcjo6SlNMYXp5RXZlbnRMaXN0ZW5lcihj b25zdCBTdHJpbmcmIGZ1bmN0aW9uTmFtZSwgY29uc3QgU3RyaW4KICAgICBpZiAobV9wb3NpdGlv biA9PSBUZXh0UG9zaXRpb246OmJlbG93UmFuZ2VQb3NpdGlvbigpKQogICAgICAgICBtX3Bvc2l0 aW9uID0gVGV4dFBvc2l0aW9uOjptaW5pbXVtUG9zaXRpb24oKTsKIAorICAgIEFTU0VSVChtX2V2 ZW50UGFyYW1ldGVyTmFtZSA9PSAiZXZ0IiB8fCBtX2V2ZW50UGFyYW1ldGVyTmFtZSA9PSAiZXZl bnQiKTsKKwogI2lmbmRlZiBOREVCVUcKICAgICBldmVudExpc3RlbmVyQ291bnRlci5pbmNyZW1l bnQoKTsKICNlbmRpZgpAQCAtNzUsNiArNzcsMTEgQEAgSlNPYmplY3QqIEpTTGF6eUV2ZW50TGlz dGVuZXI6OmluaXRpYWxpemVKU0Z1bmN0aW9uKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGV4ZWMK ICAgICBpZiAoIWV4ZWN1dGlvbkNvbnRleHQpCiAgICAgICAgIHJldHVybiAwOwogCisgICAgQVNT RVJUKCFtX2NvZGUuaXNOdWxsKCkpOworICAgIEFTU0VSVCghbV9ldmVudFBhcmFtZXRlck5hbWUu aXNOdWxsKCkpOworICAgIGlmIChtX2NvZGUuaXNOdWxsKCkgfHwgbV9ldmVudFBhcmFtZXRlck5h bWUuaXNOdWxsKCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAgRG9jdW1lbnQqIGRvY3VtZW50 ID0gc3RhdGljX2Nhc3Q8RG9jdW1lbnQqPihleGVjdXRpb25Db250ZXh0KTsKIAogICAgIGlmICgh ZG9jdW1lbnQtPmZyYW1lKCkpCkBAIC0xMTcsMTIgKzEyNCw2IEBAIEpTT2JqZWN0KiBKU0xhenlF dmVudExpc3RlbmVyOjppbml0aWFsaXplSlNGdW5jdGlvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0 KiBleGVjCiAgICAgICAgIC8vIChhbmQgdGhlIGRvY3VtZW50LCBhbmQgdGhlIGZvcm0gLSBzZWUg SlNIVE1MRWxlbWVudDo6ZXZlbnRIYW5kbGVyU2NvcGUpCiAgICAgICAgIGxpc3RlbmVyQXNGdW5j dGlvbi0+c2V0U2NvcGUoZXhlYy0+Z2xvYmFsRGF0YSgpLCBqc0Nhc3Q8SlNOb2RlKj4od3JhcHBl cigpKS0+cHVzaEV2ZW50SGFuZGxlclNjb3BlKGV4ZWMsIGxpc3RlbmVyQXNGdW5jdGlvbi0+c2Nv cGUoKSkpOwogICAgIH0KLQotICAgIC8vIFNpbmNlIHdlIG9ubHkgcGFyc2Ugb25jZSwgdGhlcmUn cyBubyBuZWVkIHRvIGtlZXAgZGF0YSB1c2VkIGZvciBwYXJzaW5nIGFyb3VuZCBhbnltb3JlLgot ICAgIG1fZnVuY3Rpb25OYW1lID0gU3RyaW5nKCk7Ci0gICAgbV9jb2RlID0gU3RyaW5nKCk7Ci0g ICAgbV9ldmVudFBhcmFtZXRlck5hbWUgPSBTdHJpbmcoKTsKLSAgICBtX3NvdXJjZVVSTCA9IFN0 cmluZygpOwogICAgIHJldHVybiBqc0Z1bmN0aW9uOwogfQogCg==