10838 2006-09-13 06:30:42 -0700 REGRESSION: Leaking of WebScriptObjectPrivate 2006-10-02 10:50:29 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED Regression P2 Normal --- 1 mrowe webkit-unassigned slewis oldest_to_newest 55392 0 mrowe 2006-09-13 06:30:42 -0700 `run-webkit-tests --leaks` generates leak reports that have dozens of WebScriptObjectPrivate's being leaked. An example of the backtrace is: Call stack: [thread 2d63a7]: | 0x0 | start | _start | main | runTest | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection(NSURLConnectionInternal) _sendDidReceiveDataCallback] | -[WebLoader connection:didReceiveData:lengthReceived:] | -[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:] | -[WebLoader didReceiveData:lengthReceived:allAtOnce:] | -[WebMainResourceLoader addData:allAtOnce:] | -[WebFrameLoader _receivedData:] | -[WebDataSource(WebInternal) _receivedData:] | -[WebDataSource(WebFileInternal) _commitLoadWithData:] | -[WebHTMLRepresentation receivedData:withDataSource:] | -[WebFrameBridge receivedData:textEncodingName:] | -[WebCoreFrameBridge setEncoding:userChosen:] | WebCore::Frame::setEncoding(WebCore::String const&, bool) | WebCore::Frame::receivedFirstData() | WebCore::Frame::begin(WebCore::KURL const&) | WebCore::FrameMac::partClearedInBegin() | -[WebFrameBridge windowObjectCleared] | -[WebCoreFrameBridge windowScriptObject] | WebCore::FrameMac::windowScriptObject() | -[WebScriptObject _initWithJSObject:originExecutionContext:executionContext:] | NSAllocateObject | _internal_class_createInstanceFromZone Leak: 0x1f89dce0 size=32 instance of 'WebScriptObjectPrivate' See http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/2531/DumpRenderTree5-leaks.txt for more examples. 55537 1 mrowe 2006-09-14 18:03:49 -0700 The WebScriptObject's and co are expected to be cleaned up from FrameMac::cleanupPluginObjects, but this is never being called. It is intended to be called from Frame::clear but as cleanupPluginObjects is a virtual method being called from the Frame destructor, the FrameMac subclass portion of the object has already been torn down. 55546 2 10567 mrowe 2006-09-14 20:21:22 -0700 Created attachment 10567 Patch 55548 3 10567 aroben 2006-09-14 20:38:11 -0700 Comment on attachment 10567 Patch r=me, although you've got a typo in your ChangeLog: "this its" should be "its" 55549 4 10567 aroben 2006-09-14 20:42:42 -0700 Comment on attachment 10567 Patch Stephanie is going to confirm that this patch helps fix some of our current performance regression, and then give you permission to check in if it does (since the tree is currently closed). 55562 5 mrowe 2006-09-14 23:02:51 -0700 Stephanie gave the go-ahead via IRC, and this was landed as r16368. 56940 6 timothy 2006-10-02 10:50:29 -0700 This landed in r16368. 10567 2006-09-14 20:21:22 -0700 2006-09-14 20:38:11 -0700 Patch webkit-bug-10838-v1.patch text/plain 2786 mrowe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjM2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDYtMDktMTUgIE1hcmsgUm93ZSAgPG9wZW5kYXJ3aW4ub3JnQGJk YXNoLm5ldC5uej4KKworICAgICAgICBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTEwODM4CisgICAgICAgIEJ1ZyAxMDgzODogUkVHUkVTU0lPTjogTGVha2lu ZyBvZiBXZWJTY3JpcHRPYmplY3RQcml2YXRlCisKKyAgICAgICAgRnJhbWVNYWMgcmVsaWVzIG9u IGl0cyBjbGVhbnVwUGx1Z2luT2JqZWN0cyBiZWluZyBjYWxsZWQgdG8gcGVyZm9ybSBjbGVhbnVw LiAgRnJhbWUKKyAgICAgICAgY2FsbHMgdGhpcyBpdHMgdmlydHVhbCBjbGVhbnVwUGx1Z2luT2Jq ZWN0cyBtZXRob2QgZnJvbSBpdHMgZGVzdHJ1Y3Rvciwgd2hpY2ggcmVzdWx0cworICAgICAgICBp biBGcmFtZTo6Y2xlYW51cFBsdWdpbk9iamVjdHMgYmVpbmcgY2FsbGVkIHJhdGhlciB0aGFuIEZy YW1lTWFjOjpjbGVhbnVwUGx1Z2luT2JqZWN0cy4KKworICAgICAgICAqIGJyaWRnZS9tYWMvRnJh bWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpGcmFtZU1hYzo6fkZyYW1lTWFjKTogQ2FsbCBj YW5jZWxBbmRDbGVhciB0byBlbnN1cmUgdGhhdCBGcmFtZU1hYzo6Y2xlYW51cFBsdWdpbk9iamVj dHMKKyAgICAgICAgd2lsbCBiZSBjYWxsZWQgZnJvbSBGcmFtZTo6Y2xlYXIKKyAgICAgICAgKiBw YWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjp+RnJhbWUpOiBVc2UgY2Fu Y2VsQW5kQ2xlYXIuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6Y2FuY2VsQW5kQ2xlYXIpOiBN b3ZlIGNhbmNlbGxhdGlvbiBhbmQgY2xlYXJpbmcgaW50byBhIHNlcGFyYXRlIG1ldGhvZCB0aGF0 CisgICAgICAgIEZyYW1lTWFjIGNhbiB1c2UuCisgICAgICAgICogcGFnZS9GcmFtZS5oOgorCiAy MDA2LTA5LTE0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBNYWNpZWoncyBydWJiZXIgc3RhbXAKSW5kZXg6IFdlYkNvcmUvYnJpZGdlL21h Yy9GcmFtZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9tYWMvRnJhbWVNYWMu bW0JKHJldmlzaW9uIDE2MzY3KQorKysgV2ViQ29yZS9icmlkZ2UvbWFjL0ZyYW1lTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0xNzYsNiArMTc2LDggQEAgRnJhbWVNYWM6On5GcmFtZU1hYygpCiAg ICAgW19icmlkZ2UgY2xlYXJGcmFtZV07CiAgICAgSGFyZFJlbGVhc2UoX2JyaWRnZSk7CiAgICAg X2JyaWRnZSA9IG5pbDsKKworICAgIGNhbmNlbEFuZENsZWFyKCk7CiB9CiAKIHZvaWQgRnJhbWVN YWM6OmZyZWVDbGlwYm9hcmQoKQpJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiAxNjM2NykKKysrIFdlYkNv cmUvcGFnZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MCwxMiArMTkwLDcgQEAgRnJh bWU6On5GcmFtZSgpCiAgICAgLS1GcmFtZUNvdW50ZXI6OmNvdW50OwogI2VuZGlmCiAKLSAgICBj YW5jZWxSZWRpcmVjdGlvbigpOwotCi0gICAgaWYgKCFkLT5tX2JDb21wbGV0ZSkKLSAgICAgICAg Y2xvc2VVUkwoKTsKLQotICAgIGNsZWFyKGZhbHNlKTsKKyAgICBjYW5jZWxBbmRDbGVhcigpOwog CiAgICAgaWYgKGQtPm1fanNjcmlwdCAmJiBkLT5tX2pzY3JpcHQtPmhhdmVJbnRlcnByZXRlcigp KQogICAgICAgICBpZiAoV2luZG93KiB3ID0gV2luZG93OjpyZXRyaWV2ZVdpbmRvdyh0aGlzKSkg ewpAQCAtNDYyLDYgKzQ1NywxNiBAQCBib29sIEZyYW1lOjphdXRvbG9hZEltYWdlcygpIGNvbnN0 CiAgIHJldHVybiB0cnVlOwogfQogCit2b2lkIEZyYW1lOjpjYW5jZWxBbmRDbGVhcigpCit7Cisg ICAgY2FuY2VsUmVkaXJlY3Rpb24oKTsKKworICAgIGlmICghZC0+bV9iQ29tcGxldGUpCisgICAg ICAgIGNsb3NlVVJMKCk7CisKKyAgICBjbGVhcihmYWxzZSk7Cit9CisKIHZvaWQgRnJhbWU6OmNs ZWFyKGJvb2wgY2xlYXJXaW5kb3dQcm9wZXJ0aWVzKQogewogICBpZiAoZC0+bV9iQ2xlYXJlZCkK SW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9G cmFtZS5oCShyZXZpc2lvbiAxNjM2NykKKysrIFdlYkNvcmUvcGFnZS9GcmFtZS5oCSh3b3JraW5n IGNvcHkpCkBAIC03NTYsNiArNzU2LDcgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBz dGFydFJlZGlyZWN0aW9uVGltZXIoKTsKICAgICB2aXJ0dWFsIHZvaWQgc3RvcFJlZGlyZWN0aW9u VGltZXIoKTsKICAgICB2aXJ0dWFsIHZvaWQgY2xlYW51cFBsdWdpbk9iamVjdHMoKSB7IH0KKyAg ICB2b2lkIGNhbmNlbEFuZENsZWFyKCk7CiAgICAgCiAgICAgdm9pZCBoYW5kbGVBdXRvc2Nyb2xs KFJlbmRlckxheWVyKik7CiAgICAgdm9pZCBzdGFydEF1dG9zY3JvbGxUaW1lcigpOwo=