108374 2013-01-30 13:23:03 -0800 Use OS() and PLATFORM() macros in WebCorePrefix.h for readability 2013-01-31 12:54:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer benjamin bfulgham darin ddkilzer laszlo.gombos mjs mrowe sam webkit.review.bot oldest_to_newest 820473 0 ddkilzer 2013-01-30 13:23:03 -0800 Use OS() and PLATFORM() macros in WebCorePrefix.h for readability 820478 1 185548 ddkilzer 2013-01-30 13:24:03 -0800 Created attachment 185548 Patch v1 820482 2 webkit.review.bot 2013-01-30 13:26:16 -0800 Attachment 185548 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCorePrefix.h']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 820485 3 ddkilzer 2013-01-30 13:27:59 -0800 I didn't replace __APPLE__ since I wasn't sure if we wanted OS(DARWIN) here or PLATFORM(APPLE) per discussion in Bug 108007. 820486 4 185549 ddkilzer 2013-01-30 13:30:07 -0800 Created attachment 185549 Patch v1 with bug URL 821088 5 185549 buildbot 2013-01-30 22:04:50 -0800 Comment on attachment 185549 Patch v1 with bug URL Attachment 185549 did not pass win-ews (win): Output: http://queues.webkit.org/results/16217980 821823 6 ddkilzer 2013-01-31 12:25:29 -0800 (In reply to comment #5) > (From update of attachment 185549 [details]) > Attachment 185549 [details] did not pass win-ews (win): > Output: http://queues.webkit.org/results/16217980 This seems bogus: Running build-dumprendertree Compiling DumpRenderTree failed! Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106. 821835 7 185549 laszlo.gombos 2013-01-31 12:30:48 -0800 Comment on attachment 185549 Patch v1 with bug URL lgtm. 821863 8 185549 webkit.review.bot 2013-01-31 12:54:02 -0800 Comment on attachment 185549 Patch v1 with bug URL Clearing flags on attachment: 185549 Committed r141468: <http://trac.webkit.org/changeset/141468> 821864 9 webkit.review.bot 2013-01-31 12:54:06 -0800 All reviewed patches have been landed. Closing bug. 185548 2013-01-30 13:24:03 -0800 2013-01-30 13:30:05 -0800 Patch v1 bug-108374-20130130132048.patch text/plain 2609 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ2MzBiYmIyYTg2ZjA4 Mzc1MWE4NDcxMzM0ZTc2YTIwYzk4NzI1Yy4uYmEyOTExMTlhNzdjMzI5ZTg1NjU0MWU1N2M4NmJl YjYwZGFiOTJkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTMwICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIE9TKCkgYW5kIFBM QVRGT1JNKCkgbWFjcm9zIGluIFdlYkNvcmVQcmVmaXguaCBmb3IgcmVhZGFiaWxpdHkKKyAgICAg ICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVByZWZpeC5oOiBSZXBsYWNlZCBhbGwgcG9z c2libGUgY2hlY2tzIHdpdGggT1MoKSBvcgorICAgICAgICBQTEFURk9STSgpIG1hY3JvcyBvdGhl ciB0aGFuIF9fQVBQTEVfXy4KKwogMjAxMy0wMS0zMCAgRmxvcmluIE1hbGl0YSAgPGZtYWxpdGFA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIERvIG5vdCByZXN0YXJ0IHRoZSBtYXRjaGVkIHByb3Bl cnRpZXMgY2FjaGUgdGltZXIgaWYgYWN0aXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9X ZWJDb3JlUHJlZml4LmggYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgKaW5kZXggYzY2 ODgwYjAxMDk0OTUwOGZkMzA5OTk3ODU2ODA3NTgxODIxNGZkMS4uOWE3YjBjYzc3YWVjNzdlZGU2 OTU5Yjc1NzQyYTY5Y2VjYWMzZTIxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29y ZVByZWZpeC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmVQcmVmaXguaApAQCAtMzcsNyAr MzcsNyBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQo X1dJTjMyKQorI2lmIE9TKFdJTkRPV1MpCiAKICNpZm5kZWYgX1dJTjMyX1dJTk5UCiAjZGVmaW5l IF9XSU4zMl9XSU5OVCAweDA1MDIKQEAgLTQ3LDcgKzQ3LDcgQEAKICNkZWZpbmUgV0lOVkVSIDB4 MDUwMgogI2VuZGlmCiAKLSNpZm5kZWYgV1RGX1VTRV9DVVJMCisjaWYgIVVTRShDVVJMKQogI2lm bmRlZiBfV0lOU09DS0FQSV8KICNkZWZpbmUgX1dJTlNPQ0tBUElfIC8vIFByZXZlbnQgaW5jbHVz aW9uIG9mIHdpbnNvY2suaCBpbiB3aW5kb3dzLmgKICNlbmRpZgpAQCAtNjQsNyArNjQsNyBAQAog CiAjaW5jbHVkZSA8cHRocmVhZC5oPgogCi0jZW5kaWYgLy8gZGVmaW5lZChXSU4zMikgfHwgZGVm aW5lZChfV0lOMzIpCisjZW5kaWYgLy8gT1MoV0lORE9XUykKIAogI2luY2x1ZGUgPHN5cy90eXBl cy5oPgogI2luY2x1ZGUgPGZjbnRsLmg+CkBAIC03NCw3ICs3NCw3IEBACiAKIC8vIE9uIExpbnV4 IHRoaXMgY2F1c2VzIGNvbmZsaWN0cyB3aXRoIGxpYnBuZyBiZWNhdXNlIHRoZXJlIGFyZSB0d28g aW1wbHMuIG9mCiAvLyBsb25nam1wIC0gc2VlIGhlcmU6IGh0dHBzOi8vYnVncy5sYXVuY2hwYWQu bmV0L3VidW50dS8rc291cmNlL2xpYnBuZy8rYnVnLzIxODQwOQotI2lmbmRlZiBCVUlMRElOR19X WF9fCisjaWYgIVBMQVRGT1JNKFdYKQogI2luY2x1ZGUgPHNldGptcC5oPgogI2VuZGlmCiAKQEAg LTEzMiwxNCArMTMyLDE0IEBAIF9MSUJDUFBfRU5EX05BTUVTUEFDRV9TVEQKICNpbmNsdWRlIDxz eXMvcmVzb3VyY2UuaD4KICNlbmRpZgogCi0jaWYgIWRlZmluZWQoQlVJTERJTkdfV1hfXykKKyNp ZiAhUExBVEZPUk0oV1gpCiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ29yZUZvdW5kYXRpb24u aD4KLSNpZmRlZiBXVEZfUExBVEZPUk1fV0lOX0NBSVJPCisjaWYgUExBVEZPUk0oV0lOX0NBSVJP KQogI2luY2x1ZGUgPENvbmRpdGlvbmFsTWFjcm9zLmg+CiAjaW5jbHVkZSA8d2luZG93cy5oPgog I2Vsc2UKIAotI2lmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKQorI2lmIE9TKFdJ TkRPV1MpCiAvLyBGSVhNRSA8cmRhcjovL3Byb2JsZW0vODIwODg2OD4gUmVtb3ZlIHN1cHBvcnQg Zm9yIG9ic29sZXRlIENvbG9yU3luYyBBUEksIENvcmVTZXJ2aWNlcyBoZWFkZXIgaW4gQ29yZUdy YXBoaWNzCiAvLyBXZSBjYW4gcmVtb3ZlIHRoaXMgb25jZSB0aGUgbmV3IENvbG9yU3luYyBBUElz IGFyZSBhdmFpbGFibGUgaW4gYW4gaW50ZXJuYWwgU2FmYXJpIFNESy4KICNpbmNsdWRlIDxDb2xv clN5bmMvQ29sb3JTeW5jLmg+CkBAIC0xNTUsMTAgKzE1NSwxMCBAQCBfTElCQ1BQX0VORF9OQU1F U1BBQ0VfU1RECiAjaWYgIVBMQVRGT1JNKElPUykKICNpbmNsdWRlIDxDb3JlU2VydmljZXMvQ29y ZVNlcnZpY2VzLmg+CiAjZW5kaWYgLy8gIVBMQVRGT1JNKElPUykKLSNlbmRpZiAvLyBkZWZpbmVk KFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikKKyNlbmRpZiAvLyBPUyhXSU5ET1dTKQogCiAjZW5k aWYKLSNlbmRpZiAvLyAhZGVmaW5lZChCVUlMRElOR19XWF9fKQorI2VuZGlmIC8vICFQTEFURk9S TShXWCkKIAogI2lmZGVmIF9fT0JKQ19fCiAjaWYgUExBVEZPUk0oSU9TKQo= 185549 2013-01-30 13:30:07 -0800 2013-01-31 12:54:02 -0800 Patch v1 with bug URL bug-108374-20130130132652.patch text/plain 2612 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ2MzBiYmIyYTg2ZjA4 Mzc1MWE4NDcxMzM0ZTc2YTIwYzk4NzI1Yy4uZmNlOTg2M2RlYTFmMTdhOTlhNjZiOWVlZmY4ZmNj ZDZhYWNkMjU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTMwICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIE9TKCkgYW5kIFBM QVRGT1JNKCkgbWFjcm9zIGluIFdlYkNvcmVQcmVmaXguaCBmb3IgcmVhZGFiaWxpdHkKKyAgICAg ICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTA4Mzc0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVByZWZpeC5oOiBSZXBsYWNlZCBhbGwg cG9zc2libGUgY2hlY2tzIHdpdGggT1MoKSBvcgorICAgICAgICBQTEFURk9STSgpIG1hY3JvcyBv dGhlciB0aGFuIF9fQVBQTEVfXy4KKwogMjAxMy0wMS0zMCAgRmxvcmluIE1hbGl0YSAgPGZtYWxp dGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERvIG5vdCByZXN0YXJ0IHRoZSBtYXRjaGVkIHBy b3BlcnRpZXMgY2FjaGUgdGltZXIgaWYgYWN0aXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9XZWJDb3JlUHJlZml4LmggYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgKaW5kZXgg YzY2ODgwYjAxMDk0OTUwOGZkMzA5OTk3ODU2ODA3NTgxODIxNGZkMS4uOWE3YjBjYzc3YWVjNzdl ZGU2OTU5Yjc1NzQyYTY5Y2VjYWMzZTIxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZVByZWZpeC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmVQcmVmaXguaApAQCAtMzcs NyArMzcsNyBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmlu ZWQoX1dJTjMyKQorI2lmIE9TKFdJTkRPV1MpCiAKICNpZm5kZWYgX1dJTjMyX1dJTk5UCiAjZGVm aW5lIF9XSU4zMl9XSU5OVCAweDA1MDIKQEAgLTQ3LDcgKzQ3LDcgQEAKICNkZWZpbmUgV0lOVkVS IDB4MDUwMgogI2VuZGlmCiAKLSNpZm5kZWYgV1RGX1VTRV9DVVJMCisjaWYgIVVTRShDVVJMKQog I2lmbmRlZiBfV0lOU09DS0FQSV8KICNkZWZpbmUgX1dJTlNPQ0tBUElfIC8vIFByZXZlbnQgaW5j bHVzaW9uIG9mIHdpbnNvY2suaCBpbiB3aW5kb3dzLmgKICNlbmRpZgpAQCAtNjQsNyArNjQsNyBA QAogCiAjaW5jbHVkZSA8cHRocmVhZC5oPgogCi0jZW5kaWYgLy8gZGVmaW5lZChXSU4zMikgfHwg ZGVmaW5lZChfV0lOMzIpCisjZW5kaWYgLy8gT1MoV0lORE9XUykKIAogI2luY2x1ZGUgPHN5cy90 eXBlcy5oPgogI2luY2x1ZGUgPGZjbnRsLmg+CkBAIC03NCw3ICs3NCw3IEBACiAKIC8vIE9uIExp bnV4IHRoaXMgY2F1c2VzIGNvbmZsaWN0cyB3aXRoIGxpYnBuZyBiZWNhdXNlIHRoZXJlIGFyZSB0 d28gaW1wbHMuIG9mCiAvLyBsb25nam1wIC0gc2VlIGhlcmU6IGh0dHBzOi8vYnVncy5sYXVuY2hw YWQubmV0L3VidW50dS8rc291cmNlL2xpYnBuZy8rYnVnLzIxODQwOQotI2lmbmRlZiBCVUlMRElO R19XWF9fCisjaWYgIVBMQVRGT1JNKFdYKQogI2luY2x1ZGUgPHNldGptcC5oPgogI2VuZGlmCiAK QEAgLTEzMiwxNCArMTMyLDE0IEBAIF9MSUJDUFBfRU5EX05BTUVTUEFDRV9TVEQKICNpbmNsdWRl IDxzeXMvcmVzb3VyY2UuaD4KICNlbmRpZgogCi0jaWYgIWRlZmluZWQoQlVJTERJTkdfV1hfXykK KyNpZiAhUExBVEZPUk0oV1gpCiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ29yZUZvdW5kYXRp b24uaD4KLSNpZmRlZiBXVEZfUExBVEZPUk1fV0lOX0NBSVJPCisjaWYgUExBVEZPUk0oV0lOX0NB SVJPKQogI2luY2x1ZGUgPENvbmRpdGlvbmFsTWFjcm9zLmg+CiAjaW5jbHVkZSA8d2luZG93cy5o PgogI2Vsc2UKIAotI2lmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKQorI2lmIE9T KFdJTkRPV1MpCiAvLyBGSVhNRSA8cmRhcjovL3Byb2JsZW0vODIwODg2OD4gUmVtb3ZlIHN1cHBv cnQgZm9yIG9ic29sZXRlIENvbG9yU3luYyBBUEksIENvcmVTZXJ2aWNlcyBoZWFkZXIgaW4gQ29y ZUdyYXBoaWNzCiAvLyBXZSBjYW4gcmVtb3ZlIHRoaXMgb25jZSB0aGUgbmV3IENvbG9yU3luYyBB UElzIGFyZSBhdmFpbGFibGUgaW4gYW4gaW50ZXJuYWwgU2FmYXJpIFNESy4KICNpbmNsdWRlIDxD b2xvclN5bmMvQ29sb3JTeW5jLmg+CkBAIC0xNTUsMTAgKzE1NSwxMCBAQCBfTElCQ1BQX0VORF9O QU1FU1BBQ0VfU1RECiAjaWYgIVBMQVRGT1JNKElPUykKICNpbmNsdWRlIDxDb3JlU2VydmljZXMv Q29yZVNlcnZpY2VzLmg+CiAjZW5kaWYgLy8gIVBMQVRGT1JNKElPUykKLSNlbmRpZiAvLyBkZWZp bmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikKKyNlbmRpZiAvLyBPUyhXSU5ET1dTKQogCiAj ZW5kaWYKLSNlbmRpZiAvLyAhZGVmaW5lZChCVUlMRElOR19XWF9fKQorI2VuZGlmIC8vICFQTEFU Rk9STShXWCkKIAogI2lmZGVmIF9fT0JKQ19fCiAjaWYgUExBVEZPUk0oSU9TKQo=