<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>108353</bug_id>
          
          <creation_ts>2013-01-30 10:22:25 -0800</creation_ts>
          <short_desc>REGRESSION(r141205): Command for running tests on windows needs to be investigated. (Requested by lforschler on #webkit).</short_desc>
          <delta_ts>2013-01-30 16:51:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>107968</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="WebKit Review Bot">webkit.review.bot</reporter>
          <assigned_to name="WebKit Review Bot">webkit.review.bot</assigned_to>
          <cc>abarth</cc>
    
    <cc>lforschler</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>820299</commentid>
    <comment_count>0</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-30 10:22:25 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/141205 broke the build:
Command for running tests on windows needs to be investigated. (Requested by lforschler on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don&apos;t already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

&quot;Only you can prevent forest fires.&quot; -- Smokey the Bear</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820301</commentid>
    <comment_count>1</comment_count>
      <attachid>185516</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-30 10:22:54 -0800</bug_when>
    <thetext>Created attachment 185516
ROLLOUT of r141205

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820302</commentid>
    <comment_count>2</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2013-01-30 10:23:44 -0800</bug_when>
    <thetext>I&apos;m rolling this out.  It looks like there is a problem with the command being used to kick off EWS tests on windows.  Here is the output.

Failed to run &quot;[&apos;/home/buildbot/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=APPLE-EWS-1&apos;, &apos;build-and-test&apos;, &apos;--no-clean&apos;, &apos;--no-update&apos;, &apos;--test&apos;, &apos;--non-interactive&apos;, &apos;--port=win&apos;]&quot; exit_code: 2 cwd: /home/buildbot/WebKit

Running run-webkit-tests
Failed to run &quot;[&apos;Tools/Scripts/run-webkit-tests&apos;, &apos;--no-new-test-results&apos;, &apos;--no-show-results&apos;, &apos;--skip-failing-tests&apos;, &apos;--exit-after-n-failures=30&apos;, &apos;--quiet&apos;]&quot; exit_code: 1

Last 500 characters of output:
only)
  -v|--verbose                    More verbose output (overrides --quiet)
  -m|--merge-leak-depth arg       Merges leak callStacks and prints the number of unique leaks beneath a callstack depth of arg.  Defaults to 5.
  --use-remote-links-to-tests     Link to test files within the SVN repository in the results.
  -2|--webkit-test-runner         Use WebKitTestRunner rather than DumpRenderTree.
Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106.

Failed to run &quot;[&apos;Tools/Scripts/run-webkit-tests&apos;, &apos;--no-new-test-results&apos;, &apos;--no-show-results&apos;, &apos;--skip-failing-tests&apos;, &apos;--exit-after-n-failures=30&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Unknown option: skip-failing-tests
Usage: old-run-webkit-tests [options] [testdir|testpath ...]
  --add-platform-exceptions       Put new results for non-platform-specific failing tests into the platform-specific results directory
  --additional-platform-directory path/to/directory
                                  Look in the specified directory before looking in any of the default platform-specific directories
  --complex-text                  Use the complex text code path for all text (Mac OS X and Windows only)
  -c|--configuration config       Set DumpRenderTree build configuration
  --gc-between-tests              Force garbage collection between each test
  -g|--guard-malloc               Enable Guard Malloc
  --exit-after-n-failures N       Exit after the first N failures (includes crashes) instead of running all tests
  --exit-after-n-crashes-or-timeouts N
                                  Exit after the first N crashes instead of running all tests
  -h|--help                       Show this help message
  --[no-]http                     Run (or do not run) http tests (default: run)
  --[no-]wait-for-httpd           Wait for httpd if some other test session is using it already (same as WEBKIT_WAIT_FOR_HTTPD=1). (default: 0) 
  -i|--ignore-tests               Comma-separated list of directories or tests to ignore
  --iterations n                  Number of times to run the set of tests (e.g. ABCABCABC)
  --[no-]launch-safari            Launch (or do not launch) Safari to display test results (default: launch)
  --[no-]show-results             Same as --[no-]launch-safari
  -l|--leaks                      Enable leaks checking
  --[no-]new-test-results         Generate results for new tests
  --nthly n                       Restart DumpRenderTree every n tests (default: 1000)
  -p|--pixel-tests                Enable pixel tests
  --tolerance t                   Ignore image differences less than this percentage (default: 0)
  --platform                      Override the detected platform to use for tests and results (default: win)
  --port                          Web server port to use with http tests
  -q|--quiet                      Less verbose output
  --reset-results                 Reset ALL results (including pixel tests if --pixel-tests is set)
  -o|--results-directory          Output results directory (default: /tmp/layout-test-results)
  --random                        Run the tests in a random order
  --repeat-each n                 Number of times to run each test (e.g. AAABBBCCC)
  --reverse                       Run the tests in reverse alphabetical order
  --root                          Path to root tools build
  --[no-]sample-on-timeout        Run sample on timeout (default: run) (Mac OS X only)
  -1|--singly                     Isolate each test case run (implies --nthly 1 --verbose)
  --skipped=[default|ignore|only] Specifies how to treat the Skipped file
                                     default: Tests/directories listed in the Skipped file are not tested
                                     ignore:  The Skipped file is ignored
                                     only:    Only those tests/directories listed in the Skipped file will be run
  --slowest                       Report the 10 slowest tests
  --ignore-metrics                Ignore metrics in tests
  --[no-]strip-editing-callbacks  Remove editing callbacks from expected results
  -t|--threaded                   Run a concurrent JavaScript thead with each test
  --timeout t                     Sets the number of seconds before a test times out (default: 35)
  --valgrind                      Run DumpRenderTree inside valgrind (Qt/Linux only)
  -v|--verbose                    More verbose output (overrides --quiet)
  -m|--merge-leak-depth arg       Merges leak callStacks and prints the number of unique leaks beneath a callstack depth of arg.  Defaults to 5.
  --use-remote-links-to-tests     Link to test files within the SVN repository in the results.
  -2|--webkit-test-runner         Use WebKitTestRunner rather than DumpRenderTree.
Failed to execute Tools/Scripts/old-run-webkit-tests at Tools/Scripts/run-webkit-tests line 106.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820750</commentid>
    <comment_count>3</comment_count>
      <attachid>185516</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-30 16:07:03 -0800</bug_when>
    <thetext>Comment on attachment 185516
ROLLOUT of r141205

Clearing flags on attachment: 185516

Committed r141337: &lt;http://trac.webkit.org/changeset/141337&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820751</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-30 16:07:07 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820805</commentid>
    <comment_count>5</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2013-01-30 16:47:05 -0800</bug_when>
    <thetext>Reopening for resolution</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820811</commentid>
    <comment_count>6</comment_count>
      <attachid>185623</attachid>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2013-01-30 16:48:49 -0800</bug_when>
    <thetext>Created attachment 185623
patch to fix EWS

--skip-failing-tests is not an option for old-run-webkit-tests (which is what is used by windows port).
Patch adds a platform check for cygwin (aka windows) to make sure that the option isn&apos;t added when test are run on windows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>820813</commentid>
    <comment_count>7</comment_count>
      <attachid>185623</attachid>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2013-01-30 16:51:02 -0800</bug_when>
    <thetext>Comment on attachment 185623
patch to fix EWS

Rubberstamped by thorton.
Committed http://trac.webkit.org/changeset/141341</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>185516</attachid>
            <date>2013-01-30 10:22:54 -0800</date>
            <delta_ts>2013-01-30 16:07:03 -0800</delta_ts>
            <desc>ROLLOUT of r141205</desc>
            <filename>bug-108353-20130130181938.patch</filename>
            <type>text/plain</type>
            <size>1443</size>
            <attacher name="WebKit Review Bot">webkit.review.bot</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGM3ZTRmOTNhYzViODE0MzU4NDFjMmU1YTcwNjQ3ZGQw
NzUwYmMxYS4uOTk3ODcyMjhiZmY2YzFlODhkMjUwYjk5ODZhMWVjNWE0YjNmNWE4MSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDEzLTAxLTMwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv
bT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQxMjA1LgorICAgICAgICBo
dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNDEyMDUKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODM1MworCisgICAgICAgIENvbW1hbmQg
Zm9yIHJ1bm5pbmcgdGVzdHMgb24gd2luZG93cyBuZWVkcyB0byBiZSBpbnZlc3RpZ2F0ZWQuCisg
ICAgICAgIChSZXF1ZXN0ZWQgYnkgbGZvcnNjaGxlciBvbiAjd2Via2l0KS4KKworICAgICAgICAq
IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHk6Cisg
ICAgICAgIChXaW5FV1MpOgorCiAyMDEzLTAxLTMwICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh
bGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF1bV0sxXSBTdXBwb3J0IGJldHRl
ciB0ZXN0aW5nIG9mIFdlYiBOb3RpZmljYXRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz
L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5IGIvVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQppbmRleCA3
OWI3Y2Y2Njg1N2FhZDYxOWZhYmExNjRkYzBhZDFkODE0NjZlM2NkLi5jNzRhNGM0ODRhNzlmODAz
NzVkNDFmNDkzMTI2ZTQ4Y2QzYWNmYWIzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CisrKyBiL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKQEAgLTE3Nyw3
ICsxNzcsNiBAQCBjbGFzcyBXaW5FV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0pOgogICAg
ICMgVXNlIGRlYnVnLCB0aGUgQXBwbGUgV2luIHBvcnQgZmFpbHMgdG8gbGluayBSZWxlYXNlIG9u
IDMyLWJpdCBXaW5kb3dzLgogICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTM5MTk3CiAgICAgX2J1aWxkX3N0eWxlID0gImRlYnVnIgotICAgIF9kZWZhdWx0X3J1
bl90ZXN0cyA9IFRydWUKIAogCiBjbGFzcyBBYnN0cmFjdENocm9taXVtRVdTKEFic3RyYWN0RWFy
bHlXYXJuaW5nU3lzdGVtKToK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>185623</attachid>
            <date>2013-01-30 16:48:49 -0800</date>
            <delta_ts>2013-01-30 16:51:01 -0800</delta_ts>
            <desc>patch to fix EWS</desc>
            <filename>fix_ews.patch</filename>
            <type>text/plain</type>
            <size>1952</size>
            <attacher name="Roger Fong">roger_fong</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTM0
MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAx
LTMwICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTW9kaWZ5
IHJ1bnRlc3RzLnB5IHNjcmlwdCBzbyB0aGF0IC0tc2tpcC1mYWlsaW5nLXRlc3RzIG9wdGlvbiBp
cyBub3QgYWRkZWQgd2hlbiBwbGF0Zm9ybSBpcyBjeWd3aW4uCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl
cHMvcnVudGVzdHMucHk6CisgICAgICAgIChSdW5UZXN0cy5ydW4pOgorCiAyMDEzLTAxLTMwICBT
aGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJl
dmlld2VkLCByb2xsaW5nIG91dCByMTQxMjA1LgpJbmRleDogU2NyaXB0cy93ZWJraXRweS90b29s
L3N0ZXBzL3J1bnRlc3RzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9z
dGVwcy9ydW50ZXN0cy5weQkocmV2aXNpb24gMTQxMTQxKQorKysgU2NyaXB0cy93ZWJraXRweS90
b29sL3N0ZXBzL3J1bnRlc3RzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw5IEBACiAj
IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg
U1VDSCBEQU1BR0UuCiAKIGltcG9ydCBsb2dnaW5nCi0KK2ltcG9ydCBvcworaW1wb3J0IHBsYXRm
b3JtCitpbXBvcnQgc3lzCiBmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMuYWJzdHJhY3RzdGVwIGlt
cG9ydCBBYnN0cmFjdFN0ZXAKIGZyb20gd2Via2l0cHkudG9vbC5zdGVwcy5vcHRpb25zIGltcG9y
dCBPcHRpb25zCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBT
Y3JpcHRFcnJvcgpAQCAtNzcsMTcgKzc5LDIxIEBACiAgICAgICAgICAgICBleGNlcHQgU2NyaXB0
RXJyb3IsIGU6CiAgICAgICAgICAgICAgICAgX2xvZy5pbmZvKCJFcnJvciBydW5uaW5nIHdlYmtp
dF91bml0X3Rlc3RzOiAlcyIgJSBlLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKSkKIAorCiAgICAgICAg
IF9sb2cuaW5mbygiUnVubmluZyBydW4td2Via2l0LXRlc3RzIikKICAgICAgICAgYXJncyA9IHNl
bGYuX3Rvb2wuZGVwcmVjYXRlZF9wb3J0KCkucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCkKICAg
ICAgICAgaWYgc2VsZi5fb3B0aW9ucy5ub25faW50ZXJhY3RpdmU6CiAgICAgICAgICAgICBhcmdz
LmV4dGVuZChbCiAgICAgICAgICAgICAgICAgIi0tbm8tbmV3LXRlc3QtcmVzdWx0cyIsCiAgICAg
ICAgICAgICAgICAgIi0tbm8tc2hvdy1yZXN1bHRzIiwKLSAgICAgICAgICAgICAgICAiLS1za2lw
LWZhaWxpbmctdGVzdHMiLAogICAgICAgICAgICAgICAgICItLWV4aXQtYWZ0ZXItbi1mYWlsdXJl
cz0lcyIgJSBzZWxmLk5PTl9JTlRFUkFDVElWRV9GQUlMVVJFX0xJTUlUX0NPVU5ULAogICAgICAg
ICAgICAgICAgICItLXF1aWV0IiwKICAgICAgICAgICAgIF0pCiAKKyAgICAgICAgaWYgc3lzLnBs
YXRmb3JtICE9ICJjeWd3aW4iOgorICAgICAgICAgICAgYXJncy5hcHBlbmQoIi0tc2tpcC1mYWls
aW5nLXRlc3QiKQogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLnF1aWV0OgogICAgICAgICAgICAg
YXJncy5hcHBlbmQoIi0tcXVpZXQiKQorCiAgICAgICAgIHNlbGYuX3Rvb2wuZXhlY3V0aXZlLnJ1
bl9hbmRfdGhyb3dfaWZfZmFpbChhcmdzLCBjd2Q9c2VsZi5fdG9vbC5zY20oKS5jaGVja291dF9y
b290KQorICAgICAgICA=
</data>

          </attachment>
      

    </bug>

</bugzilla>