10834 2006-09-13 05:56:09 -0700 FileChooser constructor in FileChooserMac appears to overretain m_controller 2006-09-13 21:57:09 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix P2 Normal --- 1 mrowe webkit-unassigned aroben oldest_to_newest 55387 0 mrowe 2006-09-13 05:56:09 -0700 m_controller's initializer (http://trac.webkit.org/projects/webkit/browser/trunk/WebCore/platform/mac/FileChooserMac.mm?rev=16323#L92) reads: , m_controller([[[OpenPanelController alloc] initWithFileChooser:this] retain]) Allocing and then retaining the OpenPanelController seems incorrect to me. If this is intended, it should have some form of explanatory comment as it's not standard practice. 55389 1 mrowe 2006-09-13 06:10:43 -0700 After trawling through some of Buildbot's leak output, I noticed: Call stack: [thread 252f87]: | 0x0 | start | _start | main | runTest | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] | -[WebLoader connectionDidFinishLoading:] | -[WebSubresourceLoader didFinishLoading] | -[WebCoreResourceLoaderImp finishWithData:] | -[WebCoreResourceLoaderImp finishJobAndHandle:] | WebCore::Loader::receivedAllData(WebCore::ResourceLoader*, NSData*) | WebCore::CachedScript::data(WTF::Vector<char, (unsigned long)0>&, bool) | WebCore::CachedScript::checkNotify() | WebCore::HTMLTokenizer::notifyFinished(WebCore::CachedResource*) | WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) | WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) | WebCore::HTMLTokenizer::processToken() | WebCore::HTMLParser::parseToken(WebCore::Token*) | WebCore::HTMLParser::insertNode(WebCore::Node*, bool) | WebCore::HTMLInputElement::attach() | WebCore::HTMLGenericFormElement::attach() | WebCore::Element::attach() | WebCore::Node::createRendererIfNeeded() | WebCore::HTMLInputElement::createRenderer(WebCore::RenderArena*, WebCore::RenderStyle*) | WebCore::RenderFileUploadControl::RenderFileUploadControl[in-charge](WebCore::Node*) | WebCore::FileChooser::FileChooser[in-charge](WebCore::Document*, WebCore::RenderFileUploadControl*) | NSAllocateObject | _internal_class_createInstanceFromZone Leak: 0x1d406050 size=16 instance of 'OpenPanelController' (http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/2531/DumpRenderTree-leaks.txt) This seems to confirm that it is being overretained. 55457 2 10550 mrowe 2006-09-13 15:50:09 -0700 Created attachment 10550 Patch 55459 3 10550 aroben 2006-09-13 15:56:39 -0700 Comment on attachment 10550 Patch r=me. Thanks for catching this! 55475 4 mrowe 2006-09-13 21:57:09 -0700 Landed in r16358. 10550 2006-09-13 15:50:09 -0700 2006-09-13 15:56:39 -0700 Patch webkit-bug-10834-patch-v1.patch text/plain 1237 mrowe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjM0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDYtMDktMTQgIE1hcmsgUm93ZSAgPG9wZW5kYXJ3aW4ub3JnQGJk YXNoLm5ldC5uej4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTEwODM0 CisgICAgICAgIEJ1ZyAxMDgzNDogRmlsZUNob29zZXIgY29uc3RydWN0b3IgaW4gRmlsZUNob29z ZXJNYWMgYXBwZWFycyB0byBvdmVycmV0YWluIG1fY29udHJvbGxlcgorCisgICAgICAgICogcGxh dGZvcm0vbWFjL0ZpbGVDaG9vc2VyTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6RmlsZUNob29z ZXI6OkZpbGVDaG9vc2VyKTogRG9uJ3Qgb3Zlci1yZXRhaW4gdGhlIE9wZW5QYW5lbENvbnRyb2xs ZXIuCisKIDIwMDYtMDktMTMgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAg ICAgIENsZWFuIHVwIHRoZSBYQkwgYW5kIFhTTFQgaWZkZWZzIHRvIGJlIGNvbnNpc3RlbnQgd2l0 aCB0aGUgU1ZHCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL21hYy9GaWxlQ2hvb3Nlck1hYy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL21hYy9GaWxlQ2hvb3Nlck1hYy5tbQkocmV2 aXNpb24gMTYzNDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL21hYy9GaWxlQ2hvb3Nlck1hYy5tbQko d29ya2luZyBjb3B5KQpAQCAtODksNyArODksNyBAQCBGaWxlQ2hvb3Nlcjo6RmlsZUNob29zZXIo RG9jdW1lbnQqIGRvY3VtCiAgICAgOiBtX2RvY3VtZW50KGRvY3VtZW50KQogICAgICwgbV9pY29u KDApCiAgICAgLCBtX3VwbG9hZENvbnRyb2wodXBsb2FkQ29udHJvbCkKLSAgICAsIG1fY29udHJv bGxlcihbW1tPcGVuUGFuZWxDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aEZpbGVDaG9vc2VyOnRo aXNdIHJldGFpbl0pCisgICAgLCBtX2NvbnRyb2xsZXIoW1tPcGVuUGFuZWxDb250cm9sbGVyIGFs bG9jXSBpbml0V2l0aEZpbGVDaG9vc2VyOnRoaXNdKQogewogfQogCg==