10833 2006-09-13 05:27:22 -0700 Windows build needs fixed after move to engine-rendered file upload widget 2006-09-13 11:42:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ PC OS X 10.4 RESOLVED FIXED EasyFix P2 Normal --- 10832 1 karthikkumar webkit-unassigned aroben mrowe oldest_to_newest 55384 0 karthikkumar 2006-09-13 05:27:22 -0700 TODO: 1. Remove FileButton.h, RenderFileButton.cpp from .vcproj project file (as build fails) 2. Remove #include "FileButton.h" and FileButton:: whatever from TemporaryLinkStubs.cpp 55385 1 mrowe 2006-09-13 05:30:56 -0700 Project file needs references to deleted files removed, references to the new files added, obselete link stubs removed, and new ones added to make things build. 55428 2 10540 fishd 2006-09-13 11:19:53 -0700 Created attachment 10540 patch This works for me. 55430 3 10540 aroben 2006-09-13 11:22:27 -0700 Comment on attachment 10540 patch r=me, and thanks for including a ChangeLog entry. Ideally you would describe the changes within the ChangeLog, but since this is a build fix I'll go ahead and land it. Thanks! 55435 4 10540 aroben 2006-09-13 11:42:35 -0700 Comment on attachment 10540 patch Landed as r16346 10540 2006-09-13 11:19:53 -0700 2006-09-13 11:22:27 -0700 patch fix-win.diff text/plain 4765 fishd SW5kZXg6IHBsYXRmb3JtL3dpbi9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHBsYXRmb3JtL3dpbi9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCShyZXZpc2lvbiAxNjM0NCkKKysr IHBsYXRmb3JtL3dpbi9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z Myw4ICszMyw4IEBACiAjaW5jbHVkZSAiQ1N0cmluZy5oIgogI2luY2x1ZGUgIk5vZGUuaCIKICNp bmNsdWRlICJUZXh0RmllbGQuaCIKKyNpbmNsdWRlICJGaWxlQ2hvb3Nlci5oIgogI2luY2x1ZGUg IkZvbnQuaCIKLSNpbmNsdWRlICJGaWxlQnV0dG9uLmgiCiAjaW5jbHVkZSAiUG9wVXBCdXR0b24u aCIKICNpbmNsdWRlICJJbnRQb2ludC5oIgogI2luY2x1ZGUgIldpZGdldC5oIgpAQCAtNjQsNiAr NjQsNyBAQAogI2luY2x1ZGUgIkFYT2JqZWN0Q2FjaGUuaCIKICNpbmNsdWRlICJSZW5kZXJQb3B1 cE1lbnVXaW4uaCIKICNpbmNsdWRlICJFZGl0Q29tbWFuZC5oIgorI2luY2x1ZGUgIkljb24uaCIK IAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTExOCwxNSArMTE5LDEyIEBACiB2b2lk IExpc3RCb3g6OmNsZWFyKCkgeyBub3RJbXBsZW1lbnRlZCgpOyB9CiBib29sIExpc3RCb3g6OmNo ZWNrc0Rlc2NlbmRhbnRzRm9yRm9jdXMoKSBjb25zdCB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVy biAwOyB9CiAKLUZpbGVCdXR0b246OkZpbGVCdXR0b24oRnJhbWUqKSB7IG5vdEltcGxlbWVudGVk KCk7IH0KLXZvaWQgRmlsZUJ1dHRvbjo6Y2xpY2soYm9vbCkgeyBub3RJbXBsZW1lbnRlZCgpOyB9 Ci1JbnRTaXplIEZpbGVCdXR0b246OnNpemVGb3JDaGFyYWN0ZXJXaWR0aChpbnQpIGNvbnN0IHsg bm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIEludFNpemUoKTsgfQotV2lkZ2V0OjpGb2N1c1BvbGlj eSBGaWxlQnV0dG9uOjpmb2N1c1BvbGljeSgpIGNvbnN0IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0 dXJuIE5vRm9jdXM7IH0KLVdlYkNvcmU6OkludFJlY3QgRmlsZUJ1dHRvbjo6ZnJhbWVHZW9tZXRy eSgpIGNvbnN0IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIEludFJlY3QoKTsgfQotdm9pZCBG aWxlQnV0dG9uOjpzZXRGaWxlbmFtZShEZXByZWNhdGVkU3RyaW5nIGNvbnN0JikgeyBub3RJbXBs ZW1lbnRlZCgpOyB9Ci1pbnQgRmlsZUJ1dHRvbjo6YmFzZWxpbmVQb3NpdGlvbihpbnQpIGNvbnN0 IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIDA7IH0KLXZvaWQgRmlsZUJ1dHRvbjo6c2V0RnJh bWVHZW9tZXRyeShXZWJDb3JlOjpJbnRSZWN0IGNvbnN0JikgeyBub3RJbXBsZW1lbnRlZCgpOyB9 Ci12b2lkIEZpbGVCdXR0b246OnNldERpc2FibGVkKGJvb2wpIHsgbm90SW1wbGVtZW50ZWQoKTsg fQorRmlsZUNob29zZXI6OkZpbGVDaG9vc2VyKERvY3VtZW50KiwgUmVuZGVyRmlsZVVwbG9hZENv bnRyb2wqKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KK0ZpbGVDaG9vc2VyOjp+RmlsZUNob29zZXIo KSB7IG5vdEltcGxlbWVudGVkKCk7IH0KK3ZvaWQgRmlsZUNob29zZXI6Om9wZW5GaWxlQ2hvb3Nl cigpIHsgbm90SW1wbGVtZW50ZWQoKTsgfQorU3RyaW5nIEZpbGVDaG9vc2VyOjpiYXNlbmFtZUZv cldpZHRoKGludCB3aWR0aCkgY29uc3QgeyBub3RJbXBsZW1lbnRlZCgpOyByZXR1cm4gU3RyaW5n KCk7IH0KK3ZvaWQgRmlsZUNob29zZXI6OnVwbG9hZENvbnRyb2xEZXRhY2hpbmcoKSB7IG5vdElt cGxlbWVudGVkKCk7IH0KK3ZvaWQgRmlsZUNob29zZXI6OmNob29zZUZpbGUoY29uc3QgU3RyaW5n JiBmaWxlbmFtZSkgeyBub3RJbXBsZW1lbnRlZCgpOyB9CiAKIFdpZGdldDo6Rm9jdXNQb2xpY3kg U2xpZGVyOjpmb2N1c1BvbGljeSgpIGNvbnN0IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIE5v Rm9jdXM7IH0KIFdpZGdldDo6Rm9jdXNQb2xpY3kgTGlzdEJveDo6Zm9jdXNQb2xpY3koKSBjb25z dCB7IG5vdEltcGxlbWVudGVkKCk7IHJldHVybiBOb0ZvY3VzOyB9CkBAIC0yMDgsNiArMjA2LDkg QEAKIFN0cmluZyBXZWJDb3JlOjpzdWJtaXRCdXR0b25EZWZhdWx0TGFiZWwoKSB7IHJldHVybiAi U3VibWl0IjsgfQogU3RyaW5nIFdlYkNvcmU6OmlucHV0RWxlbWVudEFsdFRleHQoKSB7IHJldHVy biBEZXByZWNhdGVkU3RyaW5nKCk7IH0KIFN0cmluZyBXZWJDb3JlOjpyZXNldEJ1dHRvbkRlZmF1 bHRMYWJlbCgpIHsgcmV0dXJuICJSZXNldCI7IH0KK1N0cmluZyBXZWJDb3JlOjpmaWxlQnV0dG9u Q2hvb3NlRmlsZUxhYmVsKCkgeyByZXR1cm4gIkJyb3dzZS4uLiI7IH0KK1N0cmluZyBXZWJDb3Jl OjpmaWxlQnV0dG9uTm9GaWxlU2VsZWN0ZWRMYWJlbCgpIHsgcmV0dXJuIFN0cmluZygpOyB9CisK IFN0cmluZyBXZWJDb3JlOjpkZWZhdWx0TGFuZ3VhZ2UoKSB7IHJldHVybiAiZW4iOyB9CiAKIHZv aWQgV2ViQ29yZTo6ZmluZFdvcmRCb3VuZGFyeShVQ2hhciBjb25zdCogc3RyLGludCBsZW4saW50 IHBvc2l0aW9uLGludCogc3RhcnQsIGludCogZW5kKSB7KnN0YXJ0PXBvc2l0aW9uOyAqZW5kPXBv c2l0aW9uOyB9CkBAIC0zNzIsMyArMzczLDggQEAKIHZvaWQgUmVuZGVyVGhlbWVXaW46OnN5c3Rl bUZvbnQoaW50IHByb3BJZCwgRm9udERlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24pIGNvbnN0 IHt9CiBib29sIFJlbmRlclRoZW1lV2luOjpwYWludE1lbnVMaXN0KFJlbmRlck9iamVjdCAqLCBj b25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKSB7IHJldHVybiBm YWxzZTsgfQogdm9pZCBSZW5kZXJUaGVtZVdpbjo6YWRqdXN0TWVudUxpc3RTdHlsZShDU1NTdHls ZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50KikgY29uc3QgeyB9CisKK0ljb246Oklj b24oKSB7IG5vdEltcGxlbWVudGVkKCk7IH0KK0ljb246On5JY29uKCkgeyBub3RJbXBsZW1lbnRl ZCgpOyB9CitQYXNzUmVmUHRyPEljb24+IEljb246Om5ld0ljb25Gb3JGaWxlKGNvbnN0IFN0cmlu ZyYgZmlsZW5hbWUpIHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIFBhc3NSZWZQdHI8SWNvbj4o bmV3IEljb24oKSk7IH0KK3ZvaWQgSWNvbjo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3Qg SW50UmVjdCYpIHsgbm90SW1wbGVtZW50ZWQoKTsgfQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2 MzQ1KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMjYgQEAKIDIwMDYt MDktMTMgIE1vcmdhbkwgIDxtb3JsbW9yQHlhaG9vLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVE IE9SIENIQU5HRUQKKworICAgICAgICAqIFdlYkNvcmUudmNwcm9qL1dlYkNvcmUvV2ViQ29yZS52 Y3Byb2o6CisgICAgICAgICogcGxhdGZvcm0vd2luL1RlbXBvcmFyeUxpbmtTdHVicy5jcHA6Cisg ICAgICAgIChGaWxlQ2hvb3Nlcjo6RmlsZUNob29zZXIpOgorICAgICAgICAoRmlsZUNob29zZXI6 On5GaWxlQ2hvb3Nlcik6CisgICAgICAgIChGaWxlQ2hvb3Nlcjo6b3BlbkZpbGVDaG9vc2VyKToK KyAgICAgICAgKEZpbGVDaG9vc2VyOjpiYXNlbmFtZUZvcldpZHRoKToKKyAgICAgICAgKEZpbGVD aG9vc2VyOjp1cGxvYWRDb250cm9sRGV0YWNoaW5nKToKKyAgICAgICAgKEZpbGVDaG9vc2VyOjpj aG9vc2VGaWxlKToKKyAgICAgICAgKFdlYkNvcmU6OmZpbGVCdXR0b25DaG9vc2VGaWxlTGFiZWwp OgorICAgICAgICAoV2ViQ29yZTo6ZmlsZUJ1dHRvbk5vRmlsZVNlbGVjdGVkTGFiZWwpOgorICAg ICAgICAoSWNvbjo6SWNvbik6CisgICAgICAgIChJY29uOjp+SWNvbik6CisgICAgICAgIChJY29u OjpuZXdJY29uRm9yRmlsZSk6CisgICAgICAgIChJY29uOjpwYWludCk6CisKKzIwMDYtMDktMTMg IE1vcmdhbkwgIDxtb3JsbW9yQHlhaG9vLmNvbT4KKwogICAgICAgICBSZXZpZXdlZC9sYW5kZWQg YnkgYXJvYmVuLgogCiAgICAgICAgIEZpeGVzIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9y Zy9hdHRhY2htZW50LmNnaT9pZD0xMDUzNwpJbmRleDogV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS9X ZWJDb3JlLnZjcHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlLnZjcHJvai9XZWJDb3JlL1dlYkNv cmUudmNwcm9qCShyZXZpc2lvbiAxNjM0NSkKKysrIFdlYkNvcmUudmNwcm9qL1dlYkNvcmUvV2Vi Q29yZS52Y3Byb2oJKHdvcmtpbmcgY29weSkKQEAgLTI5OTEsMTEgKzI5OTEsMTEgQEAKIAkJCQk+ CiAJCQk8L0ZpbGU+CiAJCQk8RmlsZQotCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5ccmVuZGVyaW5n XFJlbmRlckZpbGVCdXR0b24uY3BwIgorCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5ccmVuZGVyaW5n XFJlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcCIKIAkJCQk+CiAJCQk8L0ZpbGU+CiAJCQk8Rmls ZQotCQkJCVJlbGF0aXZlUGF0aD0iLi5cLi5ccmVuZGVyaW5nXFJlbmRlckZpbGVCdXR0b24uaCIK KwkJCQlSZWxhdGl2ZVBhdGg9Ii4uXC4uXHJlbmRlcmluZ1xSZW5kZXJGaWxlVXBsb2FkQ29udHJv bC5oIgogCQkJCT4KIAkJCTwvRmlsZT4KIAkJCTxGaWxlCg==