10832 2006-09-13 05:12:37 -0700 Webkit WebCore build fails on Windows. 2006-09-13 11:08:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ PC OS X 10.4 RESOLVED FIXED Regression P2 Normal --- 10833 1 karthikkumar webkit-unassigned aroben fishd mrowe oldest_to_newest 55380 0 karthikkumar 2006-09-13 05:12:37 -0700 Apparently in {$WebKit}/WebCore/bindings/scripts/CodeGenerator.pm, Line 211: $thisDir = "$ENV{SOURCE_ROOT}/$directory"; breaks. The only real way to fix it is to change it to: $thisDir = "/cygdrive/c/Webkit/WebCore/$directory"; (or some other absolute path) or change the cygwin config (.bashrc) and set the variable. Setting too many messy environmental variables is also hard. Suggestions: 1. Please make the script get the current directory and scan in it. 2. Use basename of the target idl file to be scanned and scan in it. 3. Re-document the build procedure. 55381 1 mrowe 2006-09-13 05:15:34 -0700 This is also broken on the Windows build slave. SOURCE_ROOT appears to be automagically set from Xcode, so it is not available on Windows without the user manually setting it. IMO the path should be derived from the absolute path to the script being executed (similar to point 2 in Karthik's comment). 55383 2 mrowe 2006-09-13 05:18:02 -0700 The use of SOURCE_ROOT was introduced in r16342 (http://trac.webkit.org/projects/webkit/changeset/16342). 55413 3 aroben 2006-09-13 10:18:05 -0700 Why not just set SOURCE_ROOT in build-generated-files.sh? 55419 4 10537 fishd 2006-09-13 10:57:45 -0700 Created attachment 10537 patch 55421 5 10537 aroben 2006-09-13 10:59:29 -0700 Comment on attachment 10537 patch r=me 55424 6 10537 aroben 2006-09-13 11:08:23 -0700 Comment on attachment 10537 patch Landed as r16345. 10537 2006-09-13 10:57:45 -0700 2006-09-13 10:59:29 -0700 patch win-fix.diff text/plain 535 fishd SW5kZXg6IGJ1aWxkLWdlbmVyYXRlZC1maWxlcy5zaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBidWlsZC1nZW5l cmF0ZWQtZmlsZXMuc2gJKHJldmlzaW9uIDE2MzQ0KQorKysgYnVpbGQtZ2VuZXJhdGVkLWZpbGVz LnNoCSh3b3JraW5nIGNvcHkpCkBAIC0xMiw2ICsxMiw5IEBACiBTUkNST09UPWBjeWdwYXRoIC11 ICIkU1JDUk9PVCJgCiBleHBvcnQgU1JDUk9PVAogCisjIFhjb2RlIGFsc28gZGVmaW5lcyB0aGlz IHZhcmlhYmxlLgorZXhwb3J0IFNPVVJDRV9ST09UPSIkU1JDUk9PVCIKKwogIyBGSVhNRTogRXZl bnR1YWxseSB3aW4zMiBtaWdodCB3aXNoIHRvIGdlbmVyYXRlIHRvIHRoZSBEZWJ1Zy9SZWxlYXNl IG91dHB1dCBkaXJlY3Rvcmllcy4KIGV4cG9ydCBCVUlMVF9QUk9EVUNUU19ESVI9IiRTUkNST09U IgogZXhwb3J0IENSRUFURV9IQVNIX1RBQkxFPSIkU1JDUk9PVC8uLi9KYXZhU2NyaXB0Q29yZS9r anMvY3JlYXRlX2hhc2hfdGFibGUiCg==