108318 2013-01-30 02:45:56 -0800 [Qt] Fix Qt/Mac build after r141024 and r141037 2013-01-30 06:50:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno benjamin haraken ojan.autocc webkit.review.bot zarvai oldest_to_newest 820006 0 zeno 2013-01-30 02:45:56 -0800 [Qt] Fix Qt/Mac build after r141024 820013 1 185450 zeno 2013-01-30 02:50:18 -0800 Created attachment 185450 Patch 820054 2 185450 haraken 2013-01-30 03:48:55 -0800 Comment on attachment 185450 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185450&action=review rs=me > Source/WTF/ChangeLog:3 > + [Qt] Fix Qt/Mac build after r141024 I think this error would be due to r141037. 820091 3 zeno 2013-01-30 04:42:07 -0800 *** Bug 108321 has been marked as a duplicate of this bug. *** 820104 4 185450 zeno 2013-01-30 05:00:34 -0800 Comment on attachment 185450 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185450&action=review >> Source/WTF/ChangeLog:3 >> + [Qt] Fix Qt/Mac build after r141024 > > I think this error would be due to r141037. It is failing on the bot since r141024. But it is likely that the patch fixes more than a "single" breakage. So I'll update the title to mention both revisions. I will have to re-upload the patch again, because there are two more PLATFORM(MAC) that need to be replaced with OS(DARWIN) in Functional.h. - Sorry for the inconvenience. 820111 5 185471 zeno 2013-01-30 05:09:53 -0800 Created attachment 185471 Patch 820112 6 185471 haraken 2013-01-30 05:10:27 -0800 Comment on attachment 185471 Patch rs=me 820167 7 185471 zeno 2013-01-30 06:50:28 -0800 Comment on attachment 185471 Patch Clearing flags on attachment: 185471 Committed r141263: <http://trac.webkit.org/changeset/141263> 820168 8 zeno 2013-01-30 06:50:33 -0800 All reviewed patches have been landed. Closing bug. 185450 2013-01-30 02:50:18 -0800 2013-01-30 05:09:49 -0800 Patch bug-108318-20130130114703.patch text/plain 3213 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY0ZjM4ZjI1NWI2N2RmYjdjYWZmMmE5 ZTRhMDc3YTU3Y2E0MTllY2UuLjRmOWJmNDcwYTNhNTA4NWYxODc0YmI5ZWNiN2MyOTU0ZjJkYzI1 ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDEtMzAgIFplbm8gQWxiaXNzZXIgIDx6ZW5v QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XSBGaXggUXQvTWFjIGJ1aWxkIGFmdGVyIHIxNDEw MjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODMx OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L0Z1bmN0aW9uYWwuaDoKKyAgICAgICAgICAgIE1ha2Ugc3VyZSBCbG9jay5oIGlzIGluY2x1ZGVk IGZvciBRdCBvbiBNYWMuCisKIDIwMTMtMDEtMjkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIEludHJvZHVjaW5nIFdURjo6VHlwZVNhZmVFbnVtIGFuZCBEYXRhYmFz ZUVycm9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCmluZGV4IGEzMjMyNzRlZTBhNzFkMTljNmMzZGViNjRjYTMwOTU3OWRk NzM4NzIuLjgwM2VkODk5NThlNWMxOWZjZmY4MmQ3ZWM3MDA1OWIyMGRlZjE3MmIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wMS0zMCAgWmVubyBBbGJpc3NlciAgPHplbm9Ad2Vi a2l0Lm9yZz4KKworICAgICAgICBbUXRdIEZpeCBRdC9NYWMgYnVpbGQgYWZ0ZXIgcjE0MTAyNAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MzE4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9y bS9Db3JlSVBDL21hYy9Db25uZWN0aW9uTWFjLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OkNvbm5l Y3Rpb246OnBsYXRmb3JtSW52YWxpZGF0ZSk6CisgICAgICAgICAgICBSZXBsYWNlIG51bGxwdHIg d2l0aCAwIHRvIGFsbG93IGNvbXBpbGluZyB3aXRob3V0IEMrKzExIHN1cHBvcnQuCisKIDIwMTMt MDEtMzAgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAg ICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IFJlbW92ZSBtX3BlbmRpbmdTeW5jQmFja2luZ1N0b3Jl cyBpbiBMYXllclRyZWVSZW5kZXJlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Z1bmN0 aW9uYWwuaCBiL1NvdXJjZS9XVEYvd3RmL0Z1bmN0aW9uYWwuaAppbmRleCA5ZmUyMWZhZmIxZjcx Y2Y3M2NkMzJhNzAwM2Q1ZDRiOTIyNDlmYjc3Li44YjIyMmIwNDFhMTNhNjEyZDIyNmE0ZTk2YzI2 MTg5NWFmZDlhNjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9GdW5jdGlvbmFsLmgKKysr IGIvU291cmNlL1dURi93dGYvRnVuY3Rpb25hbC5oCkBAIC0zMiw3ICszMiw3IEBACiAjaW5jbHVk ZSA8d3RmL1RocmVhZFNhZmVSZWZDb3VudGVkLmg+CiAjaW5jbHVkZSA8d3RmL1dlYWtQdHIuaD4K IAotI2lmIFBMQVRGT1JNKE1BQykgJiYgQ09NUElMRVJfU1VQUE9SVFMoQkxPQ0tTKQorI2lmIE9T KERBUldJTikgJiYgQ09NUElMRVJfU1VQUE9SVFMoQkxPQ0tTKQogI2luY2x1ZGUgPEJsb2NrLmg+ CiAjaW5jbHVkZSA8d3RmL09iamNSdW50aW1lRXh0cmFzLmg+CiAjZW5kaWYKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvbWFjL0Nvbm5lY3Rpb25NYWMuY3BwIGIv U291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9tYWMvQ29ubmVjdGlvbk1hYy5jcHAKaW5k ZXggMDQ5MjBkMjM1YjVjMWI3OGE3ZDBjNTEzMmZkNjc2M2JiMjk1ZjFhMS4uNmMxMTkxMjExYzdl ZDZhM2VlN2I0MWFhNzdlNDdhYjJmZTcxYWIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9tYWMvQ29ubmVjdGlvbk1hYy5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9tYWMvQ29ubmVjdGlvbk1hYy5jcHAKQEAgLTYxLDI1ICs2MSwy NSBAQCB2b2lkIENvbm5lY3Rpb246OnBsYXRmb3JtSW52YWxpZGF0ZSgpCiAgICAgLy8gVW5yZWdp c3RlciBvdXIgcG9ydHMuCiAgICAgZGlzcGF0Y2hfc291cmNlX2NhbmNlbChtX2RlYWROYW1lU291 cmNlKTsKICAgICBkaXNwYXRjaF9yZWxlYXNlKG1fZGVhZE5hbWVTb3VyY2UpOwotICAgIG1fZGVh ZE5hbWVTb3VyY2UgPSBudWxscHRyOworICAgIG1fZGVhZE5hbWVTb3VyY2UgPSAwOwogICAgIG1f c2VuZFBvcnQgPSBNQUNIX1BPUlRfTlVMTDsKIAogICAgIGRpc3BhdGNoX3NvdXJjZV9jYW5jZWwo bV9yZWNlaXZlUG9ydERhdGFBdmFpbGFibGVTb3VyY2UpOwogICAgIGRpc3BhdGNoX3JlbGVhc2Uo bV9yZWNlaXZlUG9ydERhdGFBdmFpbGFibGVTb3VyY2UpOwotICAgIG1fcmVjZWl2ZVBvcnREYXRh QXZhaWxhYmxlU291cmNlID0gbnVsbHB0cjsKKyAgICBtX3JlY2VpdmVQb3J0RGF0YUF2YWlsYWJs ZVNvdXJjZSA9IDA7CiAgICAgbV9yZWNlaXZlUG9ydCA9IE1BQ0hfUE9SVF9OVUxMOwogCiAgICAg aWYgKG1fZXhjZXB0aW9uUG9ydCkgewogICAgICAgICBkaXNwYXRjaF9zb3VyY2VfY2FuY2VsKG1f ZXhjZXB0aW9uUG9ydERhdGFBdmFpbGFibGVTb3VyY2UpOwogICAgICAgICBkaXNwYXRjaF9yZWxl YXNlKG1fZXhjZXB0aW9uUG9ydERhdGFBdmFpbGFibGVTb3VyY2UpOwotICAgICAgICBtX2V4Y2Vw dGlvblBvcnREYXRhQXZhaWxhYmxlU291cmNlID0gbnVsbHB0cjsKKyAgICAgICAgbV9leGNlcHRp b25Qb3J0RGF0YUF2YWlsYWJsZVNvdXJjZSA9IDA7CiAgICAgICAgIG1fZXhjZXB0aW9uUG9ydCA9 IE1BQ0hfUE9SVF9OVUxMOwogICAgIH0KIAogI2lmIEhBVkUoWFBDKQogICAgIGlmIChtX3hwY0Nv bm5lY3Rpb24pIHsKICAgICAgICAgeHBjX3JlbGVhc2UobV94cGNDb25uZWN0aW9uKTsKLSAgICAg ICAgbV94cGNDb25uZWN0aW9uID0gbnVsbHB0cjsKKyAgICAgICAgbV94cGNDb25uZWN0aW9uID0g MDsKICAgICB9CiAjZW5kaWYKIH0K 185471 2013-01-30 05:09:53 -0800 2013-01-30 06:50:28 -0800 Patch bug-108318-20130130140637.patch text/plain 3768 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY0ZjM4ZjI1NWI2N2RmYjdjYWZmMmE5 ZTRhMDc3YTU3Y2E0MTllY2UuLjhlODcyNzU3NmIwN2MxMWY3MDkzYTU2ZDQ4NjVkNzEwM2EyNjdi NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDEtMzAgIFplbm8gQWxiaXNzZXIgIDx6ZW5v QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XSBGaXggUXQvTWFjIGJ1aWxkIGFmdGVyIHIxNDEw MjQgYW5kIHIxNDEwMzcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwODMxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogd3RmL0Z1bmN0aW9uYWwuaDoKKyAgICAgICAgICAgIE1ha2Ugc3VyZSBCbG9jay5o IGlzIGluY2x1ZGVkIGFuZCBpdHMgZnVuY3Rpb25hbGl0eQorICAgICAgICAgICAgaXMgZW5hYmxl ZCBmb3IgUXQgb24gTWFjLgorCiAyMDEzLTAxLTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2luZyBXVEY6OlR5cGVTYWZlRW51bSBhbmQgRGF0YWJh c2VFcnJvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhMzIzMjc0ZWUwYTcxZDE5YzZjM2RlYjY0Y2EzMDk1Nzlk ZDczODcyLi5kYzlmNTUzNzAxYWU1N2RjMTBmZTRkOGZjMWQ4NjcwOTBjZmZmNjIzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDEtMzAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdl YmtpdC5vcmc+CisKKyAgICAgICAgW1F0XSBGaXggUXQvTWFjIGJ1aWxkIGFmdGVyIHIxNDEwMjQg YW5kIHIxNDEwMzcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwODMxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogUGxhdGZvcm0vQ29yZUlQQy9tYWMvQ29ubmVjdGlvbk1hYy5jcHA6CisgICAgICAgIChD b3JlSVBDOjpDb25uZWN0aW9uOjpwbGF0Zm9ybUludmFsaWRhdGUpOgorICAgICAgICAgICAgUmVw bGFjZSBudWxscHRyIHdpdGggMCB0byBhbGxvdyBjb21waWxpbmcgd2l0aG91dCBDKysxMSBzdXBw b3J0LgorCiAyMDEzLTAxLTMwICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAu bmV0PgogCiAgICAgICAgIENvb3JkaW5hdGVkIEdyYXBoaWNzOiBSZW1vdmUgbV9wZW5kaW5nU3lu Y0JhY2tpbmdTdG9yZXMgaW4gTGF5ZXJUcmVlUmVuZGVyZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9GdW5jdGlvbmFsLmggYi9Tb3VyY2UvV1RGL3d0Zi9GdW5jdGlvbmFsLmgKaW5kZXgg OWZlMjFmYWZiMWY3MWNmNzNjZDMyYTcwMDNkNWQ0YjkyMjQ5ZmI3Ny4uYTJmYzE1ODZjYTY3YTg5 MjAyODExYTg4ZjdjMjg5YTBlZTc0ZjA1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRnVu Y3Rpb25hbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Z1bmN0aW9uYWwuaApAQCAtMzIsNyArMzIs NyBAQAogI2luY2x1ZGUgPHd0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0 Zi9XZWFrUHRyLmg+CiAKLSNpZiBQTEFURk9STShNQUMpICYmIENPTVBJTEVSX1NVUFBPUlRTKEJM T0NLUykKKyNpZiBPUyhEQVJXSU4pICYmIENPTVBJTEVSX1NVUFBPUlRTKEJMT0NLUykKICNpbmNs dWRlIDxCbG9jay5oPgogI2luY2x1ZGUgPHd0Zi9PYmpjUnVudGltZUV4dHJhcy5oPgogI2VuZGlm CkBAIC0zNzAsNyArMzcwLDcgQEAgcHJpdmF0ZToKICAgICBSIChDOjoqbV9mdW5jdGlvbikoUDEs IFAyLCBQMywgUDQsIFA1KTsKIH07CiAKLSNpZiBQTEFURk9STShNQUMpICYmIENPTVBJTEVSX1NV UFBPUlRTKEJMT0NLUykKKyNpZiBPUyhEQVJXSU4pICYmIENPTVBJTEVSX1NVUFBPUlRTKEJMT0NL UykKIHRlbXBsYXRlPHR5cGVuYW1lIFI+CiBjbGFzcyBGdW5jdGlvbldyYXBwZXI8UiAoXikoKT4g ewogcHVibGljOgpAQCAtNzA0LDcgKzcwNCw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGlt cGw8UiAoKT4oKS0+b3BlcmF0b3IoKSgpOwogICAgIH0KIAotI2lmIFBMQVRGT1JNKE1BQykgJiYg Q09NUElMRVJfU1VQUE9SVFMoQkxPQ0tTKQorI2lmIE9TKERBUldJTikgJiYgQ09NUElMRVJfU1VQ UE9SVFMoQkxPQ0tTKQogICAgIHR5cGVkZWYgdm9pZCAoXkJsb2NrVHlwZSkoKTsKICAgICBvcGVy YXRvciBCbG9ja1R5cGUoKSBjb25zdAogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1BsYXRmb3JtL0NvcmVJUEMvbWFjL0Nvbm5lY3Rpb25NYWMuY3BwIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9tYWMvQ29ubmVjdGlvbk1hYy5jcHAKaW5kZXggMDQ5MjBkMjM1YjVj MWI3OGE3ZDBjNTEzMmZkNjc2M2JiMjk1ZjFhMS4uNmMxMTkxMjExYzdlZDZhM2VlN2I0MWFhNzdl NDdhYjJmZTcxYWIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQ Qy9tYWMvQ29ubmVjdGlvbk1hYy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29y ZUlQQy9tYWMvQ29ubmVjdGlvbk1hYy5jcHAKQEAgLTYxLDI1ICs2MSwyNSBAQCB2b2lkIENvbm5l Y3Rpb246OnBsYXRmb3JtSW52YWxpZGF0ZSgpCiAgICAgLy8gVW5yZWdpc3RlciBvdXIgcG9ydHMu CiAgICAgZGlzcGF0Y2hfc291cmNlX2NhbmNlbChtX2RlYWROYW1lU291cmNlKTsKICAgICBkaXNw YXRjaF9yZWxlYXNlKG1fZGVhZE5hbWVTb3VyY2UpOwotICAgIG1fZGVhZE5hbWVTb3VyY2UgPSBu dWxscHRyOworICAgIG1fZGVhZE5hbWVTb3VyY2UgPSAwOwogICAgIG1fc2VuZFBvcnQgPSBNQUNI X1BPUlRfTlVMTDsKIAogICAgIGRpc3BhdGNoX3NvdXJjZV9jYW5jZWwobV9yZWNlaXZlUG9ydERh dGFBdmFpbGFibGVTb3VyY2UpOwogICAgIGRpc3BhdGNoX3JlbGVhc2UobV9yZWNlaXZlUG9ydERh dGFBdmFpbGFibGVTb3VyY2UpOwotICAgIG1fcmVjZWl2ZVBvcnREYXRhQXZhaWxhYmxlU291cmNl ID0gbnVsbHB0cjsKKyAgICBtX3JlY2VpdmVQb3J0RGF0YUF2YWlsYWJsZVNvdXJjZSA9IDA7CiAg ICAgbV9yZWNlaXZlUG9ydCA9IE1BQ0hfUE9SVF9OVUxMOwogCiAgICAgaWYgKG1fZXhjZXB0aW9u UG9ydCkgewogICAgICAgICBkaXNwYXRjaF9zb3VyY2VfY2FuY2VsKG1fZXhjZXB0aW9uUG9ydERh dGFBdmFpbGFibGVTb3VyY2UpOwogICAgICAgICBkaXNwYXRjaF9yZWxlYXNlKG1fZXhjZXB0aW9u UG9ydERhdGFBdmFpbGFibGVTb3VyY2UpOwotICAgICAgICBtX2V4Y2VwdGlvblBvcnREYXRhQXZh aWxhYmxlU291cmNlID0gbnVsbHB0cjsKKyAgICAgICAgbV9leGNlcHRpb25Qb3J0RGF0YUF2YWls YWJsZVNvdXJjZSA9IDA7CiAgICAgICAgIG1fZXhjZXB0aW9uUG9ydCA9IE1BQ0hfUE9SVF9OVUxM OwogICAgIH0KIAogI2lmIEhBVkUoWFBDKQogICAgIGlmIChtX3hwY0Nvbm5lY3Rpb24pIHsKICAg ICAgICAgeHBjX3JlbGVhc2UobV94cGNDb25uZWN0aW9uKTsKLSAgICAgICAgbV94cGNDb25uZWN0 aW9uID0gbnVsbHB0cjsKKyAgICAgICAgbV94cGNDb25uZWN0aW9uID0gMDsKICAgICB9CiAjZW5k aWYKIH0K