108301 2013-01-30 00:27:23 -0800 getDecorationRootAndDecoratedRoot should add new user agent shadow roots 2013-01-30 01:43:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108209 1 esprehn esprehn ojan.autocc webkit.review.bot oldest_to_newest 819881 0 esprehn 2013-01-30 00:27:23 -0800 getDecorationRootAndDecoratedRoot should add new user agent shadow roots 819897 1 185418 esprehn 2013-01-30 00:47:25 -0800 Created attachment 185418 Patch 819903 2 185418 morrita 2013-01-30 00:52:13 -0800 Comment on attachment 185418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185418&action=review > Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:98 > + // the input. Yeah, adding UA shadow root is basically a bad idea and the team tried to get rid of it. This one has been overlooked though. 819957 3 185418 webkit.review.bot 2013-01-30 01:43:05 -0800 Comment on attachment 185418 Patch Clearing flags on attachment: 185418 Committed r141235: <http://trac.webkit.org/changeset/141235> 819958 4 webkit.review.bot 2013-01-30 01:43:08 -0800 All reviewed patches have been landed. Closing bug. 185418 2013-01-30 00:47:25 -0800 2013-01-30 01:43:05 -0800 Patch bug-108301-20130130034409.patch text/plain 3102 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzUwYjVjYWFlNjEyMGJk NzJhNWIzZjJkMTFlMDFlNzE0ZTk4Y2UxNC4uZGU2NzkwYzI1ZTBiNDM5Yzc0MDY4NDYwYjEwOGM5 YzFhN2IyYjNkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAxLTMwICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGdldERlY29yYXRp b25Sb290QW5kRGVjb3JhdGVkUm9vdCBzaG91bGQgYWRkIG5ldyB1c2VyIGFnZW50IHNoYWRvdyBy b290cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4 MzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ2V0 RGVjb3JhdGlvblJvb3RBbmREZWNvcmF0ZWRSb290IGludGVuZGVkIHRvIGFkZCBhIHNlY29uZCBV c2VyQWdlbnRTaGFkb3dSb290CisgICAgICAgIHRvIHRoZSBpbnB1dCwgbm90IGp1c3QgcmV1c2Ug dGhlIGV4aXN0aW5nIG9uZSBzbyBpdCBjb3VsZCBpbnNlcnQgaWNvbnMgaW50bworICAgICAgICB0 aGUgaW5wdXRzLiBBZGQgYmFjayBpbiB0aGlzIGJlaGF2aW9yIGZvciBub3cgc28gd2UgY2FuIHNv cnQgb3V0IHRoZSByaWdodCB0aGluZworICAgICAgICB0byBkby4KKworICAgICAgICBUaGlzIGJl aGF2aW9yIGlzIHdyb25nIGluIHRoZSBjdXJyZW50IGFyY2hpdGVjdHVyZSBzaW5jZSBpdCBtZWFu cyBpZiB5b3UgaGFkIGFuCisgICAgICAgIGlucHV0IHR5cGU9c3VibWl0LCBhZGQgYW4gYXV0aG9y IHNoYWRvdyByb290LCBhbmQgdGhlbiBjaGFuZ2UgdGhlIHR5cGUgdG8gdGV4dAorICAgICAgICBh bmQgdGhlbiB0aGUgYnJvd3NlciBkZWNvcmF0ZXMgaXQgeW91ciBzaGFkb3cgbWFnaWNhbGx5IGJl Y29tZXMgaW5hY2Nlc3NpYmxlIHNpbmNlCisgICAgICAgIGlucHV0LnNoYWRvd1Jvb3QgaXMgbm8g bG9uZ2VyIGF2YWlsYWJsZS4gVGhpcyBmZWF0dXJlIGlzIGN1cnJlbnRseSBvbmx5IHVzZWQgZm9y CisgICAgICAgIGRlY29yYXRpbmcgdHlwZT1wYXNzd29yZCBmaWVsZHMgaW4gQ2hyb21pdW0gd2l0 aCBhbiBpY29uIGZvciBwYXNzd29yZCBnZW5lcmF0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgdGhlcmUncyBubyB3YXkgdG8gdGVzdCB0aGlzIGJlY2F1c2UgaXQncyBvbmx5IHVzZWQgaW4g Q2hyb21pdW0KKyAgICAgICAgYnkgd2F5IG9mIHRoZSBDaHJvbWVDbGllbnQuCisKKyAgICAgICAg KiBodG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpnZXREZWNvcmF0aW9uUm9vdEFuZERlY29yYXRlZFJvb3QpOgorCiAyMDEzLTAxLTI5 ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU2Nyb2xs YmFyIGFuZCBzY3JvbGwgY29ybmVyIGNvbXBvc2l0ZWQgbGF5ZXJzIHBvc2l0aW9uZWQgaW5jb3Jy ZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRGaWVsZERl Y29yYXRpb25FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRGaWVs ZERlY29yYXRpb25FbGVtZW50LmNwcAppbmRleCA5ZWM1NDNhZjU2ZjM2Nzg2NDQ2YzUyZmY4Mzdi NDg4YmEzODNhMmFiLi5lZjE4ODNhYWZhZDBmZWJlZjA2ZGNmM2NlNmVmY2I4ODgwOWI2M2YyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9u RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVj b3JhdGlvbkVsZW1lbnQuY3BwCkBAIC01NCw2ICs1NCw4IEBAIFRleHRGaWVsZERlY29yYXRvcjo6 flRleHRGaWVsZERlY29yYXRvcigpCiAKIC8vIFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50IC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KIAorLy8gRklYTUU6IFRoaXMgY2xhc3MgaXMgb25seSB1c2VkIGluIENocm9taXVtLCBh bmQgaGFzIG5vIGxheW91dCB0ZXN0cyEhCisKIFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50OjpU ZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudChEb2N1bWVudCogZG9jdW1lbnQsIFRleHRGaWVsZERl Y29yYXRvciogZGVjb3JhdG9yKQogICAgIDogSFRNTERpdkVsZW1lbnQoSFRNTE5hbWVzOjpkaXZU YWcsIGRvY3VtZW50KQogICAgICwgbV90ZXh0RmllbGREZWNvcmF0b3IoZGVjb3JhdG9yKQpAQCAt ODksOCArOTEsMTMgQEAgc3RhdGljIGlubGluZSB2b2lkIGdldERlY29yYXRpb25Sb290QW5kRGVj b3JhdGVkUm9vdChIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCwgU2gKICAgICB9CiAgICAgaWYgKG5l d1Jvb3QpCiAgICAgICAgIG5ld1Jvb3QtPnJlbW92ZUNoaWxkKG5ld1Jvb3QtPmZpcnN0Q2hpbGQo KSk7Ci0gICAgZWxzZQotICAgICAgICBuZXdSb290ID0gaW5wdXQtPmVuc3VyZVVzZXJBZ2VudFNo YWRvd1Jvb3QoKTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gRklYTUU6IFRoaXMgaW50ZXJhY3Rz IHJlYWxseSBiYWRseSB3aXRoIGF1dGhvciBzaGFkb3cgcm9vdHMgYmVjYXVzZSBub3cKKyAgICAg ICAgLy8gd2UgY2FuIGludGVybGVhdmUgdXNlciBhZ2VudCBhbmQgYXV0aG9yIHNoYWRvdyByb290 cyBvbiB0aGUgZWxlbWVudCBtZWFuaW5nCisgICAgICAgIC8vIGlucHV0LnNoYWRvd1Jvb3QgbWF5 IGJlIGluYWNjZXNzaWJsZSBpZiB0aGUgYnJvd3NlciBoYXMgZGVjaWRlZCB0byBkZWNvcmF0ZQor ICAgICAgICAvLyB0aGUgaW5wdXQuCisgICAgICAgIG5ld1Jvb3QgPSBpbnB1dC0+ZW5zdXJlU2hh ZG93KCktPmFkZFNoYWRvd1Jvb3QoaW5wdXQsIFNoYWRvd1Jvb3Q6OlVzZXJBZ2VudFNoYWRvd1Jv b3QpOworICAgIH0KICAgICBkZWNvcmF0aW9uUm9vdCA9IG5ld1Jvb3Q7CiAgICAgZGVjb3JhdGVk Um9vdCA9IGV4aXN0aW5nUm9vdDsKIH0K