108298 2013-01-29 22:58:20 -0800 Element::areAuthorShadowsAllowed should be private 2013-01-30 09:42:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn cmarcelo dglazkov d-r eric.carlson feature-media-reviews fmalita mifenton morrita ojan.autocc ojan pdr schenney tkent webkit.review.bot oldest_to_newest 819822 0 esprehn 2013-01-29 22:58:20 -0800 Element::areAuthorShadowsAllowed should be private 819825 1 185401 esprehn 2013-01-29 23:00:31 -0800 Created attachment 185401 Patch 820240 2 185401 darin 2013-01-30 08:56:05 -0800 Comment on attachment 185401 Patch More private is more better. 820256 3 185401 webkit.review.bot 2013-01-30 09:16:50 -0800 Comment on attachment 185401 Patch Clearing flags on attachment: 185401 Committed r141277: <http://trac.webkit.org/changeset/141277> 820257 4 webkit.review.bot 2013-01-30 09:16:54 -0800 All reviewed patches have been landed. Closing bug. 820272 5 185401 dominicc 2013-01-30 09:42:39 -0800 Comment on attachment 185401 Patch Nice. 185401 2013-01-29 23:00:31 -0800 2013-01-30 09:42:39 -0800 Patch bug-108298-20130130015716.patch text/plain 7190 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzUwYjVjYWFlNjEyMGJk NzJhNWIzZjJkMTFlMDFlNzE0ZTk4Y2UxNC4uMTlhYjg1YzVmOGQ4YWQ1ZmIyYTkyYTI2NzE1M2Uw YTc1M2UxNDdmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAxLTI5ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEVsZW1lbnQ6OmFy ZUF1dGhvclNoYWRvd3NBbGxvd2VkIHNob3VsZCBiZSBwcml2YXRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgyOTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIHJlYXNvbiBmb3IgYXJl QXV0aG9yU2hhZG93c0FsbG93ZWQgdG8gYmUgZXhwb3NlZCBwdWJsaWNhbGx5CisgICAgICAgIG9u IEVsZW1lbnQgc2luY2UgaXQganVzdCBjb250cm9scyB0aGUgYmVoYXZpb3Igb2YgY3JlYXRlU2hh ZG93Um9vdC4gTWFrZQorICAgICAgICBpdCBwcml2YXRlIGFuZCBmaXggYWxsIHBsYWNlcyB3aGVy ZSBpdCB3YXNuJ3QgaW4gc3ViY2xhc3Nlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3Qg cmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6YXJlQXV0aG9yU2hhZG93c0FsbG93ZWQpOiBNYWRlIHByaXZhdGUuCisgICAg ICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5oOgorICAgICAgICAoSFRNTEZyYW1lRWxl bWVudEJhc2UpOgorICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5oOgorICAgICAgICAo SFRNTElucHV0RWxlbWVudCk6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6Cisg ICAgICAgIChIVE1MTWVkaWFFbGVtZW50KToKKyAgICAgICAgKiBodG1sL0hUTUxQbHVnSW5FbGVt ZW50Lmg6CisgICAgICAgIChIVE1MUGx1Z0luRWxlbWVudCk6CisgICAgICAgICogc3ZnL1NWR0Vs ZW1lbnQuaDoKKyAgICAgICAgKFNWR0VsZW1lbnQpOgorCiAyMDEzLTAxLTI5ICBKYW1lcyBSb2Jp bnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU2Nyb2xsYmFyIGFuZCBzY3Jv bGwgY29ybmVyIGNvbXBvc2l0ZWQgbGF5ZXJzIHBvc2l0aW9uZWQgaW5jb3JyZWN0bHkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5oCmluZGV4IGUxYmQ0NmMxYWIyNzliNTgyZDU3NzhjODlhMGVlZDNiODAyNmQ5Mzgu LjE4NjNjOWE2MDYwNzE2Njg3MWI0MjcyMjBmNTViNzQwYTVlNzhkODEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1l bnQuaApAQCAtMjk1LDcgKzI5NSw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaGFzQXV0aG9yU2hh ZG93Um9vdCgpIGNvbnN0IHsgcmV0dXJuIHNoYWRvd1Jvb3QoKTsgfQogICAgIHZpcnR1YWwgdm9p ZCB3aWxsQWRkQXV0aG9yU2hhZG93Um9vdCgpIHsgfQotICAgIHZpcnR1YWwgYm9vbCBhcmVBdXRo b3JTaGFkb3dzQWxsb3dlZCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAogICAgIFNoYWRvd1Jv b3QqIHVzZXJBZ2VudFNoYWRvd1Jvb3QoKSBjb25zdDsKICAgICBTaGFkb3dSb290KiBlbnN1cmVV c2VyQWdlbnRTaGFkb3dSb290KCk7CkBAIC01MzIsNiArNTMxLDcgQEAgcHJpdmF0ZToKICAgICBQ YXNzUmVmUHRyPFBzZXVkb0VsZW1lbnQ+IGNyZWF0ZVBzZXVkb0VsZW1lbnRJZk5lZWRlZChQc2V1 ZG9JZCk7CiAgICAgdm9pZCBzZXRQc2V1ZG9FbGVtZW50KFBzZXVkb0lkLCBQYXNzUmVmUHRyPFBz ZXVkb0VsZW1lbnQ+KTsKIAorICAgIHZpcnR1YWwgYm9vbCBhcmVBdXRob3JTaGFkb3dzQWxsb3dl ZCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlkQWRkVXNlckFn ZW50U2hhZG93Um9vdChTaGFkb3dSb290KikgeyB9CiAKICAgICAvLyBGSVhNRTogUmVtb3ZlIHRo ZSBuZWVkIGZvciBBdHRyIHRvIGNhbGwgd2lsbE1vZGlmeUF0dHJpYnV0ZS9kaWRNb2RpZnlBdHRy aWJ1dGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRC YXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmgKaW5kZXgg N2FmOTQ4NTMyNDkwNWMwNTdkY2MyZWVjYmExMTZiZDM5NGZjMzI0MC4uMjY2YjZjMzE1ZTZjNjRm ODkyYWFhNTVhODk5NGRmYjBhYTcwNjExNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRnJhbWVFbGVtZW50QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZy YW1lRWxlbWVudEJhc2UuaApAQCAtNTMsNyArNTMsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVh bCBJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IGluc2VydGVkSW50byhDb250YWluZXJOb2Rl KikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGRpZE5vdGlmeVN1YnRyZWVJbnNlcnRpb25z KENvbnRhaW5lck5vZGUqKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgYXR0YWNoKCk7Ci0g ICAgdmlydHVhbCBib29sIGFyZUF1dGhvclNoYWRvd3NBbGxvd2VkKCkgY29uc3QgT1ZFUlJJREUg eyByZXR1cm4gZmFsc2U7IH0KIAogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNG b2N1cygpIGNvbnN0OwpAQCAtNjIsNiArNjEsOCBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9v bCBpc1VSTEF0dHJpYnV0ZShjb25zdCBBdHRyaWJ1dGUmKSBjb25zdCBPVkVSUklERTsKICAgICB2 aXJ0dWFsIGJvb2wgaXNGcmFtZUVsZW1lbnRCYXNlKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQog CisgICAgdmlydHVhbCBib29sIGFyZUF1dGhvclNoYWRvd3NBbGxvd2VkKCkgY29uc3QgT1ZFUlJJ REUgeyByZXR1cm4gZmFsc2U7IH0KKwogICAgIGJvb2wgdmlld1NvdXJjZU1vZGUoKSBjb25zdCB7 IHJldHVybiBtX3ZpZXdTb3VyY2U7IH0KIAogICAgIHZvaWQgc2V0TmFtZUFuZE9wZW5VUkwoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXggNDkxYTM0NTkxZmMxZDQy YzUwMGRlNzA0YmE5MDVkMmM2OTE4Njc0Yi4uMmUwOGZkMzNmNThhM2MyODc3MDUyZDljODNiYTJh MGM1YjhkOTBiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVt ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAgLTMw NCwxMyArMzA0LDEzIEBAIHByb3RlY3RlZDoKIAogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZl bnRIYW5kbGVyKEV2ZW50Kik7CiAKK3ByaXZhdGU6CisgICAgZW51bSBBdXRvQ29tcGxldGVTZXR0 aW5nIHsgVW5pbml0aWFsaXplZCwgT24sIE9mZiB9OworCiAgICAgLy8gRklYTUU6IEF1dGhvciBz aGFkb3dzIHNob3VsZCBiZSBhbGxvd2VkCiAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkyNjA4CiAgICAgdmlydHVhbCBib29sIGFyZUF1dGhvclNoYWRvd3NB bGxvd2VkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KIAotcHJpdmF0ZToKLSAg ICBlbnVtIEF1dG9Db21wbGV0ZVNldHRpbmcgeyBVbmluaXRpYWxpemVkLCBPbiwgT2ZmIH07Ci0K ICAgICB2aXJ0dWFsIHZvaWQgZGlkQWRkVXNlckFnZW50U2hhZG93Um9vdChTaGFkb3dSb290Kikg T1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgd2lsbENoYW5nZUZvcm0oKSBPVkVSUklERTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKaW5kZXggMzhiMDc4MGQzOTZmOTBl MjRkZmYwZTE4YmQ1OWIyMjY3OTBlNzBmMS4uYzc1ZTFlMWU0YjdlYjA2MDYzMjI4ZWZmZjFmOWE2 ZTljMjA5NjU0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKQEAgLTg5 LDcgKzg5LDYgQEAgcHVibGljOgogICAgIE1lZGlhUGxheWVyKiBwbGF5ZXIoKSBjb25zdCB7IHJl dHVybiBtX3BsYXllci5nZXQoKTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHdpbGxBZGRBdXRob3JT aGFkb3dSb290KCkgT1ZFUlJJREU7Ci0gICAgdmlydHVhbCBib29sIGFyZUF1dGhvclNoYWRvd3NB bGxvd2VkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIHZpcnR1YWwg Ym9vbCBpc1ZpZGVvKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBoYXNWaWRlbygpIGNv bnN0IHsgcmV0dXJuIGZhbHNlOyB9CkBAIC0zODMsNiArMzgyLDggQEAgcHJvdGVjdGVkOgogcHJp dmF0ZToKICAgICB2b2lkIGNyZWF0ZU1lZGlhUGxheWVyKCk7CiAKKyAgICB2aXJ0dWFsIGJvb2wg YXJlQXV0aG9yU2hhZG93c0FsbG93ZWQoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBmYWxzZTsg fQorCiAgICAgdmlydHVhbCBib29sIGhhc0N1c3RvbUZvY3VzTG9naWMoKSBjb25zdCBPVkVSUklE RTsKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNGb2N1cygpIGNvbnN0OwogICAgIHZpcnR1YWwg Ym9vbCBpc01vdXNlRm9jdXNhYmxlKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVn SW5FbGVtZW50LmgKaW5kZXggNDY3YTRiMWJkMmM0ZDIyYTgyMGFlZDY1NWUxYjM4MjNlN2M0MjYw Yy4uMDhhMzkxZDMxYjMwMDkyNDdmODkwNDczYzQ1OWJkZjQxZTEyMTAxYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1lbnQuaApAQCAtODAsNyArODAsNiBAQCBwcm90ZWN0ZWQ6 CiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwogICAgIHZpcnR1YWwgYm9vbCBpc1ByZXNlbnRh dGlvbkF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJikgY29uc3QgT1ZFUlJJREU7CiAgICAg dmlydHVhbCB2b2lkIGNvbGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0dHJpYnV0ZShjb25zdCBB dHRyaWJ1dGUmLCBTdHlsZVByb3BlcnR5U2V0KikgT1ZFUlJJREU7Ci0gICAgdmlydHVhbCBib29s IGFyZUF1dGhvclNoYWRvd3NBbGxvd2VkKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7 IH0KIAogICAgIC8vIFN1YmNsYXNzZXMgc2hvdWxkIHVzZSBndWFyZGVkRGlzcGF0Y2hCZWZvcmVM b2FkRXZlbnQgaW5zdGVhZCBvZiBjYWxsaW5nIGRpc3BhdGNoQmVmb3JlTG9hZEV2ZW50IGRpcmVj dGx5LgogICAgIGJvb2wgZ3VhcmRlZERpc3BhdGNoQmVmb3JlTG9hZEV2ZW50KGNvbnN0IFN0cmlu ZyYgc291cmNlVVJMKTsKQEAgLTkyLDYgKzkxLDggQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToKICAg ICBib29sIGRpc3BhdGNoQmVmb3JlTG9hZEV2ZW50KGNvbnN0IFN0cmluZyYgc291cmNlVVJMKTsg Ly8gTm90IGltcGxlbWVudGVkLCBnZW5lcmF0ZXMgYSBjb21waWxlIGVycm9yIGlmIHN1YmNsYXNz ZXMgY2FsbCB0aGlzIGJ5IG1pc3Rha2UuCiAKKyAgICB2aXJ0dWFsIGJvb2wgYXJlQXV0aG9yU2hh ZG93c0FsbG93ZWQoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBmYWxzZTsgfQorCiAgICAgdmly dHVhbCB2b2lkIGRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqKTsKIAogICAgIHZpcnR1YWwgUmVu ZGVyV2lkZ2V0KiByZW5kZXJXaWRnZXRGb3JKU0JpbmRpbmdzKCkgY29uc3QgPSAwOwpAQCAtOTks NyArMTAwLDYgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNLZXlib2FyZEZvY3VzYWJs ZShLZXlib2FyZEV2ZW50KikgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzUGx1Z2luRWxlbWVu dCgpIGNvbnN0OwogCi1wcml2YXRlOgogICAgIG11dGFibGUgU2NyaXB0SW5zdGFuY2UgbV9pbnN0 YW5jZTsKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBOUE9iamVjdCogbV9O UE9iamVjdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmggYi9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5oCmluZGV4IDFiYTJmNTRjNWRjYzMxNGM4Njdk YjI0NDhlOGJjOWRkNTBmM2M5YmMuLjhiNjQ3NzdlMTA4MzQxODlkY2E4ZWMwNTBmYzZlOTVlNzM3 OTQ3NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmgKKysrIGIv U291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaApAQCAtMTM2LDEzICsxMzYsMTMgQEAgcHJv dGVjdGVkOgogCiAgICAgdm9pZCByZXBvcnRBdHRyaWJ1dGVQYXJzaW5nRXJyb3IoU1ZHUGFyc2lu Z0Vycm9yLCBjb25zdCBRdWFsaWZpZWROYW1lJiwgY29uc3QgQXRvbWljU3RyaW5nJik7CiAKK3By aXZhdGU6CisgICAgZnJpZW5kIGNsYXNzIFNWR0VsZW1lbnRJbnN0YW5jZTsKKwogICAgIC8vIEZJ WE1FOiBBdXRob3Igc2hhZG93cyBzaG91bGQgYmUgYWxsb3dlZAogICAgIC8vIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzkzOAogICAgIHZpcnR1YWwgYm9vbCBhcmVB dXRob3JTaGFkb3dzQWxsb3dlZCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIGZhbHNlOyB9CiAK LXByaXZhdGU6Ci0gICAgZnJpZW5kIGNsYXNzIFNWR0VsZW1lbnRJbnN0YW5jZTsKLQogICAgIFJl bmRlclN0eWxlKiBjb21wdXRlZFN0eWxlKFBzZXVkb0lkID0gTk9QU0VVRE8pOwogICAgIHZpcnR1 YWwgUmVuZGVyU3R5bGUqIHZpcnR1YWxDb21wdXRlZFN0eWxlKFBzZXVkb0lkIHBzZXVkb0VsZW1l bnRTcGVjaWZpZXIgPSBOT1BTRVVETykgeyByZXR1cm4gY29tcHV0ZWRTdHlsZShwc2V1ZG9FbGVt ZW50U3BlY2lmaWVyKTsgfQogICAgIHZpcnR1YWwgYm9vbCB3aWxsUmVjYWxjU3R5bGUoU3R5bGVD aGFuZ2UpOwo=