108291 2013-01-29 21:30:39 -0800 [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion 2013-02-01 01:19:05 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107650 1 rniwa cfleizach aboxhall apinheiro buildbot cfleizach dmazzoni jcraig jdiggs rniwa webkit.review.bot oldest_to_newest 819770 0 rniwa 2013-01-29 21:30:39 -0800 Fails with the following diff: --- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/accessibility/lists-expected.txt +++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/accessibility/lists-actual.txt @@ -69,7 +69,7 @@ ------------ AXRole: AXList AXSubrole: AXDescriptionList -AXRoleDescription: list +AXRoleDescription: AXList:AXDescriptionList AXChildren: <array of size 5> AXHelp: AXParent: <AXList> 819777 1 rniwa 2013-01-29 21:38:02 -0800 Added a failing test expectation in http://trac.webkit.org/changeset/141220. 819865 2 jcraig 2013-01-30 00:08:43 -0800 Actually I think we’d just want to replace the Lion expectation.txt file with the new actual results. 819866 3 jcraig 2013-01-30 00:11:20 -0800 Never mind the previous comment, I read the diff backwards. 820228 4 cfleizach 2013-01-30 08:34:39 -0800 (In reply to comment #3) > Never mind the previous comment, I read the diff backwards. It looks like the problem is that we don't explicitly return the role description for a descriptionList, instead relying on the NSAccessibility method to return one and in Lion it returns the role:subrole, and above that it returns what the role's description would be ignoring the subrole. i think we should mimic that behavior in WebCore otherwise, we'll get this unwieldy role description on lion 820433 5 185540 cfleizach 2013-01-30 12:50:37 -0800 Created attachment 185540 patch 820434 6 cfleizach 2013-01-30 12:50:57 -0800 couldn't actually test this since i don't have a Lion machine, but it looks correct to me 820448 7 rniwa 2013-01-30 13:00:29 -0800 (In reply to comment #6) > couldn't actually test this since i don't have a Lion machine, but it looks correct to me I do have a Lion machine at home so let me test on that when I get home tonight. 820539 8 185540 buildbot 2013-01-30 14:13:57 -0800 Comment on attachment 185540 patch Attachment 185540 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16195878 New failing tests: platform/mac/fast/speechsynthesis/speech-synthesis-voices.html 820769 9 185540 cfleizach 2013-01-30 16:19:48 -0800 Comment on attachment 185540 patch View in context: https://bugs.webkit.org/attachment.cgi?id=185540&action=review > LayoutTests/platform/mac/TestExpectations:192 > +# platform/mac/fast/speechsynthesis whoops obviously did not mean to enable that. will remove this line if this patch is r+ 822345 10 185540 rniwa 2013-01-31 22:46:29 -0800 Comment on attachment 185540 patch Confirmed that the list.html passes on Lion. 822474 11 cfleizach 2013-02-01 01:14:06 -0800 huzzah! thanks for taking the time to confirm 822477 12 cfleizach 2013-02-01 01:19:05 -0800 http://trac.webkit.org/changeset/141559 185540 2013-01-30 12:50:37 -0800 2013-01-31 22:46:29 -0800 patch patch text/plain 3602 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTI5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTMwICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gUkVHUkVTU0lP TihyMTQwOTc0KTogYWNjZXNzaWJpbGl0eS9saXN0cy5odG1sIGZhaWxzIG9uIExpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODI5MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWNjb3VudHMg Zm9yIGRpZmZlcmVuY2VzIGluIHdoYXQgQXBwS2l0IGdpdmVzIGZvciBhY2Nlc3NpYmlsaXR5IHJv bGUgZGVzY3JpcHRpb25zIGJldHdlZW4gcGxhdGZvcm1zCisgICAgICAgIHdoZW4gdGhlIHN1YnJv bGUgaXMgbm90IHJlY29nbml6ZWQsIGFuZCBzdGFuZGFyZGl6ZXMgaXQgZm9yIFdlYktpdC4KKwor ICAgICAgICBVbnNraXAgYSBmYWlsaW5nIExpb24gdGVzdAorCisgICAgICAgICogYWNjZXNzaWJp bGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW06CisgICAgICAgICgtW1dl YkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIHJvbGVEZXNjcmlwdGlvbl0pOgorCiAyMDEzLTAx LTMwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL XSBodHRwL3Rlc3RzL3czYy93ZWJwZXJmL3N1Ym1pc3Npb24vSW50ZWwvdXNlci10aW1pbmcvdGVz dF91c2VyX3RpbWluZ19lbnRyeV90eXBlLmh0bWwgaXMgZmFpbGluZwpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTQxMjk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTMtMDEtMzAgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxl LmNvbT4KKworICAgICAgICBbTWFjXSBSRUdSRVNTSU9OKHIxNDA5NzQpOiBhY2Nlc3NpYmlsaXR5 L2xpc3RzLmh0bWwgZmFpbHMgb24gTGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MjkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx My0wMS0zMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gaHR0cC90ZXN0cy93M2Mvd2VicGVyZi9zdWJtaXNzaW9uL0ludGVsL3VzZXItdGltaW5n L3Rlc3RfdXNlcl90aW1pbmdfZW50cnlfdHlwZS5odG1sIGlzIGZhaWxpbmcKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCShyZXZpc2lvbiAxNDEyNzMpCisrKyBTb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5t bQkod29ya2luZyBjb3B5KQpAQCAtMTg5Niw2ICsxODk2LDEzIEBACiAgICAgLy8gV2Ugc2hvdWxk IHRyeSB0aGUgc3lzdGVtIGRlZmF1bHQgcm9sZSBkZXNjcmlwdGlvbiBmb3IgYWxsIG90aGVyIHJv bGVzLgogICAgIC8vIElmIHdlIGdldCB0aGUgc2FtZSBzdHJpbmcgYmFjaywgdGhlbiBhcyBhIGxh c3QgcmVzb3J0LCByZXR1cm4gdW5rbm93bi4KICAgICBOU1N0cmluZyogZGVmYXVsdFJvbGVEZXNj cmlwdGlvbiA9IE5TQWNjZXNzaWJpbGl0eVJvbGVEZXNjcmlwdGlvbihheFJvbGUsIFtzZWxmIHN1 YnJvbGVdKTsKKyAgICAKKyAgICAvLyBPbiBlYXJsaWVyIE1hYyB2ZXJzaW9ucyAoTGlvbiksIHVz aW5nIGEgbm9uLXN0YW5kYXJkIHN1YnJvbGUgd291bGQgcmVzdWx0IGluIGEgcm9sZSBkZXNjcmlw dGlvbgorICAgIC8vIGJlaW5nIHJldHVybmVkIHRoYXQgbG9va2VkIGxpa2UgQVhSb2xlOkFYU3Vi cm9sZS4gVG8gbWFrZSBhbGwgcGxhdGZvcm1zIGhhdmUgdGhlIHNhbWUgcm9sZSBkZXNjcmlwdGlv bnMKKyAgICAvLyB3ZSBzaG91bGQgZmFsbGJhY2sgb24gYSByb2xlIGRlc2NyaXB0aW9uIGlnbm9y aW5nIHRoZSBzdWJyb2xlIGluIHRoZXNlIGNhc2VzLgorICAgIGlmIChbZGVmYXVsdFJvbGVEZXNj cmlwdGlvbiBpc0VxdWFsVG9TdHJpbmc6W05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCIlQDol QCIsIGF4Um9sZSwgW3NlbGYgc3Vicm9sZV1dXSkKKyAgICAgICAgZGVmYXVsdFJvbGVEZXNjcmlw dGlvbiA9IE5TQWNjZXNzaWJpbGl0eVJvbGVEZXNjcmlwdGlvbihheFJvbGUsIG5pbCk7CisgICAg CiAgICAgaWYgKCFbZGVmYXVsdFJvbGVEZXNjcmlwdGlvbiBpc0VxdWFsVG9TdHJpbmc6YXhSb2xl XSkKICAgICAgICAgcmV0dXJuIGRlZmF1bHRSb2xlRGVzY3JpcHRpb247CiAKSW5kZXg6IExheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxNDEyNzMpCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5 KQpAQCAtMTg5LDcgKzE4OSw3IEBACiBmYXN0L3NwZWVjaAogCiAjIFNwZWVjaCBzeW50aGVzaXMg aXMgbm90IHlldCBlbmFibGVkLgotcGxhdGZvcm0vbWFjL2Zhc3Qvc3BlZWNoc3ludGhlc2lzCisj IHBsYXRmb3JtL21hYy9mYXN0L3NwZWVjaHN5bnRoZXNpcwogCiAjIFNwZWVjaCBKYXZhU2NyaXB0 IEFQSSBpcyBub3QgeWV0IGVuYWJsZWQuCiBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvc3BlZWNo LXJlY29nbml0aW9uLWV2ZW50LWNvbnN0cnVjdG9yLmh0bWwKQEAgLTEyOTUsNSArMTI5NSwzIEBA CiB3ZWJraXQub3JnL2IvMTA2NDE1IGZhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UtbW9yZS5odG1s IFsgUGFzcyBGYWlsdXJlIF0gCiB3ZWJraXQub3JnL2IvMTA2NDE1IGZhc3Qvd29ya2Vycy93b3Jr ZXItZG9jdW1lbnQtbGVhay5odG1sIFsgUGFzcyBGYWlsdXJlIF0gCiB3ZWJraXQub3JnL2IvMTA2 NDE1IGZhc3Qvd29ya2Vycy93b3JrZXItbGlmZWN5Y2xlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQot Ci13ZWJraXQub3JnL2IvMTA4MjkxIFsgTGlvbiBdIGFjY2Vzc2liaWxpdHkvbGlzdHMuaHRtbCBb IEZhaWx1cmUgXQo=