108287 2013-01-29 21:00:58 -0800 Convert deprecatedShadowAncestorNode() to shadowHost() in Editor.cpp 2013-01-29 22:16:33 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91821 1 shinyak shinyak mifenton morrita rniwa webkit.review.bot oldest_to_newest 819749 0 shinyak 2013-01-29 21:00:58 -0800 At a glance, it is OK just converting deprecatedShadowAncestorNode() to shadowHost() in Editor.cpp, since all the occurrence are in a shadow tree, and no need to worry about nested shadow dom here. 819758 1 185389 shinyak 2013-01-29 21:15:32 -0800 Created attachment 185389 Patch 819798 2 185389 webkit.review.bot 2013-01-29 22:16:30 -0800 Comment on attachment 185389 Patch Clearing flags on attachment: 185389 Committed r141225: <http://trac.webkit.org/changeset/141225> 819799 3 webkit.review.bot 2013-01-29 22:16:33 -0800 All reviewed patches have been landed. Closing bug. 185389 2013-01-29 21:15:32 -0800 2013-01-29 22:16:30 -0800 Patch bug-108287-20130130141217.patch text/plain 2740 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODliOGIwMWYzZTk2NzA1 MTVhYjI1NzU0NjQ4ZmY5NjM5MmEzMWU4ZC4uYjU2Zjc2MTY5YTFkODcxMTdmMjFjMTgwNTQ3MWM4 YmYxMDA5ZmY1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTI5ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb252ZXJ0IGRl cHJlY2F0ZWRTaGFkb3dBbmNlc3Rvck5vZGUoKSB0byBzaGFkb3dIb3N0KCkgaW4gRWRpdG9yLmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4Mjg3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBp cyB0aGUgZWZmb3J0IHRvIGNvbnZlcnQgZGVwcmVjYXRlZFNoYWRvd0FuY2VzdG9yTm9kZSgpIHRv IHNoYWRvd0hvc3QoKS4KKworICAgICAgICBTaW5jZSBhbGwgdGhlIGNhbGxlciBvYmplY3Qgb2Yg ZGVwcmVjYXRlZFNoYWRvd0FuY2VzdG9yTm9kZSgpIGlzIGluIGEgc2hhZG93IHRyZWUsIGNhbGxp bmcgZGVwcmVjYXRlZFNoYWRvd0FuY2VzdG9yTm9kZSgpCisgICAgICAgIGlzIGVxdWlhdmFsZW50 IHRvIGNhbGxpbmcgc2hhZG93SG9zdCgpLiBBbHNvLCBmb3IgYWxsIHRoZSBvY2N1cmVuY2Ugb2Yg ZGVwcmVjYXRlZFNoYWRvd0FuY2VzdG9yTm9kZSgpLCB3ZSBkb24ndCBuZWVkIHRvCisgICAgICAg IHdvcnJ5IGFib3V0IG5lc3RlZCBTaGFkb3dET00gaXNzdWVzLiBTbyBkaXJlY3RseSBjb252ZXJ0 aW5nIGRlcHJlY2F0ZWRTaGFkb3dBbmNlc3Rvck5vZGUoKSB0byBzaGFkb3dIb3N0KCkgc2hvdWxk IGJlIHNhZmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW1wbGUgcmVmYWN0b3JpbmcuCisK KyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6 OnJhbmdlT2ZTdHJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpjb3VudE1hdGNoZXNG b3JUZXh0KToKKwogMjAxMy0wMS0yOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBEb24ndCB1cGRhdGVUaWxlQ292ZXJhZ2VNYXAoKSBmcm9tIHNldFNj cm9sbGluZ01vZGVJbmRpY2F0aW9uIGlmIHdlIGRvbid0IG5lZWQgdG8uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L0VkaXRvci5jcHAKaW5kZXggMmUxZDVlYzMzZDQyMjMwOTgwN2RmNWQ0OTZhMGVmZDcwMzYyOTM3 My4uYjJlMzI3NzBkYThmY2FjMTY5ZDIxMjRhM2Y1ZWQ2M2Q2ZmY2ZDkxZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRWRpdG9yLmNwcApAQCAtMjcwOSw5ICsyNzA5LDkgQEAgUGFzc1JlZlB0cjxSYW5nZT4g RWRpdG9yOjpyYW5nZU9mU3RyaW5nKGNvbnN0IFN0cmluZyYgdGFyZ2V0LCBSYW5nZSogcmVmZXJl bmNlUmEKICAgICBpZiAocmVzdWx0UmFuZ2UtPmNvbGxhcHNlZCgpICYmIHNoYWRvd1RyZWVSb290 KSB7CiAgICAgICAgIHNlYXJjaFJhbmdlID0gcmFuZ2VPZkNvbnRlbnRzKG1fZnJhbWUtPmRvY3Vt ZW50KCkpOwogICAgICAgICBpZiAoZm9yd2FyZCkKLSAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5z ZXRTdGFydEFmdGVyKHNoYWRvd1RyZWVSb290LT5kZXByZWNhdGVkU2hhZG93QW5jZXN0b3JOb2Rl KCkpOworICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0QWZ0ZXIoc2hhZG93VHJlZVJv b3QtPnNoYWRvd0hvc3QoKSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHNlYXJjaFJhbmdl LT5zZXRFbmRCZWZvcmUoc2hhZG93VHJlZVJvb3QtPmRlcHJlY2F0ZWRTaGFkb3dBbmNlc3Rvck5v ZGUoKSk7CisgICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kQmVmb3JlKHNoYWRvd1RyZWVS b290LT5zaGFkb3dIb3N0KCkpOwogCiAgICAgICAgIHJlc3VsdFJhbmdlID0gZmluZFBsYWluVGV4 dChzZWFyY2hSYW5nZS5nZXQoKSwgdGFyZ2V0LCBvcHRpb25zKTsKICAgICB9CkBAIC0yNzY4LDcg KzI3NjgsNyBAQCB1bnNpZ25lZCBFZGl0b3I6OmNvdW50TWF0Y2hlc0ZvclRleHQoY29uc3QgU3Ry aW5nJiB0YXJnZXQsIFJhbmdlKiByYW5nZSwgRmluZE9wdAogICAgICAgICAgICAgaWYgKCFyZXN1 bHRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+aXNJblNoYWRvd1RyZWUoKSkKICAgICAgICAgICAg ICAgICBicmVhazsKIAotICAgICAgICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0QWZ0ZXIocmVz dWx0UmFuZ2UtPnN0YXJ0Q29udGFpbmVyKCktPmRlcHJlY2F0ZWRTaGFkb3dBbmNlc3Rvck5vZGUo KSwgZXhjZXB0aW9uKTsKKyAgICAgICAgICAgIHNlYXJjaFJhbmdlLT5zZXRTdGFydEFmdGVyKHJl c3VsdFJhbmdlLT5zdGFydENvbnRhaW5lcigpLT5zaGFkb3dIb3N0KCksIGV4Y2VwdGlvbik7CiAg ICAgICAgICAgICBzZWFyY2hSYW5nZS0+c2V0RW5kKG9yaWdpbmFsRW5kQ29udGFpbmVyLCBvcmln aW5hbEVuZE9mZnNldCwgZXhjZXB0aW9uKTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICB9Cg==