108281 2013-01-29 18:38:16 -0800 [BlackBerry] Webpage was cut off after rotating to landscape and then rotating back to portrait on specific website 2013-01-30 09:14:06 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Major --- 0 xiaobwang webkit-unassigned jkjiang mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 819661 0 xiaobwang 2013-01-29 18:38:16 -0800 PR 284985 Steps to Reproduce: 1)Launch browser 2)go to http://luotuo.tmall.com/ 3)Wait until the full page is loaded, then rotate device to landscape mode 4) Rotate it back to portrait mode ... 5) Expected Results: There is no rendering issue Actual Results: After step 4, the right side of the webpage was cut off. 819668 1 xiaobwang 2013-01-29 18:39:55 -0800 When rotating back to portrait, WebPagePrivate::overflowExceedsContentsSize() was called. It will call setViewMode(), in which we will get fixedLayoutSize() and compare with the fixedLayoutSize in the FrameView. But WebPagePrivate::fixedLaoutSize() returned wrong size because the width was reset to 0 and then fallback to defaultLayoutSize.width(). if (m_pendingOrientation != -1 && !m_nestedLayoutFinishedCount) width = 0; Can be fixed by adding a check of m_overflowExceedsContentsSize, only reset width if m_overflowExceedsContentsSize is not true. 819686 2 185378 xiaobwang 2013-01-29 18:56:31 -0800 Created attachment 185378 patch 820083 3 185378 rwlbuis 2013-01-30 04:32:01 -0800 Comment on attachment 185378 patch LGTM. 820253 4 185378 webkit.review.bot 2013-01-30 09:14:01 -0800 Comment on attachment 185378 patch Clearing flags on attachment: 185378 Committed r141276: <http://trac.webkit.org/changeset/141276> 820254 5 webkit.review.bot 2013-01-30 09:14:06 -0800 All reviewed patches have been landed. Closing bug. 185378 2013-01-29 18:56:31 -0800 2013-01-30 09:14:01 -0800 patch 0001-BlackBerry-Webpage-was-cut-off-after-rotating-to-lan.patch text/plain 2366 xiaobwang RnJvbSA5OTY1N2E1MDY0YTM4ZWZiYTk5ZGVhYjllOWJlZGJhYjA5NDY3YzZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYaWFvYm8gV2FuZyA8eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KRGF0ZTogV2VkLCAzMCBKYW4gMjAxMyAxMDo1MToxOSArMDgwMApTdWJqZWN0OiBbUEFUQ0hd IFtCbGFja0JlcnJ5XSBXZWJwYWdlIHdhcyBjdXQgb2ZmIGFmdGVyIHJvdGF0aW5nIHRvIGxhbmRz Y2FwZQogYW5kIHRoZW4gcm90YXRpbmcgYmFjayB0byBwb3J0cmFpdCBvbiBzcGVjaWZpYyB3ZWJz aXRlCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MjgxIFBSIDI4 NDk4NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCkludGVybmFsbHkgcmV2aWV3ZWQgYnkg SmFja3kgSmlhbmcuCgpSZXR1cm4gY29ycmVjdCBmaXhlZExheW91dFNpemUgd2hlbiBvdmVyZmxv dyBleGNlZWRzIGNvbnRlbnRzIHNpemUuCgoqIEFwaS9XZWJQYWdlLmNwcDoKKEJsYWNrQmVycnk6 OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmZpeGVkTGF5b3V0U2l6ZSk6Ci0tLQogU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCB8ICAgIDIgKy0KIFNvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiAyIGZpbGVz IGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggNzMwMDdjNi4uNDNjNjMwOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0yNDUzLDcgKzI0NTMsNyBA QCBJbnRTaXplIFdlYlBhZ2VQcml2YXRlOjpmaXhlZExheW91dFNpemUoYm9vbCBzbmFwVG9JbmNy ZW1lbnQpIGNvbnN0CiAgICAgICAgIC8vIElmIHdlIGRldGVjdCBhbiBvdmVyZmxvdyBsYXJnZXIg dGhhbiB0aGUgY29udGVudHMgc2l6ZSB0aGVuIHVzZSB0aGF0IGluc3RlYWQgc2luY2UKICAgICAg ICAgLy8gaXQnbGwgc3RpbGwgYmUgY2xhbXBlZCBieSB0aGUgbWF4V2lkdGggYmVsb3cuLi4KICAg ICAgICAgaW50IHdpZHRoID0gc3RkOjptYXgoYWJzb2x1dGVWaXNpYmxlT3ZlcmZsb3dTaXplKCku d2lkdGgoKSwgY29udGVudHNTaXplKCkud2lkdGgoKSk7Ci0gICAgICAgIGlmIChtX3BlbmRpbmdP cmllbnRhdGlvbiAhPSAtMSAmJiAhbV9uZXN0ZWRMYXlvdXRGaW5pc2hlZENvdW50KQorICAgICAg ICBpZiAobV9wZW5kaW5nT3JpZW50YXRpb24gIT0gLTEgJiYgIW1fbmVzdGVkTGF5b3V0RmluaXNo ZWRDb3VudCAmJiAhbV9vdmVyZmxvd0V4Y2VlZHNDb250ZW50c1NpemUpCiAgICAgICAgICAgICB3 aWR0aCA9IDA7CiAKICAgICAgICAgaWYgKHNuYXBUb0luY3JlbWVudCkgewpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKaW5kZXggNDU5ZTQyMi4uZTVjZmEzYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMjkgIFhpYW9ibyBXYW5nICA8 eGJ3YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gV2VicGFn ZSB3YXMgY3V0IG9mZiBhZnRlciByb3RhdGluZyB0byBsYW5kc2NhcGUgYW5kIHRoZW4gcm90YXRp bmcgYmFjayB0byBwb3J0cmFpdCBvbiBzcGVjaWZpYyB3ZWJzaXRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgyODEKKyAgICAgICAgUFIgMjg0OTg1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIEludGVybmFs bHkgcmV2aWV3ZWQgYnkgSmFja3kgSmlhbmcuCisKKyAgICAgICAgUmV0dXJuIGNvcnJlY3QgZml4 ZWRMYXlvdXRTaXplIHdoZW4gb3ZlcmZsb3cgZXhjZWVkcyBjb250ZW50cyBzaXplLgorCisgICAg ICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQ YWdlUHJpdmF0ZTo6Zml4ZWRMYXlvdXRTaXplKToKKwogMjAxMy0wMS0yOSAgU2hlcmlmZiBCb3Qg IDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE0MDk4My4KLS0gCjEuNy42Cgo=