108251 2013-01-29 16:36:06 -0800 cloop.rb shouldn't use a method called 'dump' for code generation 2013-01-29 17:01:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 819474 0 fpizlo 2013-01-29 16:36:06 -0800 That method name is already used, and is intended entirely for debug printing. It should never be used for code generation. 819479 1 185339 fpizlo 2013-01-29 16:38:46 -0800 Created attachment 185339 the patch 819487 2 mark.lam 2013-01-29 16:44:23 -0800 LGTM. Would feel more sure if you can set ENABLE_LLINT=1 ENABLE_JIT=0 in Platform.h and build to make sure it still builds and runs, but I expect it to be fine. 819504 3 185339 mhahnenberg 2013-01-29 16:54:21 -0800 Comment on attachment 185339 the patch r=me 819505 4 ggaren 2013-01-29 16:54:47 -0800 > Would feel more sure if you can set ENABLE_LLINT=1 ENABLE_JIT=0 in Platform.h Actually, I believe this build is currently broken for other reasons :(. 819506 5 mark.lam 2013-01-29 16:55:31 -0800 (In reply to comment #4) > > Would feel more sure if you can set ENABLE_LLINT=1 ENABLE_JIT=0 in Platform.h > > Actually, I believe this build is currently broken for other reasons :(. Sad. =( 819518 6 fpizlo 2013-01-29 17:00:52 -0800 (In reply to comment #5) > (In reply to comment #4) > > > Would feel more sure if you can set ENABLE_LLINT=1 ENABLE_JIT=0 in Platform.h > > > > Actually, I believe this build is currently broken for other reasons :(. > > Sad. =( I fixed the build and tested my change. It's all good. 819519 7 fpizlo 2013-01-29 17:01:11 -0800 Landed in http://trac.webkit.org/changeset/141185 819522 8 mark.lam 2013-01-29 17:01:41 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > > Would feel more sure if you can set ENABLE_LLINT=1 ENABLE_JIT=0 in Platform.h > > > > > > Actually, I believe this build is currently broken for other reasons :(. > > > > Sad. =( > > I fixed the build and tested my change. It's all good. Yay! Thank you. =) 185339 2013-01-29 16:38:46 -0800 2013-01-29 16:54:21 -0800 the patch blah.patch text/plain 7036 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQxMTc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTAxLTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Y2xvb3AucmIgc2hvdWxkbid0IHVzZSBhIG1ldGhvZCBjYWxsZWQgJ2R1bXAnIGZvciBjb2RlIGdl bmVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwODI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgUmV2ZXJ0IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE0MTE3OCBh bmQgcmVuYW1lICdkdW1wJyB0byAnY2xEdW1wJy4KKworICAgICAgICAqIG9mZmxpbmVhc20vY2xv b3AucmI6CisKIDIwMTMtMDEtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgcmVkdW5kYW50IEFTVCBkdW1wIG1ldGhvZCBmcm9tIGNsb29wLnJiLCBz aW5jZSB0aGV5IGFyZSBhbHJlYWR5IGRlZmluZWQgaW4gYXN0LnJiCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgkocmV2aXNpb24gMTQxMTc4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIJKHdvcmtpbmcgY29weSkKQEAg LTU1LDcgKzU1LDcgQEAgZW5kCiAKIAogY2xhc3MgU3BlY2lhbFJlZ2lzdGVyIDwgTm9DaGlsZHJl bgotICAgIGRlZiBkdW1wCisgICAgZGVmIGNsRHVtcAogICAgICAgICBAbmFtZQogICAgIGVuZAog ICAgIGRlZiBjbFZhbHVlKHR5cGU9OmludCkKQEAgLTY2LDE4ICs2Niw2NyBAQCBlbmQKIENfTE9P UF9TQ1JBVENIX0ZQUiA9IFNwZWNpYWxSZWdpc3Rlci5uZXcoImQ4IikKIAogY2xhc3MgUmVnaXN0 ZXJJRAorICAgIGRlZiBjbER1bXAKKyAgICAgICAgY2FzZSBuYW1lCisgICAgICAgIHdoZW4gInQw IgorICAgICAgICAgICAgInQwIgorICAgICAgICB3aGVuICJ0MSIKKyAgICAgICAgICAgICJ0MSIK KyAgICAgICAgd2hlbiAidDIiCisgICAgICAgICAgICAidDIiCisgICAgICAgIHdoZW4gInQzIgor ICAgICAgICAgICAgInQzIgorICAgICAgICB3aGVuICJ0NCIKKyAgICAgICAgICAgICJyUEMiCisg ICAgICAgIHdoZW4gInQ2IgorICAgICAgICAgICAgInJCYXNlUEMiCisgICAgICAgIHdoZW4gImNz cjEiCisgICAgICAgICAgICAidGFnVHlwZU51bWJlciIKKyAgICAgICAgd2hlbiAiY3NyMiIKKyAg ICAgICAgICAgICJ0YWdNYXNrIgorICAgICAgICB3aGVuICJjZnIiCisgICAgICAgICAgICAiY2Zy IgorICAgICAgICB3aGVuICJsciIKKyAgICAgICAgICAgICJyUmV0VlBDIgorICAgICAgICB3aGVu ICJzcCIKKyAgICAgICAgICAgICJzcCIKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcmFpc2Ug IkJhZCByZWdpc3RlciAje25hbWV9IGZvciBDX0xPT1AgYXQgI3tjb2RlT3JpZ2luU3RyaW5nfSIK KyAgICAgICAgZW5kCisgICAgZW5kCiAgICAgZGVmIGNsVmFsdWUodHlwZT06aW50KQotICAgICAg ICBkdW1wICsgY2xvb3BNYXBUeXBlKHR5cGUpCisgICAgICAgIGNsRHVtcCArIGNsb29wTWFwVHlw ZSh0eXBlKQogICAgIGVuZAogZW5kCiAKIGNsYXNzIEZQUmVnaXN0ZXJJRAorICAgIGRlZiBjbER1 bXAKKyAgICAgICAgY2FzZSBuYW1lCisgICAgICAgIHdoZW4gImZ0MCIsICJmciIKKyAgICAgICAg ICAgICJkMCIKKyAgICAgICAgd2hlbiAiZnQxIgorICAgICAgICAgICAgImQxIgorICAgICAgICB3 aGVuICJmdDIiCisgICAgICAgICAgICAiZDIiCisgICAgICAgIHdoZW4gImZ0MyIKKyAgICAgICAg ICAgICJkMyIKKyAgICAgICAgd2hlbiAiZnQ0IgorICAgICAgICAgICAgImQ0IgorICAgICAgICB3 aGVuICJmdDUiCisgICAgICAgICAgICAiZDUiCisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJh aXNlICJCYWQgcmVnaXN0ZXIgI3tuYW1lfSBmb3IgQ19MT09QIGF0ICN7Y29kZU9yaWdpblN0cmlu Z30iCisgICAgICAgIGVuZAorICAgIGVuZAogICAgIGRlZiBjbFZhbHVlKHR5cGU9OmludCkKLSAg ICAgICAgZHVtcCArIGNsb29wTWFwVHlwZSh0eXBlKQorICAgICAgICBjbER1bXAgKyBjbG9vcE1h cFR5cGUodHlwZSkKICAgICBlbmQKIGVuZAogCiBjbGFzcyBJbW1lZGlhdGUKKyAgICBkZWYgY2xE dW1wCisgICAgICAgICIje3ZhbHVlfSIKKyAgICBlbmQKICAgICBkZWYgY2xWYWx1ZSh0eXBlPTpp bnQpCiAgICAgICAgICMgVGhlcmUgaXMgYSBjYXNlIG9mIGEgdmVyeSBsYXJnZSB1bnNpZ25lZCBu dW1iZXIgKDB4ODAwMDAwMDAwMDAwMDAwMCkKICAgICAgICAgIyB3aGljaCB3ZSB3aXNoIHRvIGVu Y29kZS4gIFVuZm9ydHVuYXRlbHksIHRoZSBDL0MrKyBjb21waWxlcgpAQCAtMTA3LDYgKzE1Niw5 IEBAIGNsYXNzIEltbWVkaWF0ZQogZW5kCiAKIGNsYXNzIEFkZHJlc3MKKyAgICBkZWYgY2xEdW1w CisgICAgICAgICJbI3tiYXNlLmNsRHVtcH0sICN7b2Zmc2V0LnZhbHVlfV0iCisgICAgZW5kCiAg ICAgZGVmIGNsVmFsdWUodHlwZT06aW50KQogICAgICAgICBjYXNlIHR5cGUKICAgICAgICAgd2hl biA6aW50ODsgICAgICAgICBpbnQ4TWVtUmVmCkBAIC0xNzcsNiArMjI5LDkgQEAgY2xhc3MgQWRk cmVzcwogZW5kCiAKIGNsYXNzIEJhc2VJbmRleAorICAgIGRlZiBjbER1bXAKKyAgICAgICAgIlsj e2Jhc2UuY2xEdW1wfSwgI3tvZmZzZXQuY2xEdW1wfSwgI3tpbmRleC5jbER1bXB9IDw8ICN7c2Nh bGVTaGlmdH1dIgorICAgIGVuZAogICAgIGRlZiBjbFZhbHVlKHR5cGU9OmludCkKICAgICAgICAg Y2FzZSB0eXBlCiAgICAgICAgIHdoZW4gOmludDg7ICAgICAgIGludDhNZW1SZWYKQEAgLTIzOSw4 ICsyOTQsMTEgQEAgY2xhc3MgQmFzZUluZGV4CiBlbmQKIAogY2xhc3MgQWJzb2x1dGVBZGRyZXNz CisgICAgZGVmIGNsRHVtcAorICAgICAgICAiI3tjb2RlT3JpZ2luU3RyaW5nfSIKKyAgICBlbmQK ICAgICBkZWYgY2xWYWx1ZQotICAgICAgICBkdW1wCisgICAgICAgIGNsRHVtcAogICAgIGVuZAog ZW5kCiAKQEAgLTI5MCw3ICszNDgsNyBAQCBjbGFzcyBTZXF1ZW5jZQogZW5kCiAKIGRlZiBjbE9w ZXJhbmRzKG9wZXJhbmRzKQotICAgIG9wZXJhbmRzLm1hcHt8dnwgdi5kdW1wfS5qb2luKCIsICIp CisgICAgb3BlcmFuZHMubWFwe3x2fCB2LmNsRHVtcH0uam9pbigiLCAiKQogZW5kCiAKIApAQCAt MzAwLDE0ICszNTgsMTQgQEAgZGVmIGNsb29wRW1pdE9wZXJhdGlvbihvcGVyYW5kcywgdHlwZSwg bwogICAgIGlmIG9wZXJhbmRzLnNpemUgPT0gMwogICAgICAgICAkYXNtLnB1dGMgIiN7b3BlcmFu ZHNbMl0uY2xWYWx1ZSh0eXBlKX0gPSAje29wZXJhbmRzWzFdLmNsVmFsdWUodHlwZSl9ICN7b3Bl cmF0b3J9ICN7b3BlcmFuZHNbMF0uY2xWYWx1ZSh0eXBlKX07IgogICAgICAgICBpZiBvcGVyYW5k c1syXS5pc19hPyBSZWdpc3RlcklEIGFuZCAodHlwZSA9PSA6aW50MzIgb3IgdHlwZSA9PSA6dWlu dDMyKQotICAgICAgICAgICAgJGFzbS5wdXRjICIje29wZXJhbmRzWzJdLmR1bXB9LmNsZWFySGln aFdvcmQoKTsiICMgSnVzdCBjbGVhciBpdC4gSXQgZG9lcyBub3RoaW5nIG9uIHRoZSAzMi1iaXQg cG9ydC4KKyAgICAgICAgICAgICRhc20ucHV0YyAiI3tvcGVyYW5kc1syXS5jbER1bXB9LmNsZWFy SGlnaFdvcmQoKTsiICMgSnVzdCBjbGVhciBpdC4gSXQgZG9lcyBub3RoaW5nIG9uIHRoZSAzMi1i aXQgcG9ydC4KICAgICAgICAgZW5kCiAgICAgZWxzZQogICAgICAgICByYWlzZSB1bmxlc3Mgb3Bl cmFuZHMuc2l6ZSA9PSAyCiAgICAgICAgIHJhaXNlIHVubGVzcyBub3Qgb3BlcmFuZHNbMV0uaXNf YT8gSW1tZWRpYXRlCiAgICAgICAgICRhc20ucHV0YyAiI3tvcGVyYW5kc1sxXS5jbFZhbHVlKHR5 cGUpfSA9ICN7b3BlcmFuZHNbMV0uY2xWYWx1ZSh0eXBlKX0gI3tvcGVyYXRvcn0gI3tvcGVyYW5k c1swXS5jbFZhbHVlKHR5cGUpfTsiCiAgICAgICAgIGlmIG9wZXJhbmRzWzFdLmlzX2E/IFJlZ2lz dGVySUQgYW5kICh0eXBlID09IDppbnQzMiBvciB0eXBlID09IDp1aW50MzIpCi0gICAgICAgICAg ICAkYXNtLnB1dGMgIiN7b3BlcmFuZHNbMV0uZHVtcH0uY2xlYXJIaWdoV29yZCgpOyIgIyBKdXN0 IGNsZWFyIGl0LiBJdCBkb2VzIG5vdGhpbmcgb24gdGhlIDMyLWJpdCBwb3J0LgorICAgICAgICAg ICAgJGFzbS5wdXRjICIje29wZXJhbmRzWzFdLmNsRHVtcH0uY2xlYXJIaWdoV29yZCgpOyIgIyBK dXN0IGNsZWFyIGl0LiBJdCBkb2VzIG5vdGhpbmcgb24gdGhlIDMyLWJpdCBwb3J0LgogICAgICAg ICBlbmQKICAgICBlbmQKIGVuZApAQCAtMzE3LDE0ICszNzUsMTQgQEAgZGVmIGNsb29wRW1pdFNo aWZ0T3BlcmF0aW9uKG9wZXJhbmRzLCB0eQogICAgIGlmIG9wZXJhbmRzLnNpemUgPT0gMwogICAg ICAgICAkYXNtLnB1dGMgIiN7b3BlcmFuZHNbMl0uY2xWYWx1ZSh0eXBlKX0gPSAje29wZXJhbmRz WzFdLmNsVmFsdWUodHlwZSl9ICN7b3BlcmF0b3J9ICgje29wZXJhbmRzWzBdLmNsVmFsdWUoOmlu dCl9ICYgMHgxZik7IgogICAgICAgICBpZiBvcGVyYW5kc1syXS5pc19hPyBSZWdpc3RlcklEIGFu ZCAodHlwZSA9PSA6aW50MzIgb3IgdHlwZSA9PSA6dWludDMyKQotICAgICAgICAgICAgJGFzbS5w dXRjICIje29wZXJhbmRzWzJdLmR1bXB9LmNsZWFySGlnaFdvcmQoKTsiICMgSnVzdCBjbGVhciBp dC4gSXQgZG9lcyBub3RoaW5nIG9uIHRoZSAzMi1iaXQgcG9ydC4KKyAgICAgICAgICAgICRhc20u cHV0YyAiI3tvcGVyYW5kc1syXS5jbER1bXB9LmNsZWFySGlnaFdvcmQoKTsiICMgSnVzdCBjbGVh ciBpdC4gSXQgZG9lcyBub3RoaW5nIG9uIHRoZSAzMi1iaXQgcG9ydC4KICAgICAgICAgZW5kCiAg ICAgZWxzZQogICAgICAgICByYWlzZSB1bmxlc3Mgb3BlcmFuZHMuc2l6ZSA9PSAyCiAgICAgICAg IHJhaXNlIHVubGVzcyBub3Qgb3BlcmFuZHNbMV0uaXNfYT8gSW1tZWRpYXRlCiAgICAgICAgICRh c20ucHV0YyAiI3tvcGVyYW5kc1sxXS5jbFZhbHVlKHR5cGUpfSA9ICN7b3BlcmFuZHNbMV0uY2xW YWx1ZSh0eXBlKX0gI3tvcGVyYXRvcn0gKCN7b3BlcmFuZHNbMF0uY2xWYWx1ZSg6aW50KX0gJiAw eDFmKTsiCiAgICAgICAgIGlmIG9wZXJhbmRzWzFdLmlzX2E/IFJlZ2lzdGVySUQgYW5kICh0eXBl ID09IDppbnQzMiBvciB0eXBlID09IDp1aW50MzIpCi0gICAgICAgICAgICAkYXNtLnB1dGMgIiN7 b3BlcmFuZHNbMV0uZHVtcH0uY2xlYXJIaWdoV29yZCgpOyIgIyBKdXN0IGNsZWFyIGl0LiBJdCBk b2VzIG5vdGhpbmcgb24gdGhlIDMyLWJpdCBwb3J0LgorICAgICAgICAgICAgJGFzbS5wdXRjICIj e29wZXJhbmRzWzFdLmNsRHVtcH0uY2xlYXJIaWdoV29yZCgpOyIgIyBKdXN0IGNsZWFyIGl0LiBJ dCBkb2VzIG5vdGhpbmcgb24gdGhlIDMyLWJpdCBwb3J0LgogICAgICAgICBlbmQKICAgICBlbmQK IGVuZApAQCAtMzM1LDcgKzM5Myw3IEBAIGRlZiBjbG9vcEVtaXRVbmFyeU9wZXJhdGlvbihvcGVy YW5kcywgdHkKICAgICByYWlzZSB1bmxlc3Mgbm90IG9wZXJhbmRzWzBdLmlzX2E/IEltbWVkaWF0 ZQogICAgICRhc20ucHV0YyAiI3tvcGVyYW5kc1swXS5jbFZhbHVlKHR5cGUpfSA9ICN7b3BlcmF0 b3J9I3tvcGVyYW5kc1swXS5jbFZhbHVlKHR5cGUpfTsiCiAgICAgaWYgb3BlcmFuZHNbMF0uaXNf YT8gUmVnaXN0ZXJJRCBhbmQgKHR5cGUgPT0gOmludDMyIG9yIHR5cGUgPT0gOnVpbnQzMikKLSAg ICAgICAgJGFzbS5wdXRjICIje29wZXJhbmRzWzBdLmR1bXB9LmNsZWFySGlnaFdvcmQoKTsiICMg SnVzdCBjbGVhciBpdC4gSXQgZG9lcyBub3RoaW5nIG9uIHRoZSAzMi1iaXQgcG9ydC4KKyAgICAg ICAgJGFzbS5wdXRjICIje29wZXJhbmRzWzBdLmNsRHVtcH0uY2xlYXJIaWdoV29yZCgpOyIgIyBK dXN0IGNsZWFyIGl0LiBJdCBkb2VzIG5vdGhpbmcgb24gdGhlIDMyLWJpdCBwb3J0LgogICAgIGVu ZAogZW5kCiAKQEAgLTY0NSw3ICs3MDMsNyBAQCBjbGFzcyBJbnN0cnVjdGlvbgogCiAgICAgICAg IHdoZW4gInRkMmkiCiAgICAgICAgICAgICAkYXNtLnB1dGMgIiN7b3BlcmFuZHNbMV0uY2xWYWx1 ZSg6aW50KX0gPSAje29wZXJhbmRzWzBdLmNsVmFsdWUoOmRvdWJsZSl9OyIKLSAgICAgICAgICAg ICRhc20ucHV0YyAiI3tvcGVyYW5kc1sxXS5kdW1wfS5jbGVhckhpZ2hXb3JkKCk7IgorICAgICAg ICAgICAgJGFzbS5wdXRjICIje29wZXJhbmRzWzFdLmNsRHVtcH0uY2xlYXJIaWdoV29yZCgpOyIK IAogICAgICAgICB3aGVuICJiY2QyaSIgICMgb3BlcmFuZHM6IHNyY0RibCBkc3RJbnQgc2xvd1Bh dGgKICAgICAgICAgICAgICRhc20ucHV0YyAieyIKQEAgLTY1NCw3ICs3MTIsNyBAQCBjbGFzcyBJ bnN0cnVjdGlvbgogICAgICAgICAgICAgJGFzbS5wdXRjICIgICAgaWYgKGFzSW50MzIgIT0gZCB8 fCAoIWFzSW50MzIgJiYgc2lnbmJpdChkKSkpIC8vIHRydWUgZm9yIC0wLjAiCiAgICAgICAgICAg ICAkYXNtLnB1dGMgIiAgICAgICAgZ290byAgI3tvcGVyYW5kc1syXS5jTGFiZWx9OyIKICAgICAg ICAgICAgICRhc20ucHV0YyAiICAgICN7b3BlcmFuZHNbMV0uY2xWYWx1ZX0gPSBhc0ludDMyOyIg ICAgICAgICAgICAKLSAgICAgICAgICAgICRhc20ucHV0YyAiICAgICN7b3BlcmFuZHNbMV0uZHVt cH0uY2xlYXJIaWdoV29yZCgpOyIKKyAgICAgICAgICAgICRhc20ucHV0YyAiICAgICN7b3BlcmFu ZHNbMV0uY2xEdW1wfS5jbGVhckhpZ2hXb3JkKCk7IgogICAgICAgICAgICAgJGFzbS5wdXRjICJ9 IgogCiAgICAgICAgIHdoZW4gIm1vdmUiCg==