108247 2013-01-29 16:24:22 -0800 Remove redundant AST dump method from cloop.rb, since they are already defined in ast.rb 2013-01-29 16:36:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ddkilzer ggaren mark.lam mhahnenberg msaboff oliver psolanki sam oldest_to_newest 819461 0 fpizlo 2013-01-29 16:24:22 -0800 The definitions in ast.rb are the correct ones since they pretty-print the code that you would have written. The ones in cloop.rb appear to do something different entirely, and often lead to either ambiguities (AbsoluteAddress will print the same as Immediate), strange assertions (RegisterID will assert the name of the register, and it's not clear it supports the full list of registers), and general confusion (RegisterID and BaseIndex use register names that are not valid offlineasm syntax). 819464 1 185336 fpizlo 2013-01-29 16:26:37 -0800 Created attachment 185336 the patch 819469 2 fpizlo 2013-01-29 16:32:25 -0800 Landed in http://trac.webkit.org/changeset/141178 819470 3 185336 mark.lam 2013-01-29 16:32:46 -0800 Comment on attachment 185336 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=185336&action=review > Source/JavaScriptCore/offlineasm/cloop.rb:-96 > - end I think you will break the cloop code with this change. See LowLevelInterpreter.cpp. These register names are used there. If you change these, I think you'll have to change it there as well to allow LLINT_C_LOOP to build. 819475 4 fpizlo 2013-01-29 16:36:15 -0800 (In reply to comment #3) > (From update of attachment 185336 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185336&action=review > > > Source/JavaScriptCore/offlineasm/cloop.rb:-96 > > - end > > I think you will break the cloop code with this change. See LowLevelInterpreter.cpp. These register names are used there. If you change these, I think you'll have to change it there as well to allow LLINT_C_LOOP to build. Ah. In that case the correct thing to do is to not have cloop.rb use a method called 'dump'. That's the bug: https://bugs.webkit.org/show_bug.cgi?id=108251 185336 2013-01-29 16:26:37 -0800 2013-01-29 16:32:46 -0800 the patch blah.patch text/plain 3202 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQxMTc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTAxLTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIHJlZHVuZGFudCBBU1QgZHVtcCBtZXRob2QgZnJvbSBjbG9vcC5yYiwgc2luY2UgdGhl eSBhcmUgYWxyZWFkeSBkZWZpbmVkIGluIGFzdC5yYgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBNYWtlcyBvZmZsaW5lYXNtIGR1bXBpbmcg ZWFzaWVyIHRvIHJlYWQgYW5kIGxlc3MgbGlrZWx5IHRvIGNhdXNlIGFzc2VydGlvbiBmYWlsdXJl cy4KKyAgICAgICAgQWxzbyBmaXhlcyB0aGUgc3RyYW5nZSBzaXR1YXRpb24gd2hlcmUgY2xvb3Au cmIgYW5kIGFzdC5yYiBib3RoIGRlZmluZWQgZHVtcCBtZXRob2RzLAorICAgICAgICBidXQgY2xv b3AucmIgd2FzIHdpbm5pbmcuCisKKyAgICAgICAgKiBvZmZsaW5lYXNtL2Nsb29wLnJiOgorCiAy MDEzLTAxLTI5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgT2JqZWN0aXZlLUMgQVBJOiBKU09iakNDbGFzc0luZm8gY3JlYXRlcyByZWZlcmVuY2Ug Y3ljbGUgd2l0aCBKU0NvbnRleHQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL2Nsb29wLnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL2Nsb29wLnJiCShyZXZpc2lvbiAxNDEwNzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv b2ZmbGluZWFzbS9jbG9vcC5yYgkod29ya2luZyBjb3B5KQpAQCAtNjYsNjcgKzY2LDE4IEBAIGVu ZAogQ19MT09QX1NDUkFUQ0hfRlBSID0gU3BlY2lhbFJlZ2lzdGVyLm5ldygiZDgiKQogCiBjbGFz cyBSZWdpc3RlcklECi0gICAgZGVmIGR1bXAKLSAgICAgICAgY2FzZSBuYW1lCi0gICAgICAgIHdo ZW4gInQwIgotICAgICAgICAgICAgInQwIgotICAgICAgICB3aGVuICJ0MSIKLSAgICAgICAgICAg ICJ0MSIKLSAgICAgICAgd2hlbiAidDIiCi0gICAgICAgICAgICAidDIiCi0gICAgICAgIHdoZW4g InQzIgotICAgICAgICAgICAgInQzIgotICAgICAgICB3aGVuICJ0NCIKLSAgICAgICAgICAgICJy UEMiCi0gICAgICAgIHdoZW4gInQ2IgotICAgICAgICAgICAgInJCYXNlUEMiCi0gICAgICAgIHdo ZW4gImNzcjEiCi0gICAgICAgICAgICAidGFnVHlwZU51bWJlciIKLSAgICAgICAgd2hlbiAiY3Ny MiIKLSAgICAgICAgICAgICJ0YWdNYXNrIgotICAgICAgICB3aGVuICJjZnIiCi0gICAgICAgICAg ICAiY2ZyIgotICAgICAgICB3aGVuICJsciIKLSAgICAgICAgICAgICJyUmV0VlBDIgotICAgICAg ICB3aGVuICJzcCIKLSAgICAgICAgICAgICJzcCIKLSAgICAgICAgZWxzZQotICAgICAgICAgICAg cmFpc2UgIkJhZCByZWdpc3RlciAje25hbWV9IGZvciBDX0xPT1AgYXQgI3tjb2RlT3JpZ2luU3Ry aW5nfSIKLSAgICAgICAgZW5kCi0gICAgZW5kCiAgICAgZGVmIGNsVmFsdWUodHlwZT06aW50KQog ICAgICAgICBkdW1wICsgY2xvb3BNYXBUeXBlKHR5cGUpCiAgICAgZW5kCiBlbmQKIAogY2xhc3Mg RlBSZWdpc3RlcklECi0gICAgZGVmIGR1bXAKLSAgICAgICAgY2FzZSBuYW1lCi0gICAgICAgIHdo ZW4gImZ0MCIsICJmciIKLSAgICAgICAgICAgICJkMCIKLSAgICAgICAgd2hlbiAiZnQxIgotICAg ICAgICAgICAgImQxIgotICAgICAgICB3aGVuICJmdDIiCi0gICAgICAgICAgICAiZDIiCi0gICAg ICAgIHdoZW4gImZ0MyIKLSAgICAgICAgICAgICJkMyIKLSAgICAgICAgd2hlbiAiZnQ0IgotICAg ICAgICAgICAgImQ0IgotICAgICAgICB3aGVuICJmdDUiCi0gICAgICAgICAgICAiZDUiCi0gICAg ICAgIGVsc2UKLSAgICAgICAgICAgIHJhaXNlICJCYWQgcmVnaXN0ZXIgI3tuYW1lfSBmb3IgQ19M T09QIGF0ICN7Y29kZU9yaWdpblN0cmluZ30iCi0gICAgICAgIGVuZAotICAgIGVuZAogICAgIGRl ZiBjbFZhbHVlKHR5cGU9OmludCkKICAgICAgICAgZHVtcCArIGNsb29wTWFwVHlwZSh0eXBlKQog ICAgIGVuZAogZW5kCiAKIGNsYXNzIEltbWVkaWF0ZQotICAgIGRlZiBkdW1wCi0gICAgICAgICIj e3ZhbHVlfSIKLSAgICBlbmQKICAgICBkZWYgY2xWYWx1ZSh0eXBlPTppbnQpCiAgICAgICAgICMg VGhlcmUgaXMgYSBjYXNlIG9mIGEgdmVyeSBsYXJnZSB1bnNpZ25lZCBudW1iZXIgKDB4ODAwMDAw MDAwMDAwMDAwMCkKICAgICAgICAgIyB3aGljaCB3ZSB3aXNoIHRvIGVuY29kZS4gIFVuZm9ydHVu YXRlbHksIHRoZSBDL0MrKyBjb21waWxlcgpAQCAtMTU2LDkgKzEwNyw2IEBAIGNsYXNzIEltbWVk aWF0ZQogZW5kCiAKIGNsYXNzIEFkZHJlc3MKLSAgICBkZWYgZHVtcAotICAgICAgICAiWyN7YmFz ZS5kdW1wfSwgI3tvZmZzZXQudmFsdWV9XSIKLSAgICBlbmQKICAgICBkZWYgY2xWYWx1ZSh0eXBl PTppbnQpCiAgICAgICAgIGNhc2UgdHlwZQogICAgICAgICB3aGVuIDppbnQ4OyAgICAgICAgIGlu dDhNZW1SZWYKQEAgLTIyOSw5ICsxNzcsNiBAQCBjbGFzcyBBZGRyZXNzCiBlbmQKIAogY2xhc3Mg QmFzZUluZGV4Ci0gICAgZGVmIGR1bXAKLSAgICAgICAgIlsje2Jhc2UuZHVtcH0sICN7b2Zmc2V0 LmR1bXB9LCAje2luZGV4LmR1bXB9IDw8ICN7c2NhbGVTaGlmdH1dIgotICAgIGVuZAogICAgIGRl ZiBjbFZhbHVlKHR5cGU9OmludCkKICAgICAgICAgY2FzZSB0eXBlCiAgICAgICAgIHdoZW4gOmlu dDg7ICAgICAgIGludDhNZW1SZWYKQEAgLTI5NCw5ICsyMzksNiBAQCBjbGFzcyBCYXNlSW5kZXgK IGVuZAogCiBjbGFzcyBBYnNvbHV0ZUFkZHJlc3MKLSAgICBkZWYgZHVtcAotICAgICAgICAiI3tj b2RlT3JpZ2luU3RyaW5nfSIKLSAgICBlbmQKICAgICBkZWYgY2xWYWx1ZQogICAgICAgICBkdW1w CiAgICAgZW5kCg==