108241 2013-01-29 15:50:25 -0800 Fix erroneous semicolon causing build failure: if statement has empty body [-Werror,-Wempty-body] 2013-01-29 16:45:31 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cmuppala cmuppala andersca webkit.review.bot oldest_to_newest 819414 0 cmuppala 2013-01-29 15:50:25 -0800 The patch for https://bugs.webkit.org/show_bug.cgi?id=108054, fails to build on a debug Mountain Lion bot with the following error: Source/WebKit2/UIProcess/WebProcessProxy.cpp:190:44: error: if statement has empty body [-Werror,-Wempty-body] This was caused by a semicolon erroneously following a if condition. 819419 1 185325 cmuppala 2013-01-29 15:53:14 -0800 Created attachment 185325 Patch 819420 2 cmuppala 2013-01-29 15:54:07 -0800 <rdar://problem/13047398> 819489 3 185325 webkit.review.bot 2013-01-29 16:45:27 -0800 Comment on attachment 185325 Patch Clearing flags on attachment: 185325 Committed r141180: <http://trac.webkit.org/changeset/141180> 819490 4 webkit.review.bot 2013-01-29 16:45:31 -0800 All reviewed patches have been landed. Closing bug. 185325 2013-01-29 15:53:14 -0800 2013-01-29 16:45:27 -0800 Patch bug-108241-20130129155000.patch text/plain 1519 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjJkNzg2ZDc4YjI4OGE1 YTFiMGI2NzM2NWU1NWRkZmM3YWIzZTE4MC4uYTkzMDdmZGM0M2U4ZTdjOWJmNWE5YWJmNjdkMTdm MzMyOTFhZTMzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTI5ICBLaXJh biBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBlcnJvbmVvdXMg c2VtaWNvbG9uIGNhdXNpbmcgYnVpbGQgZmFpbHVyZTogaWYgc3RhdGVtZW50IGhhcyBlbXB0eSBi b2R5IFstV2Vycm9yLC1XZW1wdHktYm9keV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwODI0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6YWRkRXhpc3RpbmdXZWJQYWdlKTogUmVtb3Zl IGVycm9uZW91cworICAgICAgICBzZW1pY29sb24gZm9sbG93aW5nIHRoZSBpZiBjb25kaXRpb24u CisKIDIwMTMtMDEtMjggIEtpcmFuIE11cHBhbGEgIDxjbXVwcGFsYUBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIHN1cHBvcnQgZm9yIGVuYWJsaW5nIHByb2Nlc3Mgc3VwcHJlc3Npb24gaW4gV2Vi UHJvY2Vzc2VzIHdpdGggbm8gdmlzaWJsZSBwYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAppbmRleCAwNjg4YzdmYzVkM2UwOTYxNDkwNmNkY2U2ZTk0 ZmRiZWFmMzI1OTZhLi40NzU1ZmMzZmFlYmM4NzVlNmU0MjI5M2NjNDMwN2Y2NzU2NDZkODk1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcApAQCAtMTg3 LDcgKzE4Nyw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjphZGRFeGlzdGluZ1dlYlBhZ2UoV2Vi UGFnZVByb3h5KiB3ZWJQYWdlLCB1aW50NjRfdCBwYWdlSUQpCiAgICAgbV9wYWdlTWFwLnNldChw YWdlSUQsIHdlYlBhZ2UpOwogICAgIGdsb2JhbFBhZ2VNYXAoKS5zZXQocGFnZUlELCB3ZWJQYWdl KTsKICNpZiBQTEFURk9STShNQUMpCi0gICAgaWYgKHBhZ2VJc1Byb2Nlc3NTdXBwcmVzc2libGUo d2ViUGFnZSkpOworICAgIGlmIChwYWdlSXNQcm9jZXNzU3VwcHJlc3NpYmxlKHdlYlBhZ2UpKQog ICAgICAgICBtX3Byb2Nlc3NTdXBwcmVzc2libGVQYWdlcy5hZGQocGFnZUlEKTsKICAgICB1cGRh dGVQcm9jZXNzU3VwcHJlc3Npb25TdGF0ZSgpOwogI2VuZGlmCg==