108240 2013-01-29 15:45:40 -0800 MockWeb should be able to serve mock web content 2013-01-29 16:58:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alancutter alancutter abarth dpranke eric webkit.review.bot oldest_to_newest 819412 0 alancutter 2013-01-29 15:45:40 -0800 Currently webkitpy's MockWeb only serves 404s. It would be useful for testing if it could serve testing data instead. 819444 1 185331 alancutter 2013-01-29 16:15:08 -0800 Created attachment 185331 Patch 819445 2 dpranke 2013-01-29 16:15:48 -0800 at some point I had a mock resource fetcher that I was using in webkit.common.system.urlfetcher_mock.py, but that currently looks unused, and I'm a bit wondering what I used it for and why it's unused now :). 819454 3 185331 eric 2013-01-29 16:22:14 -0800 Comment on attachment 185331 Patch Thanks! 819459 4 alancutter 2013-01-29 16:23:53 -0800 (In reply to comment #2) > at some point I had a mock resource fetcher that I was using in webkit.common.system.urlfetcher_mock.py, but that currently looks unused, and I'm a bit wondering what I used it for and why it's unused now :). I did not know about that class, poor thing is completely unused! Thanks for the review. 819510 5 185331 webkit.review.bot 2013-01-29 16:58:17 -0800 Comment on attachment 185331 Patch Clearing flags on attachment: 185331 Committed r141182: <http://trac.webkit.org/changeset/141182> 819511 6 webkit.review.bot 2013-01-29 16:58:21 -0800 All reviewed patches have been landed. Closing bug. 185331 2013-01-29 16:15:08 -0800 2013-01-29 16:58:17 -0800 Patch bug-108240-20130130111153.patch text/plain 2493 alancutter U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMTcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGFiNmM2MmQzMmYyZjNiZjNmMDVkNTkxYzY1OWNlNmJh OWVlYTRiNy4uMGNjZmQwZjQyMDUxNDI4OTViMjdkYzIxOTVhOGVlOTg5NDdlYjQ2NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTAxLTI5ICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgor CisgICAgICAgIE1vY2tXZWIgc2hvdWxkIGJlIGFibGUgdG8gc2VydmUgbW9jayB3ZWIgY29udGVu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MjQw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQg dGhlIGFiaWxpdHkgdG8gaGF2ZSBNb2NrV2ViIHNlcnZlIG1vY2sgd2ViIGRhdGEuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0X21vY2sucHk6CisgICAgICAgIChNb2Nr SG9zdC5fX2luaXRfXyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3dl Yl9tb2NrLnB5OgorICAgICAgICAoTW9ja1dlYi5fX2luaXRfXyk6CisgICAgICAgIChNb2NrV2Vi LmdldF9iaW5hcnkpOgorCiAyMDEzLTAxLTI5ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgcnVuLWFwaS10ZXN0cyBzaG91bGQgaGF2ZSBhbiBvcHRpb24gdG8g c3BlY2lmeSByb290CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9o b3N0X21vY2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0X21vY2sucHkK aW5kZXggOGI1MDhiZjhmNzkyZGQ0MGYyMjFjNDk0MTRmMmNiMmJjZDg3NTM2Yy4uZGFmNWIzNWUy MGRmNjJkNWI5OTk0ZDJiYWVjOWI3NDViMmE4OTY0MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vaG9zdF9tb2NrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2hvc3RfbW9jay5weQpAQCAtNDAsMTAgKzQwLDEwIEBAIGZyb20gd2Via2l0cHku bGF5b3V0X3Rlc3RzLnBvcnQudGVzdCBpbXBvcnQgYWRkX3VuaXRfdGVzdHNfdG9fbW9ja19maWxl c3lzdGVtCiAKIAogY2xhc3MgTW9ja0hvc3QoTW9ja1N5c3RlbUhvc3QpOgotICAgIGRlZiBfX2lu aXRfXyhzZWxmLCBsb2dfZXhlY3V0aXZlPUZhbHNlLCBleGVjdXRpdmVfdGhyb3dzX3doZW5fcnVu PU5vbmUsIGluaXRpYWxpemVfc2NtX2J5X2RlZmF1bHQ9VHJ1ZSk6CisgICAgZGVmIF9faW5pdF9f KHNlbGYsIGxvZ19leGVjdXRpdmU9RmFsc2UsIGV4ZWN1dGl2ZV90aHJvd3Nfd2hlbl9ydW49Tm9u ZSwgaW5pdGlhbGl6ZV9zY21fYnlfZGVmYXVsdD1UcnVlLCB3ZWI9Tm9uZSk6CiAgICAgICAgIE1v Y2tTeXN0ZW1Ib3N0Ll9faW5pdF9fKHNlbGYsIGxvZ19leGVjdXRpdmUsIGV4ZWN1dGl2ZV90aHJv d3Nfd2hlbl9ydW4pCiAgICAgICAgIGFkZF91bml0X3Rlc3RzX3RvX21vY2tfZmlsZXN5c3RlbShz ZWxmLmZpbGVzeXN0ZW0pCi0gICAgICAgIHNlbGYud2ViID0gTW9ja1dlYigpCisgICAgICAgIHNl bGYud2ViID0gd2ViIG9yIE1vY2tXZWIoKQogCiAgICAgICAgIHNlbGYuX2NoZWNrb3V0ID0gTW9j a0NoZWNrb3V0KCkKICAgICAgICAgc2VsZi5fc2NtID0gTm9uZQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3dlYl9tb2NrLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vbmV0L3dlYl9tb2NrLnB5CmluZGV4IDQyMzU3M2M2MGQ3YWIxZDI1NjEw ZTg1ZWExNzQxMTgwMTVmYjZkYmMuLmI1M2NiNjZlZWVjMGNkOTVlNTNhNmYzY2IwYjllNTg0M2Jj OWY2MDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC93ZWJf bW9jay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvd2ViX21vY2su cHkKQEAgLTMwLDExICszMCwxNCBAQCBpbXBvcnQgU3RyaW5nSU8KIAogCiBjbGFzcyBNb2NrV2Vi KG9iamVjdCk6Ci0gICAgZGVmIF9faW5pdF9fKHNlbGYpOgorICAgIGRlZiBfX2luaXRfXyhzZWxm LCB1cmxzPU5vbmUpOgorICAgICAgICBzZWxmLnVybHMgPSB1cmxzIG9yIHt9CiAgICAgICAgIHNl bGYudXJsc19mZXRjaGVkID0gW10KIAogICAgIGRlZiBnZXRfYmluYXJ5KHNlbGYsIHVybCwgY29u dmVydF80MDRfdG9fTm9uZT1GYWxzZSk6CiAgICAgICAgIHNlbGYudXJsc19mZXRjaGVkLmFwcGVu ZCh1cmwpCisgICAgICAgIGlmIHVybCBpbiBzZWxmLnVybHM6CisgICAgICAgICAgICByZXR1cm4g c2VsZi51cmxzW3VybF0KICAgICAgICAgcmV0dXJuICJNT0NLIFdlYiByZXN1bHQsIGNvbnZlcnQg NDA0IHRvIE5vbmU9JXMiICUgY29udmVydF80MDRfdG9fTm9uZQogCiAK