108224 2013-01-29 13:48:15 -0800 BUILD FIX: Make WebCorePrefix.h build on iOS 2013-01-30 10:28:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer abarth darin mrowe sam webkit.review.bot oldest_to_newest 819297 0 ddkilzer 2013-01-29 13:48:15 -0800 <http://webkit.org/b/000000> Reviewed by NOBODY (OOPS!). * WebCorePrefix.h: - Include <wtf/Platform.h>. - Do not include <CoreServices/CoreServices.h> on iOS. - Include <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h> on iOS. --- 2 files changed, 23 insertions(+), 2 deletions(-) 819298 1 185301 ddkilzer 2013-01-29 13:48:16 -0800 Created attachment 185301 Patch 819303 2 ddkilzer 2013-01-29 13:52:13 -0800 Was Platform.h not included in WebCorePrefix.h for a reason? (Maybe to force config.h to be included in all source files, or to prevent ENABLE(), USE(), PLATFORM(), etc. macros from appearing in headers?) 820080 3 185301 webkit.review.bot 2013-01-30 04:23:01 -0800 Comment on attachment 185301 Patch Clearing flags on attachment: 185301 Committed r141254: <http://trac.webkit.org/changeset/141254> 820081 4 webkit.review.bot 2013-01-30 04:23:04 -0800 All reviewed patches have been landed. Closing bug. 820306 5 ddkilzer 2013-01-30 10:28:10 -0800 (In reply to comment #2) > Was Platform.h not included in WebCorePrefix.h for a reason? (Maybe to force config.h to be included in all source files, or to prevent ENABLE(), USE(), PLATFORM(), etc. macros from appearing in headers?) Note that the Tools/Scripts/check-for-inappropriate-macros-in-external-headers script now checks for those macros appearing in public headers. 185301 2013-01-29 13:48:16 -0800 2013-01-30 04:23:01 -0800 Patch bug-108224-20130129134502.patch text/plain 1947 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk2MTI5OGQwODM3MzFj OTlhMDIzMDYyNWMzZGRlZjQwYTRiOWFiMC4uNDc5MGE1NzBmOGYwOGZhZGJhNmY1ZWUyZGE5ZmZl NmE4MzM3NWEyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTI5ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQlVJTEQgRklYOiBNYWtl IFdlYkNvcmVQcmVmaXguaCBidWlsZCBvbiBpT1MKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3Jn L2IvMTA4MjI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViQ29yZVByZWZpeC5oOgorICAgICAgICAtIEluY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5o Pi4KKyAgICAgICAgLSBEbyBub3QgaW5jbHVkZSA8Q29yZVNlcnZpY2VzL0NvcmVTZXJ2aWNlcy5o PiBvbiBpT1MuCisgICAgICAgIC0gSW5jbHVkZSA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9uLmg+IGlu c3RlYWQgb2YgPENvY29hL0NvY29hLmg+CisgICAgICAgICAgb24gaU9TLgorCiAyMDEzLTAxLTI4 ICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRG9uJ3Qg dXNlIHRoZSB0aHJlYWRlZCBIVE1MIHBhcnNlciBmb3IgamF2YXNjcmlwdDogVVJMcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZVByZWZpeC5oIGIvU291cmNlL1dlYkNvcmUvV2Vi Q29yZVByZWZpeC5oCmluZGV4IDQ5NWM2ZWNlYjkyNzVmOTE3OTQ5OWU2NmQzNTQzNmViYjk1ZGNj YzkuLmM2Njg4MGIwMTA5NDk1MDhmZDMwOTk5Nzg1NjgwNzU4MTgyMTRmZDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmVQcmVmaXguaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlUHJlZml4LmgKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA0LCAy MDA1LCAyMDA2LCAyMDA3IEFwcGxlIEluYy4KKyAqIENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwg MjAwNiwgMjAwNywgMjAxMyBBcHBsZSBJbmMuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUg c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTI3LDYg KzI3LDggQEAKIAogLyogVGhpbmdzIHRoYXQgbmVlZCB0byBiZSBkZWZpbmVkIGdsb2JhbGx5IHNo b3VsZCBnbyBpbnRvICJjb25maWcuaCIuICovCiAKKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4K KwogI2lmIGRlZmluZWQoX19BUFBMRV9fKQogI2lmZGVmIF9fY3BsdXNwbHVzCiAjZGVmaW5lIE5V TEwgX19udWxsCkBAIC0xNTAsMTQgKzE1MiwyMCBAQCBfTElCQ1BQX0VORF9OQU1FU1BBQ0VfU1RE CiAjaW5jbHVkZSA8Q0ZOZXR3b3JrL0NGTmV0d29yay5oPgogI2luY2x1ZGUgPHdpbmRvd3MuaD4K ICNlbHNlCisjaWYgIVBMQVRGT1JNKElPUykKICNpbmNsdWRlIDxDb3JlU2VydmljZXMvQ29yZVNl cnZpY2VzLmg+Ci0jZW5kaWYKKyNlbmRpZiAvLyAhUExBVEZPUk0oSU9TKQorI2VuZGlmIC8vIGRl ZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKQogCiAjZW5kaWYKICNlbmRpZiAvLyAhZGVm aW5lZChCVUlMRElOR19XWF9fKQogCiAjaWZkZWYgX19PQkpDX18KKyNpZiBQTEFURk9STShJT1Mp CisjaW1wb3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KKyNlbHNlCiAjaW1wb3J0IDxDb2Nv YS9Db2NvYS5oPgorI2VuZGlmIC8vIFBMQVRGT1JNKElPUykKICNlbmRpZgogCiAjaWZkZWYgX19j cGx1c3BsdXMK