108187 2013-01-29 06:06:14 -0800 Assertion failure in RenderObject::drawLineForBoxSide 2013-08-14 12:20:00 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116980 1 rhodovan.u-szeged rwlbuis commit-queue darin esprehn+autocc glenn hyatt koivisto kondapallykalyan rwlbuis sam oldest_to_newest 818883 0 rhodovan.u-szeged 2013-01-29 06:06:14 -0800 During HTML fuzzing I've found the following assert: ASSERTION FAILED: y2 >= y1 /home/reni/repos/webkit2/Source/WebCore/rendering/RenderObject.cpp(1033) : void WebCore::RenderObject::drawLineForBoxSide(WebCore::GraphicsContext*, int, int, int, int, WebCore::BoxSide, WebCore::Color, WebCore::EBorderStyle, int, int, bool) Test case: <html> <body> Test for <a style="outline: solid; outline-offset: -70px;"</a>assertion. </body> </html> 915902 1 208445 rwlbuis 2013-08-09 12:00:17 -0700 Created attachment 208445 Patch 915925 2 208445 darin 2013-08-09 13:48:13 -0700 Comment on attachment 208445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208445&action=review > Source/WebCore/rendering/RenderInline.cpp:1479 > + if (pixelSnappedBox.isEmpty()) Is a zero-sized rect the only problematic case? What about a 1x1 rect? 915958 3 rwlbuis 2013-08-09 15:21:39 -0700 (In reply to comment #2) > (From update of attachment 208445 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208445&action=review > > > Source/WebCore/rendering/RenderInline.cpp:1479 > > + if (pixelSnappedBox.isEmpty()) > > Is a zero-sized rect the only problematic case? What about a 1x1 rect? I tried 1x1 size, then there is no problem since y() < maxY() (so y1 < y2) and the ASSERT will not be triggered. zero-sized rects but especially negative width/height rects are the problem here (due to the negative outline-offset). 917163 4 rwlbuis 2013-08-14 10:01:25 -0700 Add hyatt for CC. 917206 5 208445 hyatt 2013-08-14 11:31:58 -0700 Comment on attachment 208445 Patch r=me 917229 6 rwlbuis 2013-08-14 12:20:00 -0700 Committed r154064: <http://trac.webkit.org/changeset/154064> 208445 2013-08-09 12:00:17 -0700 2013-08-14 11:31:58 -0700 Patch bug-108187-20130809150005.patch text/plain 3312 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I2MmMwNzJkZmI5NDdi ODFlNzcwZmRhNWUyN2YzZjg5N2M1ZjdhZS4uNmIzNzlhNDgyNGMwNDMzMGU4YzAyYThmZjAwOTFj ZmZhMTZlZWQyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTA4LTA5ICBSb2Ig QnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KIAorICAgICAgICBBc3NlcnRpb24gZmF1bGlyZSBp biBSZW5kZXJPYmplY3Q6OmRyYXdMaW5lRm9yQm94U2lkZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgZHJhdyB0aGUgb3V0bGluZSBpZiB0aGUg cmVjdGFuZ2xlIHRvIGRyYXcgaXMgZW1wdHkuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3Mvb3V0 bGluZS1uZWdhdGl2ZS5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcklubGluZTo6cGFpbnRPdXRsaW5lRm9yTGluZSk6 CisKKzIwMTMtMDgtMDkgIFJvYiBCdWlzICA8cndsYnVpc0B3ZWJraXQub3JnPgorCiAgICAgICAg IEFTU0VSVElPTiBGQUlMRUQ6IHN0cm9rZS0+b3BhY2l0eSAhPSBvdGhlci0+c3Ryb2tlLT5vcGFj aXR5IGluIFdlYkNvcmU6OlNWR1JlbmRlclN0eWxlOjpkaWZmCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk2MjMKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVySW5saW5lLmNwcAppbmRleCA1ZTZkNjQzYTcxY2UwYmVkN2MxZjQ5Mzc2ZDJm YzdkZTU2ZDA2OGI4Li5jZWI2MGMxZTUzMmFiMjAyZjhhOTVlZjdkYTQyODRkYWJiZmFkZTBmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcApAQCAtMTQ3Niw2ICsx NDc2LDggQEAgdm9pZCBSZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZUZvckxpbmUoR3JhcGhpY3ND b250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNvbnN0IEwKICAgICAgICAgTGF5b3V0U2l6ZSh0aGlz bGluZS53aWR0aCgpICsgb2Zmc2V0LCB0aGlzbGluZS5oZWlnaHQoKSArIG9mZnNldCkpOwogCiAg ICAgSW50UmVjdCBwaXhlbFNuYXBwZWRCb3ggPSBwaXhlbFNuYXBwZWRJbnRSZWN0KGJveCk7Cisg ICAgaWYgKHBpeGVsU25hcHBlZEJveC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKICAgICBJ bnRSZWN0IHBpeGVsU25hcHBlZExhc3RMaW5lID0gcGl4ZWxTbmFwcGVkSW50UmVjdChwYWludE9m ZnNldC54KCkgKyBsYXN0bGluZS54KCksIDAsIGxhc3RsaW5lLndpZHRoKCksIDApOwogICAgIElu dFJlY3QgcGl4ZWxTbmFwcGVkTmV4dExpbmUgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KHBhaW50T2Zm c2V0LngoKSArIG5leHRsaW5lLngoKSwgMCwgbmV4dGxpbmUud2lkdGgoKSwgMCk7CiAgICAgCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggNDQ4YjE5MzlmNDczMGM5N2JkNGViMDFiMDUwNGVkODcwODliNTBmNi4uYjNkNTU5ODky YzQxMDA2MWE1NjE5MGMwNDlmMGFjNjhkODkyNmQyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAy MDEzLTA4LTA5ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KIAorICAgICAgICBBc3Nl cnRpb24gZmF1bGlyZSBpbiBSZW5kZXJPYmplY3Q6OmRyYXdMaW5lRm9yQm94U2lkZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MTg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3RjYXNlIGZy b20gYnVnIHdpdGggc21hbGwgYWRqdXN0bWVudHMuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9vdXRs aW5lLW5lZ2F0aXZlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3Mvb3V0 bGluZS1uZWdhdGl2ZS5odG1sOiBBZGRlZC4KKworMjAxMy0wOC0wOSAgUm9iIEJ1aXMgIDxyd2xi dWlzQHdlYmtpdC5vcmc+CisKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogc3Ryb2tlLT5vcGFj aXR5ICE9IG90aGVyLT5zdHJva2UtPm9wYWNpdHkgaW4gV2ViQ29yZTo6U1ZHUmVuZGVyU3R5bGU6 OmRpZmYKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx OTYyMwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9vdXRsaW5lLW5lZ2F0aXZl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL291dGxpbmUtbmVnYXRpdmUtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdlZjIyZTlhNDMxYWQwMjcyNzEzYjcxZmRjODc5NDAxNmM4 ZWYxMmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9vdXRsaW5lLW5l Z2F0aXZlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Nzcy9vdXRsaW5lLW5lZ2F0aXZlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9vdXRsaW5lLW5lZ2F0aXZlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjVhODkwZjA3OTg0NDUyN2U0 ZWY2YTUzNzA1NzM3MzBiM2Y3MWVmNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL291dGxpbmUtbmVnYXRpdmUuaHRtbApAQCAtMCwwICsxLDkgQEAKKzxodG1sPgorICA8 c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworICA8L3NjcmlwdD4KKyAgPGJvZHk+CisgICAgICA8YSBzdHlsZT0ib3V0bGlu ZTogc29saWQ7IG91dGxpbmUtb2Zmc2V0OiAtNzBweDsiPlBBU1M8L2E+CisgIDwvYm9keT4KKzwv aHRtbD4K