108165 2013-01-29 01:02:35 -0800 Revert an accidentally changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650. 2013-04-03 07:09:31 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103747 1 hayato hayato qinmin webcomponents-bugzilla webkit.review.bot oldest_to_newest 818686 0 hayato 2013-01-29 01:02:35 -0800 Let me revert one line change in http://trac.webkit.org/changeset/135650. Please see the comment https://bugs.webkit.org/show_bug.cgi?id=103058#c9 for detail. There aren't any layout tests that catch this change. We should add a layout test, but there seems no way to detect the change from LayoutTests. I'll file another bug for that. 818698 1 185194 hayato 2013-01-29 01:14:25 -0800 Created attachment 185194 Revert the unintentional change. 818703 2 hayato 2013-01-29 01:23:42 -0800 I've filed a bug in https://bugs.webkit.org/show_bug.cgi?id=108167 818713 3 185194 morrita 2013-01-29 01:34:38 -0800 Comment on attachment 185194 Revert the unintentional change. View in context: https://bugs.webkit.org/attachment.cgi?id=185194&action=review > Source/WebCore/ChangeLog:3 > + Revert an unintentional changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650. Nit: s/unintentional/unintentionally/ probably can be just said accidentally. 818720 4 hayato 2013-01-29 01:39:12 -0800 Thank you for the review. Let me land this after updating ChagneLog. (In reply to comment #3) > (From update of attachment 185194 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185194&action=review > > > Source/WebCore/ChangeLog:3 > > + Revert an unintentional changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650. > > Nit: s/unintentional/unintentionally/ probably can be just said accidentally. 818723 5 185200 hayato 2013-01-29 01:40:18 -0800 Created attachment 185200 Patch for landing 818740 6 185200 webkit.review.bot 2013-01-29 02:16:37 -0800 Comment on attachment 185200 Patch for landing Clearing flags on attachment: 185200 Committed r141088: <http://trac.webkit.org/changeset/141088> 818741 7 webkit.review.bot 2013-01-29 02:16:41 -0800 All reviewed patches have been landed. Closing bug. 185194 2013-01-29 01:14:25 -0800 2013-01-29 01:40:16 -0800 Revert the unintentional change. bug-108165-20130129181111.patch text/plain 1347 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTEwOThmZWZlMTFmMmVj NjFiOWVjMzQxNTIzMzlhMDRhM2MyNjRhNy4uMmY2OWRhNWFjZTM5YmVmNmVmODczMDZiMWI4YjQw NmNkYjQ4Y2I4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTI5ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZlcnQgYW4gdW5pbnRl bnRpb25hbCBjaGFuZ2VkIGxpbmUgb2YgRXZlbnRIYW5kZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVu dChQbGF0Zm9ybU1vdXNlRXZlbnQmKSBpbiByMTM1NjUwLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGFn ZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5k bGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDEzLTAxLTIzICBUYWthc2hpIFNha2Ftb3RvICA8dGFz YWtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbUmVmYWN0b3JpbmddIFJlbW92ZSBlbGVtZW50UGFy ZW50U3R5bGUgZnJvbSBTZWxlY3RvckNoZWNrZXJDb250ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKaW5kZXggMGU0YTRhMzdlYjExYTJiYzkyZjFiYzk2YTFmM2Q2MTU1MjRjMzlj Mi4uNmI0YTk5MTE1NmQzM2U5MjIzMTE3YmM1YjAwODU0N2UyOTBhY2FlZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTU0OSw3ICsxNTQ5LDcgQEAgYm9vbCBFdmVudEhh bmRsZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVudChjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIG1v dXNlRXZlbnQpCiAgICAgICAgICAgICBzd2FsbG93RXZlbnQgPSBoYW5kbGVNb3VzZVByZXNzRXZl bnQobWV2KTsKICAgICB9CiAKLSAgICByZXR1cm4gIXN3YWxsb3dFdmVudDsKKyAgICByZXR1cm4g c3dhbGxvd0V2ZW50OwogfQogCiAvLyBUaGlzIG1ldGhvZCBvbmx5IGV4aXN0cyBmb3IgcGxhdGZv cm1zIHRoYXQgZG9uJ3Qga25vdyBob3cgdG8gZGVsaXZlciAK 185200 2013-01-29 01:40:18 -0800 2013-01-29 02:16:37 -0800 Patch for landing bug-108165-20130129183705.patch text/plain 1345 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTEwOThmZWZlMTFmMmVj NjFiOWVjMzQxNTIzMzlhMDRhM2MyNjRhNy4uNzU0NWVkOTE4NTBlY2VhZDlkYmJmNzFkMTY4YTY3 MGIyNjFkYjVmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTI5ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZlcnQgYW4gYWNjaWRl bnRhbGx5IGNoYW5nZWQgbGluZSBvZiBFdmVudEhhbmRlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50 KFBsYXRmb3JtTW91c2VFdmVudCYpIGluIHIxMzU2NTAuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgxNjUKKworICAgICAgICBSZXZpZXdlZCBieSBI YWppbWUgTW9yaXRhLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2Uv RXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxl TW91c2VQcmVzc0V2ZW50KToKKwogMjAxMy0wMS0yMyAgVGFrYXNoaSBTYWthbW90byAgPHRhc2Fr QGdvb2dsZS5jb20+CiAKICAgICAgICAgW1JlZmFjdG9yaW5nXSBSZW1vdmUgZWxlbWVudFBhcmVu dFN0eWxlIGZyb20gU2VsZWN0b3JDaGVja2VyQ29udGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh bmRsZXIuY3BwCmluZGV4IDBlNGE0YTM3ZWIxMWEyYmM5MmYxYmM5NmExZjNkNjE1NTI0YzM5YzIu LjZiNGE5OTExNTZkMzNlOTIyMzExN2JjNWIwMDg1NDdlMjkwYWNhZWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTE1NDksNyArMTU0OSw3IEBAIGJvb2wgRXZlbnRIYW5k bGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBtb3Vz ZUV2ZW50KQogICAgICAgICAgICAgc3dhbGxvd0V2ZW50ID0gaGFuZGxlTW91c2VQcmVzc0V2ZW50 KG1ldik7CiAgICAgfQogCi0gICAgcmV0dXJuICFzd2FsbG93RXZlbnQ7CisgICAgcmV0dXJuIHN3 YWxsb3dFdmVudDsKIH0KIAogLy8gVGhpcyBtZXRob2Qgb25seSBleGlzdHMgZm9yIHBsYXRmb3Jt cyB0aGF0IGRvbid0IGtub3cgaG93IHRvIGRlbGl2ZXIgCg==