108162 2013-01-29 00:38:46 -0800 Web Inspector: [Network] Minor refactorings. 2013-02-20 20:08:24 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov caseq eustas keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 818667 0 eustas 2013-01-29 00:38:46 -0800 Apply minor refactorings to NetworkPanel.js Add hint to statusbar selector buttons. 818668 1 185187 eustas 2013-01-29 00:41:11 -0800 Created attachment 185187 Patch 824300 2 caseq 2013-02-04 06:11:28 -0800 Committed r141765: <http://trac.webkit.org/changeset/141765> 185187 2013-01-29 00:41:11 -0800 2013-02-20 20:08:24 -0800 Patch bug-108162-20130129123757.patch text/plain 5680 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMxYWEzMjI1YzlhNDRk NjM4Nzc2YmJmNDRmYmJlMWE4ZDU3ZWY1Yy4uN2YzOWNhZTQ2OTE5ZDY1NmFjODc4YjkzNWJlNTI5 Y2Y5YTYyZmMyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTI5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtOZXR3b3JrXSBNaW5vciByZWZhY3RvcmluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgxNjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcHBseSBtaW5vciByZWZhY3RvcmluZ3MgdG8g TmV0d29ya1BhbmVsLmpzCisgICAgICAgIEFkZCBoaW50IHRvIHN0YXR1c2JhciBzZWxlY3RvciBi dXR0b25zLgorCisgICAgICAgICogRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOiBB ZGRlZCBoaW50IHN0cmluZy4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrTG9nVmlldy5wcm90b3R5cGUu X2NyZWF0ZVN0YXR1c0Jhckl0ZW1zKTogRGl0dG8uCisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0 d29ya0xvZ1ZpZXcucHJvdG90eXBlLl9tYWtlSGVhZGVyRnJhZ21lbnQpOgorICAgICAgICBBcHBs aWVkIG1pbm9yIHJlZmFjdG9yaW5nLgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dW aWV3LnByb3RvdHlwZS5fY3JlYXRlU3RhdHVzQmFySXRlbXMuY3JlYXRlRmlsdGVyRWxlbWVudCk6 CisgICAgICAgIERpdHRvLgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnBy b3RvdHlwZS5fdXBkYXRlT2Zmc2NyZWVuUm93cyk6IERpdHRvLgorICAgICAgICAoV2ViSW5zcGVj dG9yLk5ldHdvcmtQYW5lbC5wcm90b3R5cGUuX29uUm93U2l6ZUNoYW5nZWQpOiBEaXR0by4KKwog MjAxMy0wMS0yOCAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW1NoYWRvd10gR2VzdHVyZSBldmVudCBpcyBub3QgZmlyZWQgaW4gU2hhZG93RE9NCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3Mu anMgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5k ZXggNmM2YmNhYjA5MTQwNzRiN2Q5MjgxMTRlZjFiYTY5YWJkODZlOTljMS4uNDlmZTRhMDFhZWY4 YzFiZTliYWQzMjM5YTM4ZjI5ZGI0YTZlYWQ4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv RW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL0Vu Z2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtNDM3LDYgKzQzNyw3IEBAIGxvY2Fs aXplZFN0cmluZ3NbIlVuZG9jayBpbnRvIHNlcGFyYXRlIHdpbmRvdy4iXSA9ICJVbmRvY2sgaW50 byBzZXBhcmF0ZSB3aW5kb3cuCiBsb2NhbGl6ZWRTdHJpbmdzWyJVbmtub3duIHByb3BlcnR5IG5h bWUuIl0gPSAiVW5rbm93biBwcm9wZXJ0eSBuYW1lLiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJVc2Ug bGFyZ2UgcmVzb3VyY2Ugcm93cy4iXSA9ICJVc2UgbGFyZ2UgcmVzb3VyY2Ugcm93cy4iOwogbG9j YWxpemVkU3RyaW5nc1siVXNlIHNtYWxsIHJlc291cmNlIHJvd3MuIl0gPSAiVXNlIHNtYWxsIHJl c291cmNlIHJvd3MuIjsKK2xvY2FsaXplZFN0cmluZ3NbIlVzZSAlcyBDbGljayB0byBzZWxlY3Qg bXVsdGlwbGUgdHlwZXMuIl0gPSAiVXNlICVzIENsaWNrIHRvIHNlbGVjdCBtdWx0aXBsZSB0eXBl cy4iOwogbG9jYWxpemVkU3RyaW5nc1siVXNlZCBIZWFwIFNpemUiXSA9ICJVc2VkIEhlYXAgU2l6 ZSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJWYWx1ZSJdID0gIlZhbHVlIjsKIGxvY2FsaXplZFN0cmlu Z3NbIldhaXRpbmciXSA9ICJXYWl0aW5nIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKaW5kZXggMjQ5NjRkMTBhZmY2N2JlNDdiMjcy NzRiMTU3MWNhNTZhYWYzYjI3My4uYzM1NDc1OGEzNDkwYzBkYTIyNjNhOWE4ZTg0ZGQwNTY4NDRm MDY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3 b3JrUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3 b3JrUGFuZWwuanMKQEAgLTIyMSwxMSArMjIxLDkgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dW aWV3LnByb3RvdHlwZSA9IHsKICAgICBfbWFrZUhlYWRlckZyYWdtZW50OiBmdW5jdGlvbih0aXRs ZSwgc3VidGl0bGUpCiAgICAgewogICAgICAgICB2YXIgZnJhZ21lbnQgPSBkb2N1bWVudC5jcmVh dGVEb2N1bWVudEZyYWdtZW50KCk7Ci0gICAgICAgIGZyYWdtZW50LmFwcGVuZENoaWxkKGRvY3Vt ZW50LmNyZWF0ZVRleHROb2RlKHRpdGxlKSk7Ci0gICAgICAgIHZhciBzdWJ0aXRsZURpdiA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwotICAgICAgICBzdWJ0aXRsZURpdi5jbGFzc05h bWUgPSAibmV0d29yay1oZWFkZXItc3VidGl0bGUiOwotICAgICAgICBzdWJ0aXRsZURpdi50ZXh0 Q29udGVudCA9IHN1YnRpdGxlOwotICAgICAgICBmcmFnbWVudC5hcHBlbmRDaGlsZChzdWJ0aXRs ZURpdik7CisgICAgICAgIGZyYWdtZW50LmNyZWF0ZVRleHRDaGlsZCh0aXRsZSk7CisgICAgICAg IHZhciBzdWJ0aXRsZURpdiA9IGZyYWdtZW50LmNyZWF0ZUNoaWxkKCJkaXYiLCAibmV0d29yay1o ZWFkZXItc3VidGl0bGUiKTsKKyAgICAgICAgc3VidGl0bGVEaXYuY3JlYXRlVGV4dENoaWxkKHN1 YnRpdGxlKTsKICAgICAgICAgcmV0dXJuIGZyYWdtZW50OwogICAgIH0sCiAKQEAgLTM1MCw2ICsz NDgsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0xvZ1ZpZXcucHJvdG90eXBlID0gewogICAgIHsK ICAgICAgICAgdmFyIGZpbHRlckJhckVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJk aXYiKTsKICAgICAgICAgZmlsdGVyQmFyRWxlbWVudC5jbGFzc05hbWUgPSAic2NvcGUtYmFyIHN0 YXR1cy1iYXItaXRlbSI7CisgICAgICAgIGZpbHRlckJhckVsZW1lbnQudGl0bGUgPSBXZWJJbnNw ZWN0b3IuVUlTdHJpbmcoIlVzZSAlcyBDbGljayB0byBzZWxlY3QgbXVsdGlwbGUgdHlwZXMuIiwg V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuc2hvcnRjdXRUb1N0cmluZygiIiwgV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLkN0cmxPck1ldGEpKTsKIAogICAgICAg ICAvKioKICAgICAgICAgICogQHBhcmFtIHtzdHJpbmd9IHR5cGVOYW1lCkBAIC0zNjAsNyArMzU5 LDcgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgIHZhciBjYXRlZ29yeUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJsaSIpOwog ICAgICAgICAgICAgY2F0ZWdvcnlFbGVtZW50LnR5cGVOYW1lID0gdHlwZU5hbWU7CiAgICAgICAg ICAgICBjYXRlZ29yeUVsZW1lbnQuY2xhc3NOYW1lID0gdHlwZU5hbWU7Ci0gICAgICAgICAgICBj YXRlZ29yeUVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobGFiZWwp KTsKKyAgICAgICAgICAgIGNhdGVnb3J5RWxlbWVudC5jcmVhdGVUZXh0Q2hpbGQobGFiZWwpOwog ICAgICAgICAgICAgY2F0ZWdvcnlFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhp cy5fdXBkYXRlRmlsdGVyLmJpbmQodGhpcyksIGZhbHNlKTsKICAgICAgICAgICAgIGZpbHRlckJh ckVsZW1lbnQuYXBwZW5kQ2hpbGQoY2F0ZWdvcnlFbGVtZW50KTsKIApAQCAtMzY4LDExICszNjcs NyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0xvZ1ZpZXcucHJvdG90eXBlID0gewogICAgICAgICB9 CiAKICAgICAgICAgdGhpcy5fZmlsdGVyQWxsRWxlbWVudCA9IGNyZWF0ZUZpbHRlckVsZW1lbnQu Y2FsbCh0aGlzLCAiYWxsIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJBbGwiKSk7Ci0KLSAgICAg ICAgLy8gQWRkIGEgZGl2aWRlcgotICAgICAgICB2YXIgZGl2aWRlckVsZW1lbnQgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAgICAgICAgZGl2aWRlckVsZW1lbnQuYWRkU3R5bGVD bGFzcygic2NvcGUtYmFyLWRpdmlkZXIiKTsKLSAgICAgICAgZmlsdGVyQmFyRWxlbWVudC5hcHBl bmRDaGlsZChkaXZpZGVyRWxlbWVudCk7CisgICAgICAgIGZpbHRlckJhckVsZW1lbnQuY3JlYXRl Q2hpbGQoImRpdiIsICJzY29wZS1iYXItZGl2aWRlciIpOwogCiAgICAgICAgIGZvciAodmFyIHR5 cGVJZCBpbiBXZWJJbnNwZWN0b3IucmVzb3VyY2VUeXBlcykgewogICAgICAgICAgICAgdmFyIHR5 cGUgPSBXZWJJbnNwZWN0b3IucmVzb3VyY2VUeXBlc1t0eXBlSWRdOwpAQCAtMTExOCwxMCArMTEx Myw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrTG9nVmlldy5wcm90b3R5cGUgPSB7CiAKICAgICAg ICAgICAgIHZhciByb3dJc1Zpc2libGUgPSB1bmZpbHRlcmVkUm93SW5kZXggKiByb3dIZWlnaHQg PCB2aXNpYmxlQm90dG9tICYmICh1bmZpbHRlcmVkUm93SW5kZXggKyAxKSAqIHJvd0hlaWdodCA+ IHZpc2libGVUb3A7CiAgICAgICAgICAgICBpZiAocm93SXNWaXNpYmxlICE9PSByb3cucm93SXNW aXNpYmxlKSB7Ci0gICAgICAgICAgICAgICAgaWYgKHJvd0lzVmlzaWJsZSkKLSAgICAgICAgICAg ICAgICAgICAgcm93LnJlbW92ZVN0eWxlQ2xhc3MoIm9mZnNjcmVlbiIpOwotICAgICAgICAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgcm93LmFkZFN0eWxlQ2xhc3MoIm9mZnNjcmVl biIpOworICAgICAgICAgICAgICAgIHJvdy5lbmFibGVTdHlsZUNsYXNzKCJvZmZzY3JlZW4iLCAh cm93SXNWaXNpYmxlKTsKICAgICAgICAgICAgICAgICByb3cucm93SXNWaXNpYmxlID0gcm93SXNW aXNpYmxlOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgdW5maWx0ZXJlZFJvd0luZGV4Kys7 CkBAIC0xNTE4LDEwICsxNTEwLDcgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtQYW5lbC5wcm90b3R5 cGUgPSB7CiAKICAgICBfb25Sb3dTaXplQ2hhbmdlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewot ICAgICAgICBpZiAoZXZlbnQuZGF0YS5sYXJnZVJvd3MpCi0gICAgICAgICAgICB0aGlzLl92aWV3 c0NvbnRhaW5lckVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygic21hbGwiKTsKLSAgICAgICAgZWxz ZQotICAgICAgICAgICAgdGhpcy5fdmlld3NDb250YWluZXJFbGVtZW50LmFkZFN0eWxlQ2xhc3Mo InNtYWxsIik7CisgICAgICAgIHRoaXMuX3ZpZXdzQ29udGFpbmVyRWxlbWVudC5lbmFibGVTdHls ZUNsYXNzKCJzbWFsbCIsICFldmVudC5kYXRhLmxhcmdlUm93cyk7CiAgICAgfSwKIAogICAgIF9v blNlYXJjaENvdW50VXBkYXRlZDogZnVuY3Rpb24oZXZlbnQpCg==