108160 2013-01-29 00:24:10 -0800 WebFrameTest.DisambiguationPopup is failing 2013-01-31 11:41:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi dfalcantara abarth dfalcantara trchen webkit.review.bot oldest_to_newest 818657 0 keishi 2013-01-29 00:24:10 -0800 WebFrameTest.DisambiguationPopup is failing 820506 1 dfalcantara 2013-01-30 13:49:56 -0800 Error says: [3603:3612:0128/154721:1245294047:FATAL:url_request_context.cc(121)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://www.test.com/disambiguation_popup.html. [3603:3612:0128/154721:1245294047:FATAL:url_request_context.cc(121)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://www.test.com/disambiguation_popup.html. One of the unit tests appears to be using the wrong html file. 820512 2 185557 dfalcantara 2013-01-30 13:57:30 -0800 Created attachment 185557 Patch 820781 3 trchen 2013-01-30 16:27:36 -0800 LGTM 821718 4 185557 abarth 2013-01-31 11:10:38 -0800 Comment on attachment 185557 Patch Great! 821765 5 185557 webkit.review.bot 2013-01-31 11:41:47 -0800 Comment on attachment 185557 Patch Clearing flags on attachment: 185557 Committed r141454: <http://trac.webkit.org/changeset/141454> 821767 6 webkit.review.bot 2013-01-31 11:41:51 -0800 All reviewed patches have been landed. Closing bug. 185557 2013-01-30 13:57:30 -0800 2013-01-31 11:41:47 -0800 Patch bug-108160-20130130135415.patch text/plain 2793 dfalcantara SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDEzMDMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTAxLTMwICBEYW4gQWxjYW50YXJhICA8ZGZhbGNhbnRhcmFAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFdlYkZyYW1lVGVzdC5EaXNhbWJpZ3VhdGlvblBvcHVwIGlzIGZhaWxpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODE2MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUg dW5pdCB0ZXN0IHNvIHRoYXQgaXQgaXMgdXNpbmcgdGhlIHJpZ2h0IEhUTUwgZmlsZS4KKworICAg ICAgICAqIHRlc3RzL1dlYkZyYW1lVGVzdC5jcHA6CisKIDIwMTMtMDEtMzAgIERhbmEgSmFuc2Vu cyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBZGQgcmVjb3Jk UmVuZGVyaW5nU3RhdHMgdG8gV2ViU2V0dGluZ3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJKHJldmlzaW9uIDE0MTMwMykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjAwMywxNSArMjAwMywxNiBAQCBzdGF0aWMgV2ViR2VzdHVyZUV2ZW50IGZhdFRhcChpbnQg eCwgaW50CiAgICAgcmV0dXJuIGV2ZW50OwogfQogCi1URVNUX0YoV2ViRnJhbWVUZXN0LCBESVNB QkxFRF9EaXNhbWJpZ3VhdGlvblBvcHVwKQorVEVTVF9GKFdlYkZyYW1lVGVzdCwgRGlzYW1iaWd1 YXRpb25Qb3B1cCkKIHsKLSAgICByZWdpc3Rlck1vY2tlZEh0dHBVUkxMb2FkKCJkaXNhbWJpZ3Vh dGlvbl9wb3B1cC5odG1sIik7CisgICAgY29uc3Qgc3RkOjpzdHJpbmcgaHRtbEZpbGUgPSAiZGlz YW1iaWd1YXRpb25fcG9wdXAuaHRtbCI7CisgICAgcmVnaXN0ZXJNb2NrZWRIdHRwVVJMTG9hZCho dG1sRmlsZSk7CiAKICAgICBEaXNhbWJpZ3VhdGlvblBvcHVwVGVzdFdlYlZpZXdDbGllbnQgY2xp ZW50OwogCiAgICAgLy8gTWFrZSBzdXJlIHdlIGluaXRpYWxpemUgdG8gbWluaW11bSBzY2FsZSwg ZXZlbiBpZiB0aGUgd2luZG93IHNpemUKICAgICAvLyBvbmx5IGJlY29tZXMgYXZhaWxhYmxlIGFm dGVyIHRoZSBsb2FkIGJlZ2lucy4KLSAgICBXZWJWaWV3SW1wbCogd2ViVmlld0ltcGwgPSBzdGF0 aWNfY2FzdDxXZWJWaWV3SW1wbCo+KEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRM b2FkKG1fYmFzZVVSTCArICJkaXNhbWJpZ3VhdGlvbl9wb3B1cC5odG1sIiwgdHJ1ZSwgMCwgJmNs aWVudCkpOworICAgIFdlYlZpZXdJbXBsKiB3ZWJWaWV3SW1wbCA9IHN0YXRpY19jYXN0PFdlYlZp ZXdJbXBsKj4oRnJhbWVUZXN0SGVscGVyczo6Y3JlYXRlV2ViVmlld0FuZExvYWQobV9iYXNlVVJM ICsgaHRtbEZpbGUsIHRydWUsIDAsICZjbGllbnQpKTsKICAgICB3ZWJWaWV3SW1wbC0+cmVzaXpl KFdlYlNpemUoMTAwMCwgMTAwMCkpOwogICAgIHdlYlZpZXdJbXBsLT5sYXlvdXQoKTsKIApAQCAt MjA2NCwxNSArMjA2NSwxNiBAQCBURVNUX0YoV2ViRnJhbWVUZXN0LCBEaXNhbWJpZ3VhdGlvblBv cHVwCiAgICAgRVhQRUNUX0ZBTFNFKGNsaWVudC50cmlnZ2VyZWQoKSk7CiB9CiAKLVRFU1RfRihX ZWJGcmFtZVRlc3QsIERJU0FCTEVEX0Rpc2FtYmlndWF0aW9uUG9wdXBNb2JpbGVTaXRlKQorVEVT VF9GKFdlYkZyYW1lVGVzdCwgRGlzYW1iaWd1YXRpb25Qb3B1cE1vYmlsZVNpdGUpCiB7Ci0gICAg cmVnaXN0ZXJNb2NrZWRIdHRwVVJMTG9hZCgiZGlzYW1iaWd1YXRpb25fcG9wdXBfbW9iaWxlX3Np dGUuaHRtbCIpOworICAgIGNvbnN0IHN0ZDo6c3RyaW5nIGh0bWxGaWxlID0gImRpc2FtYmlndWF0 aW9uX3BvcHVwX21vYmlsZV9zaXRlLmh0bWwiOworICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExv YWQoaHRtbEZpbGUpOwogCiAgICAgRGlzYW1iaWd1YXRpb25Qb3B1cFRlc3RXZWJWaWV3Q2xpZW50 IGNsaWVudDsKIAogICAgIC8vIE1ha2Ugc3VyZSB3ZSBpbml0aWFsaXplIHRvIG1pbmltdW0gc2Nh bGUsIGV2ZW4gaWYgdGhlIHdpbmRvdyBzaXplCiAgICAgLy8gb25seSBiZWNvbWVzIGF2YWlsYWJs ZSBhZnRlciB0aGUgbG9hZCBiZWdpbnMuCi0gICAgV2ViVmlld0ltcGwqIHdlYlZpZXdJbXBsID0g c3RhdGljX2Nhc3Q8V2ViVmlld0ltcGwqPihGcmFtZVRlc3RIZWxwZXJzOjpjcmVhdGVXZWJWaWV3 QW5kTG9hZChtX2Jhc2VVUkwgKyAiZGlzYW1iaWd1YXRpb25fcG9wdXAuaHRtbCIsIHRydWUsIDAs ICZjbGllbnQpKTsKKyAgICBXZWJWaWV3SW1wbCogd2ViVmlld0ltcGwgPSBzdGF0aWNfY2FzdDxX ZWJWaWV3SW1wbCo+KEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2FkKG1fYmFz ZVVSTCArIGh0bWxGaWxlLCB0cnVlLCAwLCAmY2xpZW50KSk7CiAgICAgd2ViVmlld0ltcGwtPnJl c2l6ZShXZWJTaXplKDEwMDAsIDEwMDApKTsKICAgICB3ZWJWaWV3SW1wbC0+bGF5b3V0KCk7CiAK