108158 2013-01-29 00:10:34 -0800 Clean up interface to ElementShadow 2013-01-29 01:37:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn cmarcelo dglazkov morrita ojan.autocc ojan webkit.review.bot oldest_to_newest 818643 0 esprehn 2013-01-29 00:10:34 -0800 Clean up interface to ElementShadow 818645 1 185181 esprehn 2013-01-29 00:13:51 -0800 Created attachment 185181 Patch 818716 2 185181 webkit.review.bot 2013-01-29 01:37:07 -0800 Comment on attachment 185181 Patch Clearing flags on attachment: 185181 Committed r141083: <http://trac.webkit.org/changeset/141083> 818717 3 webkit.review.bot 2013-01-29 01:37:10 -0800 All reviewed patches have been landed. Closing bug. 185181 2013-01-29 00:13:51 -0800 2013-01-29 01:37:07 -0800 Patch bug-108158-20130129031037.patch text/plain 6729 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMyNGQ4OGM0OGE2Yzdm Zjc3MzFmY2Q3MzVjMDgxYWU0NTA2NzczOS4uN2Y3NDI3MTM3M2I4YTI1MGUzNGYzMWY4ZTUyZTlk M2E1NTg1YTZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEzLTAxLTI5ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIENsZWFuIHVwIGlu dGVyZmFjZSB0byBFbGVtZW50U2hhZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDgxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBMb3RzIG9mIGdlbmVyYWwgY2xlYW4gdXAgdG8gRWxlbWVudFNoYWRv dyByZW1vdmluZyB1bnVzZWQgaGVhZGVycywKKyAgICAgICAgYWRkaW5nIGEgY3JlYXRlKCkgbWV0 aG9kIHRoYXQgcmV0dXJucyBhIFBhc3NPd25QdHIsIGFkZGluZyBtaXNzaW5nIGNvbnN0LAorICAg ICAgICBhbmQgbW92aW5nIHNob3J0IGlubGluZSBtZXRob2RzIGludG8gdGhlIGNsYXNzIGRlZmlu aXRpb24gc28gaXQncyBlYXNpZXIKKyAgICAgICAgdG8gdW5kZXJzdGFuZCB3aGF0IG1ldGhvZHMg ZG8gd2hhdC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3JpbmcuCisKKyAg ICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjplbnN1 cmVTaGFkb3cpOgorICAgICAgICAqIGRvbS9FbGVtZW50U2hhZG93LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkVsZW1lbnRTaGFkb3c6OmNoaWxkTmVlZHNTdHlsZVJlY2FsYyk6CisgICAgICAgIChX ZWJDb3JlOjpFbGVtZW50U2hhZG93OjpuZWVkc1N0eWxlUmVjYWxjKToKKyAgICAgICAgKiBkb20v RWxlbWVudFNoYWRvdy5oOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudFNoYWRvdzo6Y3JlYXRl KToKKyAgICAgICAgKEVsZW1lbnRTaGFkb3cpOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudFNo YWRvdzo6fkVsZW1lbnRTaGFkb3cpOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudFNoYWRvdzo6 eW91bmdlc3RTaGFkb3dSb290KToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnRTaGFkb3c6Om9s ZGVzdFNoYWRvd1Jvb3QpOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudFNoYWRvdzo6ZGlzdHJp YnV0b3IpOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudFNoYWRvdzo6RWxlbWVudFNoYWRvdyk6 CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50U2hhZG93Ojpjb250YWluaW5nU2hhZG93KToKKwog MjAxMy0wMS0yOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBwb3NpdGlvbjpmaXhlZCB0aGF0IGRvZXNuJ3QgcmVuZGVyIGFueSBjb250ZW50IHNob3Vs ZCBub3QgZm9yY2UgY29tcG9zaXRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA3MmY2MDJj NzdkZmE1NjA4YWJkMWQ4MDAwNGFhYjcxNjg0ZTlkNjBlLi5lZTIxMDY5YmM3ODZiNWYxMjY0N2Vh Y2U1ZTE0MGRjY2IwMmZmYzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0xNDQ5LDcgKzE0 NDksNyBAQCBFbGVtZW50U2hhZG93KiBFbGVtZW50OjplbnN1cmVTaGFkb3coKQogICAgICAgICBy ZXR1cm4gc2hhZG93OwogCiAgICAgRWxlbWVudFJhcmVEYXRhKiBkYXRhID0gZWxlbWVudFJhcmVE YXRhKCk7Ci0gICAgZGF0YS0+c2V0U2hhZG93KGFkb3B0UHRyKG5ldyBFbGVtZW50U2hhZG93KCkp KTsKKyAgICBkYXRhLT5zZXRTaGFkb3coRWxlbWVudFNoYWRvdzo6Y3JlYXRlKCkpOwogICAgIHJl dHVybiBkYXRhLT5zaGFkb3coKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnRTaGFkb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRTaGFkb3cuY3Bw CmluZGV4IDMyZGQ0ZjA0ZDU3YWVhYzQwMzJlZWFmMmZkMWVmY2NmNTI2OGFlNGQuLmZmMGI3Yjli MjU3ZGQ4OGE3ZTI2MjM0NjU2ODk0NjY2ZWVjNGVmOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50U2hhZG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dFNoYWRvdy5jcHAKQEAgLTI3LDI5ICsyNywxMSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2lu Y2x1ZGUgIkVsZW1lbnRTaGFkb3cuaCIKIAotI2luY2x1ZGUgIkNTU1BhcnNlci5oIgotI2luY2x1 ZGUgIkNTU1NlbGVjdG9yTGlzdC5oIgogI2luY2x1ZGUgIkNvbnRhaW5lck5vZGVBbGdvcml0aG1z LmgiCi0jaW5jbHVkZSAiRG9jdW1lbnQuaCIKLSNpbmNsdWRlICJFbGVtZW50LmgiCi0jaW5jbHVk ZSAiSFRNTENvbnRlbnRFbGVtZW50LmgiCi0jaW5jbHVkZSAiSFRNTFNoYWRvd0VsZW1lbnQuaCIK ICNpbmNsdWRlICJJbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaCIKLSNpbmNsdWRlICJOb2RlVHJh dmVyc2FsLmgiCi0jaW5jbHVkZSAiU2hhZG93Um9vdC5oIgotI2luY2x1ZGUgIlN0eWxlUmVzb2x2 ZXIuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1FbGVtZW50U2hhZG93OjpFbGVtZW50U2hh ZG93KCkKLXsKLX0KLQotRWxlbWVudFNoYWRvdzo6fkVsZW1lbnRTaGFkb3coKQotewotICAgIEFT U0VSVChtX3NoYWRvd1Jvb3RzLmlzRW1wdHkoKSk7Ci19Ci0KIHN0YXRpYyBib29sIHZhbGlkYXRl U2hhZG93Um9vdChEb2N1bWVudCogZG9jdW1lbnQsIFNoYWRvd1Jvb3QqIHNoYWRvd1Jvb3QsIEV4 Y2VwdGlvbkNvZGUmIGVjKQogewogICAgIGlmICghc2hhZG93Um9vdCkKQEAgLTEzOCw3ICsxMjAs NyBAQCB2b2lkIEVsZW1lbnRTaGFkb3c6OmRldGFjaCgpCiAgICAgfQogfQogCi1ib29sIEVsZW1l bnRTaGFkb3c6OmNoaWxkTmVlZHNTdHlsZVJlY2FsYygpCitib29sIEVsZW1lbnRTaGFkb3c6OmNo aWxkTmVlZHNTdHlsZVJlY2FsYygpIGNvbnN0CiB7CiAgICAgQVNTRVJUKHlvdW5nZXN0U2hhZG93 Um9vdCgpKTsKICAgICBmb3IgKFNoYWRvd1Jvb3QqIHJvb3QgPSB5b3VuZ2VzdFNoYWRvd1Jvb3Qo KTsgcm9vdDsgcm9vdCA9IHJvb3QtPm9sZGVyU2hhZG93Um9vdCgpKQpAQCAtMTQ4LDcgKzEzMCw3 IEBAIGJvb2wgRWxlbWVudFNoYWRvdzo6Y2hpbGROZWVkc1N0eWxlUmVjYWxjKCkKICAgICByZXR1 cm4gZmFsc2U7CiB9CiAKLWJvb2wgRWxlbWVudFNoYWRvdzo6bmVlZHNTdHlsZVJlY2FsYygpCiti b29sIEVsZW1lbnRTaGFkb3c6Om5lZWRzU3R5bGVSZWNhbGMoKSBjb25zdAogewogICAgIEFTU0VS VCh5b3VuZ2VzdFNoYWRvd1Jvb3QoKSk7CiAgICAgZm9yIChTaGFkb3dSb290KiByb290ID0geW91 bmdlc3RTaGFkb3dSb290KCk7IHJvb3Q7IHJvb3QgPSByb290LT5vbGRlclNoYWRvd1Jvb3QoKSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hhZG93LmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudFNoYWRvdy5oCmluZGV4IDg5MzM2M2JiYTg3YjQ4OGU3YWZkMTJk MDI4NWNkNGE1NDQ0MWVhNzMuLmFiNzEyNGI3Yjc2MzhiYTk5ZTJmNjEzYjUzMGE5ODgxMmQ3OTc1 NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50U2hhZG93LmgKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRTaGFkb3cuaApAQCAtMzIsMjUgKzMyLDI4IEBACiAj aW5jbHVkZSAiU2hhZG93Um9vdC5oIgogI2luY2x1ZGUgPHd0Zi9Eb3VibHlMaW5rZWRMaXN0Lmg+ CiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+Ci0jaW5jbHVkZSA8d3RmL093blB0ci5oPgor I2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4K ICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3Mg Tm9kZTsKLWNsYXNzIEVsZW1lbnQ7Ci1jbGFzcyBUcmVlU2NvcGU7Ci0KIGNsYXNzIEVsZW1lbnRT aGFkb3cgewogICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRWxlbWVudFNoYWRvdyk7IFdURl9NQUtF X0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgotICAgIEVsZW1lbnRTaGFkb3coKTsKLSAgICB+RWxl bWVudFNoYWRvdygpOworICAgIHN0YXRpYyBQYXNzT3duUHRyPEVsZW1lbnRTaGFkb3c+IGNyZWF0 ZSgpCisgICAgeworICAgICAgICByZXR1cm4gYWRvcHRQdHIobmV3IEVsZW1lbnRTaGFkb3coKSk7 CisgICAgfQorCisgICAgfkVsZW1lbnRTaGFkb3coKQorICAgIHsKKyAgICAgICAgQVNTRVJUKG1f c2hhZG93Um9vdHMuaXNFbXB0eSgpKTsKKyAgICB9CiAKICAgICBFbGVtZW50KiBob3N0KCkgY29u c3Q7Ci0gICAgU2hhZG93Um9vdCogeW91bmdlc3RTaGFkb3dSb290KCkgY29uc3Q7Ci0gICAgU2hh ZG93Um9vdCogb2xkZXN0U2hhZG93Um9vdCgpIGNvbnN0OworICAgIFNoYWRvd1Jvb3QqIHlvdW5n ZXN0U2hhZG93Um9vdCgpIGNvbnN0IHsgcmV0dXJuIG1fc2hhZG93Um9vdHMuaGVhZCgpOyB9Cisg ICAgU2hhZG93Um9vdCogb2xkZXN0U2hhZG93Um9vdCgpIGNvbnN0IHsgcmV0dXJuIG1fc2hhZG93 Um9vdHMudGFpbCgpOyB9CiAgICAgRWxlbWVudFNoYWRvdyogY29udGFpbmluZ1NoYWRvdygpIGNv bnN0OwogCiAgICAgdm9pZCByZW1vdmVBbGxTaGFkb3dSb290cygpOwpAQCAtNTksNDQgKzYyLDI2 IEBAIHB1YmxpYzoKICAgICB2b2lkIGF0dGFjaCgpOwogICAgIHZvaWQgZGV0YWNoKCk7CiAKLSAg ICBib29sIGNoaWxkTmVlZHNTdHlsZVJlY2FsYygpOwotICAgIGJvb2wgbmVlZHNTdHlsZVJlY2Fs YygpOworICAgIGJvb2wgY2hpbGROZWVkc1N0eWxlUmVjYWxjKCkgY29uc3Q7CisgICAgYm9vbCBu ZWVkc1N0eWxlUmVjYWxjKCkgY29uc3Q7CiAgICAgdm9pZCByZWNhbGNTdHlsZShOb2RlOjpTdHls ZUNoYW5nZSk7CiAKICAgICB2b2lkIGludmFsaWRhdGVEaXN0cmlidXRpb24oKSB7IG1fZGlzdHJp YnV0b3IuaW52YWxpZGF0ZURpc3RyaWJ1dGlvbihob3N0KCkpOyB9CiAgICAgdm9pZCBkaWRBZmZl Y3RTZWxlY3RvcihBZmZlY3RlZFNlbGVjdG9yTWFzayBtYXNrKSB7IG1fZGlzdHJpYnV0b3IuZGlk QWZmZWN0U2VsZWN0b3IoaG9zdCgpLCBtYXNrKTsgfQogICAgIHZvaWQgd2lsbEFmZmVjdFNlbGVj dG9yKCkgeyBtX2Rpc3RyaWJ1dG9yLndpbGxBZmZlY3RTZWxlY3Rvcihob3N0KCkpOyB9CiAKLSAg ICBDb250ZW50RGlzdHJpYnV0b3ImIGRpc3RyaWJ1dG9yKCk7Ci0gICAgY29uc3QgQ29udGVudERp c3RyaWJ1dG9yJiBkaXN0cmlidXRvcigpIGNvbnN0OworICAgIENvbnRlbnREaXN0cmlidXRvciYg ZGlzdHJpYnV0b3IoKSB7IHJldHVybiBtX2Rpc3RyaWJ1dG9yOyB9CisgICAgY29uc3QgQ29udGVu dERpc3RyaWJ1dG9yJiBkaXN0cmlidXRvcigpIGNvbnN0IHsgcmV0dXJuIG1fZGlzdHJpYnV0b3I7 IH0KIAogICAgIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyopIGNvbnN0 OworCiBwcml2YXRlOgorICAgIEVsZW1lbnRTaGFkb3coKSB7IH0KIAogICAgIERvdWJseUxpbmtl ZExpc3Q8U2hhZG93Um9vdD4gbV9zaGFkb3dSb290czsKICAgICBDb250ZW50RGlzdHJpYnV0b3Ig bV9kaXN0cmlidXRvcjsKIH07CiAKLWlubGluZSBTaGFkb3dSb290KiBFbGVtZW50U2hhZG93Ojp5 b3VuZ2VzdFNoYWRvd1Jvb3QoKSBjb25zdAotewotICAgIHJldHVybiBtX3NoYWRvd1Jvb3RzLmhl YWQoKTsKLX0KLQotaW5saW5lIFNoYWRvd1Jvb3QqIEVsZW1lbnRTaGFkb3c6Om9sZGVzdFNoYWRv d1Jvb3QoKSBjb25zdAotewotICAgIHJldHVybiBtX3NoYWRvd1Jvb3RzLnRhaWwoKTsKLX0KLQot aW5saW5lIENvbnRlbnREaXN0cmlidXRvciYgRWxlbWVudFNoYWRvdzo6ZGlzdHJpYnV0b3IoKQot ewotICAgIHJldHVybiBtX2Rpc3RyaWJ1dG9yOwotfQotCi1pbmxpbmUgY29uc3QgQ29udGVudERp c3RyaWJ1dG9yJiBFbGVtZW50U2hhZG93OjpkaXN0cmlidXRvcigpIGNvbnN0Ci17Ci0gICAgcmV0 dXJuIG1fZGlzdHJpYnV0b3I7Ci19Ci0KIGlubGluZSBFbGVtZW50KiBFbGVtZW50U2hhZG93Ojpo b3N0KCkgY29uc3QKIHsKICAgICBBU1NFUlQoIW1fc2hhZG93Um9vdHMuaXNFbXB0eSgpKTsKQEAg LTExNCwxMCArOTksOSBAQCBpbmxpbmUgU2hhZG93Um9vdCogTm9kZTo6eW91bmdlc3RTaGFkb3dS b290KCkgY29uc3QKIAogaW5saW5lIEVsZW1lbnRTaGFkb3cqIEVsZW1lbnRTaGFkb3c6OmNvbnRh aW5pbmdTaGFkb3coKSBjb25zdAogewotICAgIFNoYWRvd1Jvb3QqIHBhcmVudFJvb3QgPSBob3N0 KCktPmNvbnRhaW5pbmdTaGFkb3dSb290KCk7Ci0gICAgaWYgKCFwYXJlbnRSb290KQotICAgICAg ICByZXR1cm4gMDsKLSAgICByZXR1cm4gcGFyZW50Um9vdC0+b3duZXIoKTsKKyAgICBpZiAoU2hh ZG93Um9vdCogcGFyZW50Um9vdCA9IGhvc3QoKS0+Y29udGFpbmluZ1NoYWRvd1Jvb3QoKSkKKyAg ICAgICAgcmV0dXJuIHBhcmVudFJvb3QtPm93bmVyKCk7CisgICAgcmV0dXJuIDA7CiB9CiAKIGNs YXNzIFNoYWRvd1Jvb3RWZWN0b3IgOiBwdWJsaWMgVmVjdG9yPFJlZlB0cjxTaGFkb3dSb290PiA+ IHsK