108154 2013-01-28 23:09:30 -0800 IDBFactory::webkitGetDatabaseNames should raise DOMExceptions. 2013-01-29 03:07:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94171 1 mkwst mkwst jochen jsbell webkit.review.bot oldest_to_newest 818589 0 mkwst 2013-01-28 23:09:30 -0800 In order to properly support blocking third-party IndexedDB usage, ::open, ::getDatabaseNames, and ::deleteDatabase should all throw SECURITY_ERR when used in a blocked third-party context. Currently, ::getDatabaseNames doesn't support exceptions; we should change that. 818673 1 185190 mkwst 2013-01-29 00:50:49 -0800 Created attachment 185190 Patch 818675 2 mkwst 2013-01-29 00:52:09 -0800 Is this something you'd be comfy reviewing, Jochen? See discussion on http://wkbug.com/94171, which is also where tests for this functionality will live. I'll update that patch to rebase on top of this one shortly. 818767 3 185190 jochen 2013-01-29 02:56:18 -0800 Comment on attachment 185190 Patch r=me 818773 4 185190 mkwst 2013-01-29 02:59:42 -0800 Comment on attachment 185190 Patch cq=me. Thanks. :) 818778 5 185190 webkit.review.bot 2013-01-29 03:07:33 -0800 Comment on attachment 185190 Patch Clearing flags on attachment: 185190 Committed r141090: <http://trac.webkit.org/changeset/141090> 818779 6 webkit.review.bot 2013-01-29 03:07:36 -0800 All reviewed patches have been landed. Closing bug. 185190 2013-01-29 00:50:49 -0800 2013-01-29 03:07:32 -0800 Patch bug-108154-20130129094735.patch text/plain 4880 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDVkMGY3MjhkYjY4NjNh YTAwOWFiZThlODAzZmFlNDk1YzFiZWI4Ny4uNzEwYjBlNGYyMTBkYmIwZDExYWIxMDFlZTdhMzA1 NzBhMGZjYmJmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEzLTAxLTI5ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSURCRmFjdG9yeTo6d2Via2l0 R2V0RGF0YWJhc2VOYW1lcyBzaG91bGQgcmFpc2UgRE9NRXhjZXB0aW9ucy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODE1NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIG9yZGVyIHRvIHByb3Blcmx5 IHN1cHBvcnQgYmxvY2tpbmcgdGhpcmQtcGFydHkgSW5kZXhlZERCIHVzYWdlLAorICAgICAgICBv cGVuKCksIGdldERhdGFiYXNlTmFtZXMoKSwgYW5kIGRlbGV0ZURhdGFiYXNlKCkgc2hvdWxkIGFs bCB0aHJvdworICAgICAgICBTRUNVUklUWV9FUlIgd2hlbiB1c2VkIGluIGEgYmxvY2tlZCB0aGly ZC1wYXJ0eSBjb250ZXh0LiBUaGF0J3MgcG9zc2libGUKKyAgICAgICAgbm93IGZvciBvcGVuKCkg YW5kIGRlbGV0ZURhdGFiYXNlKCksIGJ1dCBnZXREYXRhYmFzZU5hbWVzKCkgY2FuJ3QKKyAgICAg ICAgY3VycmVudGx5IHJhaXNlIGV4Y2VwdGlvbnMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGp1 c3RzIHRoZSBJREwgZmlsZSBhbmQgaW1wbGVtZW50YXRpb24uIE5vIGV4Y2VwdGlvbnMgYXJlCisg ICAgICAgIGN1cnJlbnRseSB0aHJvd24sIGJ1dCB0aGF0IHdpbGwgY2hhbmdlIGFzIHNvb24gYXMg d2tidWcuY29tLzk0MTcxIGxhbmRzLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURC RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJGYWN0b3J5OjpnZXREYXRhYmFzZU5h bWVzKToKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5Lmg6CisgICAgICAg IChJREJGYWN0b3J5KToKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5Lmlk bDoKKyAgICAgICAgICAgIEFkZCAicmFpc2VzIChET01FeGNlcHRpb24pIiB0byBnZXREYXRhYmFz ZU5hbWVzLCBhbmQgYWRqdXN0IHRoZQorICAgICAgICAgICAgaW1wbGVtZW50YXRpb24gdG8gbWF0 Y2guCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckluZGV4ZWREQkFnZW50OjpyZXF1ZXN0RGF0YWJhc2VO YW1lc0ZvckZyYW1lKToKKyAgICAgICAgICAgIFBhc3MgaW4gYW4gRXhjZXB0aW9uQ29kZSB3aGVu IGNhbGxpbmcgZ2V0RGF0YWJhc2VOYW1lcywgYW5kIGhhbmRsZQorICAgICAgICAgICAgcG9zc2li bGUgZXhjZXB0aW9ucy4KKwogMjAxMy0wMS0yOSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNDEwNzApOiBCcm9rZSBkZWJ1ZyBi dWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFj dG9yeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNw cAppbmRleCAzMTk5YzE3MTRhYWRhMTM5ZDI5MzllZmMzMDVlY2JiZjQ4YjE4OGU3Li4yZDNjMGQz ZDA3M2IxZTkzNDk2YmFlOGNkZDk3YmI5Njg0MTc4NzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNwcApAQCAtOTUsNyArOTUsNyBAQCBzdGF0 aWMgU3RyaW5nIGdldEluZGV4ZWREQkRhdGFiYXNlUGF0aChTY3JpcHRFeGVjdXRpb25Db250ZXh0 KiBjb250ZXh0KQogfQogfQogCi1QYXNzUmVmUHRyPElEQlJlcXVlc3Q+IElEQkZhY3Rvcnk6Omdl dERhdGFiYXNlTmFtZXMoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCkKK1Bhc3NSZWZQ dHI8SURCUmVxdWVzdD4gSURCRmFjdG9yeTo6Z2V0RGF0YWJhc2VOYW1lcyhTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBjb250ZXh0LCBFeGNlcHRpb25Db2RlJikKIHsKICAgICBpZiAoIWlzQ29udGV4 dFZhbGlkKGNvbnRleHQpKQogICAgICAgICByZXR1cm4gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnkuaCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnkuaAppbmRleCBjNDEzNjVkODk4ZDg3ZjNjMDJmYjA1 YjA2ODgxMzVmY2QzMGE5YWYxLi5jYjFiN2IwYjM3NmI3YWE2ZDg0OWM2ODQ4YjMwZTNlMWNlNjAy ZWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0 b3J5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5o CkBAIC01NSw3ICs1NSw3IEBAIHB1YmxpYzoKICAgICB9CiAgICAgfklEQkZhY3RvcnkoKTsKIAot ICAgIFBhc3NSZWZQdHI8SURCUmVxdWVzdD4gZ2V0RGF0YWJhc2VOYW1lcyhTY3JpcHRFeGVjdXRp b25Db250ZXh0Kik7CisgICAgUGFzc1JlZlB0cjxJREJSZXF1ZXN0PiBnZXREYXRhYmFzZU5hbWVz KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBFeGNlcHRpb25Db2RlJik7CiAKICAgICBQYXNzUmVm UHRyPElEQk9wZW5EQlJlcXVlc3Q+IG9wZW4oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIGNvbnN0 IFN0cmluZyYgbmFtZSwgRXhjZXB0aW9uQ29kZSYpOwogICAgIFBhc3NSZWZQdHI8SURCT3BlbkRC UmVxdWVzdD4gb3BlbihTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgY29uc3QgU3RyaW5nJiBuYW1l LCBpbnQ2NF90IHZlcnNpb24sIEV4Y2VwdGlvbkNvZGUmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnkuaWRsIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCRmFjdG9yeS5pZGwKaW5kZXggNmEwMjExZmU1YWYxYTU2YWZh ZTMwZDMwNzM4YTI0N2RjM2NjYjM0Mi4uYTUxNjA1YjJiNGUzMTI5N2JiNTVkYTNiNTE3ZDVkZDEy YzNkMjJhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC RmFjdG9yeS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRmFj dG9yeS5pZGwKQEAgLTI4LDcgKzI4LDggQEAKICAgICBKU05vU3RhdGljVGFibGVzLAogICAgIElt cGxlbWVudGF0aW9uTGFja3NWVGFibGUKIF0gaW50ZXJmYWNlIElEQkZhY3RvcnkgewotICAgIFtD YWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LCBJbXBsZW1lbnRlZEFzPWdldERhdGFiYXNl TmFtZXNdIElEQlJlcXVlc3Qgd2Via2l0R2V0RGF0YWJhc2VOYW1lcygpOworICAgIFtDYWxsV2l0 aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LCBJbXBsZW1lbnRlZEFzPWdldERhdGFiYXNlTmFtZXNd IElEQlJlcXVlc3Qgd2Via2l0R2V0RGF0YWJhc2VOYW1lcygpCisgICAgICAgIHJhaXNlcyAoRE9N RXhjZXB0aW9uKTsKIAogICAgIC8vIEZJWE1FOiBNYWtlIHRoaXMgW0VuZm9yY2VSYW5nZV0gdW5z aWduZWQgbG9uZyBsb25nIG9uY2Ugd2Via2l0Lm9yZy9iLzk2Nzk4IGxhbmRzLgogICAgIFtDYWxs V2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0XSBJREJPcGVuREJSZXF1ZXN0IG9wZW4oaW4gRE9N U3RyaW5nIG5hbWUsIGluIFtPcHRpb25hbF0gbG9uZyBsb25nIHZlcnNpb24pCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcAppbmRl eCA1MDg5N2NkYzAwMjQyMzhmZjY1Njc3OWQyY2Y1YjNhZWEyNzBiZTQzLi40OWU5NjUzMmI4NmJj OGViOTZlOGQ0M2U2NTYwYzVlMmRjZDZjMjg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHAKQEAgLTY1Miw3ICs2NTIsMTIg QEAgdm9pZCBJbnNwZWN0b3JJbmRleGVkREJBZ2VudDo6cmVxdWVzdERhdGFiYXNlTmFtZXNGb3JG cmFtZShFcnJvclN0cmluZyogZXJyb3JTdHIKICAgICB2ODo6Q29udGV4dDo6U2NvcGUgY29udGV4 dFNjb3BlKGNvbnRleHQpOwogI2VuZGlmCiAKLSAgICBSZWZQdHI8SURCUmVxdWVzdD4gaWRiUmVx dWVzdCA9IGlkYkZhY3RvcnktPmdldERhdGFiYXNlTmFtZXMoZG9jdW1lbnQpOworICAgIEV4Y2Vw dGlvbkNvZGUgZWMgPSAwOworICAgIFJlZlB0cjxJREJSZXF1ZXN0PiBpZGJSZXF1ZXN0ID0gaWRi RmFjdG9yeS0+Z2V0RGF0YWJhc2VOYW1lcyhkb2N1bWVudCwgZWMpOworICAgIGlmIChlYykgewor ICAgICAgICByZXF1ZXN0Q2FsbGJhY2stPnNlbmRGYWlsdXJlKCJDb3VsZCBub3Qgb2J0YWluIGRh dGFiYXNlIG5hbWVzLiIpOworICAgICAgICByZXR1cm47CisgICAgfQogICAgIGlkYlJlcXVlc3Qt PmFkZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLnN1Y2Nlc3NFdmVudCwgR2V0RGF0YWJhc2VO YW1lc0NhbGxiYWNrOjpjcmVhdGUocmVxdWVzdENhbGxiYWNrLCBkb2N1bWVudC0+c2VjdXJpdHlP cmlnaW4oKS0+dG9TdHJpbmcoKSksIGZhbHNlKTsKIH0KIAo=