10813 2006-09-11 13:39:18 -0700 REGRESSION (r16245): double-clicking on javascript exceptions fails to show source 2006-09-17 23:38:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 eric webkit-unassigned ap darin mitz oldest_to_newest 55262 0 eric 2006-09-11 13:39:18 -0700 Regression: double-clicking on javascript exceptions fails to show source Perhaps this is specific to SVG files, not sure. Either way, this used to work. 55265 1 10506 eric 2006-09-11 13:57:13 -0700 Created attachment 10506 svg file containing bad javascript to trigger exception 55269 2 mitz 2006-09-11 15:31:07 -0700 The regression happend between in r16245 (text encoding fixes, bug 10728). +[WebCoreFrameBridge stringWithData:textEncodingName:] is assumed to default to Latin-1 when passed nil for the encoding name, but nothing in the code supports it: TextEncoding just passes the nil down to atomicCanonicalTextEncodingName() which returns 0. The TextEncoding's m_encoding remains 0, and consequently it doesn't decode or encode. 55442 3 10543 eric 2006-09-13 14:02:36 -0700 Created attachment 10543 A hack-ish fix. Not sure if this is the right way to fix it or not. 55523 4 10543 ap 2006-09-14 12:54:21 -0700 Comment on attachment 10543 A hack-ish fix. r=me (yes, even without a ChangeLog entry ;) ) I think that this patch properly fixes the regression, but the behavior is still seriously broken. This code path is used when HTTP headers don't specify an encoding, but there are numerous other ways for WebCore to pick one, and the same encoding should be used for handling a resource and for providing it source, obviously. + NSString* name = textEncodingName ? textEncodingName : @"Latin-1"; We usually call this encoding "iso-8859-1". Might make sense to do so here for consistency, as well. 10506 2006-09-11 13:57:13 -0700 2006-09-11 13:57:13 -0700 svg file containing bad javascript to trigger exception animtest.svg image/svg+xml 1044 eric PD94bWwgdmVyc2lvbj0iMS4wIj8+CjxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAv c3ZnIiB3aWR0aD0iNDAwIiBoZWlnaHQ9IjQwMCI+CiAgPHJlY3QgaWQ9InJlY3QiIHg9IjAiIHk9 IjAiIHdpZHRoPSIwIiBoZWlnaHQ9IjAiIC8+CiAgPGZvcmVpZ25PYmplY3Q+CiAgICA8aHRtbCB4 bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CiAgICAgIDxkaXYgaWQ9ImxvZyIg Lz4KICAgIDwvaHRtbD4KICA8L2ZvcmVpZ25PYmplY3Q+CiAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph dmFzY3JpcHQiPgogIDwhW0NEQVRBWwogICAgZnVuY3Rpb24gbG9nKG1lc3NhZ2UpIHsKICAgICAg ICB2YXIgbG9nRGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xvZycpOwogICAgICAgIHZh ciBuZXdEaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKICAgICAgICBuZXdEaXYu YXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSkpOwogICAgICAgIGxv Z0Rpdi5hcHBlbmRDaGlsZChuZXdEaXYpOwogICAgfQogICAgCiAgICB2YXIgcmVjdCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdyZWN0Jyk7CiAgICBpZiAocmVjdC54LmJhc2VWYWwgJiYgcmVj dC54LmFuaW1WYWwpIHsKICAgICAgbG9nKHJlY3QueC5iYXNlVmFsLnZhbHVlKTsKICAgICAgbG9n KHJlY3QueC5hbmltVmFsLnZhbHVlKTsKICAgICAgcmVjdC5iYXNlVmFsLnggPSAxMDsKICAgICAg bG9nKHJlY3QueC5iYXNlVmFsLnZhbHVlKTsKICAgICAgbG9nKHJlY3QueC5hbmltVmFsLnZhbHVl KTsKICAgICAgaWYgKChyZWN0LnguYmFzZVZhbC52YWx1ZSA9PSByZWN0LnguYW5pbVZhbC52YWx1 ZSkgJiYgKHJlY3QueC5hbmltVmFsLnZhbHVlID09IDEwKSkKICAgICAgICBsb2coIlNVQ0NFU1Mh Iik7CiAgICB9IGVsc2UgewogICAgICBsb2coIkZBSUxFRCwgcmVjdC54LmJhc2VWYWwgb3IgcmVj dC54LmFuaW1WYWwgdW5kZWZpbmVkLiIpCiAgICB9CiAgICBhbGVydCgiZG9uZSIpOwogIF1dPgog IDwvc2NyaXB0Pgo8L3N2Zz4K 10543 2006-09-13 14:02:36 -0700 2006-09-14 12:54:21 -0700 A hack-ish fix. fix.patch text/plain 699 eric SW5kZXg6IGJyaWRnZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGJy aWRnZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCShyZXZpc2lvbiAxNjM0NikKKysrIGJyaWRn ZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDg4LDcgKzE0 ODgsOCBAQCBzdGF0aWMgSFRNTEZvcm1FbGVtZW50ICpmb3JtRWxlbWVudEZyb21ECiAKICsgKE5T U3RyaW5nICopc3RyaW5nV2l0aERhdGE6KE5TRGF0YSAqKWRhdGEgdGV4dEVuY29kaW5nTmFtZToo TlNTdHJpbmcgKil0ZXh0RW5jb2RpbmdOYW1lCiB7Ci0gICAgcmV0dXJuIFdlYkNvcmU6OlRleHRF bmNvZGluZyh0ZXh0RW5jb2RpbmdOYW1lKS5kZWNvZGUocmVpbnRlcnByZXRfY2FzdDxjb25zdCBj aGFyKj4oW2RhdGEgYnl0ZXNdKSwgW2RhdGEgbGVuZ3RoXSk7CisgICAgTlNTdHJpbmcqIG5hbWUg PSB0ZXh0RW5jb2RpbmdOYW1lID8gdGV4dEVuY29kaW5nTmFtZSA6IEAiTGF0aW4tMSI7CisgICAg cmV0dXJuIFdlYkNvcmU6OlRleHRFbmNvZGluZyhuYW1lKS5kZWNvZGUocmVpbnRlcnByZXRfY2Fz dDxjb25zdCBjaGFyKj4oW2RhdGEgYnl0ZXNdKSwgW2RhdGEgbGVuZ3RoXSk7CiB9CiAKIC0gKEJP T0wpbmVlZHNMYXlvdXQK