108126 2013-01-28 15:59:15 -0800 WebKit2 should notify the client if the NetworkProcess crashes 2013-01-29 12:06:42 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap sam oldest_to_newest 818214 0 beidson 2013-01-28 15:59:15 -0800 WebKit2 should notify the client if the NetworkProcess crashes <rdar://problem/13090513> 818218 1 185089 beidson 2013-01-28 16:01:44 -0800 Created attachment 185089 Patch v1 818260 2 beidson 2013-01-28 16:43:15 -0800 http://trac.webkit.org/changeset/141026 818513 3 ap 2013-01-28 22:01:04 -0800 I don't think that adding this API this is desirable or necessary. Network process crashing is not the only case when authentication request should be canceled. Another case is when NSURLConnection dispatches -connection:didCancelAuthenticationChallenge:. So, we need a code path for that, and crashing can be handled using that code path. Exposing details of NetworkProcess lifecycle to clients seems unnecessary at this point. 819165 4 beidson 2013-01-29 12:03:56 -0800 (In reply to comment #3) > I don't think that adding this API this is desirable or necessary. > > Network process crashing is not the only case when authentication request should be canceled. Another case is when NSURLConnection dispatches -connection:didCancelAuthenticationChallenge:. So, we need a code path for that, and crashing can be handled using that code path. > > Exposing details of NetworkProcess lifecycle to clients seems unnecessary at this point. Sam and I have already had discussions by the couches for future uses of this API. They seem valid and are symmetric with the value we get from notifying the client that a WebProcess crashed. Feel free to ping me about them when you're back. 819172 5 beidson 2013-01-29 12:06:42 -0800 (In reply to comment #3) > Network process crashing is not the only case when authentication request should be canceled. Another case is when NSURLConnection dispatches -connection:didCancelAuthenticationChallenge:. So, we need a code path for that, and crashing can be handled using that code path. Also when you get back in, take a look at <rdar://problem/8773140> 185089 2013-01-28 16:01:44 -0800 2013-01-28 16:02:39 -0800 Patch v1 patch text/plain 5629 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2MjkzMzYyLi4yY2MyZDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMDEtMjggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFdlYktpdDIgc2hvdWxkIG5vdGlmeSB0aGUgY2xpZW50IGlmIHRoZSBOZXR3b3JrUHJvY2Vz cyBjcmFzaGVzLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTMwOTA1MTM+IGFuZCBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MTI2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG5ldyBjbGllbnQgY2FsbGJhY2sg dG8gdGhlIENvbnRleHRDbGllbnQ6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4 dC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0Q2xpZW50LmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViQ29udGV4dENsaWVudDo6bmV0d29ya1Byb2Nlc3NEaWRDcmFzaCk6CisgICAg ICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHRDbGllbnQuaDoKKworICAgICAgICBDYWxsIG91dCB0 byB0aGUgY2xpZW50IHdoZW4gdGhlIE5ldHdvcmtQcm9jZXNzIGNyYXNoZXM6CisgICAgICAgICog VUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0Ojpu ZXR3b3JrUHJvY2Vzc0NyYXNoZWQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0Lmg6 CisKKyAgICAgICAgKiBVSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcDoK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3NQcm94eTo6bmV0d29ya1Byb2Nlc3NDcmFz aGVkT3JGYWlsZWRUb0xhdW5jaCk6CisKIDIwMTMtMDEtMjggIFJlbmF0YSBIb2RvdmFuICA8cmVu aUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bV2luXVtXSzJdIEJ1aWxkIGZpeCBhZnRlciBy MTQwOTU3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29u dGV4dC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5oCmluZGV4 IGM2NjgyODguLjcyYTU0NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQy9XS0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tD b250ZXh0LmgKQEAgLTQxLDExICs0MSwxMyBAQCB0eXBlZGVmIHVpbnQzMl90IFdLQ2FjaGVNb2Rl bDsKIAogLy8gQ29udGV4dCBDbGllbnQKIHR5cGVkZWYgdm9pZCAoKldLQ29udGV4dFBsdWdJbkF1 dG9TdGFydE9yaWdpbkhhc2hlc0NoYW5nZWRDYWxsYmFjaykoV0tDb250ZXh0UmVmIGNvbnRleHQs IGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwordHlwZWRlZiB2b2lkICgqV0tDb250ZXh0TmV0d29y a1Byb2Nlc3NEaWRDcmFzaENhbGxiYWNrKShXS0NvbnRleHRSZWYgY29udGV4dCwgY29uc3Qgdm9p ZCAqY2xpZW50SW5mbyk7CiAKIHN0cnVjdCBXS0NvbnRleHRDbGllbnQgewogICAgIGludCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdmVyc2lvbjsKICAgICBjb25zdCB2b2lkICogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsaWVudEluZm87CiAgICAgV0tDb250ZXh0UGx1 Z0luQXV0b1N0YXJ0T3JpZ2luSGFzaGVzQ2hhbmdlZENhbGxiYWNrICAgICAgICAgICAgICAgICBw bHVnSW5BdXRvU3RhcnRPcmlnaW5IYXNoZXNDaGFuZ2VkOworICAgIFdLQ29udGV4dE5ldHdvcmtQ cm9jZXNzRGlkQ3Jhc2hDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmV0d29y a1Byb2Nlc3NEaWRDcmFzaDsKIH07CiB0eXBlZGVmIHN0cnVjdCBXS0NvbnRleHRDbGllbnQgV0tD b250ZXh0Q2xpZW50OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTmV0 d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9O ZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3BwCmluZGV4IGFkNjQ4ZjIuLjE5MTc1ODcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNz UHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQ cm9jZXNzUHJveHkuY3BwCkBAIC0xMDUsNyArMTA1LDcgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzc1By b3h5OjpuZXR3b3JrUHJvY2Vzc0NyYXNoZWRPckZhaWxlZFRvTGF1bmNoKCkKICAgICB9CiAKICAg ICAvLyBUZWxsIHRoZSBuZXR3b3JrIHByb2Nlc3MgbWFuYWdlciB0byBmb3JnZXQgYWJvdXQgdGhp cyBuZXR3b3JrIHByb2Nlc3MgcHJveHkuIFRoaXMgbWF5IGNhdXNlIHVzIHRvIGJlIGRlbGV0ZWQu Ci0gICAgbV93ZWJDb250ZXh0LT5yZW1vdmVOZXR3b3JrUHJvY2Vzc1Byb3h5KHRoaXMpOworICAg IG1fd2ViQ29udGV4dC0+bmV0d29ya1Byb2Nlc3NDcmFzaGVkKHRoaXMpOwogfQogCiB2b2lkIE5l dHdvcmtQcm9jZXNzUHJveHk6OmRpZFJlY2VpdmVNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24q IGNvbm5lY3Rpb24sIENvcmVJUEM6Ok1lc3NhZ2VJRCBtZXNzYWdlSUQsIENvcmVJUEM6Ok1lc3Nh Z2VEZWNvZGVyJiBkZWNvZGVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3Bw CmluZGV4IGMzNzU1ZTYuLmI2NjdjZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5jcHAKQEAgLTM3NSw3ICszNzUsNyBAQCB2b2lkIFdlYkNvbnRleHQ6OmVuc3VyZU5ldHdv cmtQcm9jZXNzKCkKICAgICBtX25ldHdvcmtQcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpOZXR3b3Jr UHJvY2Vzczo6SW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKHBhcmFtZXRlcnMpLCAwKTsKIH0KIAot dm9pZCBXZWJDb250ZXh0OjpyZW1vdmVOZXR3b3JrUHJvY2Vzc1Byb3h5KE5ldHdvcmtQcm9jZXNz UHJveHkqIG5ldHdvcmtQcm9jZXNzUHJveHkpCit2b2lkIFdlYkNvbnRleHQ6Om5ldHdvcmtQcm9j ZXNzQ3Jhc2hlZChOZXR3b3JrUHJvY2Vzc1Byb3h5KiBuZXR3b3JrUHJvY2Vzc1Byb3h5KQogewog ICAgIEFTU0VSVChtX25ldHdvcmtQcm9jZXNzKTsKICAgICBBU1NFUlQobmV0d29ya1Byb2Nlc3NQ cm94eSA9PSBtX25ldHdvcmtQcm9jZXNzLmdldCgpKTsKQEAgLTM4Niw2ICszODYsOCBAQCB2b2lk IFdlYkNvbnRleHQ6OnJlbW92ZU5ldHdvcmtQcm9jZXNzUHJveHkoTmV0d29ya1Byb2Nlc3NQcm94 eSogbmV0d29ya1Byb2Nlc3NQcgogICAgICAgICBpdC0+dmFsdWUtPnByb2Nlc3NEaWRDbG9zZShu ZXR3b3JrUHJvY2Vzc1Byb3h5KTsKIAogICAgIG1fbmV0d29ya1Byb2Nlc3MgPSBudWxscHRyOwor CisgICAgbV9jbGllbnQubmV0d29ya1Byb2Nlc3NEaWRDcmFzaCh0aGlzKTsKIH0KIAogdm9pZCBX ZWJDb250ZXh0OjpnZXROZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24oUGFzc1JlZlB0cjxNZXNzYWdl czo6V2ViUHJvY2Vzc1Byb3h5OjpHZXROZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb246OkRlbGF5ZWRS ZXBseT4gcmVwbHkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAppbmRleCAzZjc1 YzA4Li5mMWIyZGY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgKQEAgLTI2 Myw3ICsyNjMsNyBAQCBwdWJsaWM6CiAjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKICAgICB2 b2lkIGVuc3VyZU5ldHdvcmtQcm9jZXNzKCk7CiAgICAgTmV0d29ya1Byb2Nlc3NQcm94eSogbmV0 d29ya1Byb2Nlc3MoKSB7IHJldHVybiBtX25ldHdvcmtQcm9jZXNzLmdldCgpOyB9Ci0gICAgdm9p ZCByZW1vdmVOZXR3b3JrUHJvY2Vzc1Byb3h5KE5ldHdvcmtQcm9jZXNzUHJveHkqKTsKKyAgICB2 b2lkIG5ldHdvcmtQcm9jZXNzQ3Jhc2hlZChOZXR3b3JrUHJvY2Vzc1Byb3h5Kik7CiAKICAgICB2 b2lkIGdldE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbihQYXNzUmVmUHRyPE1lc3NhZ2VzOjpXZWJQ cm9jZXNzUHJveHk6OkdldE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbjo6RGVsYXllZFJlcGx5Pik7 CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0 Q2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0Q2xpZW50LmNw cAppbmRleCBmZTllZmYzLi4yYmM5NDI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViQ29udGV4dENsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYkNvbnRleHRDbGllbnQuY3BwCkBAIC0zOCw0ICszOCwxMiBAQCB2b2lkIFdlYkNvbnRleHRD bGllbnQ6OnBsdWdJbkF1dG9TdGFydE9yaWdpbkhhc2hlc0NoYW5nZWQoV2ViQ29udGV4dCogY29u dGV4dCkKICAgICBtX2NsaWVudC5wbHVnSW5BdXRvU3RhcnRPcmlnaW5IYXNoZXNDaGFuZ2VkKHRv QVBJKGNvbnRleHQpLCBtX2NsaWVudC5jbGllbnRJbmZvKTsKIH0KIAordm9pZCBXZWJDb250ZXh0 Q2xpZW50OjpuZXR3b3JrUHJvY2Vzc0RpZENyYXNoKFdlYkNvbnRleHQqIGNvbnRleHQpCit7Cisg ICAgaWYgKCFtX2NsaWVudC5uZXR3b3JrUHJvY2Vzc0RpZENyYXNoKQorICAgICAgICByZXR1cm47 CisKKyAgICBtX2NsaWVudC5uZXR3b3JrUHJvY2Vzc0RpZENyYXNoKHRvQVBJKGNvbnRleHQpLCBt X2NsaWVudC5jbGllbnRJbmZvKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dENsaWVudC5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHRDbGllbnQuaAppbmRleCBmMTU0M2MzLi44YjNh NzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dENsaWVu dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0Q2xpZW50LmgKQEAg LTM2LDYgKzM2LDcgQEAgY2xhc3MgV2ViQ29udGV4dDsKIGNsYXNzIFdlYkNvbnRleHRDbGllbnQg OiBwdWJsaWMgQVBJQ2xpZW50PFdLQ29udGV4dENsaWVudCwga1dLQ29udGV4dENsaWVudEN1cnJl bnRWZXJzaW9uPiB7CiBwdWJsaWM6CiAgICAgdm9pZCBwbHVnSW5BdXRvU3RhcnRPcmlnaW5IYXNo ZXNDaGFuZ2VkKFdlYkNvbnRleHQqKTsKKyAgICB2b2lkIG5ldHdvcmtQcm9jZXNzRGlkQ3Jhc2go V2ViQ29udGV4dCopOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==