108122 2013-01-28 15:36:00 -0800 [EFL] Add Toggle fullscreen (F11) to MiniBrowser 2013-02-04 12:46:33 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108201 108850 1 bruno.abinader bruno.abinader cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 818192 0 bruno.abinader 2013-01-28 15:36:00 -0800 This bug intends to implement the ewk_view_fullscreen_enter() function as part of UIProcess' ewk_view API. This enables application to request for fullscreen (i.e. user triggered F11 key). 818419 1 185138 bruno.abinader 2013-01-28 19:55:48 -0800 Created attachment 185138 Patch Proposed patch (requires patch from bug 108121). 818576 2 185138 eflews.bot 2013-01-28 22:57:20 -0800 Comment on attachment 185138 Patch Attachment 185138 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16160927 818607 3 185138 cdumez 2013-01-28 23:36:14 -0800 Comment on attachment 185138 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185138&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:944 > + impl->page()->fullScreenManager()->requestEnterFullScreen(); Please use C API in new patches. We are in the process of porting everything to the C API. > Source/WebKit2/UIProcess/API/efl/ewk_view.h:802 > +EAPI Eina_Bool ewk_view_fullscreen_enter(Evas_Object *o); Missing API test. 818930 4 185241 bruno.abinader 2013-01-29 07:24:28 -0800 Created attachment 185241 Patch Simpler approach using native API suggested by Christophe 818943 5 185241 cdumez 2013-01-29 07:49:52 -0800 Comment on attachment 185241 Patch Did you make sure that pressing "ESC" does not exit fullscreen if it has been triggered using F11? 818948 6 bruno.abinader 2013-01-29 07:54:24 -0800 (In reply to comment #5) > (From update of attachment 185241 [details]) > Did you make sure that pressing "ESC" does not exit fullscreen if it has been triggered using F11? You're right, the browser crashes if ESC is pressed (my bad). However to avoid checking for FullScreen API directly, I'll add a boolean that specifies whether the fullscreen mode was activated by F11 or JS user gesture. Do you agree on this approach? 818956 7 cdumez 2013-01-29 08:07:50 -0800 Hmm, ewk_view_fullscreen_exit() should not crash if full screen was not triggered by fullscreen API. We should probably fix ewk_view_fullscreen_exit() instead of adding a boolean. 819002 8 bruno.abinader 2013-01-29 09:09:09 -0800 (In reply to comment #7) > Hmm, ewk_view_fullscreen_exit() should not crash if full screen was not triggered by fullscreen API. We should probably fix ewk_view_fullscreen_exit() instead of adding a boolean. Agreed, so this bug's implementation is correct. This crash is now handled on bug 108201. 819012 9 185241 cdumez 2013-01-29 09:26:06 -0800 Comment on attachment 185241 Patch LGTM. 819215 10 185241 tonikitoo 2013-01-29 12:38:50 -0800 Comment on attachment 185241 Patch Trivial enough. r+ 819251 11 185241 webkit.review.bot 2013-01-29 13:06:18 -0800 Comment on attachment 185241 Patch Clearing flags on attachment: 185241 Committed r141152: <http://trac.webkit.org/changeset/141152> 819252 12 webkit.review.bot 2013-01-29 13:06:24 -0800 All reviewed patches have been landed. Closing bug. 185138 2013-01-28 19:55:48 -0800 2013-01-29 07:24:23 -0800 Patch bug-108122-20130128235234.patch text/plain 4461 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmRlMmI4Y2ViOGRhMGMw OWFlZDcxYmM1YWE4YzIyZjdhNWFmMjZlMC4uOGNiN2Q3OGM2ZjBkNmJiYmIzZjI3ZGRiNTgyZTA2 MTgyNjNmOGM4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTAxLTI4ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KIAor ICAgICAgICBbV0syXVtFRkxdIEltcGxlbWVudCBld2tfdmlld19mdWxsc2NyZWVuX2VudGVyKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODEyMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZnVu Y3Rpb24gZW5hYmxlcyBhcHBsaWNhdGlvbiB0byByZXF1ZXN0IGZvciBmdWxsc2NyZWVuIChpLmUu IHVzZXIKKyAgICAgICAgdHJpZ2dlcmVkIEYxMSBrZXkpLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfZnVsbHNjcmVlbl9lbnRl cik6IEFkZGVkIGZ1bmN0aW9uLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 Lmg6IEFkZGVkIGV3a192aWV3X2Z1bGxzY3JlZW5fZW50ZXIoKS4KKworMjAxMy0wMS0yOCAgQnJ1 bm8gZGUgT2xpdmVpcmEgQWJpbmFkZXIgIDxicnVuby5hYmluYWRlckBiYXN5c2tvbS5jb20+CisK ICAgICAgICAgW1dLMl0gRW5hYmxlIGZ1bGxzY3JlZW4gcmVxdWVzdCBmcm9tIFVJUHJvY2VzcyAo aS5lLiB1c2VyIGNvbW1hbmQpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDgxMjEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXcuY3BwCmluZGV4IDcyYTZhZmFhM2VlYzEwODU1OWFmZGFmODc2MzgyZmI1YzM3M2Nj MTEuLjcyZWIyY2QxMjY5YThhNTlmNWRiYjIxMGQ5ZmI2YjBkNjIzZmM0YzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTkzNiw2ICs5MzYs MjAgQEAgRXdrX1BhZ2luYXRpb25fTW9kZSBld2tfdmlld19wYWdpbmF0aW9uX21vZGVfZ2V0KGNv bnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxFd2tfUGFn aW5hdGlvbl9Nb2RlPihpbXBsLT5wYWdlKCktPnBhZ2luYXRpb25Nb2RlKCkpOwogfQogCitFaW5h X0Jvb2wgZXdrX3ZpZXdfZnVsbHNjcmVlbl9lbnRlcihFdmFzX09iamVjdCogZXdrVmlldykKK3sK KyNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCisgICAgRVdLX1ZJRVdfSU1QTF9HRVRfT1JfUkVU VVJOKGV3a1ZpZXcsIGltcGwsIGZhbHNlKTsKKworICAgIGltcGwtPnBhZ2UoKS0+ZnVsbFNjcmVl bk1hbmFnZXIoKS0+cmVxdWVzdEVudGVyRnVsbFNjcmVlbigpOworCisgICAgcmV0dXJuIHRydWU7 CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShld2tWaWV3KTsKKyAgICByZXR1cm4gZmFsc2U7Cisj ZW5kaWYKK30KKwogRWluYV9Cb29sIGV3a192aWV3X2Z1bGxzY3JlZW5fZXhpdChFdmFzX09iamVj dCogZXdrVmlldykKIHsKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAppbmRleCA3ZDFkZjZkOWNlZWM4MTQwMGZh MmVlMjI5ZGY3Y2U3M2Q4YjZmMTNhLi42OTFjNDg3NTdlMjU4MzllZjAxN2RkZDg0Y2UzMjA1NTE4 MjBhZjg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf dmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgK QEAgLTc5Myw2ICs3OTMsMTUgQEAgRUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfcGFnaW5hdGlvbl9t b2RlX3NldChFdmFzX09iamVjdCAqbywgRXdrX1BhZ2luYXRpb25fTW9kZQogRUFQSSBFd2tfUGFn aW5hdGlvbl9Nb2RlIGV3a192aWV3X3BhZ2luYXRpb25fbW9kZV9nZXQoY29uc3QgRXZhc19PYmpl Y3QgKm8pOwogCiAvKioKKyAqIEVudGVyIGZ1bGxzY3JlZW4gbW9kZS4KKyAqCisgKiBAcGFyYW0g byB2aWV3IG9iamVjdCB3aGVyZSB0byBlbnRlciBmdWxsc2NyZWVuCisgKgorICogQHJldHVybiBA YyBFSU5BX1RSVUUgaWYgc3VjY2Vzc2Z1bCwgQGMgRUlOQV9GQUxTRSBvdGhlcndpc2UKKyAqLwor RUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfZnVsbHNjcmVlbl9lbnRlcihFdmFzX09iamVjdCAqbyk7 CisKKy8qKgogICogRXhpdCBmdWxsc2NyZWVuIG1vZGUuCiAgKgogICogQHBhcmFtIG8gdmlldyBv YmplY3Qgd2hlcmUgdG8gZXhpdCBmdWxsc2NyZWVuCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTJiYWZkMGY3NjQ4YjkxMzhhNjcwZTFiZTI3NjJl NTg5NzVjNDc0Yi4uYzM1MGJlN2ZkZjIwNTQ5OTYyZGEyYmIxOGY5YmIxMTUyNDE4MTFjNyAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEzLTAxLTI4ICBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFi aW5hZGVyQGJhc3lza29tLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEltcGxlbWVudCBld2tf dmlld19mdWxsc2NyZWVuX2VudGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwODEyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgZnVuY3Rpb24gZW5hYmxlcyBhcHBsaWNhdGlvbiB0byByZXF1 ZXN0IGZvciBmdWxsc2NyZWVuIChpLmUuIHVzZXIKKyAgICAgICAgdHJpZ2dlcmVkIEYxMSBrZXkp LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKG9uX2tleV9k b3duKTogQWRkZWQgJ0YxMScga2V5IGhhbmRsZXIuCisKIDIwMTMtMDEtMjggIFJhcGhhZWwgS3Vi byBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAg W0VGTF0gSW5jbHVkZSBFY29yZV9HZXRvcHQuaCBpbiBNaW5pQnJvd3Nlci4KZGlmZiAtLWdpdCBh L1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFp bi5jCmluZGV4IDA4YjRkMjQ4MjRlZWQyZDgxN2U4OTFmMzBmYWJjMmNjODVjYTIxMGUuLjQ2YzE2 Y2I4NGMxYzcxMDU5MDgwZTIwNWIyMTJhOWEwYmU5ODM2NWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01p bmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpA QCAtMzAyLDYgKzMwMiwxMiBAQCBvbl9rZXlfZG93bih2b2lkICp1c2VyX2RhdGEsIEV2YXMgKmUs IEV2YXNfT2JqZWN0ICpld2tfdmlldywgdm9pZCAqZXZlbnRfaW5mbykKICAgICAgICAgaW5mbygi Q3JlYXRlIHNvdWNlIGNvZGUgd2luZG93IChGOCkgd2FzIHByZXNzZWQuXG4iKTsKICAgICAgICAg QnJvd3Nlcl9XaW5kb3cgKndpbmRvdyA9IHdpbmRvd19jcmVhdGUoZXdrX3ZpZXcsIGV3a192aWV3 X3VybF9nZXQoZXdrX3ZpZXcpLCAwLCAwLCBFSU5BX1RSVUUpOwogICAgICAgICB3aW5kb3dzID0g ZWluYV9saXN0X2FwcGVuZCh3aW5kb3dzLCB3aW5kb3cpOworICAgIH0gZWxzZSBpZiAoIXN0cmNt cChldi0+a2V5LCAiRjExIikpIHsKKyAgICAgICAgaW5mbygiRnVsbHNjcmVlbiAoRjExKSB3YXMg cHJlc3NlZCwgdG9nZ2xpbmcgd2luZG93L2Z1bGxzY3JlZW4uXG4iKTsKKyAgICAgICAgaWYgKGVs bV93aW5fZnVsbHNjcmVlbl9nZXQod2luZG93LT5lbG1fd2luZG93KSkKKyAgICAgICAgICAgIGV3 a192aWV3X2Z1bGxzY3JlZW5fZXhpdChld2tfdmlldyk7CisgICAgICAgIGVsc2UKKyAgICAgICAg ICAgIGV3a192aWV3X2Z1bGxzY3JlZW5fZW50ZXIoZXdrX3ZpZXcpOwogICAgIH0gZWxzZSBpZiAo IXN0cmNtcChldi0+a2V5LCAibiIpICYmIGN0cmxQcmVzc2VkKSB7CiAgICAgICAgIGluZm8oIkNy ZWF0ZSBuZXcgd2luZG93IChDdHJsK24pIHdhcyBwcmVzc2VkLlxuIik7CiAgICAgICAgIEJyb3dz ZXJfV2luZG93ICp3aW5kb3cgPSB3aW5kb3dfY3JlYXRlKE5VTEwsIERFRkFVTFRfVVJMLCAwLCAw LCBFSU5BX0ZBTFNFKTsK 185241 2013-01-29 07:24:28 -0800 2013-01-29 13:06:18 -0800 Patch bug-108122-20130129112114.patch text/plain 1728 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWE1NTEzMTY0MjUyMjY4YjZjOGEzYzFiNjdiMDcyZjky YWQ0Nzg5OC4uYTRhNGE5NzZhY2M4ZjBhODQ0YjIxOTBlNzkyYmQyYWI0OGEzMGNjOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAxLTI5ICBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5h ZGVyQGJhc3lza29tLmNvbT4KKworICAgICAgICBbRUZMXSBBZGQgVG9nZ2xlIGZ1bGxzY3JlZW4g KEYxMSkgdG8gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwODEyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZHMgZnVsbHNjcmVlbiBtb2RlIHRvZ2dsZSAoRjExKSBvcHRpb24gdG8g TWluaUJyb3dzZXIgdXNpbmcgbmF0aXZlIEFQSS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2Vm bC9tYWluLmM6CisgICAgICAgIChvbl9rZXlfZG93bik6IEFkZCAnRjExJyBrZXkgaGFuZGxlci4K KwogMjAxMy0wMS0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gSW1wbGVtZW50IHJlc291cmNlcyBBUEkgdXNpbmcgaW5qZWN0ZWQg YnVuZGxlCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYwppbmRleCAwOGI0ZDI0ODI0ZWVkMmQ4MTdlODkxZjMwZmFi YzJjYzg1Y2EyMTBlLi5jMDNjMDhmYjJhODkyZDRjYjBjN2UyMjRhNWI0ZjZmMDFmYTdlMmFlIDEw MDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL2VmbC9tYWluLmMKQEAgLTMwMiw2ICszMDIsOSBAQCBvbl9rZXlfZG93bih2b2lkICp1 c2VyX2RhdGEsIEV2YXMgKmUsIEV2YXNfT2JqZWN0ICpld2tfdmlldywgdm9pZCAqZXZlbnRfaW5m bykKICAgICAgICAgaW5mbygiQ3JlYXRlIHNvdWNlIGNvZGUgd2luZG93IChGOCkgd2FzIHByZXNz ZWQuXG4iKTsKICAgICAgICAgQnJvd3Nlcl9XaW5kb3cgKndpbmRvdyA9IHdpbmRvd19jcmVhdGUo ZXdrX3ZpZXcsIGV3a192aWV3X3VybF9nZXQoZXdrX3ZpZXcpLCAwLCAwLCBFSU5BX1RSVUUpOwog ICAgICAgICB3aW5kb3dzID0gZWluYV9saXN0X2FwcGVuZCh3aW5kb3dzLCB3aW5kb3cpOworICAg IH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjExIikpIHsKKyAgICAgICAgaW5mbygiRnVs bHNjcmVlbiAoRjExKSB3YXMgcHJlc3NlZCwgdG9nZ2xpbmcgd2luZG93L2Z1bGxzY3JlZW4uXG4i KTsKKyAgICAgICAgZWxtX3dpbl9mdWxsc2NyZWVuX3NldCh3aW5kb3ctPmVsbV93aW5kb3csICFl bG1fd2luX2Z1bGxzY3JlZW5fZ2V0KHdpbmRvdy0+ZWxtX3dpbmRvdykpOwogICAgIH0gZWxzZSBp ZiAoIXN0cmNtcChldi0+a2V5LCAibiIpICYmIGN0cmxQcmVzc2VkKSB7CiAgICAgICAgIGluZm8o IkNyZWF0ZSBuZXcgd2luZG93IChDdHJsK24pIHdhcyBwcmVzc2VkLlxuIik7CiAgICAgICAgIEJy b3dzZXJfV2luZG93ICp3aW5kb3cgPSB3aW5kb3dfY3JlYXRlKE5VTEwsIERFRkFVTFRfVVJMLCAw LCAwLCBFSU5BX0ZBTFNFKTsK