108121 2013-01-28 15:16:26 -0800 [WK2] Enable fullscreen request from UIProcess (i.e. user command) 2013-01-30 16:42:12 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 bruno.abinader bruno.abinader andersca benjamin cdumez eric jer.noble laszlo.gombos tmpsantos oldest_to_newest 818173 0 bruno.abinader 2013-01-28 15:16:26 -0800 While implementing fullscreen/window toggle (F11) in EFL's MiniBrowser, I've noticed there is no way other than using JS to request full screen view. This bug intends to implement a method to allow UIProcess (i.e. a user command flag or keyboard key associated to fullscreen toggle) to request full screen view to WebProcess, which handles the necessary user authorization request (accept/deny). The workflow works like this: 1. UIProcess generates a call to WebFullScreenManagerProxy::requestEnterFullScreen() 2. WebFullScreenManagerProxy::requestEnterFullScreen() sends a message to WebProcess' WebFullScreenManager::requestEnterFullScreen() 3. The latter calls a public function from its own class WebFullScreenManager::enterFullScreenForElement(element), with element being the core page's element document. 4. User authorization modal dialog shows as expected, with accept/deny callbacks correctly toggling fullscreen/window modes. Besides that, the already-implemented WebProcess' WebFullScreenManager::requestExitFullScreen() has been modified to use exitEnterFullScreen() (which uses InjectedBundle's code), following code design and avoiding issues when fullscreen was called from JS (clicking on 'deny' wasn't actually triggering window mode). 818188 1 185083 bruno.abinader 2013-01-28 15:32:28 -0800 Created attachment 185083 Patch Proposed patch 818228 2 185083 jer.noble 2013-01-28 16:07:46 -0800 Comment on attachment 185083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185083&action=review Overall, the addition of requestEnterFullScreen() looks good, but I recommend a r- due to the change to requestExitFullScreen. > Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:147 > +void WebFullScreenManager::requestEnterFullScreen() > +{ > + // Default to document.documentElement(). > + enterFullScreenForElement(m_page->corePage()->mainFrame()->document()->documentElement()); > +} > + LGTM. In the future, clients may want some way to specify which element they'd like to be the full-screen one (instead of documentElement()), but this is good for now. > Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:151 > - m_element->document()->webkitCancelFullScreen(); > + exitFullScreenForElement(m_element.get()); By not calling webkitCancelFullScreen(), I believe the contents of m_fullScreenElement and m_fullScreenElementStack won't be modified, which is not desirable. If you're not getting an exitFullScreenForElement() in response, it's probably because the element wasn't in full screen to begin with, and you'll have to handle that case explicitly in the UIProcess. 818247 3 185097 bruno.abinader 2013-01-28 16:29:08 -0800 Created attachment 185097 Patch Removed changes on requestExitFullScreen as reviewed by Jer Noble. 818265 4 jer.noble 2013-01-28 16:48:14 -0800 (In reply to comment #3) > Created an attachment (id=185097) [details] > Patch > > Removed changes on requestExitFullScreen as reviewed by Jer Noble. Unofficial r+. 818310 5 eric 2013-01-28 17:33:49 -0800 I'm not a webkit2 owner, you'll have to deal with them. 818389 6 185097 benjamin 2013-01-28 18:58:56 -0800 Comment on attachment 185097 Patch -Not really an explanation for why that is needed. -The fullscreen element is always the documentElement, that is not what the Fullscreen API is for. -No test. 818395 7 benjamin 2013-01-28 19:04:43 -0800 (In reply to comment #0) > While implementing fullscreen/window toggle (F11) in EFL's MiniBrowser, I've noticed there is no way other than using JS to request full screen view. This bug intends to implement a method to allow UIProcess (i.e. a user command flag or keyboard key associated to fullscreen toggle) to request full screen view to WebProcess, which handles the necessary user authorization request (accept/deny). The workflow works like this: It looks like you are mixing two concepts. The fullscreen API and the browser ability to run fullscreen. You do not need the Web Fullscreen API to show your browser fullscreen. You can just use your native functions to take the View and put it fullscreen. By abusing the Web Fullscreen API, you are altering the page state (the fullscreen extensions to the Document element) and you give a way for a page to get out of fullscreen. 818412 8 bruno.abinader 2013-01-28 19:46:40 -0800 (In reply to comment #7) > (In reply to comment #0) > > While implementing fullscreen/window toggle (F11) in EFL's MiniBrowser, I've noticed there is no way other than using JS to request full screen view. This bug intends to implement a method to allow UIProcess (i.e. a user command flag or keyboard key associated to fullscreen toggle) to request full screen view to WebProcess, which handles the necessary user authorization request (accept/deny). The workflow works like this: > > It looks like you are mixing two concepts. The fullscreen API and the browser ability to run fullscreen. > > You do not need the Web Fullscreen API to show your browser fullscreen. You can just use your native functions to take the View and put it fullscreen. I understand one can simply call the platform's native API to enter fullscreen mode, however, as Jer mentioned, the CSS ComputedStyles does not get updated when this occurs. Indeed the current implementation is buggy in a sense that the Document fullscreen elements stack is not updated, this is what I'm planning to fix on the following patch. > > By abusing the Web Fullscreen API, you are altering the page state (the fullscreen extensions to the Document element) and you give a way for a page to get out of fullscreen. Isn't the page state supposed to be changed after we toggle fullscreen mode (i.e. activate CSS :fullscreen pseudo-class)? 818415 9 185135 bruno.abinader 2013-01-28 19:51:19 -0800 Created attachment 185135 Patch Now using Document::requestFullScreenForElement for proper fullscreen element stack treatment. 818429 10 185135 benjamin 2013-01-28 20:09:20 -0800 Comment on attachment 185135 Patch Not addressed my concerns. No tests. 818866 11 bruno.abinader 2013-01-29 05:48:50 -0800 (In reply to comment #10) > (From update of attachment 185135 [details]) > Not addressed my concerns. > No tests. OK, let me try to clarify: Currently on Google Chrome, for instance, if you press the F11 key to go fullscreen mode, the document element is not notified, thus document.webkitIsFullScreen returns 'false' (you can verify this by going fullscreen on this example page - http://johndyer.name/lab/fullscreenapi/ ). My idea is to take advantage of the FullScreen API internals to provide proper style updates. By using only native API to provide fullscreen mode, I've noticed that at least for EFL platform, the app gets unexpected behavior when switching back to window mode. As you mentioned, yes, the document element is always the fullscreen element, this is why Document::requestEnterFullScreenForElement() sets documentElement() if 'element' parameter is invalid. I'm working on providing tests for this addition, but most important now is to have your opinion on the idea, or even suggest another approach other than using only native API. If this is still not desired, we can of course abort this patch submission. 818884 12 tmpsantos 2013-01-29 06:07:15 -0800 (In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 185135 [details] [details]) > > Not addressed my concerns. > > No tests. > > OK, let me try to clarify: > > Currently on Google Chrome, for instance, if you press the F11 key to go fullscreen mode, the document element is not notified, thus document.webkitIsFullScreen returns 'false' (you can verify this by going fullscreen on this example page - http://johndyer.name/lab/fullscreenapi/ ). My idea is to take advantage of the FullScreen API internals to provide proper style updates. By using only native API to provide fullscreen mode, I've noticed that at least for EFL platform, the app gets unexpected behavior when switching back to window mode. > > As you mentioned, yes, the document element is always the fullscreen element, this is why Document::requestEnterFullScreenForElement() sets documentElement() if 'element' parameter is invalid. > > I'm working on providing tests for this addition, but most important now is to have your opinion on the idea, or even suggest another approach other than using only native API. If this is still not desired, we can of course abort this patch submission. Let's think about this from a WebApp standpoint: the WebApp won't go to fullscreen unless it wants to go fullscreen. Going further and comparing this use case with a native app, there is no way of the window manager forcing your, let's say, IRC client, to go fullscreen. If think the current behavior is correct: if the browser goes fullscreen, it is a resize from the WebApp perspective. Think your browser as a window manager: the WebApp might ask it to go fullscreen, but not the other way around. 818887 13 tmpsantos 2013-01-29 06:15:45 -0800 To complement: I'm myself a user of Chromium fullscreen sometimes (specially on netbooks). I would find it very very weird if I start to see websites changing their appearance because of that. 818889 14 bruno.abinader 2013-01-29 06:17:40 -0800 (In reply to comment #12) > Let's think about this from a WebApp standpoint: the WebApp won't go to fullscreen unless it wants to go fullscreen. Going further and comparing this use case with a native app, there is no way of the window manager forcing your, let's say, IRC client, to go fullscreen. > > If think the current behavior is correct: if the browser goes fullscreen, it is a resize from the WebApp perspective. Think your browser as a window manager: the WebApp might ask it to go fullscreen, but not the other way around. Fair enough, as we discussed on IRC it is not up to the browser to decide for the WebApp to apply its fullscreen styles or not. However, from the debugging point of view, would it still have a chance as a debugging setting one can set up to force fullscreen style to be shown? Otherwise I agree we can skip this change. 820743 15 benjamin 2013-01-30 16:02:55 -0800 > Fair enough, as we discussed on IRC it is not up to the browser to decide for the WebApp to apply its fullscreen styles or not. Like Thiago, I think this particular approach is not going to fly. Web Fullscreen API is a weird little spec with special use cases and I would be cautious abusing it. BUT, I think you have an interesting idea that a webpage may be interested in knowing if it is going fullscreen. If you have solid use cases, that is worth raising the issue to the W3C. > However, from the debugging point of view, would it still have a chance as a debugging setting one can set up to force fullscreen style to be shown? Otherwise I agree we can skip this change. Any code has a cost. I don't think is worth is. It is already easy to debug fullscreen APIs. 820796 16 bruno.abinader 2013-01-30 16:42:12 -0800 (In reply to comment #15) > > However, from the debugging point of view, would it still have a chance as a debugging setting one can set up to force fullscreen style to be shown? Otherwise I agree we can skip this change. > > Any code has a cost. I don't think is worth is. It is already easy to debug fullscreen APIs. Indeed, a couple JS calls can do the job. Thanks for the insightful discussion! 185083 2013-01-28 15:32:28 -0800 2013-01-28 16:29:04 -0800 Patch bug-108121-20130128192914.patch text/plain 5273 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjI5MzM2MjNjODVkZDNh NzZkNWIyMGE4N2YwNzc5YTVhMGFmYzMwYS4uOGVmZTFiMmM5MGQ1MzhmYWQ5MDJhYTQ0OTViYTli MTMzYzY2ZjFjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAxLTI4ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbV0syXSBFbmFibGUgZnVsbHNjcmVlbiByZXF1ZXN0IGZyb20gVUlQcm9jZXNzIChp LmUuIHVzZXIgY29tbWFuZCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwODEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudHMgYSBtZXRob2QgdG8gYWxsb3cgVUlQcm9jZXNzIChpLmUuIGEg dXNlciBjb21tYW5kCisgICAgICAgIGZsYWcgb3Iga2V5Ym9hcmQga2V5IGFzc29jaWF0ZWQgdG8g ZnVsbHNjcmVlbiB0b2dnbGUpIHRvIHJlcXVlc3QKKyAgICAgICAgZnVsbHNjcmVlbiB2aWV3IHRv IFdlYlByb2Nlc3MsIHdoaWNoIGhhbmRsZXMgdGhlIG5lY2Vzc2FyeSB1c2VyCisgICAgICAgIGF1 dGhvcml6YXRpb24gcmVxdWVzdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJGdWxsU2NyZWVu TWFuYWdlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnVsbFNjcmVlbk1hbmFnZXJQ cm94eTo6cmVxdWVzdEVudGVyRnVsbFNjcmVlbik6IEFkZGVkIGZ1bmN0aW9uLgorICAgICAgICAq IFVJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5Lmg6CisgICAgICAgIChXZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5KTogQWRkZWQgcmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLgorICAg ICAgICAqIFdlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYkZ1bGxTY3JlZW5NYW5hZ2VyOjpyZXF1ZXN0RW50ZXJGdWxsU2Ny ZWVuKTogQWRkZWQgZnVuY3Rpb24uCisgICAgICAgIChXZWJLaXQ6OldlYkZ1bGxTY3JlZW5NYW5h Z2VyOjpyZXF1ZXN0RXhpdEZ1bGxTY3JlZW4pOiBVc2luZyBidWlsdC1pbiBleGl0RW50ZXJGdWxs U2NyZWVuRWxlbWVudChlbGVtZW50KSBmdW5jdGlvbi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0Z1 bGxTY3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuaDogQWRkZWQgcmVxdWVzdEVudGVyRnVsbFNj cmVlbigpLgorICAgICAgICAoV2ViRnVsbFNjcmVlbk1hbmFnZXIpOgorICAgICAgICAqIFdlYlBy b2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5tZXNzYWdlcy5pbjogQWRkZWQg cmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLgorCiAyMDEzLTAxLTI4ICBSZW5hdGEgSG9kb3ZhbiAg PHJlbmlAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW1dpbl1bV0syXSBCdWlsZCBmaXggYWZ0 ZXIgcjE0MDk1Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5LmNwcAppbmRleCBlNDlhZDg2ZWZjZTcwNzhjY2EwNmExYmIzNjA2 OWNiMDU2MjdkZTg1Li4xZDk2ZjhiMDk0NzUxZWNiM2I2NzhiZGQyOTM5YzAwODcwZGU0Y2YwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnVsbFNjcmVlbk1hbmFnZXJQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5h Z2VyUHJveHkuY3BwCkBAIC04OSw2ICs4OSwxMSBAQCB2b2lkIFdlYkZ1bGxTY3JlZW5NYW5hZ2Vy UHJveHk6OnNldEFuaW1hdGluZ0Z1bGxTY3JlZW4oYm9vbCBhbmltYXRpbmcpCiAgICAgbV9wYWdl LT5wcm9jZXNzKCktPnNlbmQoTWVzc2FnZXM6OldlYkZ1bGxTY3JlZW5NYW5hZ2VyOjpTZXRBbmlt YXRpbmdGdWxsU2NyZWVuKGFuaW1hdGluZyksIG1fcGFnZS0+cGFnZUlEKCkpOwogfQogCit2b2lk IFdlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHk6OnJlcXVlc3RFbnRlckZ1bGxTY3JlZW4oKQorewor ICAgIG1fcGFnZS0+cHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJGdWxsU2NyZWVuTWFuYWdl cjo6UmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLCBtX3BhZ2UtPnBhZ2VJRCgpKTsKK30KKwogdm9p ZCBXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5OjpyZXF1ZXN0RXhpdEZ1bGxTY3JlZW4oKQogewog ICAgIG1fcGFnZS0+cHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJGdWxsU2NyZWVuTWFuYWdl cjo6UmVxdWVzdEV4aXRGdWxsU2NyZWVuKCksIG1fcGFnZS0+cGFnZUlEKCkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5LmgKaW5k ZXggMWZhMmVlODliMThhNzBlZTc0Mzg3YzYzMTUwM2M4MDQ2NzJjZGU2ZC4uMGRlOTQ4ZTkxZjU3 YTAyMDRjM2E5MTlhYzAwMmI0NmZkNzM2M2MzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eS5oCkBAIC04NCw2ICs4NCw3IEBA IHB1YmxpYzoKICAgICB2b2lkIHdpbGxFeGl0RnVsbFNjcmVlbigpOwogICAgIHZvaWQgZGlkRXhp dEZ1bGxTY3JlZW4oKTsKICAgICB2b2lkIHNldEFuaW1hdGluZ0Z1bGxTY3JlZW4oYm9vbCk7Cisg ICAgdm9pZCByZXF1ZXN0RW50ZXJGdWxsU2NyZWVuKCk7CiAgICAgdm9pZCByZXF1ZXN0RXhpdEZ1 bGxTY3JlZW4oKTsKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuY3BwCmluZGV4IDlj MDBkMjgxZTk0NWNiMjMzZjVkMjkwMzFjOGM4M2M1Zjg2ZTcxYTkuLmRhMzYzMzVlY2UwMjUwZGVm ODYwNzY4N2RjOTIwMjM5ZjQ3MTc2M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmNwcApAQCAt MTM5LDEwICsxMzksMTYgQEAgdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlcjo6c2V0QW5pbWF0aW5n RnVsbFNjcmVlbihib29sIGFuaW1hdGluZykKICAgICBtX2VsZW1lbnQtPmRvY3VtZW50KCktPnNl dEFuaW1hdGluZ0Z1bGxTY3JlZW4oYW5pbWF0aW5nKTsKIH0KIAordm9pZCBXZWJGdWxsU2NyZWVu TWFuYWdlcjo6cmVxdWVzdEVudGVyRnVsbFNjcmVlbigpCit7CisgICAgLy8gRGVmYXVsdCB0byBk b2N1bWVudC5kb2N1bWVudEVsZW1lbnQoKS4KKyAgICBlbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50 KG1fcGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCktPmRvY3VtZW50RWxl bWVudCgpKTsKK30KKwogdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlcjo6cmVxdWVzdEV4aXRGdWxs U2NyZWVuKCkKIHsKICAgICBBU1NFUlQobV9lbGVtZW50KTsKLSAgICBtX2VsZW1lbnQtPmRvY3Vt ZW50KCktPndlYmtpdENhbmNlbEZ1bGxTY3JlZW4oKTsKKyAgICBleGl0RnVsbFNjcmVlbkZvckVs ZW1lbnQobV9lbGVtZW50LmdldCgpKTsKIH0KIAogdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlcjo6 Y2xvc2UoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVu L1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxT Y3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuaAppbmRleCA4YzA0OTIyNWI4YzEzNTZiYmVmNjBh MGQ1OTQxNjA3ZDA2N2FhYTRlLi41NDUwYjE3YzEyZWI5NDE4YmIxYTcwYTczODkwMmRlMWRjZDIx Yjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2Vi RnVsbFNjcmVlbk1hbmFnZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxT Y3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuaApAQCAtNzEsNiArNzEsNyBAQCBwcm90ZWN0ZWQ6 CiAgICAgV2ViRnVsbFNjcmVlbk1hbmFnZXIoV2ViUGFnZSopOwogCiAgICAgdm9pZCBzZXRBbmlt YXRpbmdGdWxsU2NyZWVuKGJvb2wpOworICAgIHZvaWQgcmVxdWVzdEVudGVyRnVsbFNjcmVlbigp OwogICAgIHZvaWQgcmVxdWVzdEV4aXRGdWxsU2NyZWVuKCk7CiAKICAgICB2b2lkIGRpZFJlY2Vp dmVXZWJGdWxsU2NyZWVuTWFuYWdlck1lc3NhZ2UoQ29yZUlQQzo6Q29ubmVjdGlvbiosIENvcmVJ UEM6Ok1lc3NhZ2VJRCwgQ29yZUlQQzo6TWVzc2FnZURlY29kZXImKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5t ZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxs U2NyZWVuTWFuYWdlci5tZXNzYWdlcy5pbgppbmRleCBmNGUwYWZiMmJmMGU0YWYyZmE4MzcxNWQx NTNiZGE2MDA3NDA5MGI3Li40OTg5N2FmMmJlN2Q2M2ZhNTIyNzQ4ZTc5NmRmMWZmYjA2MTJkN2U2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVs bFNjcmVlbk1hbmFnZXIubWVzc2FnZXMuaW4KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLm1lc3NhZ2VzLmluCkBAIC0yMiw2ICsy Miw3IEBACiAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiBtZXNzYWdlcyAtPiBXZWJGdWxs U2NyZWVuTWFuYWdlciBMZWdhY3lSZWNlaXZlciB7CisgICAgUmVxdWVzdEVudGVyRnVsbFNjcmVl bigpCiAgICAgUmVxdWVzdEV4aXRGdWxsU2NyZWVuKCkKICAgICBXaWxsRW50ZXJGdWxsU2NyZWVu KCkKICAgICBEaWRFbnRlckZ1bGxTY3JlZW4oKQo= 185097 2013-01-28 16:29:08 -0800 2013-01-28 19:51:15 -0800 Patch bug-108121-20130128202554.patch text/plain 5004 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjI5MzM2MjNjODVkZDNh NzZkNWIyMGE4N2YwNzc5YTVhMGFmYzMwYS4uNzlkYjhmMzUyZWRhODRiOTE5NTY4MDRmYjZjZmZk YWVhOTQ5OTFkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAxLTI4ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbV0syXSBFbmFibGUgZnVsbHNjcmVlbiByZXF1ZXN0IGZyb20gVUlQcm9jZXNzIChp LmUuIHVzZXIgY29tbWFuZCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwODEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudHMgYSBtZXRob2QgdG8gYWxsb3cgVUlQcm9jZXNzIChpLmUuIGEg dXNlciBjb21tYW5kCisgICAgICAgIGZsYWcgb3Iga2V5Ym9hcmQga2V5IGFzc29jaWF0ZWQgdG8g ZnVsbHNjcmVlbiB0b2dnbGUpIHRvIHJlcXVlc3QKKyAgICAgICAgZnVsbHNjcmVlbiB2aWV3IHRv IFdlYlByb2Nlc3MsIHdoaWNoIGhhbmRsZXMgdGhlIG5lY2Vzc2FyeSB1c2VyCisgICAgICAgIGF1 dGhvcml6YXRpb24gcmVxdWVzdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJGdWxsU2NyZWVu TWFuYWdlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnVsbFNjcmVlbk1hbmFnZXJQ cm94eTo6cmVxdWVzdEVudGVyRnVsbFNjcmVlbik6IEFkZGVkIGZ1bmN0aW9uLgorICAgICAgICAq IFVJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5Lmg6CisgICAgICAgIChXZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5KTogQWRkZWQgcmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLgorICAg ICAgICAqIFdlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYkZ1bGxTY3JlZW5NYW5hZ2VyOjpyZXF1ZXN0RW50ZXJGdWxsU2Ny ZWVuKTogQWRkZWQgZnVuY3Rpb24uCisgICAgICAgICogV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dl YkZ1bGxTY3JlZW5NYW5hZ2VyLmg6IEFkZGVkIHJlcXVlc3RFbnRlckZ1bGxTY3JlZW4oKS4KKyAg ICAgICAgKFdlYkZ1bGxTY3JlZW5NYW5hZ2VyKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL0Z1bGxT Y3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIubWVzc2FnZXMuaW46IEFkZGVkIHJlcXVlc3RFbnRl ckZ1bGxTY3JlZW4oKS4KKwogMjAxMy0wMS0yOCAgUmVuYXRhIEhvZG92YW4gIDxyZW5pQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW1F0XVtXaW5dW1dLMl0gQnVpbGQgZml4IGFmdGVyIHIxNDA5NTcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnVsbFNjcmVlbk1hbmFn ZXJQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnVsbFNjcmVlbk1hbmFn ZXJQcm94eS5jcHAKaW5kZXggZTQ5YWQ4NmVmY2U3MDc4Y2NhMDZhMWJiMzYwNjljYjA1NjI3ZGU4 NS4uMWQ5NmY4YjA5NDc1MWVjYjNiNjc4YmRkMjkzOWMwMDg3MGRlNGNmMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5LmNw cApAQCAtODksNiArODksMTEgQEAgdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5OjpzZXRB bmltYXRpbmdGdWxsU2NyZWVuKGJvb2wgYW5pbWF0aW5nKQogICAgIG1fcGFnZS0+cHJvY2Vzcygp LT5zZW5kKE1lc3NhZ2VzOjpXZWJGdWxsU2NyZWVuTWFuYWdlcjo6U2V0QW5pbWF0aW5nRnVsbFNj cmVlbihhbmltYXRpbmcpLCBtX3BhZ2UtPnBhZ2VJRCgpKTsKIH0KIAordm9pZCBXZWJGdWxsU2Ny ZWVuTWFuYWdlclByb3h5OjpyZXF1ZXN0RW50ZXJGdWxsU2NyZWVuKCkKK3sKKyAgICBtX3BhZ2Ut PnByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViRnVsbFNjcmVlbk1hbmFnZXI6OlJlcXVlc3RF bnRlckZ1bGxTY3JlZW4oKSwgbV9wYWdlLT5wYWdlSUQoKSk7Cit9CisKIHZvaWQgV2ViRnVsbFNj cmVlbk1hbmFnZXJQcm94eTo6cmVxdWVzdEV4aXRGdWxsU2NyZWVuKCkKIHsKICAgICBtX3BhZ2Ut PnByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViRnVsbFNjcmVlbk1hbmFnZXI6OlJlcXVlc3RF eGl0RnVsbFNjcmVlbigpLCBtX3BhZ2UtPnBhZ2VJRCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5LmggYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eS5oCmluZGV4IDFmYTJlZTg5 YjE4YTcwZWU3NDM4N2M2MzE1MDNjODA0NjcyY2RlNmQuLjBkZTk0OGU5MWY1N2EwMjA0YzNhOTE5 YWMwMDJiNDZmZDczNjNjM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkuaApAQCAtODQsNiArODQsNyBAQCBwdWJsaWM6CiAg ICAgdm9pZCB3aWxsRXhpdEZ1bGxTY3JlZW4oKTsKICAgICB2b2lkIGRpZEV4aXRGdWxsU2NyZWVu KCk7CiAgICAgdm9pZCBzZXRBbmltYXRpbmdGdWxsU2NyZWVuKGJvb2wpOworICAgIHZvaWQgcmVx dWVzdEVudGVyRnVsbFNjcmVlbigpOwogICAgIHZvaWQgcmVxdWVzdEV4aXRGdWxsU2NyZWVuKCk7 CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxT Y3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmNwcAppbmRleCA5YzAwZDI4MWU5NDVj YjIzM2Y1ZDI5MDMxYzhjODNjNWY4NmU3MWE5Li4xMzYxMDVkZWY5MDU1YzIzM2FiNGZiNmQyMWJi ZTI0M2RkOWNlZWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxT Y3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHAKQEAgLTEzOSw2ICsxMzks MTIgQEAgdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlcjo6c2V0QW5pbWF0aW5nRnVsbFNjcmVlbihi b29sIGFuaW1hdGluZykKICAgICBtX2VsZW1lbnQtPmRvY3VtZW50KCktPnNldEFuaW1hdGluZ0Z1 bGxTY3JlZW4oYW5pbWF0aW5nKTsKIH0KIAordm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlcjo6cmVx dWVzdEVudGVyRnVsbFNjcmVlbigpCit7CisgICAgLy8gRGVmYXVsdCB0byBkb2N1bWVudC5kb2N1 bWVudEVsZW1lbnQoKS4KKyAgICBlbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KG1fcGFnZS0+Y29y ZVBhZ2UoKS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCktPmRvY3VtZW50RWxlbWVudCgpKTsKK30K Kwogdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlcjo6cmVxdWVzdEV4aXRGdWxsU2NyZWVuKCkKIHsK ICAgICBBU1NFUlQobV9lbGVtZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5oIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmgKaW5kZXggOGMwNDky MjViOGMxMzU2YmJlZjYwYTBkNTk0MTYwN2QwNjdhYWE0ZS4uNTQ1MGIxN2MxMmViOTQxOGJiMWE3 MGE3Mzg5MDJkZTFkY2QyMWI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmgKQEAgLTcxLDYgKzcx LDcgQEAgcHJvdGVjdGVkOgogICAgIFdlYkZ1bGxTY3JlZW5NYW5hZ2VyKFdlYlBhZ2UqKTsKIAog ICAgIHZvaWQgc2V0QW5pbWF0aW5nRnVsbFNjcmVlbihib29sKTsKKyAgICB2b2lkIHJlcXVlc3RF bnRlckZ1bGxTY3JlZW4oKTsKICAgICB2b2lkIHJlcXVlc3RFeGl0RnVsbFNjcmVlbigpOwogCiAg ICAgdm9pZCBkaWRSZWNlaXZlV2ViRnVsbFNjcmVlbk1hbmFnZXJNZXNzYWdlKENvcmVJUEM6OkNv bm5lY3Rpb24qLCBDb3JlSVBDOjpNZXNzYWdlSUQsIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVs bFNjcmVlbk1hbmFnZXIubWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1 bGxTY3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIubWVzc2FnZXMuaW4KaW5kZXggZjRlMGFmYjJi ZjBlNGFmMmZhODM3MTVkMTUzYmRhNjAwNzQwOTBiNy4uNDk4OTdhZjJiZTdkNjNmYTUyMjc0OGU3 OTZkZjFmZmIwNjEyZDdlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9G dWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5tZXNzYWdl cy5pbgpAQCAtMjIsNiArMjIsNyBAQAogCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogbWVz c2FnZXMgLT4gV2ViRnVsbFNjcmVlbk1hbmFnZXIgTGVnYWN5UmVjZWl2ZXIgeworICAgIFJlcXVl c3RFbnRlckZ1bGxTY3JlZW4oKQogICAgIFJlcXVlc3RFeGl0RnVsbFNjcmVlbigpCiAgICAgV2ls bEVudGVyRnVsbFNjcmVlbigpCiAgICAgRGlkRW50ZXJGdWxsU2NyZWVuKCkK 185135 2013-01-28 19:51:19 -0800 2013-01-28 20:09:19 -0800 Patch bug-108121-20130128234805.patch text/plain 5268 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjI5MzM2MjNjODVkZDNh NzZkNWIyMGE4N2YwNzc5YTVhMGFmYzMwYS4uNmRlMmI4Y2ViOGRhMGMwOWFlZDcxYmM1YWE4YzIy ZjdhNWFmMjZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAxLTI4ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbV0syXSBFbmFibGUgZnVsbHNjcmVlbiByZXF1ZXN0IGZyb20gVUlQcm9jZXNzIChp LmUuIHVzZXIgY29tbWFuZCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwODEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudHMgYSBtZXRob2QgdG8gYWxsb3cgVUlQcm9jZXNzIChpLmUuIGEg dXNlciBjb21tYW5kCisgICAgICAgIGZsYWcgb3Iga2V5Ym9hcmQga2V5IGFzc29jaWF0ZWQgdG8g ZnVsbHNjcmVlbiB0b2dnbGUpIHRvIHJlcXVlc3QKKyAgICAgICAgZnVsbHNjcmVlbiB2aWV3Lgor CisgICAgICAgICogVUlQcm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5OjpyZXF1ZXN0RW50ZXJGdWxs U2NyZWVuKTogQWRkZWQgZnVuY3Rpb24uCisgICAgICAgICogVUlQcm9jZXNzL1dlYkZ1bGxTY3Jl ZW5NYW5hZ2VyUHJveHkuaDoKKyAgICAgICAgKFdlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkpOiBB ZGRlZCByZXF1ZXN0RW50ZXJGdWxsU2NyZWVuKCkuCisgICAgICAgICogV2ViUHJvY2Vzcy9GdWxs U2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnVs bFNjcmVlbk1hbmFnZXI6OnJlcXVlc3RFbnRlckZ1bGxTY3JlZW4pOiBBZGRlZCBmdW5jdGlvbi4K KyAgICAgICAgKiBXZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuaDog QWRkZWQgcmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLgorICAgICAgICAoV2ViRnVsbFNjcmVlbk1h bmFnZXIpOgorICAgICAgICAqIFdlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFu YWdlci5tZXNzYWdlcy5pbjogQWRkZWQgcmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLgorCiAyMDEz LTAxLTI4ICBSZW5hdGEgSG9kb3ZhbiAgPHJlbmlAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRd W1dpbl1bV0syXSBCdWlsZCBmaXggYWZ0ZXIgcjE0MDk1Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5LmNwcAppbmRleCBlNDlh ZDg2ZWZjZTcwNzhjY2EwNmExYmIzNjA2OWNiMDU2MjdkZTg1Li4xZDk2ZjhiMDk0NzUxZWNiM2I2 NzhiZGQyOTM5YzAwODcwZGU0Y2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHkuY3BwCkBAIC04OSw2ICs4OSwxMSBAQCB2 b2lkIFdlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHk6OnNldEFuaW1hdGluZ0Z1bGxTY3JlZW4oYm9v bCBhbmltYXRpbmcpCiAgICAgbV9wYWdlLT5wcm9jZXNzKCktPnNlbmQoTWVzc2FnZXM6OldlYkZ1 bGxTY3JlZW5NYW5hZ2VyOjpTZXRBbmltYXRpbmdGdWxsU2NyZWVuKGFuaW1hdGluZyksIG1fcGFn ZS0+cGFnZUlEKCkpOwogfQogCit2b2lkIFdlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHk6OnJlcXVl c3RFbnRlckZ1bGxTY3JlZW4oKQoreworICAgIG1fcGFnZS0+cHJvY2VzcygpLT5zZW5kKE1lc3Nh Z2VzOjpXZWJGdWxsU2NyZWVuTWFuYWdlcjo6UmVxdWVzdEVudGVyRnVsbFNjcmVlbigpLCBtX3Bh Z2UtPnBhZ2VJRCgpKTsKK30KKwogdm9pZCBXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5OjpyZXF1 ZXN0RXhpdEZ1bGxTY3JlZW4oKQogewogICAgIG1fcGFnZS0+cHJvY2VzcygpLT5zZW5kKE1lc3Nh Z2VzOjpXZWJGdWxsU2NyZWVuTWFuYWdlcjo6UmVxdWVzdEV4aXRGdWxsU2NyZWVuKCksIG1fcGFn ZS0+cGFnZUlEKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZ1 bGxTY3JlZW5NYW5hZ2VyUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5LmgKaW5kZXggMWZhMmVlODliMThhNzBlZTc0Mzg3YzYzMTUwM2M4 MDQ2NzJjZGU2ZC4uMGRlOTQ4ZTkxZjU3YTAyMDRjM2E5MTlhYzAwMmI0NmZkNzM2M2MzZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJv eHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnVsbFNjcmVlbk1hbmFnZXJQ cm94eS5oCkBAIC04NCw2ICs4NCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHdpbGxFeGl0RnVsbFNj cmVlbigpOwogICAgIHZvaWQgZGlkRXhpdEZ1bGxTY3JlZW4oKTsKICAgICB2b2lkIHNldEFuaW1h dGluZ0Z1bGxTY3JlZW4oYm9vbCk7CisgICAgdm9pZCByZXF1ZXN0RW50ZXJGdWxsU2NyZWVuKCk7 CiAgICAgdm9pZCByZXF1ZXN0RXhpdEZ1bGxTY3JlZW4oKTsKIAogcHJpdmF0ZToKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFu YWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVsbFNj cmVlbk1hbmFnZXIuY3BwCmluZGV4IDljMDBkMjgxZTk0NWNiMjMzZjVkMjkwMzFjOGM4M2M1Zjg2 ZTcxYTkuLjQ0NzE5OTQ0MWFiZjFjZjkzNzFkMWQyM2UyYmI1MjMzY2RiMTVlM2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFu YWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1 bGxTY3JlZW5NYW5hZ2VyLmNwcApAQCAtNDAsNiArNDAsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUv UmVuZGVyT2JqZWN0Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZW5kZXJWaWV3Lmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9TZXR0aW5ncy5oPgorI2luY2x1ZGUgPFdlYkNvcmUvZG9tL1VzZXJHZXN0dXJl SW5kaWNhdG9yLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC0xMzksNiArMTQw LDEzIEBAIHZvaWQgV2ViRnVsbFNjcmVlbk1hbmFnZXI6OnNldEFuaW1hdGluZ0Z1bGxTY3JlZW4o Ym9vbCBhbmltYXRpbmcpCiAgICAgbV9lbGVtZW50LT5kb2N1bWVudCgpLT5zZXRBbmltYXRpbmdG dWxsU2NyZWVuKGFuaW1hdGluZyk7CiB9CiAKK3ZvaWQgV2ViRnVsbFNjcmVlbk1hbmFnZXI6OnJl cXVlc3RFbnRlckZ1bGxTY3JlZW4oKQoreworICAgIFVzZXJHZXN0dXJlSW5kaWNhdG9yIGdlc3R1 cmVJbmRpY2F0b3IoRGVmaW5pdGVseVByb2Nlc3NpbmdVc2VyR2VzdHVyZSk7CisgICAgUmVmUHRy PFdlYkNvcmU6OkRvY3VtZW50PiBkb2N1bWVudCA9IG1fcGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZy YW1lKCktPmRvY3VtZW50KCk7CisgICAgZG9jdW1lbnQtPnJlcXVlc3RGdWxsU2NyZWVuRm9yRWxl bWVudCgwLCBFbGVtZW50OjpBTExPV19LRVlCT0FSRF9JTlBVVCwgRG9jdW1lbnQ6OkV4ZW1wdElG cmFtZUFsbG93RnVsbFNjcmVlblJlcXVpcmVtZW50KTsKK30KKwogdm9pZCBXZWJGdWxsU2NyZWVu TWFuYWdlcjo6cmVxdWVzdEV4aXRGdWxsU2NyZWVuKCkKIHsKICAgICBBU1NFUlQobV9lbGVtZW50 KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVsbFNjcmVlbi9XZWJG dWxsU2NyZWVuTWFuYWdlci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVu L1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmgKaW5kZXggOGMwNDkyMjViOGMxMzU2YmJlZjYwYTBkNTk0 MTYwN2QwNjdhYWE0ZS4uNTQ1MGIxN2MxMmViOTQxOGJiMWE3MGE3Mzg5MDJkZTFkY2QyMWI4NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxT Y3JlZW5NYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVu L1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmgKQEAgLTcxLDYgKzcxLDcgQEAgcHJvdGVjdGVkOgogICAg IFdlYkZ1bGxTY3JlZW5NYW5hZ2VyKFdlYlBhZ2UqKTsKIAogICAgIHZvaWQgc2V0QW5pbWF0aW5n RnVsbFNjcmVlbihib29sKTsKKyAgICB2b2lkIHJlcXVlc3RFbnRlckZ1bGxTY3JlZW4oKTsKICAg ICB2b2lkIHJlcXVlc3RFeGl0RnVsbFNjcmVlbigpOwogCiAgICAgdm9pZCBkaWRSZWNlaXZlV2Vi RnVsbFNjcmVlbk1hbmFnZXJNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3JlSVBDOjpN ZXNzYWdlSUQsIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJik7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIubWVzc2Fn ZXMuaW4gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Z1bGxTY3JlZW4vV2ViRnVsbFNjcmVl bk1hbmFnZXIubWVzc2FnZXMuaW4KaW5kZXggZjRlMGFmYjJiZjBlNGFmMmZhODM3MTVkMTUzYmRh NjAwNzQwOTBiNy4uNDk4OTdhZjJiZTdkNjNmYTUyMjc0OGU3OTZkZjFmZmIwNjEyZDdlNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3Jl ZW5NYW5hZ2VyLm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRnVs bFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5tZXNzYWdlcy5pbgpAQCAtMjIsNiArMjIsNyBA QAogCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogbWVzc2FnZXMgLT4gV2ViRnVsbFNjcmVl bk1hbmFnZXIgTGVnYWN5UmVjZWl2ZXIgeworICAgIFJlcXVlc3RFbnRlckZ1bGxTY3JlZW4oKQog ICAgIFJlcXVlc3RFeGl0RnVsbFNjcmVlbigpCiAgICAgV2lsbEVudGVyRnVsbFNjcmVlbigpCiAg ICAgRGlkRW50ZXJGdWxsU2NyZWVuKCkK