108101 2013-01-28 12:32:39 -0800 PLATFORM(IOS) should come before __MAC_OS_X_VERSION_MIN_REQUIRED 2013-01-28 16:20:10 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ddkilzer psolanki oldest_to_newest 817986 0 psolanki 2013-01-28 12:32:39 -0800 __MAC_OS_X_VERSION_MIN_REQUIRED is not defined on iOS so code like the following fails to achieve its intended purpose #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 && !PLATFORM(IOS) It should be updated to #if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 817993 1 185036 psolanki 2013-01-28 12:36:08 -0800 Created attachment 185036 Patch 817998 2 ddkilzer 2013-01-28 12:38:18 -0800 I fixed this as a BUILD FIX in r140988. <http://trac.webkit.org/changeset/140988> 818001 3 psolanki 2013-01-28 12:40:11 -0800 Yup. This is fixed. 818004 4 psolanki 2013-01-28 12:42:30 -0800 Umm. r140988 doesn't cover all the cases. There's a few more places that need to be fixed. 818234 5 psolanki 2013-01-28 16:20:10 -0800 Committed r141025: <http://trac.webkit.org/changeset/141025> 185036 2013-01-28 12:36:08 -0800 2013-01-28 12:37:34 -0800 Patch bug-108101-20130128123255.patch text/plain 7012 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3ZWUzNjhiMGJjM2E4NDQ3Y2ZkNmVh OGRiOTFlYTFkZWRiNjM5YjIuLmIyNGY0Zjg2ZjE4NTVlZDg2YmM2YzE5ZTQzZDM5N2JlMTBkZDky MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDEtMjggIFByYXRpayBTb2xhbmtpICA8cHNv bGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFBMQVRGT1JNKElPUykgc2hvdWxkIGNvbWUgYmVm b3JlIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODEwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGlPUyBkb2VzIG5vdCBkZWZpbmUgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCwgYW55IHVzYWdlIG9mCisgICAgICAgIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgc2hvdWxkIGJlIGFmdGVyIGEgUExBVEZPUk0oSU9T KSBjaGVjay4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEzLTAxLTI3ICBMYXN6 bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0FORFJPSURdIEZp eCBhIHR5cG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMWM2OWJjNTZjMmEzNjA4MWJkYjVmOTkyYzQ0M2IyMWYz YjUxYzY1Li5mNzk2YTc0ODg5NTM1YTdiNDU5MmY1ZjRiODY0YTk4NTI2NjIwMzIxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDEtMjggIFByYXRpayBTb2xhbmtpICA8cHNvbGFu a2lAYXBwbGUuY29tPgorCisgICAgICAgIFBMQVRGT1JNKElPUykgc2hvdWxkIGNvbWUgYmVmb3Jl IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGlPUyBkb2VzIG5vdCBkZWZpbmUgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCwgYW55IHVzYWdlIG9mCisgICAgICAgIF9fTUFDX09T X1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgc2hvdWxkIGJlIGFmdGVyIGEgUExBVEZPUk0oSU9TKSBj aGVjay4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmg6 CisgICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UubW06CisKIDIw MTMtMDEtMjggIEphbWVzIENyYWlnICA8amFtZXNAY29va2llY3Jvb2suY29tPgogCiAgICAgICAg IEhUTUw1IHByb21vdGVzIERMIGZyb20gc3BlY2lmaWMgJ2RlZmluaXRpb24gbGlzdCcgdG8gc3Vw ZXJzZXQgJ2Rlc2NyaXB0aW9uIGxpc3QnOyBhY2Nlc3NpYmlsaXR5IHN0cmluZ3MgYW5kIGFjY2Vz c29ycyBzaG91bGQgYmUgdXBkYXRlZCB0byBtYXRjaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCA2Mzdh MjhjMjQ0MjYzZWNhODc5ZjMxYjMwNDI2NjEwNGM1YjM3Yzg4Li41YmQ1MGMyMjIwMmJjNTExZmJk YmIwYjA1ZTA2OTE3ZTU5N2NkZmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTMtMDEtMjggIFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAg ICAgIFBMQVRGT1JNKElPUykgc2hvdWxkIGNvbWUgYmVmb3JlIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwODEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNpbmNlIGlPUyBkb2VzIG5vdCBkZWZpbmUgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCwgYW55IHVzYWdlIG9mCisgICAgICAgIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgc2hvdWxkIGJlIGFmdGVyIGEgUExBVEZPUk0oSU9TKSBjaGVjay4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5tbToKKyAgICAgICAgKEluaXRXZWJDb3Jl U3lzdGVtSW50ZXJmYWNlKToKKwogMjAxMy0wMS0yNSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgV3JhcCBjb250ZW50IGZpbHRlcmluZyBjb2RlIGluIGFuIG9iamVj dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCmluZGV4IDYyOTMzNjIzYzg1ZGQzYTc2ZDViMjBhODdmMDc3OWE1YTBhZmMzMGEu LjkxMDUzYTRjYWE3MDhiNjAzYzJhZjA1OGUzNTA0Y2FiZDAxMTI1M2UgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMy0wMS0yOCAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBs ZS5jb20+CisKKyAgICAgICAgUExBVEZPUk0oSU9TKSBzaG91bGQgY29tZSBiZWZvcmUgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MTAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2luY2UgaU9TIGRvZXMgbm90IGRlZmluZSBfX01BQ19PU19YX1ZF UlNJT05fTUlOX1JFUVVJUkVELCBhbnkgdXNhZ2Ugb2YKKyAgICAgICAgX19NQUNfT1NfWF9WRVJT SU9OX01JTl9SRVFVSVJFRCBzaG91bGQgYmUgYWZ0ZXIgYSBQTEFURk9STShJT1MpIGNoZWNrLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViU3lzdGVtSW50ZXJm YWNlLm1tOgorICAgICAgICAoSW5pdFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2UpOgorCiAyMDEzLTAx LTI4ICBSZW5hdGEgSG9kb3ZhbiAgPHJlbmlAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW1dp bl1bV0syXSBCdWlsZCBmaXggYWZ0ZXIgcjE0MDk1Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGIyZDg2NWEz OGY2NThkNzdhZWM3YWJkOTBlYjlhOTE3ZmU4NzdhYTEuLmI4ZmJjOTAyOWNkYzcwOTdjZWUyMWE2 YjQ1ZmVhZTNmYzRiNmI3MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgK KysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtMTIwOSw3ICsxMjA5LDcgQEAKICNl bmRpZgogI2VuZGlmCiAKLSNpZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTA4MCAmJiAhUExBVEZPUk0oSU9TKQorI2lmICFQTEFURk9STShJT1Mp ICYmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx MDgwCiAjZGVmaW5lIFdURl9VU0VfQ09OVEVOVF9GSUxURVJJTkcgMQogI2VuZGlmCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNl LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5o CmluZGV4IDliNjZmN2Y4MWU1OWY5ODg3MDRkZDA5MjY5ZDBlNzAxMWYyOWQzZGEuLjY3MTVmMDcx MTkwYTNjODY1NjFjMWY5NWY1YTBmZjNlYmNlYWI0ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UuaApAQCAtMzQ1LDcgKzM0 NSw3IEBAIGV4dGVybiBOU0RhdGEgKigqd2tGaWx0ZXJBZGREYXRhKShXZWJGaWx0ZXJFdmFsdWF0 b3IgKiwgTlNEYXRhICopOwogZXh0ZXJuIE5TRGF0YSAqKCp3a0ZpbHRlckRhdGFDb21wbGV0ZSko V2ViRmlsdGVyRXZhbHVhdG9yICopOwogI2VuZGlmCiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05f TUlOX1JFUVVJUkVEID49IDEwODAgJiYgIVBMQVRGT1JNKElPUykKKyNpZiAhUExBVEZPUk0oSU9T KSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwODAKIGV4dGVybiBDR0Zs b2F0ICgqd2tOU0VsYXN0aWNEZWx0YUZvclRpbWVEZWx0YSkoQ0dGbG9hdCBpbml0aWFsUG9zaXRp b24sIENHRmxvYXQgaW5pdGlhbFZlbG9jaXR5LCBDR0Zsb2F0IGVsYXBzZWRUaW1lKTsKIGV4dGVy biBDR0Zsb2F0ICgqd2tOU0VsYXN0aWNEZWx0YUZvclJlYm91bmREZWx0YSkoQ0dGbG9hdCBkZWx0 YSk7CiBleHRlcm4gQ0dGbG9hdCAoKndrTlNSZWJvdW5kRGVsdGFGb3JFbGFzdGljRGVsdGEpKENH RmxvYXQgZGVsdGEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dl YkNvcmVTeXN0ZW1JbnRlcmZhY2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2Vi Q29yZVN5c3RlbUludGVyZmFjZS5tbQppbmRleCBhYmY0YjZjMDVkOTUzMTI2MzU2MTRkYWY0YzI1 MTU0NmMzZmRhNWUwLi5hMzkyOTMwYmRiOWJmNTE2MDg4YjY0OTY4NTY5YzExMTgzYjU3NmY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUludGVy ZmFjZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUlu dGVyZmFjZS5tbQpAQCAtMjE3LDcgKzIxNyw3IEBAIE5TRGF0YSAqKCp3a0ZpbHRlckFkZERhdGEp KFdlYkZpbHRlckV2YWx1YXRvciAqLCBOU0RhdGEgKik7CiBOU0RhdGEgKigqd2tGaWx0ZXJEYXRh Q29tcGxldGUpKFdlYkZpbHRlckV2YWx1YXRvciAqKTsKICNlbmRpZgogCi0jaWYgX19NQUNfT1Nf WF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgwICYmICFQTEFURk9STShJT1MpCisjaWYgIVBM QVRGT1JNKElPUykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgwCiBD R0Zsb2F0ICgqd2tOU0VsYXN0aWNEZWx0YUZvclRpbWVEZWx0YSkoQ0dGbG9hdCBpbml0aWFsUG9z aXRpb24sIENHRmxvYXQgaW5pdGlhbFZlbG9jaXR5LCBDR0Zsb2F0IGVsYXBzZWRUaW1lKTsKIENH RmxvYXQgKCp3a05TRWxhc3RpY0RlbHRhRm9yUmVib3VuZERlbHRhKShDR0Zsb2F0IGRlbHRhKTsK IENHRmxvYXQgKCp3a05TUmVib3VuZERlbHRhRm9yRWxhc3RpY0RlbHRhKShDR0Zsb2F0IGRlbHRh KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3Rl bUludGVyZmFjZS5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3Rl bUludGVyZmFjZS5tbQppbmRleCAxZjU4MDc4Y2M5NDdiODA1MGQyOTA0YjllYjZlMzBhOWZkNGE1 YjY5Li45M2ZkZTkwNjBhMWUyMjFhYzE1ZGRiZjg3NGZlNzkwMjdiN2I3ODU5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0ZW1JbnRlcmZhY2UubW0K KysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNl Lm1tCkBAIC0yMTQsNyArMjE0LDcgQEAgdm9pZCBJbml0V2ViQ29yZVN5c3RlbUludGVyZmFjZSh2 b2lkKQogICAgIElOSVQoRmlsdGVyRGF0YUNvbXBsZXRlKTsKICNlbmRpZgogCi0jaWYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgwICYmICFQTEFURk9STShJT1MpCisjaWYg IVBMQVRGT1JNKElPUykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgw CiAgICAgSU5JVChOU0VsYXN0aWNEZWx0YUZvclRpbWVEZWx0YSk7CiAgICAgSU5JVChOU0VsYXN0 aWNEZWx0YUZvclJlYm91bmREZWx0YSk7CiAgICAgSU5JVChOU1JlYm91bmREZWx0YUZvckVsYXN0 aWNEZWx0YSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L21hYy9XZWJTeXN0ZW1JbnRlcmZhY2UubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9XZWJTeXN0ZW1JbnRlcmZhY2UubW0KaW5kZXggMDI3YWNk NzllODdlNzAwZDg1NzYxYmI3NTJkMDIzMGJmMjJiM2QyOC4uMzNhZDMyZDUzOWVjMmQ4MzAxNGZj N2M3OTcxNGVjNDRmNGEwMjI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViU3lzdGVtSW50ZXJmYWNlLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYlN5c3RlbUludGVyZmFjZS5t bQpAQCAtMTc3LDcgKzE3Nyw3IEBAIHZvaWQgSW5pdFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2Uodm9p ZCkKICAgICAgICAgSU5JVChGaWx0ZXJEYXRhQ29tcGxldGUpOwogI2VuZGlmCiAKLSNpZiBQTEFU Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA4MCAmJiAh UExBVEZPUk0oSU9TKQorI2lmICFQTEFURk9STShJT1MpICYmIFBMQVRGT1JNKE1BQykgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDgwCiAgICAgICAgIElOSVQoTlNFbGFz dGljRGVsdGFGb3JUaW1lRGVsdGEpOwogICAgICAgICBJTklUKE5TRWxhc3RpY0RlbHRhRm9yUmVi b3VuZERlbHRhKTsKICAgICAgICAgSU5JVChOU1JlYm91bmREZWx0YUZvckVsYXN0aWNEZWx0YSk7 Cg==