108087 2013-01-28 09:05:55 -0800 Web Inspector: in inspector-protocol tests do not swallow errors 2013-01-29 04:58:39 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 817792 0 prybin 2013-01-28 09:05:55 -0800 If function the test function hasn't been found or failed to be compiled, test will timeout. Kill test in this case and provide error message. 817796 1 184993 prybin 2013-01-28 09:09:48 -0800 Created attachment 184993 Patch 818803 2 184993 yurys 2013-01-29 03:34:20 -0800 Comment on attachment 184993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89 > + if (typeof testFunction == "function") { == -> === 818809 3 185214 prybin 2013-01-29 03:39:42 -0800 Created attachment 185214 Patch 818810 4 prybin 2013-01-29 03:40:52 -0800 (In reply to comment #2) > (From update of attachment 184993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review > > > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89 > > + if (typeof testFunction == "function") { > > == -> === Done 818842 5 185214 webkit.review.bot 2013-01-29 04:58:35 -0800 Comment on attachment 185214 Patch Clearing flags on attachment: 185214 Committed r141100: <http://trac.webkit.org/changeset/141100> 818843 6 webkit.review.bot 2013-01-29 04:58:39 -0800 All reviewed patches have been landed. Closing bug. 184993 2013-01-28 09:09:48 -0800 2013-01-29 03:39:37 -0800 Patch bug-108087-20130128210635.patch text/plain 2604 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNDUxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzY2OThiNDFjODFmMGM1ZmYwNGQx MDMxNWFhN2VhOWI4N2QwZDI1OS4uZDc2NzVjZWJmZmU3MzM2OGVjY2UxZDc2ODk3ZmNlNTE4OTJh MDRjYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTI4ICBQZXRlciBSeWJpbiAgPHBl dGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbiBpbnNwZWN0 b3ItcHJvdG9jb2wgdGVzdHMgZG8gbm90IHN3YWxsb3cgZXJyb3JzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgwODcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgQWRkaXRpb25hbCBjaGVja3MgYXJlIGFkZGVk LiBEZWJ1Z2dlZSBpcyBtb3JlIGFnZ3Jlc3NpdmUgYXQKKyAgICAgICAgd2hlbiB0byBraWxsIHRo ZSB0ZXN0LgorCisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3Vy Y2VzL0luc3BlY3RvclRlc3QuanM6CisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJv dG9jb2wvcmVzb3VyY2VzL3Byb3RvY29sLXRlc3QuanM6CisgICAgICAgIChydW5UZXN0KToKKwog MjAxMy0wMS0yMiAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjE0MDIzMSk6IG1lZGlhIHRyYWNrIGxheW91dCB0ZXN0cyBjcmFzaGluZwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3Vy Y2VzL0luc3BlY3RvclRlc3QuanMgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci1w cm90b2NvbC9yZXNvdXJjZXMvSW5zcGVjdG9yVGVzdC5qcwppbmRleCAxZWMxYWUxZWE4MjdiODNl MjUwYzAzMjAwMjUxYmQ1MjVhMDU4MDAzLi42ZDI5MmRiZWJhMTI2NGJmYjBlMDQwNjg5Njk2NDhi MWUyMmE2NDc1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci1w cm90b2NvbC9yZXNvdXJjZXMvSW5zcGVjdG9yVGVzdC5qcworKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9yZXNvdXJjZXMvSW5zcGVjdG9yVGVzdC5qcwpAQCAt OTQsNiArOTQsNyBAQCB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIGZ1bmN0aW9u KGV2ZW50KSB7CiAgICAgICAgIGV2YWwoZXZlbnQuZGF0YSk7CiAgICAgfSBjYXRjaCAoZSkgewog ICAgICAgICBhbGVydChlLnN0YWNrKTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRl c3QoKTsKICAgICAgICAgdGhyb3cgZTsKICAgICB9CiB9KTsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9wcm90b2NvbC10ZXN0 LmpzIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3VyY2Vz L3Byb3RvY29sLXRlc3QuanMKaW5kZXggODQwYzhkMzU3NGI5ZWEwYzRlYjYzZjk4NzVmMzRiNTY3 MzEwMmRmZC4uZTQ4OTZhNjI5ZmMzOTJlYmQzODEyOGU1NmEzMmE0NWE4ODI3M2QxZSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3VyY2Vz L3Byb3RvY29sLXRlc3QuanMKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3It cHJvdG9jb2wvcmVzb3VyY2VzL3Byb3RvY29sLXRlc3QuanMKQEAgLTgzLDggKzgzLDE1IEBAIGZ1 bmN0aW9uIHJ1blRlc3QoKQogCiAgICAgdmFyIHVybCA9IHNjcmlwdFVybEJhc2VQYXRoICsgIi9w cm90b2NvbC10ZXN0Lmh0bWwiOwogICAgIHZhciBpbnNwZWN0b3JGcm9udGVuZCA9IHdpbmRvdy5p bnRlcm5hbHMub3BlbkR1bW15SW5zcGVjdG9yRnJvbnRlbmQodXJsKTsKLQogICAgIGluc3BlY3Rv ckZyb250ZW5kLmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbihldmVudCkgewotICAg ICAgICBpbnNwZWN0b3JGcm9udGVuZC5wb3N0TWVzc2FnZSgiKCIgKyB0ZXN0LnRvU3RyaW5nKCkg KyIpKCk7IiwgIioiKTsKKyAgICAgICAgLy8gRklYTUU6IHJlbmFtZSB0aGlzICd0ZXN0JyBnbG9i YWwgZmllbGQgYWNyb3NzIGFsbCB0ZXN0cy4KKyAgICAgICAgdmFyIHRlc3RGdW5jdGlvbiA9IHdp bmRvdy50ZXN0OworICAgICAgICBpZiAodHlwZW9mIHRlc3RGdW5jdGlvbiA9PSAiZnVuY3Rpb24i KSB7CisJICAgICAgICBpbnNwZWN0b3JGcm9udGVuZC5wb3N0TWVzc2FnZSgiKCIgKyB0ZXN0RnVu Y3Rpb24udG9TdHJpbmcoKSArIikoKTsiLCAiKiIpOworICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICB9CisgICAgICAgIC8vIEtpbGwgd2FpdGluZyBwcm9jZXNzIGlmIGZhaWxlZCB0byBzZW5k LgorICAgICAgICBhbGVydCgiRmFpbGVkIHRvIHNlbmQgdGVzdCBmdW5jdGlvbiIpOworICAgICAg ICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKICAgICB9KTsKIH0K 185214 2013-01-29 03:39:42 -0800 2013-01-29 04:58:35 -0800 Patch bug-108087-20130129153628.patch text/plain 2636 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTkzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDBjNjljNzc4ZGE5ODhlYTIzZWEw YmQ2N2I2M2UwZDM3NzNiNTBkOS4uODhhYzc0MmM5YWMxZDAwY2U4M2QwYjk3NjUyMmQ2MGYyYjU4 YmE1NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTI5ICBQZXRlciBSeWJpbiAgPHBl dGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbiBpbnNwZWN0 b3ItcHJvdG9jb2wgdGVzdHMgZG8gbm90IHN3YWxsb3cgZXJyb3JzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgwODcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgQWRkaXRpb25hbCBjaGVja3MgYXJlIGFkZGVk LiBEZWJ1Z2dlZSBpcyBtb3JlIGFnZ3Jlc3NpdmUgYXQKKyAgICAgICAgd2hlbiB0byBraWxsIHRo ZSB0ZXN0LgorCisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3Vy Y2VzL0luc3BlY3RvclRlc3QuanM6CisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJv dG9jb2wvcmVzb3VyY2VzL3Byb3RvY29sLXRlc3QuanM6CisgICAgICAgIChydW5UZXN0KToKKwog MjAxMy0wMS0yOCAgVWRheSBLaXJhbiAgPHVkYXlraXJhbkBtb3Rvcm9sYS5jb20+CiAKICAgICAg ICAgZ2V0Q29tcHV0ZWRTdHlsZSByZXR1cm5zICJsZWZ0IiBpbnN0ZWFkIG9mICJub25lIiBmb3Ig ImZsb2F0IiBvbiBhYnNwb3MgZWxlbWVudHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9JbnNwZWN0b3JUZXN0LmpzIGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3VyY2VzL0luc3BlY3Rv clRlc3QuanMKaW5kZXggMWVjMWFlMWVhODI3YjgzZTI1MGMwMzIwMDI1MWJkNTI1YTA1ODAwMy4u NmQyOTJkYmViYTEyNjRiZmIwZTA0MDY4OTY5NjQ4YjFlMjJhNjQ3NSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3VyY2VzL0luc3BlY3Rv clRlc3QuanMKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wv cmVzb3VyY2VzL0luc3BlY3RvclRlc3QuanMKQEAgLTk0LDYgKzk0LDcgQEAgd2luZG93LmFkZEV2 ZW50TGlzdGVuZXIoIm1lc3NhZ2UiLCBmdW5jdGlvbihldmVudCkgewogICAgICAgICBldmFsKGV2 ZW50LmRhdGEpOwogICAgIH0gY2F0Y2ggKGUpIHsKICAgICAgICAgYWxlcnQoZS5zdGFjayk7Cisg ICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7CiAgICAgICAgIHRocm93IGU7CiAg ICAgfQogfSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci1w cm90b2NvbC9yZXNvdXJjZXMvcHJvdG9jb2wtdGVzdC5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9wcm90b2NvbC10ZXN0LmpzCmluZGV4IDg0 MGM4ZDM1NzRiOWVhMGM0ZWI2M2Y5ODc1ZjM0YjU2NzMxMDJkZmQuLjBjZGM2YzE1OTljYWRkMmYw NWRkYzM4NmYzMDlhNGNjYTRiYjdjODMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9wcm90b2NvbC10ZXN0LmpzCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9wcm90b2Nv bC10ZXN0LmpzCkBAIC04Myw4ICs4MywxNSBAQCBmdW5jdGlvbiBydW5UZXN0KCkKIAogICAgIHZh ciB1cmwgPSBzY3JpcHRVcmxCYXNlUGF0aCArICIvcHJvdG9jb2wtdGVzdC5odG1sIjsKICAgICB2 YXIgaW5zcGVjdG9yRnJvbnRlbmQgPSB3aW5kb3cuaW50ZXJuYWxzLm9wZW5EdW1teUluc3BlY3Rv ckZyb250ZW5kKHVybCk7Ci0KICAgICBpbnNwZWN0b3JGcm9udGVuZC5hZGRFdmVudExpc3RlbmVy KCJsb2FkIiwgZnVuY3Rpb24oZXZlbnQpIHsKLSAgICAgICAgaW5zcGVjdG9yRnJvbnRlbmQucG9z dE1lc3NhZ2UoIigiICsgdGVzdC50b1N0cmluZygpICsiKSgpOyIsICIqIik7CisgICAgICAgIC8v IEZJWE1FOiByZW5hbWUgdGhpcyAndGVzdCcgZ2xvYmFsIGZpZWxkIGFjcm9zcyBhbGwgdGVzdHMu CisgICAgICAgIHZhciB0ZXN0RnVuY3Rpb24gPSB3aW5kb3cudGVzdDsKKyAgICAgICAgaWYgKHR5 cGVvZiB0ZXN0RnVuY3Rpb24gPT09ICJmdW5jdGlvbiIpIHsKKwkgICAgICAgIGluc3BlY3RvckZy b250ZW5kLnBvc3RNZXNzYWdlKCIoIiArIHRlc3RGdW5jdGlvbi50b1N0cmluZygpICsiKSgpOyIs ICIqIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgLy8gS2lsbCB3 YWl0aW5nIHByb2Nlc3MgaWYgZmFpbGVkIHRvIHNlbmQuCisgICAgICAgIGFsZXJ0KCJGYWlsZWQg dG8gc2VuZCB0ZXN0IGZ1bmN0aW9uIik7CisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgp OwogICAgIH0pOwogfQo=