108083 2013-01-28 07:43:36 -0800 [GTK] Building fails in an armv5tel board 2013-02-01 22:27:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 aperez webkit-unassigned dbates mrobinson webkit.review.bot oldest_to_newest 817752 0 aperez 2013-01-28 07:43:36 -0800 [GTK] Building fails in an armv5tel board 817754 1 aperez 2013-01-28 07:47:49 -0800 More precisely, the “configure” script claims that the C++ compiler cannot be found, examining “configure.log” this can be observed: configure:5761: g++ -c -march=pentium4 -msse2 -mfpmath=sse conftest.cpp >&5 g++: error: unrecognized argument in option '-march=pentium4' g++: note: valid arguments to '-march=' are: armv2 armv2a armv3 armv3m armv4 armv4t armv5 armv5e armv5t armv5te armv6 armv6-m armv6j armv6k armv6s-m armv6t2 armv6z armv6zk armv7 armv7-a armv7-m armv7-r armv7e-m ep9312 iwmmxt iwmmxt2 native g++: error: unrecognized command line option '-msse2' g++: error: unrecognized command line option '-mfpmath=sse' Of course, passing those options does not make sense in ARM. 817755 2 aperez 2013-01-28 07:49:12 -0800 For reference, the board is a Dreamplug, which reports the following: % cat /proc/cpuinfo processor : 0 model name : Feroceon 88FR131 rev 1 (v5l) BogoMIPS : 1191.11 Features : swp half thumb fastmult edsp CPU implementer : 0x56 CPU architecture: 5TE CPU variant : 0x2 CPU part : 0x131 CPU revision : 1 Hardware : Marvell Kirkwood (Flattened Device Tree) Revision : 0000 Serial : 0000000000000000 % uname -m armv5tel 817758 3 184983 aperez 2013-01-28 07:53:42 -0800 Created attachment 184983 Patch 818585 4 184983 dbates 2013-01-28 23:03:50 -0800 Comment on attachment 184983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184983&action=review > Tools/Scripts/webkitdirs.pm:1323 > + return $Config{archname} =~ /^arm(-|v[567])/; Would it be sufficient to match a string that begins with "arm-" or "armv"? In particular, would it be sufficient to match a string that begins with "armv" as opposed to {armv5, armv6, armv7}? 818833 5 aperez 2013-01-29 04:39:34 -0800 (In reply to comment #4) > (From update of attachment 184983 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184983&action=review > > > Tools/Scripts/webkitdirs.pm:1323 > > + return $Config{archname} =~ /^arm(-|v[567])/; > > Would it be sufficient to match a string that begins with "arm-" or "armv"? In particular, would it be sufficient to match a string that begins with "armv" as opposed to {armv5, armv6, armv7}? After thinking a bit more about this, I think you are right: it may be better to go for the broader /^arm[v-]/ regexp here, so it won't be needed in the future to edit this if some new ARM incarnation happens to be reported e.g. as “armv8” (or whatever the version is). 818864 6 185226 aperez 2013-01-29 05:46:15 -0800 Created attachment 185226 Patch 823541 7 aperez 2013-02-01 21:18:46 -0800 Could the second version of the patch (which checks for "^arm[v-]") be landed? Probably that's the best we can to get builds being done in the broadest amount of ARM machines possible. 823554 8 185226 webkit.review.bot 2013-02-01 22:27:54 -0800 Comment on attachment 185226 Patch Clearing flags on attachment: 185226 Committed r141683: <http://trac.webkit.org/changeset/141683> 823555 9 webkit.review.bot 2013-02-01 22:27:57 -0800 All reviewed patches have been landed. Closing bug. 184983 2013-01-28 07:53:42 -0800 2013-01-29 05:46:10 -0800 Patch bug-108083-20130128175250.patch text/plain 1308 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTJiYWZkMGY3NjQ4YjkxMzhhNjcwZTFiZTI3NjJlNTg5 NzVjNDc0Yi4uMzNlNDdkMGU4MjUxNzQxODE2YTA5MDEzYWQ5ZTE4M2M1Nzc0NGM2ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTAxLTI4ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gQnVpbGRpbmcgZmFpbHMgaW4gYW4gYXJtdjV0ZWwgYm9hcmQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODA4Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHNvbWUg c3lzdGVtcyBpbiB3aGljaCAkYXJjaGl0ZWN0dXJlIGlzIGZpbGxlZC1pbiBmcm9tICJ1bmFtZSAt bSIKKyAgICAgICAgdGhlIHZhbHVlIG1heSBub3Qgc3RhcnQgd2l0aCAiYXJtLSIsIGJ1dCB3aXRo ICJhcm12TiIsIHdoZXJlICJOIiBpcworICAgICAgICBhbiBhcmNoaXRlY3R1cmUgdmVyc2lvbiBu dW1iZXIuIFRoZSByZWdleHAgaW4gaXNBUk0oKSBpcyBtb2RpZmllZAorICAgICAgICBzbyBpdCBj b3ZlcnMgdGhlc2Uga2luZCBvZiBjYXNlcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbToKKyAgICAgICAgKGlzQVJNKToKKwogMjAxMy0wMS0yOCAgUmFwaGFlbCBLdWJvIGRhIENv c3RhICA8cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBJ bmNsdWRlIEVjb3JlX0dldG9wdC5oIGluIE1pbmlCcm93c2VyLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IDhkMzdhOGNmMjUyZjRlYTM5ZDE3MmE2ZDllYzM0YmNkMTY3MDRmN2YuLjliOTdmM2JmM2YyMWVj MjhjZmIyZDNmZTNjOWEzNGM3NDlkOTllYzYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTEzMjAsNyAr MTMyMCw3IEBAIHN1YiBpc0ZyZWVCU0QoKQogCiBzdWIgaXNBUk0oKQogewotICAgIHJldHVybiAk Q29uZmlne2FyY2huYW1lfSA9fiAvXmFybS0vOworICAgIHJldHVybiAkQ29uZmlne2FyY2huYW1l fSA9fiAvXmFybSgtfHZbNTY3XSkvOwogfQogCiBzdWIgaXNDcm9zc0NvbXBpbGF0aW9uKCkK 185226 2013-01-29 05:46:15 -0800 2013-02-01 22:27:54 -0800 Patch bug-108083-20130129154522.patch text/plain 1296 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxMDk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWE1NTEzMTY0MjUyMjY4YjZjOGEzYzFiNjdiMDcyZjky YWQ0Nzg5OC4uZjY4YTExYjY5YTYxMjYzM2YyZDE5MGUxNDM0YThkZmQ4YTBlZGExMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTAxLTI5ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gQnVpbGRpbmcgZmFpbHMgaW4gYW4gYXJtdjV0ZWwgYm9hcmQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODA4Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHNvbWUg c3lzdGVtcyBpbiB3aGljaCAkYXJjaGl0ZWN0dXJlIGlzIGZpbGxlZC1pbiBmcm9tICJ1bmFtZSAt bSIKKyAgICAgICAgdGhlIHZhbHVlIG1heSBub3Qgc3RhcnQgd2l0aCAiYXJtLSIsIGJ1dCB3aXRo ICJhcm12TiIsIHdoZXJlICJOIiBpcworICAgICAgICBhbiBhcmNoaXRlY3R1cmUgdmVyc2lvbiBu dW1iZXIuIFRoZSByZWdleHAgaW4gaXNBUk0oKSBpcyBtb2RpZmllZAorICAgICAgICBzbyBpdCBj b3ZlcnMgdGhlc2Uga2luZCBvZiBjYXNlcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbToKKyAgICAgICAgKGlzQVJNKToKKwogMjAxMy0wMS0yOSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gSW1wbGVtZW50IHJlc291 cmNlcyBBUEkgdXNpbmcgaW5qZWN0ZWQgYnVuZGxlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggOGQzN2E4 Y2YyNTJmNGVhMzlkMTcyYTZkOWVjMzRiY2QxNjcwNGY3Zi4uNjliNzdlYjU5Njc4Y2VhM2ZiMjZj MWE0NDg5NzkwYmJiZjZiNDg4MiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTMyMCw3ICsxMzIwLDcg QEAgc3ViIGlzRnJlZUJTRCgpCiAKIHN1YiBpc0FSTSgpCiB7Ci0gICAgcmV0dXJuICRDb25maWd7 YXJjaG5hbWV9ID1+IC9eYXJtLS87CisgICAgcmV0dXJuICRDb25maWd7YXJjaG5hbWV9ID1+IC9e YXJtW3ZcLV0vOwogfQogCiBzdWIgaXNDcm9zc0NvbXBpbGF0aW9uKCkK