108072 2013-01-28 03:40:54 -0800 Web Inspector: [CPU Profile] Taking profile crashes renderer. 2013-01-29 03:57:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas abarth apavlov caseq eustas haraken japhet keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 817671 0 eustas 2013-01-28 03:40:54 -0800 This regression is caused by https://bugs.webkit.org/show_bug.cgi?id=107674 More precisely: in file ScriptProfiler.cpp it is explicitly declared that "start" and "stop" could be invoked with state == 0 (see "startForPage", "stopForPage", etc.) Accessing "isolate" of a null pointer causes crashes. 817676 1 184967 eustas 2013-01-28 04:03:41 -0800 Created attachment 184967 Patch 817685 2 184967 yurys 2013-01-28 04:31:49 -0800 Comment on attachment 184967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184967&action=review > Source/WebCore/bindings/v8/ScriptProfiler.cpp:80 > const v8::CpuProfile* profile = state ? In which cases it the state is 0? 818815 3 184967 webkit.review.bot 2013-01-29 03:57:15 -0800 Comment on attachment 184967 Patch Clearing flags on attachment: 184967 Committed r141094: <http://trac.webkit.org/changeset/141094> 818816 4 webkit.review.bot 2013-01-29 03:57:19 -0800 All reviewed patches have been landed. Closing bug. 184967 2013-01-28 04:03:41 -0800 2013-01-29 03:57:15 -0800 Patch bug-108072-20130128160027.patch text/plain 4626 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTE0YzJjYmYxMmRmOTYy NDgyODg3MWQ1MWNjNGNkYmI1OGJiN2Y1Yy4uNTc0NmEwYmM2Zjc4NTAzNTNkNTkxZGJmMTVkZDI1 OTMzY2VjNmU4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTI4ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtDUFUgUHJvZmlsZV0gVGFraW5nIHByb2ZpbGUgY3Jhc2hlcyByZW5kZXJlci4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODA3MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGluc3Bl Y3Rvci9wcm9maWxlci9jcHUtcHJvZmlsZXItYWdlbnQtY3Jhc2gtb24tc3RhcnQuaHRtbAorCisg ICAgICAgIEZpeGVkIG51bGwtcG9pbnRlciBhY2Nlc3MuCisKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9TY3JpcHRQcm9maWxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRQcm9maWxlcjo6 c3RhcnQpOiBGaXhlZCBudWxsLXBvaW50ZXIgYWNjZXNzLgorICAgICAgICAoV2ViQ29yZTo6U2Ny aXB0UHJvZmlsZXI6OnN0b3ApOiBEaXR0by4KKwogMjAxMy0wMS0yOCAgU2hlcmlmZiBCb3QgIDx3 ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjE0MDU1NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nj cmlwdFByb2ZpbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2Zp bGVyLmNwcAppbmRleCBlMmFlMDQxNGJlODg0MjZmYjNkOGIxZjMzM2I0M2EwYzM3YmI0NjZlLi5m ZTIxOWQwYjIxYTQ5YTMwNzJjZWQ2NGVjMTdmYjM0ZTA0Nzc0OWI4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZXIuY3BwCkBAIC01OSw3ICs1OSw3IEBAIHZv aWQgU2NyaXB0UHJvZmlsZXI6OnN0YXJ0KFNjcmlwdFN0YXRlKiBzdGF0ZSwgY29uc3QgU3RyaW5n JiB0aXRsZSkKICAgICBwcm9maWxlTmFtZUlkbGVUaW1lTWFwLT5hZGQodGl0bGUsIDApOwogCiAg ICAgdjg6OkhhbmRsZVNjb3BlIGhzOwotICAgIHY4OjpDcHVQcm9maWxlcjo6U3RhcnRQcm9maWxp bmcodjhTdHJpbmcodGl0bGUsIHN0YXRlLT5pc29sYXRlKCkpKTsKKyAgICB2ODo6Q3B1UHJvZmls ZXI6OlN0YXJ0UHJvZmlsaW5nKHY4U3RyaW5nKHRpdGxlLCB2ODo6SXNvbGF0ZTo6R2V0Q3VycmVu dCgpKSk7CiB9CiAKIHZvaWQgU2NyaXB0UHJvZmlsZXI6OnN0YXJ0Rm9yUGFnZShQYWdlKiwgY29u c3QgU3RyaW5nJiB0aXRsZSkKQEAgLTc4LDggKzc4LDggQEAgUGFzc1JlZlB0cjxTY3JpcHRQcm9m aWxlPiBTY3JpcHRQcm9maWxlcjo6c3RvcChTY3JpcHRTdGF0ZSogc3RhdGUsIGNvbnN0IFN0cmlu ZyYKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgaHM7CiAgICAgY29uc3Qgdjg6OkNwdVByb2ZpbGUq IHByb2ZpbGUgPSBzdGF0ZSA/Ci0gICAgICAgIHY4OjpDcHVQcm9maWxlcjo6U3RvcFByb2ZpbGlu Zyh2OFN0cmluZyh0aXRsZSwgc3RhdGUtPmlzb2xhdGUoKSksIHN0YXRlLT5jb250ZXh0KCktPkdl dFNlY3VyaXR5VG9rZW4oKSkgOgotICAgICAgICB2ODo6Q3B1UHJvZmlsZXI6OlN0b3BQcm9maWxp bmcodjhTdHJpbmcodGl0bGUsIHN0YXRlLT5pc29sYXRlKCkpKTsKKyAgICAgICAgdjg6OkNwdVBy b2ZpbGVyOjpTdG9wUHJvZmlsaW5nKHY4U3RyaW5nKHRpdGxlLCB2ODo6SXNvbGF0ZTo6R2V0Q3Vy cmVudCgpKSwgc3RhdGUtPmNvbnRleHQoKS0+R2V0U2VjdXJpdHlUb2tlbigpKSA6CisgICAgICAg IHY4OjpDcHVQcm9maWxlcjo6U3RvcFByb2ZpbGluZyh2OFN0cmluZyh0aXRsZSwgdjg6Oklzb2xh dGU6OkdldEN1cnJlbnQoKSkpOwogICAgIGlmICghcHJvZmlsZSkKICAgICAgICAgcmV0dXJuIDA7 CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA2ZjE1MDg4Njg5MTcwNjM0Nzg1ZGQyMDM5MWNhZDUyMmU2ZWYzMDQ4Li5kYzNm NmMzYmU4YjVmNGI3MzA2NWU2Y2JkZWI3ZTBlNDE2OTY3YzdkIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDEtMjggIEV1Z2VuZSBLbHl1Y2huaWtvdiAgPGV1c3Rhc0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW0NQVSBQcm9maWxlXSBUYWtpbmcgcHJvZmlsZSBj cmFzaGVzIHJlbmRlcmVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgdGVzdCB0byBjaGVjayB0aGF0IFByb2ZpbGVyQWdlbnQgc3RhcnQvc3Rv cCBkb2Vzbid0IGNyYXNoLgorCisgICAgICAgICogaW5zcGVjdG9yL3Byb2ZpbGVyL2NwdS1wcm9m aWxlci1hZ2VudC1jcmFzaC1vbi1zdGFydC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGluc3BlY3Rvci9wcm9maWxlci9jcHUtcHJvZmlsZXItYWdlbnQtY3Jhc2gtb24tc3RhcnQuaHRt bDogQWRkZWQuCisKIDIwMTMtMDEtMjcgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5v cmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBNYXJraW5nIHR3byBmYXN0L2Zvcm1zIHRlc3RzIGFz IHNsb3cgb24gZGVidWcgbWFjLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3By b2ZpbGVyL2NwdS1wcm9maWxlci1hZ2VudC1jcmFzaC1vbi1zdGFydC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvZmlsZXIvY3B1LXByb2ZpbGVyLWFnZW50LWNyYXNoLW9u LXN0YXJ0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40ZjcwNTA1ZjA3MzQ1NTkxZDViYzNhNWM5 ODExODQwOTRiYjZmODEwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L3Byb2ZpbGVyL2NwdS1wcm9maWxlci1hZ2VudC1jcmFzaC1vbi1zdGFydC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSw2IEBACitUZXN0IHRoYXQgUHJvZmlsZXJBZ2VudCBzdGFydC9zdG9wIGRvZXNu J3QgY3Jhc2guCisKK1Byb2ZpbGVyQWdlbnQgc3RhcnRlZC4KK1Byb2ZpbGVyQWdlbnQgc3RvcHBl ZC4KK1Byb2ZpbGVyQWdlbnQgY2xlYXJlZC4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3Byb2ZpbGVyL2NwdS1wcm9maWxlci1hZ2VudC1jcmFzaC1vbi1zdGFydC5odG1sIGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb2ZpbGVyL2NwdS1wcm9maWxlci1hZ2VudC1jcmFzaC1v bi1zdGFydC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBiMzYyZjkzODAxOTI0MjcwZGJkYzY3OTVkYWRmMTcy MWIyMmI0MzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvZmls ZXIvY3B1LXByb2ZpbGVyLWFnZW50LWNyYXNoLW9uLXN0YXJ0Lmh0bWwKQEAgLTAsMCArMSwzOSBA QAorPGh0bWw+Cis8aGVhZD4KKyAgPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVj dG9yL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIHRl c3QoKQoreworICAgIFdlYkluc3BlY3Rvci5zaG93UGFuZWwoInByb2ZpbGVzIik7CisgICAgUHJv ZmlsZXJBZ2VudC5zdGFydChvblN0YXJ0KTsKKworICAgIGZ1bmN0aW9uIG9uU3RhcnQoKQorICAg IHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIlByb2ZpbGVyQWdlbnQgc3RhcnRl ZC4iKTsKKyAgICAgICAgUHJvZmlsZXJBZ2VudC5zdG9wKG9uU3RvcCk7CisgICAgfQorCisgICAg ZnVuY3Rpb24gb25TdG9wKCkKKyAgICB7CisgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0 KCJQcm9maWxlckFnZW50IHN0b3BwZWQuIik7CisgICAgICAgIFByb2ZpbGVyQWdlbnQuY2xlYXJQ cm9maWxlcyhkb25lKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBkb25lKCkKKyAgICB7CisgICAg ICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJQcm9maWxlckFnZW50IGNsZWFyZWQuIik7Cisg ICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7CisgICAgfQorfQorCis8L3Njcmlw dD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+CitUZXN0IHRoYXQg UHJvZmlsZXJBZ2VudCBzdGFydC9zdG9wIGRvZXNuJ3QgY3Jhc2guCis8L3A+CisKKzwvYm9keT4K KzwvaHRtbD4K