10807 2006-09-10 15:43:36 -0700 REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg 2006-09-21 02:24:54 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned rwlbuis oldest_to_newest 55217 0 mitz 2006-09-10 15:43:36 -0700 Safari crashes when you click the B in manual-tests/svg-repaint-image.svg. This is a regression from r16259 (fix for bug 9753). "CGContextRestoreGState: invalid context" Backtrace: Thread 0 Crashed: 0 com.apple.CoreGraphics 0x903cc44c CGGStackRestore + 136 1 com.apple.WebCore 0x01068c90 WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) + 2400 2 com.apple.WebCore 0x011840a4 WebCore::RenderBox::paint(WebCore::RenderObject::PaintInfo&, int, int) + 116 3 com.apple.WebCore 0x01068bcc WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) + 2204 4 com.apple.WebCore 0x0118e9c0 WebCore::RenderView::paint(WebCore::RenderObject::PaintInfo&, int, int) + 256 5 com.apple.WebCore 0x011a61d0 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, WebCore::PaintRestriction, WebCore::RenderObject*) + 1104 6 com.apple.WebCore 0x010de114 WebCore::Frame::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) + 196 7 com.apple.WebCore 0x0111b9d8 -[WebCoreFrameBridge drawRect:] + 168 8 com.apple.WebKit 0x003389a0 -[WebHTMLView drawSingleRect:] + 288 9 com.apple.WebKit 0x00338c2c -[WebHTMLView drawRect:] + 348 10 com.apple.AppKit 0x93734858 -[NSView _drawRect:clip:] + 2128 11 com.apple.AppKit 0x937335fc -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 736 12 com.apple.WebKit 0x00333b48 -[WebHTMLView(WebPrivate) _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 296 13 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 14 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 15 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 16 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 17 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 18 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 19 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 20 com.apple.AppKit 0x93754044 -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 192 21 com.apple.AppKit 0x9372d054 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 384 22 com.apple.AppKit 0x93722348 -[NSView displayIfNeeded] + 248 23 com.apple.AppKit 0x937221b8 -[NSWindow displayIfNeeded] + 180 24 com.apple.Safari 0x0001a5f8 0x1000 + 103928 25 com.apple.AppKit 0x93722064 _handleWindowNeedsDisplay + 200 26 com.apple.CoreFoundation 0x907db73c __CFRunLoopDoObservers + 352 27 com.apple.CoreFoundation 0x907db9dc __CFRunLoopRun + 420 28 com.apple.CoreFoundation 0x907db47c CFRunLoopRunSpecific + 268 29 com.apple.HIToolbox 0x931eb740 RunCurrentEventLoopInMode + 264 30 com.apple.HIToolbox 0x931eadd4 ReceiveNextEventCommon + 380 31 com.apple.HIToolbox 0x931eac40 BlockUntilNextEventMatchingListInMode + 96 32 com.apple.AppKit 0x936eeae4 _DPSNextEvent + 384 33 com.apple.AppKit 0x936ee7a8 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 116 34 com.apple.Safari 0x00006740 0x1000 + 22336 35 com.apple.AppKit 0x936eacec -[NSApplication run] + 472 36 com.apple.AppKit 0x937db87c NSApplicationMain + 452 37 com.apple.Safari 0x0005c77c 0x1000 + 374652 38 com.apple.Safari 0x0005c624 0x1000 + 374308 55264 1 10505 rwlbuis 2006-09-11 13:45:50 -0700 Created attachment 10505 First attempt This patch should fix both regressions (10806 and 10807). Cheers, Rob. 55300 2 10505 mjs 2006-09-12 00:23:27 -0700 Comment on attachment 10505 First attempt r=me 55346 3 eric 2006-09-12 22:33:40 -0700 Patch fails to apply cleanly. I'll leave rob to deal with this one. 56110 4 rwlbuis 2006-09-21 02:24:54 -0700 (In reply to comment #3) > Patch fails to apply cleanly. I'll leave rob to deal with this one. > Landed in r16421. 10505 2006-09-11 13:45:50 -0700 2006-09-12 00:23:27 -0700 First attempt 10807.diff text/plain 2567 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjMwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDYtMDktMTEgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWd6 aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MDYKKyAgICAgICAgUkVHUkVT U0lPTiAocjE2MjU5KTogZmFpbGluZyBtYW51YWwtdGVzdHMvc3ZnLXJlcGFpbnQtZ3JvdXAuc3Zn CisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA4MDcKKyAgICAgICAgUkVHUkVTU0lPTiAocjE2MjU5KTogUmVwcm8gY3Jhc2ggb24gbWFudWFs LXRlc3RzL3N2Zy1yZXBhaW50LWltYWdlLnN2ZworCisgICAgICAgIE1ha2Ugc3VyZSB0aGUgcGFp bnQgbWV0aG9kIGlzIG5vdCBleGl0ZWQgd2l0aG91dCBwb3BwaW5nCisgICAgICAgIGNvbnRleHQg YW5kIHRyYW5zcGFyZW5jeSBsYXllci4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VT IEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIGtjYW52YXMvUmVuZGVyU1ZHSW1hZ2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHSW1hZ2U6OnBhaW50KToKKwogMjAwNi0wOS0x MSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4 CkluZGV4OiBXZWJDb3JlL2tjYW52YXMvUmVuZGVyU1ZHSW1hZ2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUva2NhbnZhcy9SZW5kZXJTVkdJbWFnZS5jcHAJKHJldmlzaW9uIDE2Mjk4KQorKysg V2ViQ29yZS9rY2FudmFzL1JlbmRlclNWR0ltYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY2 LDIzICsxNjYsMjEgQEAgdm9pZCBSZW5kZXJTVkdJbWFnZTo6cGFpbnQoUGFpbnRJbmZvJiBwYQog ICAgIHBpLnIgPSBhYnNvbHV0ZVRyYW5zZm9ybSgpLmludmVydCgpLm1hcFJlY3QocGFpbnRJbmZv LnIpOwogCiAgICAgaW50IHggPSAwLCB5ID0gMDsKLSAgICBpZiAoIXNob3VsZFBhaW50KHBpLCB4 LCB5KSkKLSAgICAgICAgcmV0dXJuOwotICAgICAgICAKLSAgICBTVkdJbWFnZUVsZW1lbnQgKmlt YWdlRWx0ID0gc3RhdGljX2Nhc3Q8U1ZHSW1hZ2VFbGVtZW50ICo+KG5vZGUoKSk7Ci0gICAgICAg IAotICAgIGlmIChpbWFnZUVsdC0+cHJlc2VydmVBc3BlY3RSYXRpbygpLT5hbGlnbigpID09IFNW R19QUkVTRVJWRUFTUEVDVFJBVElPX05PTkUpCi0gICAgICAgIFJlbmRlckltYWdlOjpwYWludChw aSwgMCwgMCk7Ci0gICAgZWxzZSB7Ci0gICAgICAgIEZsb2F0UmVjdCBkZXN0UmVjdChtX3gsIG1f eSwgY29udGVudFdpZHRoKCksIGNvbnRlbnRIZWlnaHQoKSk7Ci0gICAgICAgIEZsb2F0UmVjdCBz cmNSZWN0KDAsIDAsIGltYWdlKCktPndpZHRoKCksIGltYWdlKCktPmhlaWdodCgpKTsKLSAgICAg ICAgYWRqdXN0UmVjdHNGb3JBc3BlY3RSYXRpbyhkZXN0UmVjdCwgc3JjUmVjdCwgaW1hZ2VFbHQt PnByZXNlcnZlQXNwZWN0UmF0aW8oKSk7Ci0gICAgICAgIGMtPmRyYXdJbWFnZShpbWFnZSgpLCBk ZXN0UmVjdCwgc3JjUmVjdCk7Ci0gICAgfQorICAgIGlmIChzaG91bGRQYWludChwaSwgeCwgeSkp IHsKKyAgICAgICAgU1ZHSW1hZ2VFbGVtZW50ICppbWFnZUVsdCA9IHN0YXRpY19jYXN0PFNWR0lt YWdlRWxlbWVudCAqPihub2RlKCkpOwogCi0gICAgaWYgKGZpbHRlcikKLSAgICAgICAgZmlsdGVy LT5hcHBseUZpbHRlcihib3VuZGluZ0JveCk7Ci0gICAgCisgICAgICAgIGlmIChpbWFnZUVsdC0+ cHJlc2VydmVBc3BlY3RSYXRpbygpLT5hbGlnbigpID09IFNWR19QUkVTRVJWRUFTUEVDVFJBVElP X05PTkUpCisgICAgICAgICAgICBSZW5kZXJJbWFnZTo6cGFpbnQocGksIDAsIDApOworICAgICAg ICBlbHNlIHsKKyAgICAgICAgICAgIEZsb2F0UmVjdCBkZXN0UmVjdChtX3gsIG1feSwgY29udGVu dFdpZHRoKCksIGNvbnRlbnRIZWlnaHQoKSk7CisgICAgICAgICAgICBGbG9hdFJlY3Qgc3JjUmVj dCgwLCAwLCBpbWFnZSgpLT53aWR0aCgpLCBpbWFnZSgpLT5oZWlnaHQoKSk7CisgICAgICAgICAg ICBhZGp1c3RSZWN0c0ZvckFzcGVjdFJhdGlvKGRlc3RSZWN0LCBzcmNSZWN0LCBpbWFnZUVsdC0+ cHJlc2VydmVBc3BlY3RSYXRpbygpKTsKKyAgICAgICAgICAgIGMtPmRyYXdJbWFnZShpbWFnZSgp LCBkZXN0UmVjdCwgc3JjUmVjdCk7CisgICAgICAgIH0KKworICAgICAgICBpZiAoZmlsdGVyKQor ICAgICAgICAgICAgZmlsdGVyLT5hcHBseUZpbHRlcihib3VuZGluZ0JveCk7CisgICAgfQogICAg IGlmIChvcGFjaXR5IDwgMS4wZikKICAgICAgICAgYy0+ZW5kVHJhbnNwYXJlbmN5TGF5ZXIoKTsK IAo=