108068 2013-01-28 02:01:00 -0800 Web Inspector: [Regression] Search all sources should not search across service projects. 2013-01-28 23:51:14 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov johnjbarton keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 817621 0 vsevik 2013-01-28 02:01:00 -0800 Patch to follow. 817681 1 184969 vsevik 2013-01-28 04:18:26 -0800 Created attachment 184969 Patch 817692 2 184969 webkit.review.bot 2013-01-28 04:49:14 -0800 Comment on attachment 184969 Patch Clearing flags on attachment: 184969 Committed r140966: <http://trac.webkit.org/changeset/140966> 817693 3 webkit.review.bot 2013-01-28 04:49:18 -0800 All reviewed patches have been landed. Closing bug. 818137 4 johnjbarton 2013-01-28 14:49:59 -0800 Global "Search sources" is broken, I guess we don't have test coverage for it? > Source/WebCore/inspector/front-end/ScriptsSearchScope.js:126 > + uiSourceCodes = this._uiSourceCodes.concat(projects[i].uiSourceCodes()); I guess you meant uiSourceCodes = uiSourceCodes.concat(projects[i].uiSourceCodes()); since there is no this._uiSourceCodes 818629 5 vsevik 2013-01-28 23:51:14 -0800 I'll fix it and add a test in https://bugs.webkit.org/show_bug.cgi?id=108157. 184969 2013-01-28 04:18:26 -0800 2013-01-28 04:49:14 -0800 Patch bug-108068-20130128161512.patch text/plain 2412 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRhMTM1N2YzMGU0MDM0 N2FlOWI4NDkzNzNmZDI3YWQ4Njk2YTY1Zi4uMWZkMTc1M2NkYWM1NTIwNTgzYzRlOTEzMjViYjQ5 MGZjZDBiZTVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTI4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtSZWdyZXNzaW9uXSBTZWFyY2ggYWxsIHNvdXJjZXMgc2hvdWxkIG5vdCBzZWFyY2ggYWNy b3NzIHNlcnZpY2UgcHJvamVjdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDgwNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1NlYXJjaFNjb3BlLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNTZWFyY2hTY29wZSk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuU2NyaXB0c1NlYXJjaFNjb3BlLnByb3RvdHlwZS5fc29ydGVkVUlTb3VyY2VD b2Rlcyk6CisKIDIwMTMtMDEtMjcgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEFuIFtBY3RpdmVET01PYmplY3RdIElETCBhdHRyaWJ1dGUgc2hvdWxkIGJl IGluaGVyaXRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9TY3JpcHRzU2VhcmNoU2NvcGUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1NjcmlwdHNTZWFyY2hTY29wZS5qcwppbmRleCBjOTgwZWNlNzIxYThlNjgzMGU3MDEzNWE3 MmFjZTQxZDljY2MxZjE5Li4zNjdlZjU0ODU2ZDk2YzhjOGNmNDk1NTQzY2U0NDk0ZWI4ODQ4MmFi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNT ZWFyY2hTY29wZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nj cmlwdHNTZWFyY2hTY29wZS5qcwpAQCAtMjksMTQgKzI5LDE0IEBACiAvKioKICAqIEBjb25zdHJ1 Y3RvcgogICogQGltcGxlbWVudHMge1dlYkluc3BlY3Rvci5TZWFyY2hTY29wZX0KLSAqIEBwYXJh bSB7V2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZVByb3ZpZGVyfSB1aVNvdXJjZUNvZGVQcm92aWRl cgorICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuV29ya3NwYWNlfSB3b3Jrc3BhY2UKICAqLwotV2Vi SW5zcGVjdG9yLlNjcmlwdHNTZWFyY2hTY29wZSA9IGZ1bmN0aW9uKHVpU291cmNlQ29kZVByb3Zp ZGVyKQorV2ViSW5zcGVjdG9yLlNjcmlwdHNTZWFyY2hTY29wZSA9IGZ1bmN0aW9uKHdvcmtzcGFj ZSkKIHsKICAgICAvLyBGSVhNRTogQWRkIHRpdGxlIG9uY2UgaXQgaXMgdXNlZCBieSBzZWFyY2gg Y29udHJvbGxlci4KICAgICBXZWJJbnNwZWN0b3IuU2VhcmNoU2NvcGUuY2FsbCh0aGlzKQogICAg IHRoaXMuX3NlYXJjaElkID0gMDsKLSAgICB0aGlzLl91aVNvdXJjZUNvZGVQcm92aWRlciA9IHVp U291cmNlQ29kZVByb3ZpZGVyOworICAgIHRoaXMuX3dvcmtzcGFjZSA9IHdvcmtzcGFjZTsKIH0K IAogV2ViSW5zcGVjdG9yLlNjcmlwdHNTZWFyY2hTY29wZS5wcm90b3R5cGUgPSB7CkBAIC0xMTgs NyArMTE4LDEzIEBAIFdlYkluc3BlY3Rvci5TY3JpcHRzU2VhcmNoU2NvcGUucHJvdG90eXBlID0g ewogICAgICAgICAgICAgcmV0dXJuIGEub3JpZ2luVVJMKCkuY29tcGFyZVRvKGIub3JpZ2luVVJM KCkpOyAgIAogICAgICAgICB9CiAgICAgICAgIAotICAgICAgICB2YXIgdWlTb3VyY2VDb2RlcyA9 IHRoaXMuX3VpU291cmNlQ29kZVByb3ZpZGVyLnVpU291cmNlQ29kZXMoKTsKKyAgICAgICAgdmFy IHByb2plY3RzID0gdGhpcy5fd29ya3NwYWNlLnByb2plY3RzKCk7CisgICAgICAgIHZhciB1aVNv dXJjZUNvZGVzID0gW107CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcHJvamVjdHMubGVu Z3RoOyArK2kpIHsKKyAgICAgICAgICAgIGlmIChwcm9qZWN0c1tpXS5pc1NlcnZpY2VQcm9qZWN0 KCkpCisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICB1aVNvdXJjZUNvZGVz ID0gdGhpcy5fdWlTb3VyY2VDb2Rlcy5jb25jYXQocHJvamVjdHNbaV0udWlTb3VyY2VDb2Rlcygp KTsKKyAgICAgICAgfQogICAgICAgICAKICAgICAgICAgdWlTb3VyY2VDb2RlcyA9IHVpU291cmNl Q29kZXMuZmlsdGVyKGZpbHRlck91dEFub255bW91cyk7CiAgICAgICAgIHVpU291cmNlQ29kZXMu c29ydChjb21wYXJhdG9yKTsK