108063 2013-01-28 01:02:48 -0800 Change test expectation to ensure that seamless iframes do not inherit editability. 2013-01-28 01:40:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst eric ojan webkit.review.bot oldest_to_newest 817584 0 mkwst 2013-01-28 01:02:48 -0800 Based on the conversation at https://bugs.webkit.org/show_bug.cgi?id=95890#c3, I believe that the expectation in `fast/frames/seamless/seamless-inherited-document-style.html` regarding `-webkit-user-modify` is incorrect. We don't want to inherit `-webkit-user-modify` from the IFrame, for the same reasons that we don't want to inherit the `contenteditable` attribute. 817588 1 184948 mkwst 2013-01-28 01:07:09 -0800 Created attachment 184948 Patch 817592 2 184948 eric 2013-01-28 01:12:20 -0800 Comment on attachment 184948 Patch If this is what the spec'rs say, then sure. :) 817601 3 184948 mkwst 2013-01-28 01:31:57 -0800 Comment on attachment 184948 Patch (In reply to comment #2) > (From update of attachment 184948 [details]) > If this is what the spec'rs say, then sure. :) This is what you "r=me"'d in the comment I linked up. :) The spec notes that contenteditable on the iframe shouldn't be inherited, and Hixie and Ojan were clear on extending that point to `-webkit-user-modify` in https://bugs.webkit.org/show_bug.cgi?id=95890. I'm comfy with this change. :) 817604 4 184948 webkit.review.bot 2013-01-28 01:40:30 -0800 Comment on attachment 184948 Patch Clearing flags on attachment: 184948 Committed r140954: <http://trac.webkit.org/changeset/140954> 817605 5 webkit.review.bot 2013-01-28 01:40:34 -0800 All reviewed patches have been landed. Closing bug. 184948 2013-01-28 01:07:09 -0800 2013-01-28 01:40:30 -0800 Patch bug-108063-20130128100356.patch text/plain 3645 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTUwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmYxNTA4ODY4OTE3MDYzNDc4NWRk MjAzOTFjYWQ1MjJlNmVmMzA0OC4uNWU4ZTllMGVhZmFjZTI3OWU4YzU1M2QxOGU1NDlmZGZhNjcy Y2U2OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTI4ICBNaWtlIFdlc3QgIDxta3dz dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hhbmdlIHRlc3QgZXhwZWN0YXRpb24gdG8gZW5z dXJlIHRoYXQgc2VhbWxlc3MgaWZyYW1lcyBkbyBub3QgaW5oZXJpdCBlZGl0YWJpbGl0eS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODA2MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlYW1sZXNzbHkg cmVuZGVyZWQgZG9jdW1lbnRzIHNob3VsZCBub3QgaW5oZXJpdCBlZGl0YWJpbGl0eSBmcm9tIHRo ZWlyCisgICAgICAgIHBhcmVudCBJRnJhbWUuIEN1cnJlbnRseSwgdGhlIHRlc3QgZXhwZWN0YXRp b25zIGRvbid0IG1hdGNoIHRoaXMKKyAgICAgICAgYmVoYXZpb3IuIFRoaXMgcGF0Y2ggdHJpdmlh bGx5IGFkanVzdHMgdGhlIGV4cGVjdGF0aW9uIHRvIGVuc3VyZSB0aGF0CisgICAgICAgIGVkaXRh YmlsaXR5IGlzIF9ub3RfIGluaGVyaXRlZC4KKworICAgICAgICAqIGZhc3QvZnJhbWVzL3NlYW1s ZXNzL3NlYW1sZXNzLWluaGVyaXRlZC1kb2N1bWVudC1zdHlsZS1leHBlY3RlZC50eHQ6CisgICAg ICAgICogZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtaW5oZXJpdGVkLWRvY3VtZW50LXN0 eWxlLmh0bWw6CisKIDIwMTMtMDEtMjcgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5v cmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBNYXJraW5nIHR3byBmYXN0L2Zvcm1zIHRlc3RzIGFz IHNsb3cgb24gZGVidWcgbWFjLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMv c2VhbWxlc3Mvc2VhbWxlc3MtaW5oZXJpdGVkLWRvY3VtZW50LXN0eWxlLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWluaGVyaXRlZC1kb2N1 bWVudC1zdHlsZS1leHBlY3RlZC50eHQKaW5kZXggZmRkY2I4NzU3NWU3NDMyNDMxOWU1MmIzYmZj ZWRmNTBmZmY0YTNmZS4uNmFjZTRhMmVkZDAzNjcxMDBjODYyNzIyN2IyOGNmZTI3ZDAyZjA3OSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtaW5o ZXJpdGVkLWRvY3VtZW50LXN0eWxlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1pbmhlcml0ZWQtZG9jdW1lbnQtc3R5bGUtZXhwZWN0 ZWQudHh0CkBAIC0xLDggKzEsOSBAQAogVGVzdCB0aGF0IHNlYW1sZXNzIGlmcmFtZXMgaW5oZXJp dCBzdHlsZXMgZnJvbSB0aGVpciBwYXJlbnQgaWZyYW1lIGluc3RlYWQgb2YgdXNpbmcgU3R5bGVS ZXNvbHZlcjo6c3R5bGVGb3JEb2N1bWVudCBkZWZhdWx0cy4KIFBBU1Mgd2luZG93LmdldENvbXB1 dGVkU3R5bGUocm9vdEVsZW1lbnQpWyctd2Via2l0LXJ0bC1vcmRlcmluZyddIGlzICJ2aXN1YWwi Ci1GQUlMIHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKHJvb3RFbGVtZW50KVsnLXdlYmtpdC11c2Vy LW1vZGlmeSddIHNob3VsZCBiZSByZWFkLXdyaXRlLiBXYXMgcmVhZC1vbmx5LgogUEFTUyB3aW5k b3cuZ2V0Q29tcHV0ZWRTdHlsZShyb290RWxlbWVudClbJy13ZWJraXQtbG9jYWxlJ10gaXMgImVu X1VTIgogUEFTUyB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShyb290RWxlbWVudClbJ3dyaXRpbmct bW9kZSddIGlzICJsciIKIFBBU1Mgd2luZG93LmdldENvbXB1dGVkU3R5bGUocm9vdEVsZW1lbnQp WydkaXJlY3Rpb24nXSBpcyAicnRsIgogUEFTUyB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShyb290 RWxlbWVudClbJ2ZvbnQnXSBpcyAibm9ybWFsIG5vcm1hbCBub3JtYWwgMThweC9ub3JtYWwgQWhl bSIKKyctd2Via2l0LXVzZXItbW9kaWZ5Jywgb24gdGhlIG90aGVyIGhhbmQsIHNob3VsZCBub3Qg YmUgaW5oZXJpdGVkLgorUEFTUyB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShyb290RWxlbWVudClb Jy13ZWJraXQtdXNlci1tb2RpZnknXSBpcyAicmVhZC1vbmx5IgogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1pbmhlcml0ZWQtZG9jdW1lbnQt c3R5bGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWlu aGVyaXRlZC1kb2N1bWVudC1zdHlsZS5odG1sCmluZGV4IDhiZmI1MDg0NzU3Zjk3MTVkYzViNmI3 NjZhNzhkNjZhM2RmNmY2NGUuLjAyNDc2YzNhOTQ4ZGU2NDdmMDdkYzJiNDhjMDJhMTAwYjk2Njk2 YjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNz LWluaGVyaXRlZC1kb2N1bWVudC1zdHlsZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZnJh bWVzL3NlYW1sZXNzL3NlYW1sZXNzLWluaGVyaXRlZC1kb2N1bWVudC1zdHlsZS5odG1sCkBAIC0x NywxMCArMTcsMTIgQEAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uICgpIHsKICAgICB3aW5kb3cu aWZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlmcmFtZSIpOwogICAgIHdpbmRvdy5y b290RWxlbWVudCA9IGlmcmFtZS5jb250ZW50RG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50OwogICAg IHNob3VsZEJlRXF1YWxUb1N0cmluZygid2luZG93LmdldENvbXB1dGVkU3R5bGUocm9vdEVsZW1l bnQpWyctd2Via2l0LXJ0bC1vcmRlcmluZyddIiwgInZpc3VhbCIpOwotICAgIHNob3VsZEJlRXF1 YWxUb1N0cmluZygid2luZG93LmdldENvbXB1dGVkU3R5bGUocm9vdEVsZW1lbnQpWyctd2Via2l0 LXVzZXItbW9kaWZ5J10iLCAicmVhZC13cml0ZSIpOwogICAgIHNob3VsZEJlRXF1YWxUb1N0cmlu Zygid2luZG93LmdldENvbXB1dGVkU3R5bGUocm9vdEVsZW1lbnQpWyctd2Via2l0LWxvY2FsZSdd IiwgImVuX1VTIik7CiAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ3aW5kb3cuZ2V0Q29tcHV0 ZWRTdHlsZShyb290RWxlbWVudClbJ3dyaXRpbmctbW9kZSddIiwgImxyIik7CiAgICAgc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCJ3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShyb290RWxlbWVudClbJ2Rp cmVjdGlvbiddIiwgInJ0bCIpOwogICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygid2luZG93Lmdl dENvbXB1dGVkU3R5bGUocm9vdEVsZW1lbnQpWydmb250J10iLCAibm9ybWFsIG5vcm1hbCBub3Jt YWwgMThweC9ub3JtYWwgQWhlbSIpOworCisgICAgZGVidWcoIictd2Via2l0LXVzZXItbW9kaWZ5 Jywgb24gdGhlIG90aGVyIGhhbmQsIHNob3VsZCBub3QgYmUgaW5oZXJpdGVkLiIpOworICAgIHNo b3VsZEJlRXF1YWxUb1N0cmluZygid2luZG93LmdldENvbXB1dGVkU3R5bGUocm9vdEVsZW1lbnQp Wyctd2Via2l0LXVzZXItbW9kaWZ5J10iLCAicmVhZC1vbmx5Iik7CiB9CiA8L3NjcmlwdD4K