108061 2013-01-28 00:58:39 -0800 [CMake] Use offical Windows CE support 2013-01-29 12:09:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97592 1 paroga paroga dbates laszlo.gombos webkit.review.bot oldest_to_newest 817580 0 paroga 2013-01-28 00:58:39 -0800 [CMake] Use offical Windwos CE support 817628 1 184959 paroga 2013-01-28 02:07:45 -0800 Created attachment 184959 Patch 818577 2 184959 dbates 2013-01-28 22:57:48 -0800 Comment on attachment 184959 Patch Can you elaborate on when such support was added to CMake? 818611 3 paroga 2013-01-28 23:40:43 -0800 (In reply to comment #2) > (From update of attachment 184959 [details]) > Can you elaborate on when such support was added to CMake? It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601 818871 4 laszlo.gombos 2013-01-29 05:53:24 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 184959 [details] [details]) > > Can you elaborate on when such support was added to CMake? > > It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601 According to http://www.vtk.org/Wiki/CMake_Cross_Compiling this is in CMake 2.8.11. Would it make sense to add cmake_minimum_required(VERSION 2.8.3) to OptionsWinCE.cmake (or somewhere else and guard it with WinCE). The change in webkitdirs.pm looks good to me. 818873 5 184959 laszlo.gombos 2013-01-29 05:54:26 -0800 Comment on attachment 184959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184959&action=review > Tools/ChangeLog:3 > + [CMake] Use offical Windwos CE support Typo: Windwos --> Windows. 818875 6 paroga 2013-01-29 05:57:47 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 184959 [details] [details] [details]) > > > Can you elaborate on when such support was added to CMake? > > > > It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601 > > According to http://www.vtk.org/Wiki/CMake_Cross_Compiling this is in CMake 2.8.11. > > Would it make sense to add cmake_minimum_required(VERSION 2.8.3) to OptionsWinCE.cmake (or somewhere else and guard it with WinCE). No, since the WinCE port is not Windows CE only and can be built on Win32 with older compilers too. (In reply to comment #5) > (From update of attachment 184959 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184959&action=review > > > Tools/ChangeLog:3 > > + [CMake] Use offical Windwos CE support > > Typo: Windwos --> Windows. I'll fix it when landing manually. Can someone please r+ this simple change? 818972 7 184959 laszlo.gombos 2013-01-29 08:31:55 -0800 Comment on attachment 184959 Patch r=me. Please fix the typo in the ChangeLog title before landing. 819178 8 paroga 2013-01-29 12:09:57 -0800 Committed r141137: <http://trac.webkit.org/changeset/141137> 184959 2013-01-28 02:07:45 -0800 2013-01-29 08:31:55 -0800 Patch bug-108061.patch text/plain 1267 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMDA2 NTIzLi45MWU1YTNjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMjggIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NNYWtlXSBVc2Ugb2ZmaWNhbCBXaW5kd29z IENFIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwODA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlY2VudCB2ZXJzaW9uIG9mIENNYWtlIGhhcyBhZGRlZCBXaW5kb3dzIENFIHN1cHBvcnQs IGJ1dCB1c2VzIGEKKyAgICAgICAgc2xpZ2h0bHkgZGlmZmVyZW50IGludGVyZmFjZSB0aGFuIHRo ZSBwYXRjaGVkIHZlcnNpb24gdXNlZCBiZWZvcmUuCisgICAgICAgIENoYW5nZSB0aGUgY29tbWFu ZCBsaW5lIHBhcmFtZXRlcnMgdG8gdXNlIHRoZSBvZmZpY2FsIENNYWtlIGJpbmFyaWVzLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoY21ha2VCYXNlZFBvcnRB cmd1bWVudHMpOgorCiAyMDEzLTAxLTI2ICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNv bT4KIAogICAgICAgICBNYWtlZmlsZXMgc2hvdWxkIHdvcmsgZm9yIGFyYml0cmFyeSBTREtzIGFu ZCBhcmNoaXRlY3R1cmVzIG9uIEFwcGxlIHBvcnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZTk0MDZl My4uNWIyOGQxMyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjI5Nyw3ICsyMjk3LDcgQEAgc3ViIGJ1 aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCQkJCRAKQogc3ViIGNtYWtlQmFzZWRQb3J0QXJndW1lbnRz KCkKIHsKICAgICByZXR1cm4gYmxhY2tiZXJyeUNNYWtlQXJndW1lbnRzKCkgaWYgaXNCbGFja0Jl cnJ5KCk7Ci0gICAgcmV0dXJuICgnLURDTUFLRV9XSU5DRV9TREs9IlNUQU5EQVJEU0RLXzUwMCAo QVJNVjRJKSInKSBpZiBpc1dpbkNFKCk7CisgICAgcmV0dXJuICgnLUcgIlZpc3VhbCBTdHVkaW8g OCAyMDA1IFNUQU5EQVJEU0RLXzUwMCAoQVJNVjRJKSInKSBpZiBpc1dpbkNFKCk7CiAgICAgcmV0 dXJuICgpOwogfQogCg==