108056 2013-01-28 00:00:18 -0800 [wk2] WKView's intrinsicContentSize should only report a flexible width if the content width is less than the minimum width 2013-01-28 13:39:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca sam simon.fraser oldest_to_newest 817553 0 thorton 2013-01-28 00:00:18 -0800 Right now, we're returning flexible width if content size is less than *or equal* to the minimum layout width. This is wrong and causes ping-ponging between flexible and inflexible intrinsic content width in cases where autolayout fits our view to exactly the intrinsic content size. <rdar://problem/13066798> 817556 1 184942 thorton 2013-01-28 00:02:20 -0800 Created attachment 184942 patch 818054 2 thorton 2013-01-28 13:39:24 -0800 http://trac.webkit.org/changeset/141003 184942 2013-01-28 00:02:20 -0800 2013-01-28 09:29:18 -0800 patch autolayout.diff text/plain 2319 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YWY2NzliLi5lYzdiZWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDEtMjcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gV0tWaWV3J3MgaW50cmluc2ljQ29udGVudFNpemUgc2hvdWxkIG9ubHkg cmVwb3J0IGEgZmxleGlibGUgd2lkdGggaWYgdGhlIGNvbnRlbnQgd2lkdGggaXMgbGVzcyB0aGFu IHRoZSBtaW5pbXVtIHdpZHRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDgwNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZSdyZSBjdXJyZW50bHkgcmVwb3J0aW5nIGEgZmxleGlibGUgd2lkdGggaWYg dGhlIGludHJpbnNpYworICAgICAgICBjb250ZW50IHNpemUgaXMgbGVzcyB0aGFuICpvciBlcXVh bCogdG8gdGhlIG1pbmltdW0gbGF5b3V0CisgICAgICAgIHdpZHRoLiBUaGlzIGlzIHdyb25nIGFu ZCBjYXVzZXMgcGluZy1wb25naW5nIGJldHdlZW4gZmxleGlibGUKKyAgICAgICAgYW5kIGluZmxl eGlibGUgd2lkdGggaW4gY2FzZXMgd2hlcmUgYXV0b2xheW91dCBmaXRzIG91cgorICAgICAgICB2 aWV3IHRvIGV4YWN0bHkgdGhlIGludHJpbnNpYyBjb250ZW50IHNpemUuIEl0IHNob3VsZCBiZSBz dHJpY3RseQorICAgICAgICBsZXNzIHRoYW4gaW5zdGVhZC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF9zZXRJbnRyaW5zaWNDb250 ZW50U2l6ZTpdKToKKwogMjAxMy0wMS0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBGaXggbG9jYXRpb24gb2Ygc2FuZGJveCBwcm9maWxlcyBpbiBidWls dCBwcm9kdWN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMv V0tWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmlu ZGV4IDc5YzExYTEuLjgxYTMxZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXcubW0KQEAgLTI4NTcsMTIgKzI4NTcsMTIgQEAgc3RhdGljIE5TU3RyaW5nICpwYXRo V2l0aFVuaXF1ZUZpbGVuYW1lRm9yUGF0aChOU1N0cmluZyAqcGF0aCkKIAogLSAodm9pZClfc2V0 SW50cmluc2ljQ29udGVudFNpemU6KE5TU2l6ZSlpbnRyaW5zaWNDb250ZW50U2l6ZQogewotICAg IC8vIElmIHRoZSBpbnRyaW5zaWMgY29udGVudCBzaXplIGlzIHRoZSBzYW1lIGFzIHRoZSBtaW5p bXVtIGxheW91dCB3aWR0aCwgdGhlIGNvbnRlbnQgZmxvd2VkIHRvIGZpdCwKLSAgICAvLyBzbyB3 ZSBjYW4gcmVwb3J0IHRoYXQgdGhhdCBkaW1lbnNpb24gaXMgZmxleGlibGUuIElmIG5vdCwgd2Ug bmVlZCB0byByZXBvcnQgb3VyIGdyZWF0ZXIgaW50cmluc2ljIHdpZHRoCisgICAgLy8gSWYgdGhl IGludHJpbnNpYyBjb250ZW50IHNpemUgaXMgbGVzcyB0aGFuIHRoZSBtaW5pbXVtIGxheW91dCB3 aWR0aCwgdGhlIGNvbnRlbnQgZmxvd2VkIHRvIGZpdCwKKyAgICAvLyBzbyB3ZSBjYW4gcmVwb3J0 IHRoYXQgdGhhdCBkaW1lbnNpb24gaXMgZmxleGlibGUuIElmIG5vdCwgd2UgbmVlZCB0byByZXBv cnQgb3VyIGludHJpbnNpYyB3aWR0aAogICAgIC8vIHNvIHRoYXQgYXV0b2xheW91dCB3aWxsIGtu b3cgdG8gcHJvdmlkZSBzcGFjZSBmb3IgdXMuCiAKICAgICBOU1NpemUgaW50cmluc2ljQ29udGVu dFNpemVBY2tub3dsZWRnaW5nRmxleGlibGVXaWR0aCA9IGludHJpbnNpY0NvbnRlbnRTaXplOwot ICAgIGlmIChpbnRyaW5zaWNDb250ZW50U2l6ZS53aWR0aCA8PSBfZGF0YS0+X3BhZ2UtPm1pbmlt dW1MYXlvdXRXaWR0aCgpKQorICAgIGlmIChpbnRyaW5zaWNDb250ZW50U2l6ZS53aWR0aCA8IF9k YXRhLT5fcGFnZS0+bWluaW11bUxheW91dFdpZHRoKCkpCiAgICAgICAgIGludHJpbnNpY0NvbnRl bnRTaXplQWNrbm93bGVkZ2luZ0ZsZXhpYmxlV2lkdGgud2lkdGggPSBOU1ZpZXdOb0luc3RyaW5z aWNNZXRyaWM7CiAKICAgICBfZGF0YS0+X2ludHJpbnNpY0NvbnRlbnRTaXplID0gaW50cmluc2lj Q29udGVudFNpemVBY2tub3dsZWRnaW5nRmxleGlibGVXaWR0aDsK