<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>108046</bug_id>
          
          <creation_ts>2013-01-27 20:05:59 -0800</creation_ts>
          <short_desc>[ANDROID] Fix a typo from HAVE_NMAP to HAVE_MMAP</short_desc>
          <delta_ts>2013-01-27 21:17:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>benjamin</cc>
    
    <cc>eric</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>peter</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>817483</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2013-01-27 20:05:59 -0800</bug_when>
    <thetext>The typo was committed as part of http://trac.webkit.org/changeset/94235 .

It seems to me that ANDROID build does not build any code where this define is important that is why the typo was not detected.

I will look into consolidating the definition of this macro, but before doing so it would be good to get a confirmation that this is indeed a typo.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817486</commentid>
    <comment_count>1</comment_count>
      <attachid>184932</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2013-01-27 20:14:10 -0800</bug_when>
    <thetext>Created attachment 184932
proposed change</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817501</commentid>
    <comment_count>2</comment_count>
      <attachid>184932</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-27 21:17:12 -0800</bug_when>
    <thetext>Comment on attachment 184932
proposed change

Clearing flags on attachment: 184932

Committed r140942: &lt;http://trac.webkit.org/changeset/140942&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>817502</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-27 21:17:16 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>184932</attachid>
            <date>2013-01-27 20:14:10 -0800</date>
            <delta_ts>2013-01-27 21:17:11 -0800</delta_ts>
            <desc>proposed change</desc>
            <filename>108046.patch</filename>
            <type>text/plain</type>
            <size>970</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxNDA5MzcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTI3ICBMYXN6bG8gR29tYm9zICA8bC5n
b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0FORFJPSURdIEZpeCBhIHR5cG8KKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODA0NgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhBVkVfTk1BUCAtPiBI
QVZFX01NQVAuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxMy0wMS0yNyAgWm9s
dGFuIEFydmFpICA8emFydmFpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBGaXhpbmcgYXRv
bWljSW5jcmVtZW50IGltcGxlbWVudGF0aW9uIGZvciBXaW5kb3dzIGJ5IGRyb3BwaW5nIHN1cHBv
cnQgYmVmb3JlIFhQIFNQMi4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMTQwOTMzKQorKysg
U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNzU5LDcgKzc1OSw3
IEBACiAjZWxpZiBPUyhBTkRST0lEKQogCiAjZGVmaW5lIEhBVkVfRVJSTk9fSCAxCi0jZGVmaW5l
IEhBVkVfTk1BUCAxCisjZGVmaW5lIEhBVkVfTU1BUCAxCiAjZGVmaW5lIEhBVkVfU1RSSU5HU19I
IDEKICNkZWZpbmUgSEFWRV9TWVNfUEFSQU1fSCAxCiAjZGVmaW5lIEhBVkVfU1lTX1RJTUVfSCAx
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>