108018 2013-01-26 17:15:41 -0800 Collapse testing for list of PLATFORM() into OS() and USE() tests 2013-01-28 23:01:17 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned ddkilzer eric webkit.review.bot oldest_to_newest 817290 0 laszlo.gombos 2013-01-26 17:15:41 -0800 OS() and USE() tests are preferred over a series of PLATFORM() tests for "for low-level services" - see also the discussion at bug 107406. JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT), PLATFORM(WX) and PLATFORM(GTK), so "PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))" can be replaced by "OS(DARWIN) && USE(CF)" which makes the code more readable as well. PLATFORM(MAC), PLATFORM(QT) and PLATFORM(WX) are all enable USE(CF) but not PLATFORM(GTK). 817294 1 184893 laszlo.gombos 2013-01-26 18:26:49 -0800 Created attachment 184893 proposed change 818553 2 184893 eric 2013-01-28 22:41:34 -0800 Comment on attachment 184893 proposed change LGTM. 818582 3 184893 webkit.review.bot 2013-01-28 23:01:13 -0800 Comment on attachment 184893 proposed change Clearing flags on attachment: 184893 Committed r141059: <http://trac.webkit.org/changeset/141059> 818583 4 webkit.review.bot 2013-01-28 23:01:17 -0800 All reviewed patches have been landed. Closing bug. 184893 2013-01-26 18:26:49 -0800 2013-01-28 23:01:13 -0800 proposed change 108018.patch text/plain 2255 laszlo.gombos SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwOTIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTAxLTI2ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgQ29sbGFwc2UgdGVzdGluZyBmb3IgYSBsaXN0IG9mIFBMQVRGT1JNKCkgaW50byBPUygp IGFuZCBVU0UoKSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4MDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2UgYXMgIk9TKERBUldJTikgJiYgVVNFKENGKSIg ZXF1YWxzIHRvIHRoZQorICAgICAgICBmb2xsb3dpbmcgcGxhdGZvcm1zOiBNQUMsIFdYLCBRVCBh bmQgQ0hST01JVU0uIENIUk9NSVVNCisgICAgICAgIGlzIG5vdCB1c2luZyBKYXZhU2NyaXB0Q29y ZS4gCisKKyAgICAgICAgKiBydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlND KToKKwogMjAxMy0wMS0yNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAg ICAgIERGRyB2YXJpYWJsZSBldmVudCBzdHJlYW0gc2hvdWxkbid0IHVzZSBOb2RlSW5kZXgKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3Bw CShyZXZpc2lvbiAxNDA4MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRl UHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsNyArNjEsNyBAQAogI2luY2x1ZGUg PHN5cy90aW1lYi5oPgogI2VuZGlmCiAKLSNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKElP UykgfHwgKFBMQVRGT1JNKFdYKSAmJiBPUyhEQVJXSU4pKSB8fCAoUExBVEZPUk0oUVQpICYmIE9T KERBUldJTikpCisjaWYgT1MoREFSV0lOKSAmJiBVU0UoQ0YpCiAjaW5jbHVkZSA8Q29yZUZvdW5k YXRpb24vQ29yZUZvdW5kYXRpb24uaD4KICNlbGlmIFVTRShJQ1VfVU5JQ09ERSkKICNpbmNsdWRl IDx1bmljb2RlL3VkYXQuaD4KQEAgLTEyNSw5ICsxMjUsOSBAQCBuYW1lc3BhY2UgSlNDIHsKIAog ZW51bSBMb2NhbGVEYXRlVGltZUZvcm1hdCB7IExvY2FsZURhdGVBbmRUaW1lLCBMb2NhbGVEYXRl LCBMb2NhbGVUaW1lIH07CiAgCi0jaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShJT1MpIHx8 IChQTEFURk9STShXWCkgJiYgT1MoREFSV0lOKSkgfHwgKFBMQVRGT1JNKFFUKSAmJiBPUyhEQVJX SU4pKQorI2lmIE9TKERBUldJTikgJiYgVVNFKENGKQogCi0vLyBGSVhNRTogU2luY2UgdGhpcyBp cyBzdXBlcmlvciB0byB0aGUgc3RyZnRpbWUtYmFzZWQgdmVyc2lvbiwgd2h5IGxpbWl0IHRoaXMg dG8gUExBVEZPUk0oTUFDKT8KKy8vIEZJWE1FOiBTaW5jZSB0aGlzIGlzIHN1cGVyaW9yIHRvIHRo ZSBzdHJmdGltZS1iYXNlZCB2ZXJzaW9uLCB3aHkgbGltaXQgdGhpcyB0byBPUyhEQVJXSU4pPwog Ly8gSW5zdGVhZCB3ZSBzaG91bGQgY29uc2lkZXIgdXNpbmcgdGhpcyB3aGVuZXZlciBVU0UoQ0Yp IGlzIHRydWUuCiAKIHN0YXRpYyBDRkRhdGVGb3JtYXR0ZXJTdHlsZSBzdHlsZUZyb21BcmdTdHJp bmcoY29uc3QgU3RyaW5nJiBzdHJpbmcsIENGRGF0ZUZvcm1hdHRlclN0eWxlIGRlZmF1bHRTdHls ZSkKQEAgLTMzNyw3ICszMzcsNyBAQCBzdGF0aWMgSlNDZWxsKiBmb3JtYXRMb2NhbGVEYXRlKEV4 ZWNTdGF0CiAgICAgcmV0dXJuIGZvcm1hdExvY2FsZURhdGUoZXhlYywgKmdyZWdvcmlhbkRhdGVU aW1lLCBmb3JtYXQpOwogfQogCi0jZW5kaWYgLy8gIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JN KElPUykKKyNlbmRpZiAvLyBPUyhEQVJXSU4pICYmIFVTRShDRikKIAogc3RhdGljIEVuY29kZWRK U1ZhbHVlIGZvcm1hdGVEYXRlSW5zdGFuY2UoRXhlY1N0YXRlKiBleGVjLCBEYXRlVGltZUZvcm1h dCBmb3JtYXQsIGJvb2wgYXNVVENWYXJpYW50KQogewo=