108012 2013-01-26 13:54:50 -0800 [chromium] add missing plumbing for Notification.requestPermission 2013-01-27 13:05:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth jonlee webkit.review.bot oldest_to_newest 817258 0 jochen 2013-01-26 13:54:50 -0800 [chromium] add missing plumbing for Notification.requestPermission 817259 1 184884 jochen 2013-01-26 13:55:14 -0800 Created attachment 184884 Patch 817406 2 184884 webkit.review.bot 2013-01-27 13:05:51 -0800 Comment on attachment 184884 Patch Clearing flags on attachment: 184884 Committed r140928: <http://trac.webkit.org/changeset/140928> 817407 3 webkit.review.bot 2013-01-27 13:05:55 -0800 All reviewed patches have been landed. Closing bug. 184884 2013-01-26 13:55:14 -0800 2013-01-27 13:05:51 -0800 Patch bug-108012-20130126225203.patch text/plain 7517 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU1NWIyZGU1NDcyMTJhNjhiMjRkNTY5OWVhMmU0MjA3Zjg3Y2U1YWEuLjUyNjBkNzU5OGNmMzdk MzdiYzIwZGFhMzQzNTU5NDBmM2ExNWU5NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTMtMDEtMjYgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBhZGQgbWlzc2luZyBwbHVtYmluZyBmb3Ig Tm90aWZpY2F0aW9uLnJlcXVlc3RQZXJtaXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgwMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OlZvaWRDYWxsYmFja0NsaWVu dDo6Vm9pZENhbGxiYWNrQ2xpZW50KToKKyAgICAgICAgKE5vdGlmaWNhdGlvblBlcm1pc3Npb25D YWxsYmFja0NsaWVudCk6CisgICAgICAgIChXZWJLaXQ6Ok5vdGlmaWNhdGlvblBlcm1pc3Npb25D YWxsYmFja0NsaWVudDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrQ2xpZW50KToKKyAg ICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrQ2xpZW50OjpwZXJt aXNzaW9uUmVxdWVzdENvbXBsZXRlKToKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVy bWlzc2lvbkNhbGxiYWNrQ2xpZW50Ojp+Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrQ2xp ZW50KToKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUHJlc2VudGVySW1wbDo6cmVxdWVz dFBlcm1pc3Npb24pOgorICAgICAgICAqIHNyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmg6 CisgICAgICAgIChOb3RpZmljYXRpb25QcmVzZW50ZXJJbXBsKToKKwogMjAxMy0wMS0yNiAgSmFt ZXMgU2ltb25zZW4gIDxzaW1vbmphbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVt XSBFeHBvcnQgUmVzb3VyY2VSZXF1ZXN0J3MgcHJpb3JpdHkgdGhyb3VnaCBXZWJVUkxSZXF1ZXN0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Ob3RpZmljYXRpb25QcmVz ZW50ZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL05vdGlmaWNhdGlvblBy ZXNlbnRlckltcGwuY3BwCmluZGV4IGQ2ZGY3MmVmYjYyNjJjMDM1MTViNGIzODhkZDdlNjY2MDVi ZjE3ZmYuLmQ2ZTkzNGNiNzJlYmMzYjAwNzAxMDZmZWI4MWI0M2Y2N2VjMTE4NWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL05vdGlmaWNhdGlvblByZXNlbnRlckltcGwu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL05vdGlmaWNhdGlvblByZXNlbnRl ckltcGwuY3BwCkBAIC00OSw5ICs0OSwxMCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAog bmFtZXNwYWNlIFdlYktpdCB7CiAKKyNpZiBFTkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMpCiBj bGFzcyBWb2lkQ2FsbGJhY2tDbGllbnQgOiBwdWJsaWMgV2ViTm90aWZpY2F0aW9uUGVybWlzc2lv bkNhbGxiYWNrIHsKIHB1YmxpYzoKLSAgICBWb2lkQ2FsbGJhY2tDbGllbnQoUGFzc1JlZlB0cjxW b2lkQ2FsbGJhY2s+IGNhbGxiYWNrKQorICAgIGV4cGxpY2l0IFZvaWRDYWxsYmFja0NsaWVudChQ YXNzUmVmUHRyPFZvaWRDYWxsYmFjaz4gY2FsbGJhY2spCiAgICAgICAgIDogbV9jYWxsYmFjayhj YWxsYmFjaykKICAgICB7CiAgICAgfQpAQCAtNjgsNiArNjksMzMgQEAgcHJpdmF0ZToKIAogICAg IFJlZlB0cjxWb2lkQ2FsbGJhY2s+IG1fY2FsbGJhY2s7CiB9OworI2VuZGlmIC8vIEVOQUJMRShM RUdBQ1lfTk9USUZJQ0FUSU9OUykKKworI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQorY2xhc3Mg Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrQ2xpZW50IDogcHVibGljIFdlYk5vdGlmaWNh dGlvblBlcm1pc3Npb25DYWxsYmFjayB7CitwdWJsaWM6CisgICAgTm90aWZpY2F0aW9uUGVybWlz c2lvbkNhbGxiYWNrQ2xpZW50KFdlYk5vdGlmaWNhdGlvblByZXNlbnRlciogcHJlc2VudGVyLCBQ YXNzUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiBzZWN1cml0eU9yaWdpbiwgUGFzc1JlZlB0cjxOb3Rp ZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2s+IGNhbGxiYWNrKQorICAgICAgICA6IG1fcHJlc2Vu dGVyKHByZXNlbnRlcikKKyAgICAgICAgLCBtX3NlY3VyaXR5T3JpZ2luKHNlY3VyaXR5T3JpZ2lu KQorICAgICAgICAsIG1fY2FsbGJhY2soY2FsbGJhY2spCisgICAgeworICAgIH0KKworICAgIHZp cnR1YWwgdm9pZCBwZXJtaXNzaW9uUmVxdWVzdENvbXBsZXRlKCkKKyAgICB7CisgICAgICAgIGlm IChtX2NhbGxiYWNrKQorICAgICAgICAgICAgbV9jYWxsYmFjay0+aGFuZGxlRXZlbnQoTm90aWZp Y2F0aW9uOjpwZXJtaXNzaW9uU3RyaW5nKHN0YXRpY19jYXN0PE5vdGlmaWNhdGlvbkNsaWVudDo6 UGVybWlzc2lvbj4obV9wcmVzZW50ZXItPmNoZWNrUGVybWlzc2lvbihXZWJTZWN1cml0eU9yaWdp bihtX3NlY3VyaXR5T3JpZ2luKSkpKSk7CisgICAgICAgIGRlbGV0ZSB0aGlzOworICAgIH0KKwor cHJpdmF0ZToKKyAgICB2aXJ0dWFsIH5Ob3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2tDbGll bnQoKSB7IH0KKworICAgIFdlYk5vdGlmaWNhdGlvblByZXNlbnRlciogbV9wcmVzZW50ZXI7Cisg ICAgUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiBtX3NlY3VyaXR5T3JpZ2luOworICAgIFJlZlB0cjxO b3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2s+IG1fY2FsbGJhY2s7Cit9OworI2VuZGlmIC8v IEVOQUJMRShOT1RJRklDQVRJT05TKQogCiB2b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckltcGw6 OmluaXRpYWxpemUoV2ViTm90aWZpY2F0aW9uUHJlc2VudGVyKiBwcmVzZW50ZXIpCiB7CkBAIC0x MDQsMTAgKzEzMiwxOSBAQCBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb24gTm90aWZpY2F0 aW9uUHJlc2VudGVySW1wbDo6Y2hlY2tQZXJtaXNzaW9uKFNjcmlwdAogICAgIHJldHVybiBzdGF0 aWNfY2FzdDxOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb24+KHJlc3VsdCk7CiB9CiAKKyNp ZiBFTkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMpCiB2b2lkIE5vdGlmaWNhdGlvblByZXNlbnRl ckltcGw6OnJlcXVlc3RQZXJtaXNzaW9uKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQs IFBhc3NSZWZQdHI8Vm9pZENhbGxiYWNrPiBjYWxsYmFjaykKIHsKICAgICBtX3ByZXNlbnRlci0+ cmVxdWVzdFBlcm1pc3Npb24oV2ViU2VjdXJpdHlPcmlnaW4oY29udGV4dC0+c2VjdXJpdHlPcmln aW4oKSksIG5ldyBWb2lkQ2FsbGJhY2tDbGllbnQoY2FsbGJhY2spKTsKIH0KKyNlbmRpZiAvLyBF TkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMpCisKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykK K3ZvaWQgTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbDo6cmVxdWVzdFBlcm1pc3Npb24oU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgV1RGOjpQYXNzUmVmUHRyPE5vdGlmaWNhdGlvblBl cm1pc3Npb25DYWxsYmFjaz4gY2FsbGJhY2spCit7CisgICAgbV9wcmVzZW50ZXItPnJlcXVlc3RQ ZXJtaXNzaW9uKFdlYlNlY3VyaXR5T3JpZ2luKGNvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCkpLCBu ZXcgTm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrQ2xpZW50KG1fcHJlc2VudGVyLCBjb250 ZXh0LT5zZWN1cml0eU9yaWdpbigpLCBjYWxsYmFjaykpOworfQorI2VuZGlmIC8vIEVOQUJMRShO T1RJRklDQVRJT05TKQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5oCmluZGV4 IGQyOTY5OWVjYWUyOWQwMzc2NWE0OTM1ZmJmYzhjZGZjNzZkZmZlNWYuLjViNTZlNDUzOGUyNTkz YTliYzU2YTViNWFiZTg4MDgzM2Y2NzE2MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmgKQEAgLTYwLDcgKzYwLDcg QEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCByZXF1ZXN0UGVybWlzc2lvbihXZWJDb3JlOjpT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiwgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OlZvaWRDYWxs YmFjaz4gY2FsbGJhY2spOwogI2VuZGlmCiAjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCi0gICAg dmlydHVhbCB2b2lkIHJlcXVlc3RQZXJtaXNzaW9uKFdlYkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNv bnRleHQqLCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNh bGxiYWNrPiBjYWxsYmFjaykgeyB9CisgICAgdmlydHVhbCB2b2lkIHJlcXVlc3RQZXJtaXNzaW9u KFdlYkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29y ZTo6Tm90aWZpY2F0aW9uUGVybWlzc2lvbkNhbGxiYWNrPik7CiAjZW5kaWYKICAgICB2aXJ0dWFs IHZvaWQgY2FuY2VsUmVxdWVzdHNGb3JQZXJtaXNzaW9uKFdlYkNvcmU6OlNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqKSB7fQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmUyN2MzYjRjNzAzZGY1ZTkwNjJmZjQwMWFmMjEwNzcy OTFlYWMzZi4uN2M1YmQ0YjMzNzNhNzU3MjE0ZGJiZjBkZWYwYzU1MWE1ZjU3MDZlMyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEzLTAxLTI2ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRkIG1pc3NpbmcgcGx1bWJpbmcgZm9y IE5vdGlmaWNhdGlvbi5yZXF1ZXN0UGVybWlzc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9u cy1jb25zdHJ1Y3Rvci1yZXF1ZXN0LXBlcm1pc3Npb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1jb25zdHJ1Y3Rvci1yZXF1 ZXN0LXBlcm1pc3Npb24uaHRtbDogQWRkZWQuCisKIDIwMTMtMDEtMjYgIFJvYmVydCBIb2dhbiAg PHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyMDYxNik6IENlbGwn cyBsb2dpY2FsIGhlaWdodCB3cm9uZ2x5IGNvbXB1dGVkIHdpdGggdmVydGljYWwtYWxpZ246IGJh c2VsaW5lIGFuZCByb3dzcGFuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L25vdGlmaWNh dGlvbnMvbm90aWZpY2F0aW9ucy1jb25zdHJ1Y3Rvci1yZXF1ZXN0LXBlcm1pc3Npb24tZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtY29u c3RydWN0b3ItcmVxdWVzdC1wZXJtaXNzaW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41ZDc2 MDE1YmExNjc1NmY1MDcwYWE0NDYwMzNhOWM0NDMxMmExYjUxCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtY29uc3RydWN0b3It cmVxdWVzdC1wZXJtaXNzaW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK0RFU0tUT1Ag Tk9USUZJQ0FUSU9OIFBFUk1JU1NJT04gUkVRVUVTVEVEOiBmaWxlOi8vCitSZXF1ZXN0aW5nIG5v dGlmaWNhdGlvbiBwZXJtaXNzaW9uLi4uCisKK1BBU1M6IFBlcm1pc3Npb24gY2FsbGJhY2sgaW52 b2tlZC4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRpb25zL25vdGlm aWNhdGlvbnMtY29uc3RydWN0b3ItcmVxdWVzdC1wZXJtaXNzaW9uLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1jb25zdHJ1Y3Rvci1yZXF1ZXN0LXBl cm1pc3Npb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42NWE2YmYyNDkzN2MxMmY3MmJkZWY2ODVlMGQyYTg2 YTQxMDBlYzkyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRp b25zL25vdGlmaWNhdGlvbnMtY29uc3RydWN0b3ItcmVxdWVzdC1wZXJtaXNzaW9uLmh0bWwKQEAg LTAsMCArMSwzNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3Jp cHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgZnVuY3Rpb24gbG9nKG1lc3NhZ2Up CisgICAgICAgIHsKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQi KS5pbm5lckhUTUwgKz0gbWVzc2FnZSArICI8YnI+IjsKKyAgICAgICAgfQorICAgICAgICAKKyAg ICAgICAgZnVuY3Rpb24gcnVuVGVzdHMoKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAod2lu ZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgaWYgKCF3aW5kb3cuTm90aWZpY2F0aW9u KSB7CisgICAgICAgICAgICAgICAgbG9nKCJGQUlMOiBObyBOb3RpZmljYXRpb24gaW50ZXJmYWNl ISIpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgCisgICAgICAgICAgICB2YXIgTiA9IHdp bmRvdy5Ob3RpZmljYXRpb24ucmVxdWVzdFBlcm1pc3Npb24oCisgICAgICAgICAgICAgICAgZnVu Y3Rpb24oKSB7IGxvZygiUEFTUzogUGVybWlzc2lvbiBjYWxsYmFjayBpbnZva2VkLiIpOyB9Cisg ICAgICAgICAgICApOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KyAgICA8cD5SZXF1ZXN0aW5nIG5vdGlmaWNhdGlvbiBwZXJtaXNzaW9uLi4uPC9wPgorICAgIAor PGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4gICAgCis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCI+CitydW5UZXN0cygpOworPC9zY3JpcHQ+CisKKworPC9ib2R5PgorPC9odG1sPgo=