108006 2013-01-26 09:02:25 -0800 Fix the test for CHANNEL_MESSAGING in idl files 2013-01-26 16:11:12 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned abarth eric ojan.autocc webkit.review.bot oldest_to_newest 817210 0 laszlo.gombos 2013-01-26 09:02:25 -0800 I run into a test in an idl file which does not follow the "defined(ENABLE_XXX) && ENABLE_XXX" pattern for a conditional and instead it is only testing for "ENABLE_XXX". This seems the be the single place in idl files where this is the case - so this is likely a source for inconsistency and potentially a build issue. 817213 1 184871 laszlo.gombos 2013-01-26 10:28:06 -0800 Created attachment 184871 proposed chnage 817277 2 184871 webkit.review.bot 2013-01-26 16:11:09 -0800 Comment on attachment 184871 proposed chnage Clearing flags on attachment: 184871 Committed r140918: <http://trac.webkit.org/changeset/140918> 817278 3 webkit.review.bot 2013-01-26 16:11:12 -0800 All reviewed patches have been landed. Closing bug. 184871 2013-01-26 10:28:06 -0800 2013-01-26 16:11:09 -0800 proposed chnage 108006.patch text/plain 1367 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDkxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTI2ICBMYXN6bG8g R29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IHRoZSB0ZXN0IGZv ciBDSEFOTkVMX01FU1NBR0lORyBpbiBpZGwgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODAwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBhIGJ1aWxkIGZp eC4KKworICAgICAgICAqIHdvcmtlcnMvV29ya2VyQ29udGV4dC5pZGw6IE1ha2Ugc3VyZSBFTkFC TEVfQ0hBTk5FTF9NRVNTQUdJTkcgaXMKKyAgICAgICAgZGVmaW5lZCBiZWZvcmUgdXNpbmcgaXQg dG8gYmUgY29uc2l0ZW50IHdpdGggb3RoZXIgZ3VhcmRzIGluc2lkZSBpZGwKKyAgICAgICAgZmls ZXMuCisKIDIwMTMtMDEtMjYgIERhbiBDYXJuZXkgIDxkY2FybmV5QGdvb2dsZS5jb20+CiAKICAg ICAgICAgW3Y4XSBwcmVwYXJlIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBmb3IgdHJhbnNpdGlvbiB0 byBMYXRpbi0xCkluZGV4OiBTb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRs Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwJ KHJldmlzaW9uIDE0MDgyMSkKKysrIFNvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4 dC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTc0LDcgKzc0LDcgQEAKICAgICBhdHRyaWJ1dGUgTWVz c2FnZUV2ZW50Q29uc3RydWN0b3IgTWVzc2FnZUV2ZW50OwogICAgIGF0dHJpYnV0ZSBXb3JrZXJM b2NhdGlvbkNvbnN0cnVjdG9yIFdvcmtlckxvY2F0aW9uOwogCi0jaWYgRU5BQkxFX0NIQU5ORUxf TUVTU0FHSU5HCisjaWYgZGVmaW5lZChFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkcpICYmIEVOQUJM RV9DSEFOTkVMX01FU1NBR0lORwogICAgIFtKU0N1c3RvbUdldHRlcl0gYXR0cmlidXRlIE1lc3Nh Z2VDaGFubmVsQ29uc3RydWN0b3IgTWVzc2FnZUNoYW5uZWw7CiAjZW5kaWYKICAgICBbSlNDdXN0 b21HZXR0ZXJdIGF0dHJpYnV0ZSBFdmVudFNvdXJjZUNvbnN0cnVjdG9yIEV2ZW50U291cmNlOwo=