107984 2013-01-25 14:31:36 -0800 [chromium] Don't use goma to preprocess bindings idl files 2013-01-28 09:38:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth dpranke mike piman thakis webkit.review.bot oldest_to_newest 816916 0 tony 2013-01-25 14:31:36 -0800 [chromium] Don't use goma to preprocess bindings idl files 816918 1 184811 tony 2013-01-25 14:34:23 -0800 Created attachment 184811 Patch 816924 2 piman 2013-01-25 14:37:21 -0800 I'm cool with this, just wondering about weird build environments (a la Chrome OS chroot, though that one looks ok, or Android, that I don't know about), but maybe we already depend on /usr/bin/gcc for something else. 816926 3 tony 2013-01-25 14:39:07 -0800 (In reply to comment #2) > I'm cool with this, just wondering about weird build environments (a la Chrome OS chroot, though that one looks ok, or Android, that I don't know about), but maybe we already depend on /usr/bin/gcc for something else. Ah, I didn't think about Android. Let's see what the EWS bot thinks. 816948 4 tony 2013-01-25 15:20:20 -0800 Over email, Nico asks: > Doesn't it make more sense to let goma fall back to local if it sees a -E parameter? That's what I proposed to the goma folks. (Also, in clang builds, the script should probably use clang?) Making goma smarter sounds great to me. I don't think it matters much whether we use clang or gcc for preprocessing idl files. For example, the Qt port uses moc. 816950 5 thakis 2013-01-25 15:22:17 -0800 Before-collision text: I think a nicer fix is to let goma fall back to local if it sees -E transparently. On OS X, /usr/bin/gcc will eventually disappear. Is it possible to set this to the clang binary if clang==1 is set? 816967 6 184821 tony 2013-01-25 15:40:50 -0800 Created attachment 184821 Patch 816968 7 tony 2013-01-25 15:41:49 -0800 (In reply to comment #5) > I think a nicer fix is to let goma fall back to local if it sees -E transparently. Yeah, we should rollout after a goma fix is pushed. > On OS X, /usr/bin/gcc will eventually disappear. Is it possible to set this to the clang binary if clang==1 is set? Sure. 816975 8 184821 thakis 2013-01-25 15:46:44 -0800 Comment on attachment 184821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184821&action=review lgtm > Source/WebCore/WebCore.gyp/WebCore.gyp:245 > + ['clang==1 and OS=="mac"', { nit: This is redundant, clang is always set for OS=="mac". Probably want this for OS="ios" too. This uses the system clang instead of "our" clang, but for preprocessing I suppose that's cool. 816983 9 184827 tony 2013-01-25 15:50:46 -0800 Created attachment 184827 Patch 816985 10 thakis 2013-01-25 15:51:45 -0800 lgtm 817148 11 184827 abarth 2013-01-26 00:03:21 -0800 Comment on attachment 184827 Patch I guess it falls to me to mark this r. 817319 12 184827 webkit.review.bot 2013-01-26 22:41:09 -0800 Comment on attachment 184827 Patch Clearing flags on attachment: 184827 Committed r140925: <http://trac.webkit.org/changeset/140925> 817320 13 webkit.review.bot 2013-01-26 22:41:13 -0800 All reviewed patches have been landed. Closing bug. 817814 14 mike 2013-01-28 09:38:34 -0800 Please see bug 108089. In my environment OSX 10.6.8 environment, the hard-coding of the /usr/bin/clang path from this bug causes the build step that preprocesses the bindings idl files to generate hundreds of "clang: warning: not using the clang compiler for C++ inputs" messages. 184811 2013-01-25 14:34:23 -0800 2013-01-25 15:40:49 -0800 Patch bug-107984-20130125143114.patch text/plain 1661 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ5ZTIxNGI0Yzg2ODY1 ZWFlYWI5NmZiNjM2YmMwZmIzZGU5NTYzOC4uMGE1M2I4YmFjODU5YTBmMzBmZjYxZDkzNjFiZWE4 YTk1Y2MxMjE3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTI1ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24ndCB1 c2UgZ29tYSB0byBwcmVwcm9jZXNzIGJpbmRpbmdzIGlkbCBmaWxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3OTg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gTGludXggYW5kIE1hYywgdXNlIC91 c3IvYmluL2djYyB0byBwcmVwcm9jZXNzIHRoZSBiaW5kaW5ncyBpZGwgZmlsZXMuCisgICAgICAg IE9uIG15IG1hY2hpbmUsIHRoaXMgZHJvcHMgdGhlIGJpbmRpbmdzIGdlbmVyYXRpb24gZnJvbSAx MzdzIHRvIDI0cyB3aGVuCisgICAgICAgIHVzaW5nIGdvbWEgYW5kIC1qNDAwLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBhIGJ1aWxkIGNoYW5nZS4KKworICAgICAgICAqIFdlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwOiBGb3JjZSB0aGUgdXNlIG9mIHRoZSBsb2NhbCBnY2MgZm9yIHBy ZXByb2Nlc3NpbmcuCisKIDIwMTMtMDEtMjUgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZWdyZXNzaW9uKHIxMzk4MzYpOiBDcmFzaCBpbiBXVEY6OmVx dWFsSWdub3JpbmdDYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9X ZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4 IGRlZThhMzk2YzgyYmEzOTRmZDg1MjQ4OGU5YTBmZTRmOWQ1YWY5YzQuLmRlYzJkM2JiNWNkNTI3 ZTcxOWMzMGJkOGQ5ZmRkMWExM2UzMDczZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dl YkNvcmUuZ3lwCkBAIC0yMzksOCArMjM5LDggQEAKICAgICAgICAgJ3BlcmxfZXhlJzogJ3Blcmwn LAogICAgICAgICAnZ3BlcmZfZXhlJzogJ2dwZXJmJywKICAgICAgICAgJ2Jpc29uX2V4ZSc6ICdi aXNvbicsCi0gICAgICAgICMgV2l0aG91dCBvbmUgc3BlY2lmaWVkLCB0aGUgc2NyaXB0cyBkZWZh dWx0IHRvICdnY2MnLgotICAgICAgICAncHJlcHJvY2Vzc29yJzogJycsCisgICAgICAgICMgV2Ug c3BlY2lmeSBhIHByZXByb2Nlc3Mgc28gaXQgaGFwcGVucyBsb2NhbGx5IGFuZCB3b24ndCBnZXQg ZGlzdHJpYnV0ZWQgdG8gZ29tYS4KKyAgICAgICAgJ3ByZXByb2Nlc3Nvcic6ICctLXByZXByb2Nl c3NvciAiL3Vzci9iaW4vZ2NjIC1FIC1QIC14IGMrKyInLAogICAgICAgfV0sCiAgICAgICBbJ3Vz ZV94MTE9PTEgb3IgT1M9PSJhbmRyb2lkIicsIHsKICAgICAgICAgJ3dlYmNvcmVfaW5jbHVkZV9k aXJzJzogWwo= 184821 2013-01-25 15:40:50 -0800 2013-01-25 15:50:45 -0800 Patch bug-107984-20130125153741.patch text/plain 1859 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ5ZTIxNGI0Yzg2ODY1 ZWFlYWI5NmZiNjM2YmMwZmIzZGU5NTYzOC4uMWFmZjI5Njk0YzNkMzUxZWJmMTZkNGE0ZmRhM2Zm YjQ5YTQwOGE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTI1ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24ndCB1 c2UgZ29tYSB0byBwcmVwcm9jZXNzIGJpbmRpbmdzIGlkbCBmaWxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3OTg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gTGludXggYW5kIE1hYywgdXNlIGEg bG9jYWwgZ2NjIG9yIGNsYW5nIHRvIHByZXByb2Nlc3MgdGhlIGJpbmRpbmdzIGlkbCBmaWxlcy4K KyAgICAgICAgT24gbXkgbWFjaGluZSwgdGhpcyBkcm9wcyB0aGUgYmluZGluZ3MgZ2VuZXJhdGlv biBmcm9tIDEzN3MgdG8gMjRzIHdoZW4KKyAgICAgICAgdXNpbmcgZ29tYSBhbmQgLWo0MDAuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIGEgYnVpbGQgY2hhbmdlLgorCisgICAgICAg ICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6IEZvcmNlIHRoZSB1c2Ugb2YgdGhlIGxvY2FsIGdj YyBmb3IgcHJlcHJvY2Vzc2luZy4KKwogMjAxMy0wMS0yNSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVy bm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjEzOTgzNik6IENyYXNoIGlu IFdURjo6ZXF1YWxJZ25vcmluZ0Nhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5n eXAKaW5kZXggZGVlOGEzOTZjODJiYTM5NGZkODUyNDg4ZTlhMGZlNGY5ZDVhZjljNC4uNzQ4NjNl YTYxNjhiMjIwNTJkOTg4MWFmNzQ3MTFmNjgzYjJlMTAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5neXAvV2ViQ29yZS5neXAKQEAgLTIzOSw4ICsyMzksMTUgQEAKICAgICAgICAgJ3BlcmxfZXhl JzogJ3BlcmwnLAogICAgICAgICAnZ3BlcmZfZXhlJzogJ2dwZXJmJywKICAgICAgICAgJ2Jpc29u X2V4ZSc6ICdiaXNvbicsCi0gICAgICAgICMgV2l0aG91dCBvbmUgc3BlY2lmaWVkLCB0aGUgc2Ny aXB0cyBkZWZhdWx0IHRvICdnY2MnLgotICAgICAgICAncHJlcHJvY2Vzc29yJzogJycsCisKKyAg ICAgICAgJ2NvbmRpdGlvbnMnOiBbCisgICAgICAgICAgIyBXZSBzcGVjaWZ5IGEgcHJlcHJvY2Vz cyBzbyBpdCBoYXBwZW5zIGxvY2FsbHkgYW5kIHdvbid0IGdldCBkaXN0cmlidXRlZCB0byBnb21h LgorICAgICAgICAgIFsnY2xhbmc9PTEgYW5kIE9TPT0ibWFjIicsIHsKKyAgICAgICAgICAgICdw cmVwcm9jZXNzb3InOiAnLS1wcmVwcm9jZXNzb3IgIi91c3IvYmluL2NsYW5nIC1FIC1QIC14IGMr KyInCisgICAgICAgICAgfSx7CisgICAgICAgICAgICAncHJlcHJvY2Vzc29yJzogJy0tcHJlcHJv Y2Vzc29yICIvdXNyL2Jpbi9nY2MgLUUgLVAgLXggYysrIicKKyAgICAgICAgICB9XQorICAgICAg ICBdLAogICAgICAgfV0sCiAgICAgICBbJ3VzZV94MTE9PTEgb3IgT1M9PSJhbmRyb2lkIicsIHsK ICAgICAgICAgJ3dlYmNvcmVfaW5jbHVkZV9kaXJzJzogWwo= 184827 2013-01-25 15:50:46 -0800 2013-01-26 22:41:09 -0800 Patch bug-107984-20130125154737.patch text/plain 1868 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ5ZTIxNGI0Yzg2ODY1 ZWFlYWI5NmZiNjM2YmMwZmIzZGU5NTYzOC4uMTYxZGY4YzhhZjQ3OTU0NWExMTY5NDhkN2M5MDJl MjliMDA5Y2Y2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTI1ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24ndCB1 c2UgZ29tYSB0byBwcmVwcm9jZXNzIGJpbmRpbmdzIGlkbCBmaWxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3OTg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gTGludXggYW5kIE1hYywgdXNlIGEg bG9jYWwgZ2NjIG9yIGNsYW5nIHRvIHByZXByb2Nlc3MgdGhlIGJpbmRpbmdzIGlkbCBmaWxlcy4K KyAgICAgICAgT24gbXkgbWFjaGluZSwgdGhpcyBkcm9wcyB0aGUgYmluZGluZ3MgZ2VuZXJhdGlv biBmcm9tIDEzN3MgdG8gMjRzIHdoZW4KKyAgICAgICAgdXNpbmcgZ29tYSBhbmQgLWo0MDAuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIGEgYnVpbGQgY2hhbmdlLgorCisgICAgICAg ICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6IEZvcmNlIHRoZSB1c2Ugb2YgdGhlIGxvY2FsIGdj YyBvciBjbGFuZyBmb3IgcHJlcHJvY2Vzc2luZy4KKwogMjAxMy0wMS0yNSAgQWJoaXNoZWsgQXJ5 YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjEzOTgzNik6 IENyYXNoIGluIFdURjo6ZXF1YWxJZ25vcmluZ0Nhc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAv V2ViQ29yZS5neXAKaW5kZXggZGVlOGEzOTZjODJiYTM5NGZkODUyNDg4ZTlhMGZlNGY5ZDVhZjlj NC4uZTBkYTE5ODk3NzY0MzI2NGUxZGJjYjA2ZGJmMjliODA0MjVkMGE5MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKKysrIGIvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTIzOSw4ICsyMzksMTUgQEAKICAgICAgICAg J3BlcmxfZXhlJzogJ3BlcmwnLAogICAgICAgICAnZ3BlcmZfZXhlJzogJ2dwZXJmJywKICAgICAg ICAgJ2Jpc29uX2V4ZSc6ICdiaXNvbicsCi0gICAgICAgICMgV2l0aG91dCBvbmUgc3BlY2lmaWVk LCB0aGUgc2NyaXB0cyBkZWZhdWx0IHRvICdnY2MnLgotICAgICAgICAncHJlcHJvY2Vzc29yJzog JycsCisKKyAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCisgICAgICAgICAgIyBXZSBzcGVjaWZ5IGEg cHJlcHJvY2VzcyBzbyBpdCBoYXBwZW5zIGxvY2FsbHkgYW5kIHdvbid0IGdldCBkaXN0cmlidXRl ZCB0byBnb21hLgorICAgICAgICAgIFsnT1M9PSJtYWMiIG9yIE9TPT0iaW9zIicsIHsKKyAgICAg ICAgICAgICdwcmVwcm9jZXNzb3InOiAnLS1wcmVwcm9jZXNzb3IgIi91c3IvYmluL2NsYW5nIC1F IC1QIC14IGMrKyInCisgICAgICAgICAgfSx7CisgICAgICAgICAgICAncHJlcHJvY2Vzc29yJzog Jy0tcHJlcHJvY2Vzc29yICIvdXNyL2Jpbi9nY2MgLUUgLVAgLXggYysrIicKKyAgICAgICAgICB9 XQorICAgICAgICBdLAogICAgICAgfV0sCiAgICAgICBbJ3VzZV94MTE9PTEgb3IgT1M9PSJhbmRy b2lkIicsIHsKICAgICAgICAgJ3dlYmNvcmVfaW5jbHVkZV9kaXJzJzogWwo=