107980 2013-01-25 13:01:34 -0800 AX: VoiceOver not reading bullets correctly in the text of notes 2013-01-29 19:43:33 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro dmazzoni jdiggs rniwa webkit.review.bot oldest_to_newest 816856 0 cfleizach 2013-01-25 13:01:34 -0800 WebKit is returning the wrong suffix for list markers 816859 1 184797 cfleizach 2013-01-25 13:03:53 -0800 Created attachment 184797 patch 816877 2 184797 dmazzoni 2013-01-25 13:31:12 -0800 Comment on attachment 184797 patch View in context: https://bugs.webkit.org/attachment.cgi?id=184797&action=review > LayoutTests/platform/mac/accessibility/listmarker-suffix.html:29 > + var list1 = accessibilityController.accessibleElementById("listitem1"); Nit: how about item1 instead of list1 (and same below). 816878 3 dmazzoni 2013-01-25 13:31:26 -0800 Unofficial review, looks good. 819716 4 184797 webkit.review.bot 2013-01-29 19:43:30 -0800 Comment on attachment 184797 patch Clearing flags on attachment: 184797 Committed r141212: <http://trac.webkit.org/changeset/141212> 819717 5 webkit.review.bot 2013-01-29 19:43:33 -0800 All reviewed patches have been landed. Closing bug. 184797 2013-01-25 13:03:53 -0800 2013-01-29 19:43:30 -0800 patch patch text/plain 4868 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTI1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFZvaWNlT3ZlciBu b3QgcmVhZGluZyBidWxsZXRzIGNvcnJlY3RseSBpbiB0aGUgdGV4dCBvZiBub3RlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3OTgwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eSBj b2RlIHNob3VsZCBub3QgYXNzdW1lIHRoYXQgYWxsIGxpc3QgbWFya2VycyBlbmQgd2l0aCB0aGUg c2FtZSAiLiIgc3VmZml4LgorICAgICAgICBXZSBuZWVkIHRvIHVzZSB0aGUgYWN0dWFsIHN1ZmZp eC4KKworICAgICAgICBUZXN0OiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9saXN0bWFya2Vy LXN1ZmZpeC5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6bGlzdE1hcmtl clRleHRGb3JOb2RlQW5kUG9zaXRpb24pOgorCiAyMDEzLTAxLTI1ICBFbGxpb3R0IFNwcmVobiAg PGVzcHJlaG5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENvbnNpZGVyIGFsbCBhbmNlc3RvcnMg bm90IGp1c3QgcGFyZW50RWxlbWVudCB3aGVuIGRpc2Nvbm5lY3RpbmcgZnJhbWVzCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVj dC5jcHAJKHJldmlzaW9uIDE0MDg1NSkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxNiwxNCArODE2LDcg QEAKICAgICAvLyBJZiB0aGlzIGlzIGluIGEgbGlzdCBpdGVtLCB3ZSBuZWVkIHRvIG1hbnVhbGx5 IGFkZCB0aGUgdGV4dCBmb3IgdGhlIGxpc3QgbWFya2VyIAogICAgIC8vIGJlY2F1c2UgYSBSZW5k ZXJMaXN0TWFya2VyIGRvZXMgbm90IGhhdmUgYSBOb2RlIGVxdWl2YWxlbnQgYW5kIHRodXMgZG9l cyBub3QgYXBwZWFyCiAgICAgLy8gd2hlbiBpdGVyYXRpbmcgdGV4dC4KLSAgICBjb25zdCBTdHJp bmcmIG1hcmtlclRleHQgPSBsaXN0SXRlbS0+bWFya2VyVGV4dCgpOwotICAgIGlmIChtYXJrZXJU ZXh0LmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIFN0cmluZygpOwotICAgICAgICAgICAgICAg IAotICAgIC8vIEFwcGVuZCB0ZXh0LCBwbHVzIHRoZSBwZXJpb2QgdGhhdCBmb2xsb3dzIHRoZSB0 ZXh0LgotICAgIC8vIEZJWE1FOiBOb3QgYWxsIGxpc3QgbWFya2VyIHN0eWxlcyBhcmUgZm9sbG93 ZWQgYnkgYSBwZXJpb2QsIGJ1dCB0aGlzCi0gICAgLy8gc291bmRzIG11Y2ggYmV0dGVyIHdoZW4g dGhlcmUgaXMgYSBzeW50aGVzaXplZCBwYXVzZSBiZWNhdXNlIG9mIGEgcGVyaW9kLgotICAgIHJl dHVybiBtYXJrZXJUZXh0ICsgIi4gIjsKKyAgICByZXR1cm4gbGlzdEl0ZW0tPm1hcmtlclRleHRX aXRoU3VmZml4KCk7CiB9CiAgICAgCiBTdHJpbmcgQWNjZXNzaWJpbGl0eU9iamVjdDo6c3RyaW5n Rm9yVmlzaWJsZVBvc2l0aW9uUmFuZ2UoY29uc3QgVmlzaWJsZVBvc2l0aW9uUmFuZ2UmIHZpc2li bGVQb3NpdGlvblJhbmdlKSBjb25zdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQwODYwKQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMt MDEtMjUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBB WDogVm9pY2VPdmVyIG5vdCByZWFkaW5nIGJ1bGxldHMgY29ycmVjdGx5IGluIHRoZSB0ZXh0IG9m IG5vdGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDc5ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2xpc3RtYXJrZXItc3VmZml4LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvbGlzdG1hcmtl ci1zdWZmaXguaHRtbDogQWRkZWQuCisKIDIwMTMtMDEtMjUgIEVyaWsgQXJ2aWRzc29uICA8YXJ2 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVtIHJlYmFzZWxpbmUu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9saXN0bWFya2Vy LXN1ZmZpeC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2FjY2Vzc2liaWxpdHkvbGlzdG1hcmtlci1zdWZmaXgtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvbGlzdG1hcmtl ci1zdWZmaXgtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACitpdGVt IDEKK2l0ZW0gMgorVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhlIHJpZ2h0IHN1ZmZpeCBpcyByZXR1 cm5lZCB3aGVuIGZldGNoaW5nIHRleHQgbWFya2VyIHN0cmluZ3MgZm9yIGxpc3QgaXRlbXMuCisK K09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGxpc3QxLnN0cmluZ0ZvclRleHRN YXJrZXJSYW5nZSh0ZXh0UmFuZ2UpIGlzIGJ1bGxldFN0cmluZyArICcgaXRlbSAxJworUEFTUyBs aXN0Mi5zdHJpbmdGb3JUZXh0TWFya2VyUmFuZ2UodGV4dFJhbmdlKSBpcyAnMS4gaXRlbSAyJwor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2xpc3RtYXJrZXItc3VmZml4 Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp dHkvbGlzdG1hcmtlci1zdWZmaXguaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2xpc3RtYXJrZXItc3VmZml4Lmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNDUgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFRE IEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2lmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keT4KKworPHVsIHN0eWxlPSJkaXNjIj4KKzxsaSBpZD0ibGlzdGl0ZW0xIj5p dGVtIDE8L2xpPgorPC91bD4KKworPG9sPgorPGxpIGlkPSJsaXN0aXRlbTIiPml0ZW0gMjwvbGk+ Cis8L29sPgorCisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IG1ha2VzIHN1 cmUgdGhlIHJpZ2h0IHN1ZmZpeCBpcyByZXR1cm5lZCB3aGVuIGZldGNoaW5nIHRleHQgbWFya2Vy IHN0cmluZ3MgZm9yIGxpc3QgaXRlbXMuIik7CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxp dHlDb250cm9sbGVyKSB7CisgICAgICAgIHZhciBsaXN0MSA9IGFjY2Vzc2liaWxpdHlDb250cm9s bGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgibGlzdGl0ZW0xIik7CisgICAgICAgIHZhciB0ZXh0 UmFuZ2UgPSBsaXN0MS50ZXh0TWFya2VyUmFuZ2VGb3JFbGVtZW50KGxpc3QxKTsKKyAgICAgICAg dmFyIGJ1bGxldFN0cmluZyA9IFN0cmluZy5mcm9tQ2hhckNvZGUoMHgyMDIyKTsKKyAgICAgICAg c2hvdWxkQmUoImxpc3QxLnN0cmluZ0ZvclRleHRNYXJrZXJSYW5nZSh0ZXh0UmFuZ2UpIiwgImJ1 bGxldFN0cmluZyArICcgaXRlbSAxJyIpOworCisgICAgICAgIHZhciBsaXN0MiA9IGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgibGlzdGl0ZW0yIik7CisgICAg ICAgIHZhciB0ZXh0UmFuZ2UgPSBsaXN0Mi50ZXh0TWFya2VyUmFuZ2VGb3JFbGVtZW50KGxpc3Qy KTsKKyAgICAgICAgc2hvdWxkQmUoImxpc3QyLnN0cmluZ0ZvclRleHRNYXJrZXJSYW5nZSh0ZXh0 UmFuZ2UpIiwgIicxLiBpdGVtIDInIik7CisgICAgfQorCis8L3NjcmlwdD4KKworPHNjcmlwdCBz cmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ CisKKzwvYm9keT4KKzwvaHRtbD4KKwo=