107972 2013-01-25 11:46:46 -0800 Change svg/text/text-rect-precision.html to pass on non-subpixel platforms and add results 2013-01-25 12:21:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae leviw rniwa webkit.review.bot oldest_to_newest 816803 0 eae 2013-01-25 11:46:46 -0800 Change svg/text/text-rect-precision.html to pass on non-subpixel platforms and add results 816810 1 leviw 2013-01-25 11:51:57 -0800 I can't wait for this to no longer be an issue :-/ 816818 2 184789 eae 2013-01-25 11:56:03 -0800 Created attachment 184789 Patch 816819 3 184789 leviw 2013-01-25 11:59:08 -0800 Comment on attachment 184789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184789&action=review > LayoutTests/svg/text/text-rect-precision.html:47 > - testPassed('Width of text element is ' + elementWidth + ', expected ' + textWidth); > + testFailed('Width of text element is ' + elementWidth + ', expected ' + textWidth); This doesn't look like it was right before! 816839 4 184789 webkit.review.bot 2013-01-25 12:21:17 -0800 Comment on attachment 184789 Patch Clearing flags on attachment: 184789 Committed r140858: <http://trac.webkit.org/changeset/140858> 816840 5 webkit.review.bot 2013-01-25 12:21:21 -0800 All reviewed patches have been landed. Closing bug. 184789 2013-01-25 11:56:03 -0800 2013-01-25 12:21:17 -0800 Patch bug-107972-20130125115254.patch text/plain 3680 eae SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0MDg1MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTI1ICBFbWlsIEEgRWtsdW5kICA8 ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2Ugc3ZnL3RleHQvdGV4dC1yZWN0LXBy ZWNpc2lvbi5odG1sIHRvIHBhc3Mgb24gbm9uLXN1YnBpeGVsIHBsYXRmb3JtcyBhbmQgYWRkIHJl c3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Nzk3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0tbGludXgvc3ZnL3RleHQvdGV4dC1yZWN0LXByZWNpc2lvbi1leHBl Y3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0tbWFjL3N2Zy90 ZXh0L3RleHQtcmVjdC1wcmVjaXNpb24tZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAq IHN2Zy90ZXh0L3RleHQtcmVjdC1wcmVjaXNpb24uaHRtbDoKKyAgICAgICAgKiBzdmcvdGV4dC90 ZXh0LXJlY3QtcHJlY2lzaW9uLWV4cGVjdGVkLnR4dDogQWRkZWQKKwogMjAxMy0wMS0yNSAgQXJu YXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIE1v dmUgV2ViR0xFcnJvcnNUb0NvbnNvbGUgcGFnZSBzZXR0aW5nIHRvIHdpbmRvdy5pbnRlcm5hbHMu c2V0dGluZ3MKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3N2Zy90 ZXh0L3RleHQtcmVjdC1wcmVjaXNpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3N2Zy90ZXh0L3RleHQtcmVjdC1wcmVjaXNp b24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNDA3NjYpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS1saW51eC9zdmcvdGV4dC90ZXh0LXJlY3QtcHJlY2lzaW9uLWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMSwzICswLDAgQEAKLVBBU1MgV2lkdGggb2YgdGV4dCBlbGVt ZW50IGlzIHRoZSBzdW0gb2YgdGhlIHdpZHRoIG9mIGFsbCBjaGFyYWN0ZXJzLgotU3BoaW54IG9m IGJsYWNrIHF1YXJ0eiwganVkZ2UgbXkgdm93LgotLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0tbWFjL3N2Zy90ZXh0L3RleHQtcmVjdC1wcmVjaXNpb24tZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLW1hYy9zdmcvdGV4 dC90ZXh0LXJlY3QtcHJlY2lzaW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTQwNzY2KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjL3N2Zy90ZXh0L3RleHQtcmVjdC1wcmVj aXNpb24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzAsMCBAQAotUEFTUyBX aWR0aCBvZiB0ZXh0IGVsZW1lbnQgaXMgMzkxLCBleHBlY3RlZCAzOTMKLVNwaGlueCBvZiBibGFj ayBxdWFydHosIGp1ZGdlIG15IHZvdy4KLS4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy90ZXh0L3Rl eHQtcmVjdC1wcmVjaXNpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3N2Zy90ZXh0L3RleHQtcmVjdC1wcmVjaXNpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvc3ZnL3RleHQvdGV4dC1yZWN0LXByZWNpc2lvbi1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorUEFTUyBXaWR0aCBvZiB0ZXh0IGVsZW1lbnQg aXMgdGhlIHN1bSBvZiB0aGUgd2lkdGggb2YgYWxsIGNoYXJhY3RlcnMuCitTcGhpbnggb2YgYmxh Y2sgcXVhcnR6LCBqdWRnZSBteSB2b3cuCisuCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvdGV4dC90 ZXh0LXJlY3QtcHJlY2lzaW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL3Rl eHQvdGV4dC1yZWN0LXByZWNpc2lvbi5odG1sCShyZXZpc2lvbiAxNDA3NjYpCisrKyBMYXlvdXRU ZXN0cy9zdmcvdGV4dC90ZXh0LXJlY3QtcHJlY2lzaW9uLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTEzLDYgKzEzLDggQEAKICAgICA8L3N2Zz4KIDxzY3JpcHQ+CiAgICAgCisgICAgdmFyIGhhc1N1 YnBpeGVsUHJlY2lzaW9uID0gZmFsc2U7CisgICAgCiAgICAgZnVuY3Rpb24gbWVhc3VyZVRleHQo dGVzdEVsZW1lbnQpCiAgICAgewogICAgICAgICB2YXIgbWVhc3VyZUVsZW1lbnQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnbWVhc3VyZScpOwpAQCAtMjgsNiArMzAsNyBAQAogICAgICAgICAg ICAgICAgIG1lYXN1cmVFbGVtZW50LmZpcnN0Q2hpbGQubm9kZVZhbHVlID0gYzsKICAgICAgICAg ICAgICAgICB3ID0gbWVhc3VyZUVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lkdGg7 CiAgICAgICAgICAgICAgICAgY2hhcmFjdGVyV2lkdGhzW2NdID0gdzsKKyAgICAgICAgICAgICAg ICBoYXNTdWJwaXhlbFByZWNpc2lvbiA9IGhhc1N1YnBpeGVsUHJlY2lzaW9uIHx8IHcudG9GaXhl ZCgyKSAhPSBNYXRoLnJvdW5kKHcpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgd2lkdGgg Kz0gdzsKICAgICAgICAgfQpAQCAtMzcsMTAgKzQwLDExIEBACiAgICAgdmFyIGVsID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKICAgICB2YXIgZWxlbWVudFdpZHRoID0gZWwuZ2V0 Qm91bmRpbmdDbGllbnRSZWN0KCkud2lkdGg7CiAgICAgdmFyIHRleHRXaWR0aCA9IG1lYXN1cmVU ZXh0KGVsKTsKLSAgICBpZiAoTWF0aC5hYnMoZWxlbWVudFdpZHRoIC0gdGV4dFdpZHRoKSA8PSAw LjEpCisgICAgdmFyIHRvbGVyYW5jZSA9IGhhc1N1YnBpeGVsUHJlY2lzaW9uID8gMC4xIDogMjsg Ly8gZW5jbG9zaW5nIG1heSBleHBhbmQgdXAgdG8gb25lIHBpeGVsIGluIGVhY2ggZGlyZWN0aW9u LgorICAgIGlmIChNYXRoLmFicyhlbGVtZW50V2lkdGggLSB0ZXh0V2lkdGgpIDw9IHRvbGVyYW5j ZSkKICAgICAgICAgdGVzdFBhc3NlZCgnV2lkdGggb2YgdGV4dCBlbGVtZW50IGlzIHRoZSBzdW0g b2YgdGhlIHdpZHRoIG9mIGFsbCBjaGFyYWN0ZXJzLicpOwogICAgIGVsc2UKLSAgICAgICAgdGVz dFBhc3NlZCgnV2lkdGggb2YgdGV4dCBlbGVtZW50IGlzICcgKyBlbGVtZW50V2lkdGggKyAnLCBl eHBlY3RlZCAnICsgdGV4dFdpZHRoKTsKKyAgICAgICAgdGVzdEZhaWxlZCgnV2lkdGggb2YgdGV4 dCBlbGVtZW50IGlzICcgKyBlbGVtZW50V2lkdGggKyAnLCBleHBlY3RlZCAnICsgdGV4dFdpZHRo KTsKIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgo=